diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-02-21 08:55:47 +0800 | 
|---|---|---|
| committer | Jagannadha Sutradharudu Teki <jaganna@xilinx.com> | 2014-03-17 21:54:57 +0530 | 
| commit | 7dfc4dbd2d1592ee420945afe6a82003c374b0de (patch) | |
| tree | 98be23c4969c1feec322bd7063965b94cbf2ece5 /drivers/spi/atmel_dataflash_spi.c | |
| parent | c6136aad91da493c446f22af8f5d774a74dec9d1 (diff) | |
| download | olio-uboot-2014.01-7dfc4dbd2d1592ee420945afe6a82003c374b0de.tar.xz olio-uboot-2014.01-7dfc4dbd2d1592ee420945afe6a82003c374b0de.zip | |
spi: atmel_dataflash: Simplify AT91F_SpiEnable implementation
Refactor the code a bit to make it better in readability.
Remove the comments because now the intention of the code is pretty clear.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
Diffstat (limited to 'drivers/spi/atmel_dataflash_spi.c')
| -rw-r--r-- | drivers/spi/atmel_dataflash_spi.c | 31 | 
1 files changed, 12 insertions, 19 deletions
| diff --git a/drivers/spi/atmel_dataflash_spi.c b/drivers/spi/atmel_dataflash_spi.c index 8a5eddcbf..a2e9c00ea 100644 --- a/drivers/spi/atmel_dataflash_spi.c +++ b/drivers/spi/atmel_dataflash_spi.c @@ -102,33 +102,26 @@ void AT91F_SpiEnable(int cs)  {  	unsigned long mode; +	mode = readl(ATMEL_BASE_SPI0 + AT91_SPI_MR); +	mode &= ~AT91_SPI_PCS; +  	switch (cs) { -	case 0:	/* Configure SPI CS0 for Serial DataFlash AT45DBxx */ -		mode = readl(ATMEL_BASE_SPI0 + AT91_SPI_MR); -		mode &= 0xFFF0FFFF; -		writel(mode | ((AT91_SPI_PCS0_DATAFLASH_CARD<<16) & AT91_SPI_PCS), -		       ATMEL_BASE_SPI0 + AT91_SPI_MR); +	case 0: +		mode |= AT91_SPI_PCS0_DATAFLASH_CARD << 16;  		break; -	case 1:	/* Configure SPI CS1 for Serial DataFlash AT45DBxx */ -		mode = readl(ATMEL_BASE_SPI0 + AT91_SPI_MR); -		mode &= 0xFFF0FFFF; -		writel(mode | ((AT91_SPI_PCS1_DATAFLASH_CARD<<16) & AT91_SPI_PCS), -		       ATMEL_BASE_SPI0 + AT91_SPI_MR); +	case 1: +		mode |= AT91_SPI_PCS1_DATAFLASH_CARD << 16;  		break; -	case 2:	/* Configure SPI CS2 for Serial DataFlash AT45DBxx */ -		mode = readl(ATMEL_BASE_SPI0 + AT91_SPI_MR); -		mode &= 0xFFF0FFFF; -		writel(mode | ((AT91_SPI_PCS2_DATAFLASH_CARD<<16) & AT91_SPI_PCS), -		       ATMEL_BASE_SPI0 + AT91_SPI_MR); +	case 2: +		mode |= AT91_SPI_PCS2_DATAFLASH_CARD << 16;  		break;  	case 3: -		mode = readl(ATMEL_BASE_SPI0 + AT91_SPI_MR); -		mode &= 0xFFF0FFFF; -		writel(mode | ((AT91_SPI_PCS3_DATAFLASH_CARD<<16) & AT91_SPI_PCS), -		       ATMEL_BASE_SPI0 + AT91_SPI_MR); +		mode |= AT91_SPI_PCS3_DATAFLASH_CARD << 16;  		break;  	} +	writel(mode, ATMEL_BASE_SPI0 + AT91_SPI_MR); +  	/* SPI_Enable */  	writel(AT91_SPI_SPIEN, ATMEL_BASE_SPI0 + AT91_SPI_CR);  } |