diff options
Diffstat (limited to 'net/caif/cfcnfg.c')
| -rw-r--r-- | net/caif/cfcnfg.c | 49 | 
1 files changed, 21 insertions, 28 deletions
diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c index 1c29189b344..41adafd1891 100644 --- a/net/caif/cfcnfg.c +++ b/net/caif/cfcnfg.c @@ -3,6 +3,9 @@   * Author:	Sjur Brendeland/sjur.brandeland@stericsson.com   * License terms: GNU General Public License (GPL) version 2   */ + +#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ +  #include <linux/kernel.h>  #include <linux/stddef.h>  #include <linux/slab.h> @@ -78,7 +81,7 @@ struct cfcnfg *cfcnfg_create(void)  	/* Initiate this layer */  	this = kzalloc(sizeof(struct cfcnfg), GFP_ATOMIC);  	if (!this) { -		pr_warning("CAIF: %s(): Out of memory\n", __func__); +		pr_warn("Out of memory\n");  		return NULL;  	}  	this->mux = cfmuxl_create(); @@ -106,7 +109,7 @@ struct cfcnfg *cfcnfg_create(void)  	layer_set_up(this->ctrl, this);  	return this;  out_of_mem: -	pr_warning("CAIF: %s(): Out of memory\n", __func__); +	pr_warn("Out of memory\n");  	kfree(this->mux);  	kfree(this->ctrl);  	kfree(this); @@ -194,7 +197,7 @@ int cfcnfg_disconn_adapt_layer(struct cfcnfg *cnfg, struct cflayer *adap_layer)  	caif_assert(adap_layer != NULL);  	channel_id = adap_layer->id;  	if (adap_layer->dn == NULL || channel_id == 0) { -		pr_err("CAIF: %s():adap_layer->id is 0\n", __func__); +		pr_err("adap_layer->dn == NULL or adap_layer->id is 0\n");  		ret = -ENOTCONN;  		goto end;  	} @@ -204,9 +207,8 @@ int cfcnfg_disconn_adapt_layer(struct cfcnfg *cnfg, struct cflayer *adap_layer)  	layer_set_up(servl, NULL);  	ret = cfctrl_linkdown_req(cnfg->ctrl, channel_id, adap_layer);  	if (servl == NULL) { -		pr_err("CAIF: %s(): PROTOCOL ERROR " -		       "- Error removing service_layer Channel_Id(%d)", -			__func__, channel_id); +		pr_err("PROTOCOL ERROR - Error removing service_layer Channel_Id(%d)", +		       channel_id);  		ret = -EINVAL;  		goto end;  	} @@ -216,18 +218,14 @@ int cfcnfg_disconn_adapt_layer(struct cfcnfg *cnfg, struct cflayer *adap_layer)  		phyinfo = cfcnfg_get_phyinfo(cnfg, phyid);  		if (phyinfo == NULL) { -			pr_warning("CAIF: %s(): " -				"No interface to send disconnect to\n", -				__func__); +			pr_warn("No interface to send disconnect to\n");  			ret = -ENODEV;  			goto end;  		}  		if (phyinfo->id != phyid ||  			phyinfo->phy_layer->id != phyid ||  			phyinfo->frm_layer->id != phyid) { -			pr_err("CAIF: %s(): " -				"Inconsistency in phy registration\n", -				__func__); +			pr_err("Inconsistency in phy registration\n");  			ret = -EINVAL;  			goto end;  		} @@ -276,21 +274,20 @@ int cfcnfg_add_adaptation_layer(struct cfcnfg *cnfg,  {  	struct cflayer *frml;  	if (adap_layer == NULL) { -		pr_err("CAIF: %s(): adap_layer is zero", __func__); +		pr_err("adap_layer is zero\n");  		return -EINVAL;  	}  	if (adap_layer->receive == NULL) { -		pr_err("CAIF: %s(): adap_layer->receive is NULL", __func__); +		pr_err("adap_layer->receive is NULL\n");  		return -EINVAL;  	}  	if (adap_layer->ctrlcmd == NULL) { -		pr_err("CAIF: %s(): adap_layer->ctrlcmd == NULL", __func__); +		pr_err("adap_layer->ctrlcmd == NULL\n");  		return -EINVAL;  	}  	frml = cnfg->phy_layers[param->phyid].frm_layer;  	if (frml == NULL) { -		pr_err("CAIF: %s(): Specified PHY type does not exist!", -			__func__); +		pr_err("Specified PHY type does not exist!\n");  		return -ENODEV;  	}  	caif_assert(param->phyid == cnfg->phy_layers[param->phyid].id); @@ -330,9 +327,7 @@ cfcnfg_linkup_rsp(struct cflayer *layer, u8 channel_id, enum cfctrl_srv serv,  	struct net_device *netdev;  	if (adapt_layer == NULL) { -		pr_debug("CAIF: %s(): link setup response " -				"but no client exist, send linkdown back\n", -				__func__); +		pr_debug("link setup response but no client exist, send linkdown back\n");  		cfctrl_linkdown_req(cnfg->ctrl, channel_id, NULL);  		return;  	} @@ -374,13 +369,11 @@ cfcnfg_linkup_rsp(struct cflayer *layer, u8 channel_id, enum cfctrl_srv serv,  		servicel = cfdbgl_create(channel_id, &phyinfo->dev_info);  		break;  	default: -		pr_err("CAIF: %s(): Protocol error. " -			"Link setup response - unknown channel type\n", -			__func__); +		pr_err("Protocol error. Link setup response - unknown channel type\n");  		return;  	}  	if (!servicel) { -		pr_warning("CAIF: %s(): Out of memory\n", __func__); +		pr_warn("Out of memory\n");  		return;  	}  	layer_set_dn(servicel, cnfg->mux); @@ -418,7 +411,7 @@ cfcnfg_add_phy_layer(struct cfcnfg *cnfg, enum cfcnfg_phy_type phy_type,  		}  	}  	if (*phyid == 0) { -		pr_err("CAIF: %s(): No Available PHY ID\n", __func__); +		pr_err("No Available PHY ID\n");  		return;  	} @@ -427,7 +420,7 @@ cfcnfg_add_phy_layer(struct cfcnfg *cnfg, enum cfcnfg_phy_type phy_type,  		phy_driver =  		    cfserl_create(CFPHYTYPE_FRAG, *phyid, stx);  		if (!phy_driver) { -			pr_warning("CAIF: %s(): Out of memory\n", __func__); +			pr_warn("Out of memory\n");  			return;  		} @@ -436,7 +429,7 @@ cfcnfg_add_phy_layer(struct cfcnfg *cnfg, enum cfcnfg_phy_type phy_type,  		phy_driver = NULL;  		break;  	default: -		pr_err("CAIF: %s(): %d", __func__, phy_type); +		pr_err("%d\n", phy_type);  		return;  		break;  	} @@ -455,7 +448,7 @@ cfcnfg_add_phy_layer(struct cfcnfg *cnfg, enum cfcnfg_phy_type phy_type,  	phy_layer->type = phy_type;  	frml = cffrml_create(*phyid, fcs);  	if (!frml) { -		pr_warning("CAIF: %s(): Out of memory\n", __func__); +		pr_warn("Out of memory\n");  		return;  	}  	cnfg->phy_layers[*phyid].frm_layer = frml;  |