diff options
Diffstat (limited to 'net/bluetooth')
| -rw-r--r-- | net/bluetooth/hci_sock.c | 15 | ||||
| -rw-r--r-- | net/bluetooth/rfcomm/sock.c | 13 | ||||
| -rw-r--r-- | net/bluetooth/sco.c | 14 | 
3 files changed, 15 insertions, 27 deletions
diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c index 07f07393581..6a93614f2c4 100644 --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -70,14 +70,13 @@ static struct bt_sock_list hci_sk_list = {  void hci_send_to_sock(struct hci_dev *hdev, struct sk_buff *skb)  {  	struct sock *sk; -	struct hlist_node *node;  	struct sk_buff *skb_copy = NULL;  	BT_DBG("hdev %p len %d", hdev, skb->len);  	read_lock(&hci_sk_list.lock); -	sk_for_each(sk, node, &hci_sk_list.head) { +	sk_for_each(sk, &hci_sk_list.head) {  		struct hci_filter *flt;  		struct sk_buff *nskb; @@ -142,13 +141,12 @@ void hci_send_to_sock(struct hci_dev *hdev, struct sk_buff *skb)  void hci_send_to_control(struct sk_buff *skb, struct sock *skip_sk)  {  	struct sock *sk; -	struct hlist_node *node;  	BT_DBG("len %d", skb->len);  	read_lock(&hci_sk_list.lock); -	sk_for_each(sk, node, &hci_sk_list.head) { +	sk_for_each(sk, &hci_sk_list.head) {  		struct sk_buff *nskb;  		/* Skip the original socket */ @@ -176,7 +174,6 @@ void hci_send_to_control(struct sk_buff *skb, struct sock *skip_sk)  void hci_send_to_monitor(struct hci_dev *hdev, struct sk_buff *skb)  {  	struct sock *sk; -	struct hlist_node *node;  	struct sk_buff *skb_copy = NULL;  	__le16 opcode; @@ -210,7 +207,7 @@ void hci_send_to_monitor(struct hci_dev *hdev, struct sk_buff *skb)  	read_lock(&hci_sk_list.lock); -	sk_for_each(sk, node, &hci_sk_list.head) { +	sk_for_each(sk, &hci_sk_list.head) {  		struct sk_buff *nskb;  		if (sk->sk_state != BT_BOUND) @@ -251,13 +248,12 @@ void hci_send_to_monitor(struct hci_dev *hdev, struct sk_buff *skb)  static void send_monitor_event(struct sk_buff *skb)  {  	struct sock *sk; -	struct hlist_node *node;  	BT_DBG("len %d", skb->len);  	read_lock(&hci_sk_list.lock); -	sk_for_each(sk, node, &hci_sk_list.head) { +	sk_for_each(sk, &hci_sk_list.head) {  		struct sk_buff *nskb;  		if (sk->sk_state != BT_BOUND) @@ -393,11 +389,10 @@ void hci_sock_dev_event(struct hci_dev *hdev, int event)  	if (event == HCI_DEV_UNREG) {  		struct sock *sk; -		struct hlist_node *node;  		/* Detach sockets from device */  		read_lock(&hci_sk_list.lock); -		sk_for_each(sk, node, &hci_sk_list.head) { +		sk_for_each(sk, &hci_sk_list.head) {  			bh_lock_sock_nested(sk);  			if (hci_pi(sk)->hdev == hdev) {  				hci_pi(sk)->hdev = NULL; diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c index ce3f6658f4b..c23bae86263 100644 --- a/net/bluetooth/rfcomm/sock.c +++ b/net/bluetooth/rfcomm/sock.c @@ -107,15 +107,14 @@ static void rfcomm_sk_state_change(struct rfcomm_dlc *d, int err)  static struct sock *__rfcomm_get_sock_by_addr(u8 channel, bdaddr_t *src)  {  	struct sock *sk = NULL; -	struct hlist_node *node; -	sk_for_each(sk, node, &rfcomm_sk_list.head) { +	sk_for_each(sk, &rfcomm_sk_list.head) {  		if (rfcomm_pi(sk)->channel == channel &&  				!bacmp(&bt_sk(sk)->src, src))  			break;  	} -	return node ? sk : NULL; +	return sk ? sk : NULL;  }  /* Find socket with channel and source bdaddr. @@ -124,11 +123,10 @@ static struct sock *__rfcomm_get_sock_by_addr(u8 channel, bdaddr_t *src)  static struct sock *rfcomm_get_sock_by_channel(int state, u8 channel, bdaddr_t *src)  {  	struct sock *sk = NULL, *sk1 = NULL; -	struct hlist_node *node;  	read_lock(&rfcomm_sk_list.lock); -	sk_for_each(sk, node, &rfcomm_sk_list.head) { +	sk_for_each(sk, &rfcomm_sk_list.head) {  		if (state && sk->sk_state != state)  			continue; @@ -145,7 +143,7 @@ static struct sock *rfcomm_get_sock_by_channel(int state, u8 channel, bdaddr_t *  	read_unlock(&rfcomm_sk_list.lock); -	return node ? sk : sk1; +	return sk ? sk : sk1;  }  static void rfcomm_sock_destruct(struct sock *sk) @@ -970,11 +968,10 @@ done:  static int rfcomm_sock_debugfs_show(struct seq_file *f, void *p)  {  	struct sock *sk; -	struct hlist_node *node;  	read_lock(&rfcomm_sk_list.lock); -	sk_for_each(sk, node, &rfcomm_sk_list.head) { +	sk_for_each(sk, &rfcomm_sk_list.head) {  		seq_printf(f, "%pMR %pMR %d %d\n",  			   &bt_sk(sk)->src, &bt_sk(sk)->dst,  			   sk->sk_state, rfcomm_pi(sk)->channel); diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c index b5178d62064..79d87d8d4f5 100644 --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -259,10 +259,9 @@ drop:  /* -------- Socket interface ---------- */  static struct sock *__sco_get_sock_listen_by_addr(bdaddr_t *ba)  { -	struct hlist_node *node;  	struct sock *sk; -	sk_for_each(sk, node, &sco_sk_list.head) { +	sk_for_each(sk, &sco_sk_list.head) {  		if (sk->sk_state != BT_LISTEN)  			continue; @@ -279,11 +278,10 @@ static struct sock *__sco_get_sock_listen_by_addr(bdaddr_t *ba)  static struct sock *sco_get_sock_listen(bdaddr_t *src)  {  	struct sock *sk = NULL, *sk1 = NULL; -	struct hlist_node *node;  	read_lock(&sco_sk_list.lock); -	sk_for_each(sk, node, &sco_sk_list.head) { +	sk_for_each(sk, &sco_sk_list.head) {  		if (sk->sk_state != BT_LISTEN)  			continue; @@ -298,7 +296,7 @@ static struct sock *sco_get_sock_listen(bdaddr_t *src)  	read_unlock(&sco_sk_list.lock); -	return node ? sk : sk1; +	return sk ? sk : sk1;  }  static void sco_sock_destruct(struct sock *sk) @@ -951,14 +949,13 @@ static void sco_conn_ready(struct sco_conn *conn)  int sco_connect_ind(struct hci_dev *hdev, bdaddr_t *bdaddr, __u8 *flags)  {  	struct sock *sk; -	struct hlist_node *node;  	int lm = 0;  	BT_DBG("hdev %s, bdaddr %pMR", hdev->name, bdaddr);  	/* Find listening sockets */  	read_lock(&sco_sk_list.lock); -	sk_for_each(sk, node, &sco_sk_list.head) { +	sk_for_each(sk, &sco_sk_list.head) {  		if (sk->sk_state != BT_LISTEN)  			continue; @@ -1018,11 +1015,10 @@ drop:  static int sco_debugfs_show(struct seq_file *f, void *p)  {  	struct sock *sk; -	struct hlist_node *node;  	read_lock(&sco_sk_list.lock); -	sk_for_each(sk, node, &sco_sk_list.head) { +	sk_for_each(sk, &sco_sk_list.head) {  		seq_printf(f, "%pMR %pMR %d\n", &bt_sk(sk)->src,  			   &bt_sk(sk)->dst, sk->sk_state);  	}  |