diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2009-10-03 20:30:48 -0300 | 
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-10-04 19:37:11 +0200 | 
| commit | ec218fc4a796a1b584741d59ef22615d96981188 (patch) | |
| tree | 59e1060af0aa674d32bb81701bd08802209ef416 /tools/perf/builtin-annotate.c | |
| parent | 9735abf11bec48bfbbb1b54772a02deb2ae0c403 (diff) | |
| download | olio-linux-3.10-ec218fc4a796a1b584741d59ef22615d96981188.tar.xz olio-linux-3.10-ec218fc4a796a1b584741d59ef22615d96981188.zip  | |
perf tools: Remove show_mask bitmask
As it was not being exposed via any command line and with --dsos/--comms
we can do this and even more, like asking for just kernel + some module:
[root@doppio linux-2.6-tip]# perf report --dsos \[kernel\],\[drm\]
--vmlinux /home/acme/git/build/tip-recvmmsg/vmlinux --modules | head -15
 # Samples: 619669
 #
 # Overhead          Command  Shared Object  Symbol
 # ........  ...............  .............  ......
 #
      7.12%          swapper  [kernel]       [k] read_hpet
      6.86%             init  [kernel]       [k] read_hpet
      6.22%             init  [kernel]       [k] mwait_idle_with_hints
      5.34%          swapper  [kernel]       [k] mwait_idle_with_hints
      3.01%          firefox  [kernel]       [.] vread_hpet
      2.14%             Xorg  [drm]          [k] drm_clflush_pages
      2.09%           pidgin  [kernel]       [.] vread_hpet
      1.58%     npviewer.bin  [kernel]       [.] vread_hpet
      1.37%          swapper  [kernel]       [k] hpet_next_event
      1.23%             Xorg  [kernel]       [k] read_hpet
[root@doppio linux-2.6-tip]#
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <20091003233048.GA30535@ghostprotocols.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
| -rw-r--r-- | tools/perf/builtin-annotate.c | 15 | 
1 files changed, 4 insertions, 11 deletions
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index 855094234f2..35ed97bd0c6 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c @@ -29,7 +29,6 @@ static char		const *input_name = "perf.data";  static int		force;  static int		input; -static int		show_mask = SHOW_KERNEL | SHOW_USER | SHOW_HV;  static int		full_paths; @@ -97,7 +96,6 @@ static int  process_sample_event(event_t *event, unsigned long offset, unsigned long head)  {  	char level; -	int show = 0;  	struct thread *thread;  	u64 ip = event->ip.ip;  	struct map *map = NULL; @@ -121,13 +119,11 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head)  	}  	if (event->header.misc & PERF_RECORD_MISC_KERNEL) { -		show = SHOW_KERNEL;  		level = 'k';  		sym = kernel_maps__find_symbol(ip, &map);  		dump_printf(" ...... dso: %s\n",  			    map ? map->dso->long_name : "<not found>");  	} else if (event->header.misc & PERF_RECORD_MISC_USER) { -		show = SHOW_USER;  		level = '.';  		map = thread__find_map(thread, ip);  		if (map != NULL) { @@ -153,17 +149,14 @@ got_map:  		dump_printf(" ...... dso: %s\n",  			    map ? map->dso->long_name : "<not found>");  	} else { -		show = SHOW_HV;  		level = 'H';  		dump_printf(" ...... dso: [hypervisor]\n");  	} -	if (show & show_mask) { -		if (hist_entry__add(thread, map, sym, ip, 1, level)) { -			fprintf(stderr, -		"problem incrementing symbol count, skipping event\n"); -			return -1; -		} +	if (hist_entry__add(thread, map, sym, ip, 1, level)) { +		fprintf(stderr, "problem incrementing symbol count, " +				"skipping event\n"); +		return -1;  	}  	total++;  |