diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-21 17:38:49 -0800 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-21 17:38:49 -0800 | 
| commit | 7c2db36e730ee4facd341679ecb21ee73ba92831 (patch) | |
| tree | 75016fba72aaf0581b9263f7fa4c565e6e634f3c /scripts/checkpatch.pl | |
| parent | 8b5628ab83b671f96ac9f174c1bd51c92589fc82 (diff) | |
| parent | a47a376f1c025e23e836c0376813c0424de665c2 (diff) | |
| download | olio-linux-3.10-7c2db36e730ee4facd341679ecb21ee73ba92831.tar.xz olio-linux-3.10-7c2db36e730ee4facd341679ecb21ee73ba92831.zip  | |
Merge branch 'akpm' (incoming from Andrew)
Merge misc patches from Andrew Morton:
 - Florian has vanished so I appear to have become fbdev maintainer
   again :(
 - Joel and Mark are distracted to welcome to the new OCFS2 maintainer
 - The backlight queue
 - Small core kernel changes
 - lib/ updates
 - The rtc queue
 - Various random bits
* akpm: (164 commits)
  rtc: rtc-davinci: use devm_*() functions
  rtc: rtc-max8997: use devm_request_threaded_irq()
  rtc: rtc-max8907: use devm_request_threaded_irq()
  rtc: rtc-da9052: use devm_request_threaded_irq()
  rtc: rtc-wm831x: use devm_request_threaded_irq()
  rtc: rtc-tps80031: use devm_request_threaded_irq()
  rtc: rtc-lp8788: use devm_request_threaded_irq()
  rtc: rtc-coh901331: use devm_clk_get()
  rtc: rtc-vt8500: use devm_*() functions
  rtc: rtc-tps6586x: use devm_request_threaded_irq()
  rtc: rtc-imxdi: use devm_clk_get()
  rtc: rtc-cmos: use dev_warn()/dev_dbg() instead of printk()/pr_debug()
  rtc: rtc-pcf8583: use dev_warn() instead of printk()
  rtc: rtc-sun4v: use pr_warn() instead of printk()
  rtc: rtc-vr41xx: use dev_info() instead of printk()
  rtc: rtc-rs5c313: use pr_err() instead of printk()
  rtc: rtc-at91rm9200: use dev_dbg()/dev_err() instead of printk()/pr_debug()
  rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug()
  rtc: rtc-ds2404: use dev_err() instead of printk()
  rtc: rtc-efi: use dev_err()/dev_warn()/pr_err() instead of printk()
  ...
Diffstat (limited to 'scripts/checkpatch.pl')
| -rwxr-xr-x | scripts/checkpatch.pl | 26 | 
1 files changed, 24 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2bb08a962ce..747bcd768da 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1931,6 +1931,12 @@ sub process {  			      "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);  		} +# check for old HOTPLUG __dev<foo> section markings +		if ($line =~ /\b(__dev(init|exit)(data|const|))\b/) { +			WARN("HOTPLUG_SECTION", +			     "Using $1 is unnecessary\n" . $herecurr); +		} +  # Check for potential 'bare' types  		my ($stat, $cond, $line_nr_next, $remain_next, $off_next,  		    $realline_next); @@ -2430,6 +2436,15 @@ sub process {  			     "Prefer pr_warn(... to pr_warning(...\n" . $herecurr);  		} +		if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) { +			my $orig = $1; +			my $level = lc($orig); +			$level = "warn" if ($level eq "warning"); +			$level = "dbg" if ($level eq "debug"); +			WARN("PREFER_DEV_LEVEL", +			     "Prefer dev_$level(... to dev_printk(KERN_$orig, ...\n" . $herecurr); +		} +  # function brace can't be on same line, except for #defines of do while,  # or if closed on same line  		if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and @@ -2915,6 +2930,7 @@ sub process {  			my $var = $1;  			if ($var !~ /$Constant/ &&  			    $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && +			    $var !~ /^Page[A-Z]/ &&  			    !defined $camelcase{$var}) {  				$camelcase{$var} = 1;  				WARN("CAMELCASE", @@ -3237,9 +3253,9 @@ sub process {  		}  # prefer usleep_range over udelay -		if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) { +		if ($line =~ /\budelay\s*\(\s*(\d+)\s*\)/) {  			# ignore udelay's < 10, however -			if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) { +			if (! ($1 < 10) ) {  				CHK("USLEEP_RANGE",  				    "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);  			} @@ -3460,6 +3476,12 @@ sub process {  			     "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);  		} +# check for alloc argument mismatch +		if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) { +			WARN("ALLOC_ARRAY_ARGS", +			     "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr); +		} +  # check for multiple semicolons  		if ($line =~ /;\s*;\s*$/) {  			WARN("ONE_SEMICOLON",  |