diff options
| author | Xi Wang <xi.wang@gmail.com> | 2011-12-20 18:39:41 -0500 | 
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-01-17 16:17:03 -0500 | 
| commit | 5afb8a3f96573f7ea018abb768f5b6ebe1a6c1a4 (patch) | |
| tree | da5f2278624eeb9dd09c91f3e9cfb6718a4b44ac /kernel/auditsc.c | |
| parent | 10d68360871657204885371cdf2594412675d2f9 (diff) | |
| download | olio-linux-3.10-5afb8a3f96573f7ea018abb768f5b6ebe1a6c1a4.tar.xz olio-linux-3.10-5afb8a3f96573f7ea018abb768f5b6ebe1a6c1a4.zip  | |
audit: fix signedness bug in audit_log_execve_info()
In the loop, a size_t "len" is used to hold the return value of
audit_log_single_execve_arg(), which returns -1 on error.  In that
case the error handling (len <= 0) will be bypassed since "len" is
unsigned, and the loop continues with (p += len) being wrapped.
Change the type of "len" to signed int to fix the error handling.
	size_t len;
	...
	for (...) {
		len = audit_log_single_execve_arg(...);
		if (len <= 0)
			break;
		p += len;
	}
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'kernel/auditsc.c')
| -rw-r--r-- | kernel/auditsc.c | 4 | 
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 593237e3654..86584ecb103 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -1362,8 +1362,8 @@ static void audit_log_execve_info(struct audit_context *context,  				  struct audit_buffer **ab,  				  struct audit_aux_data_execve *axi)  { -	int i; -	size_t len, len_sent = 0; +	int i, len; +	size_t len_sent = 0;  	const char __user *p;  	char *buf;  |