diff options
| author | Ingo Molnar <mingo@elte.hu> | 2012-02-24 08:31:31 +0100 | 
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2012-02-24 10:05:59 +0100 | 
| commit | c5905afb0ee6550b42c49213da1c22d67316c194 (patch) | |
| tree | 253fdb322e6e5b257ffda3b9b66bce90a473a6f7 /include/linux/perf_event.h | |
| parent | 1cfa60dc7d7c7cc774a44eee47ff135a644a1f31 (diff) | |
| download | olio-linux-3.10-c5905afb0ee6550b42c49213da1c22d67316c194.tar.xz olio-linux-3.10-c5905afb0ee6550b42c49213da1c22d67316c194.zip  | |
static keys: Introduce 'struct static_key', static_key_true()/false() and static_key_slow_[inc|dec]()
So here's a boot tested patch on top of Jason's series that does
all the cleanups I talked about and turns jump labels into a
more intuitive to use facility. It should also address the
various misconceptions and confusions that surround jump labels.
Typical usage scenarios:
        #include <linux/static_key.h>
        struct static_key key = STATIC_KEY_INIT_TRUE;
        if (static_key_false(&key))
                do unlikely code
        else
                do likely code
Or:
        if (static_key_true(&key))
                do likely code
        else
                do unlikely code
The static key is modified via:
        static_key_slow_inc(&key);
        ...
        static_key_slow_dec(&key);
The 'slow' prefix makes it abundantly clear that this is an
expensive operation.
I've updated all in-kernel code to use this everywhere. Note
that I (intentionally) have not pushed through the rename
blindly through to the lowest levels: the actual jump-label
patching arch facility should be named like that, so we want to
decouple jump labels from the static-key facility a bit.
On non-jump-label enabled architectures static keys default to
likely()/unlikely() branches.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Jason Baron <jbaron@redhat.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: a.p.zijlstra@chello.nl
Cc: mathieu.desnoyers@efficios.com
Cc: davem@davemloft.net
Cc: ddaney.cavm@gmail.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20120222085809.GA26397@elte.hu
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'include/linux/perf_event.h')
| -rw-r--r-- | include/linux/perf_event.h | 12 | 
1 files changed, 6 insertions, 6 deletions
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 412b790f5da..0d21e6f1cf5 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -514,7 +514,7 @@ struct perf_guest_info_callbacks {  #include <linux/ftrace.h>  #include <linux/cpu.h>  #include <linux/irq_work.h> -#include <linux/jump_label.h> +#include <linux/static_key.h>  #include <linux/atomic.h>  #include <asm/local.h> @@ -1038,7 +1038,7 @@ static inline int is_software_event(struct perf_event *event)  	return event->pmu->task_ctx_nr == perf_sw_context;  } -extern struct jump_label_key perf_swevent_enabled[PERF_COUNT_SW_MAX]; +extern struct static_key perf_swevent_enabled[PERF_COUNT_SW_MAX];  extern void __perf_sw_event(u32, u64, struct pt_regs *, u64); @@ -1066,7 +1066,7 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr)  {  	struct pt_regs hot_regs; -	if (static_branch(&perf_swevent_enabled[event_id])) { +	if (static_key_false(&perf_swevent_enabled[event_id])) {  		if (!regs) {  			perf_fetch_caller_regs(&hot_regs);  			regs = &hot_regs; @@ -1075,12 +1075,12 @@ perf_sw_event(u32 event_id, u64 nr, struct pt_regs *regs, u64 addr)  	}  } -extern struct jump_label_key_deferred perf_sched_events; +extern struct static_key_deferred perf_sched_events;  static inline void perf_event_task_sched_in(struct task_struct *prev,  					    struct task_struct *task)  { -	if (static_branch(&perf_sched_events.key)) +	if (static_key_false(&perf_sched_events.key))  		__perf_event_task_sched_in(prev, task);  } @@ -1089,7 +1089,7 @@ static inline void perf_event_task_sched_out(struct task_struct *prev,  {  	perf_sw_event(PERF_COUNT_SW_CONTEXT_SWITCHES, 1, NULL, 0); -	if (static_branch(&perf_sched_events.key)) +	if (static_key_false(&perf_sched_events.key))  		__perf_event_task_sched_out(prev, next);  }  |