diff options
| author | Jeff Layton <jlayton@redhat.com> | 2012-10-10 15:25:21 -0400 | 
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-10-12 00:32:00 -0400 | 
| commit | c43a25abba97c7d87131e71db6be24b24d7791a5 (patch) | |
| tree | 0fe959853254064e17805ca111838e7869720e43 /include/linux/audit.h | |
| parent | 9cec9d68ae53aae60b4a1fca4505c75a1d026392 (diff) | |
| download | olio-linux-3.10-c43a25abba97c7d87131e71db6be24b24d7791a5.tar.xz olio-linux-3.10-c43a25abba97c7d87131e71db6be24b24d7791a5.zip  | |
audit: reverse arguments to audit_inode_child
Most of the callers get called with an inode and dentry in the reverse
order. The compiler then has to reshuffle the arg registers and/or
stack in order to pass them on to audit_inode_child.
Reverse those arguments for a micro-optimization.
Reported-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'include/linux/audit.h')
| -rw-r--r-- | include/linux/audit.h | 18 | 
1 files changed, 9 insertions, 9 deletions
diff --git a/include/linux/audit.h b/include/linux/audit.h index 2c83e5f7edb..8c66fc248c7 100644 --- a/include/linux/audit.h +++ b/include/linux/audit.h @@ -464,8 +464,8 @@ extern void __audit_syscall_exit(int ret_success, long ret_value);  extern void __audit_getname(const char *name);  extern void audit_putname(const char *name);  extern void __audit_inode(const char *name, const struct dentry *dentry); -extern void __audit_inode_child(const struct dentry *dentry, -				const struct inode *parent); +extern void __audit_inode_child(const struct inode *parent, +				const struct dentry *dentry);  extern void __audit_seccomp(unsigned long syscall, long signr, int code);  extern void __audit_ptrace(struct task_struct *t); @@ -504,10 +504,10 @@ static inline void audit_inode(const char *name, const struct dentry *dentry) {  	if (unlikely(!audit_dummy_context()))  		__audit_inode(name, dentry);  } -static inline void audit_inode_child(const struct dentry *dentry, -				     const struct inode *parent) { +static inline void audit_inode_child(const struct inode *parent, +				     const struct dentry *dentry) {  	if (unlikely(!audit_dummy_context())) -		__audit_inode_child(dentry, parent); +		__audit_inode_child(parent, dentry);  }  void audit_core_dumps(long signr); @@ -657,13 +657,13 @@ static inline void audit_putname(const char *name)  { }  static inline void __audit_inode(const char *name, const struct dentry *dentry)  { } -static inline void __audit_inode_child(const struct dentry *dentry, -					const struct inode *parent) +static inline void __audit_inode_child(const struct inode *parent, +					const struct dentry *dentry)  { }  static inline void audit_inode(const char *name, const struct dentry *dentry)  { } -static inline void audit_inode_child(const struct dentry *dentry, -				     const struct inode *parent) +static inline void audit_inode_child(const struct inode *parent, +				     const struct dentry *dentry)  { }  static inline void audit_core_dumps(long signr)  { }  |