diff options
| author | Greg Kroah-Hartman <gregkh@suse.de> | 2005-07-28 11:37:33 -0700 | 
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-08 14:57:25 -0700 | 
| commit | 95a629657dbe28e44a312c47815b3dc3f1ce0970 (patch) | |
| tree | 0e48656b5d61e26078a50af9f6766e52934fbedf /drivers/usb/core/hcd-pci.c | |
| parent | 085ae41f66657a9655ce832b0a61832a06f0e1dc (diff) | |
| download | olio-linux-3.10-95a629657dbe28e44a312c47815b3dc3f1ce0970.tar.xz olio-linux-3.10-95a629657dbe28e44a312c47815b3dc3f1ce0970.zip  | |
[PATCH] PCI: start paying attention to a lot of pci function return values
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/core/hcd-pci.c')
| -rw-r--r-- | drivers/usb/core/hcd-pci.c | 24 | 
1 files changed, 19 insertions, 5 deletions
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c index 7b9e54c3967..cbb451d227d 100644 --- a/drivers/usb/core/hcd-pci.c +++ b/drivers/usb/core/hcd-pci.c @@ -260,8 +260,10 @@ int usb_hcd_pci_suspend (struct pci_dev *dev, pm_message_t message)  		retval = pci_set_power_state (dev, PCI_D3hot);  		if (retval == 0) {  			dev_dbg (hcd->self.controller, "--> PCI D3\n"); -			pci_enable_wake (dev, PCI_D3hot, hcd->remote_wakeup); -			pci_enable_wake (dev, PCI_D3cold, hcd->remote_wakeup); +			retval = pci_enable_wake (dev, PCI_D3hot, hcd->remote_wakeup); +			if (retval) +				break; +			retval = pci_enable_wake (dev, PCI_D3cold, hcd->remote_wakeup);  		} else if (retval < 0) {  			dev_dbg (&dev->dev, "PCI D3 suspend fail, %d\n",  					retval); @@ -335,8 +337,20 @@ int usb_hcd_pci_resume (struct pci_dev *dev)  				dev->current_state);  		}  #endif -		pci_enable_wake (dev, dev->current_state, 0); -		pci_enable_wake (dev, PCI_D3cold, 0); +		retval = pci_enable_wake (dev, dev->current_state, 0); +		if (retval) { +			dev_err(hcd->self.controller, +				"can't enable_wake to %d, %d!\n", +				dev->current_state, retval); +			return retval; +		} +		retval = pci_enable_wake (dev, PCI_D3cold, 0); +		if (retval) { +			dev_err(hcd->self.controller, +				"can't enable_wake to %d, %d!\n", +				PCI_D3cold, retval); +			return retval; +		}  	} else {  		/* Same basic cases: clean (powered/not), dirty */  		dev_dbg(hcd->self.controller, "PCI legacy resume\n"); @@ -376,7 +390,7 @@ int usb_hcd_pci_resume (struct pci_dev *dev)  		usb_hc_died (hcd);  	} -	pci_enable_device(dev); +	retval = pci_enable_device(dev);  	return retval;  }  EXPORT_SYMBOL (usb_hcd_pci_resume);  |