diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-01 17:51:54 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-01 17:51:54 -0700 | 
| commit | 20b4fb485227404329e41ad15588afad3df23050 (patch) | |
| tree | f3e099f0ab3da8a93b447203e294d2bb22f6dc05 /drivers/scsi/scsi_debug.c | |
| parent | b9394d8a657cd3c064fa432aa0905c1b58b38fe9 (diff) | |
| parent | ac3e3c5b1164397656df81b9e9ab4991184d3236 (diff) | |
| download | olio-linux-3.10-20b4fb485227404329e41ad15588afad3df23050.tar.xz olio-linux-3.10-20b4fb485227404329e41ad15588afad3df23050.zip  | |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull VFS updates from Al Viro,
Misc cleanups all over the place, mainly wrt /proc interfaces (switch
create_proc_entry to proc_create(), get rid of the deprecated
create_proc_read_entry() in favor of using proc_create_data() and
seq_file etc).
7kloc removed.
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (204 commits)
  don't bother with deferred freeing of fdtables
  proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h
  proc: Make the PROC_I() and PDE() macros internal to procfs
  proc: Supply a function to remove a proc entry by PDE
  take cgroup_open() and cpuset_open() to fs/proc/base.c
  ppc: Clean up scanlog
  ppc: Clean up rtas_flash driver somewhat
  hostap: proc: Use remove_proc_subtree()
  drm: proc: Use remove_proc_subtree()
  drm: proc: Use minor->index to label things, not PDE->name
  drm: Constify drm_proc_list[]
  zoran: Don't print proc_dir_entry data in debug
  reiserfs: Don't access the proc_dir_entry in r_open(), r_start() r_show()
  proc: Supply an accessor for getting the data from a PDE's parent
  airo: Use remove_proc_subtree()
  rtl8192u: Don't need to save device proc dir PDE
  rtl8187se: Use a dir under /proc/net/r8180/
  proc: Add proc_mkdir_data()
  proc: Move some bits from linux/proc_fs.h to linux/{of.h,signal.h,tty.h}
  proc: Move PDE_NET() to fs/proc/proc_net.c
  ...
Diffstat (limited to 'drivers/scsi/scsi_debug.c')
| -rw-r--r-- | drivers/scsi/scsi_debug.c | 53 | 
1 files changed, 21 insertions, 32 deletions
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 5cda11c07c6..5add6f4e792 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -2823,31 +2823,27 @@ static const char * scsi_debug_info(struct Scsi_Host * shp)  /* scsi_debug_proc_info   * Used if the driver currently has no own support for /proc/scsi   */ -static int scsi_debug_proc_info(struct Scsi_Host *host, char *buffer, char **start, off_t offset, -				int length, int inout) +static int scsi_debug_write_info(struct Scsi_Host *host, char *buffer, int length)  { -	int len, pos, begin; -	int orig_length; +	char arr[16]; +	int opts; +	int minLen = length > 15 ? 15 : length; -	orig_length = length; - -	if (inout == 1) { -		char arr[16]; -		int minLen = length > 15 ? 15 : length; +	if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO)) +		return -EACCES; +	memcpy(arr, buffer, minLen); +	arr[minLen] = '\0'; +	if (1 != sscanf(arr, "%d", &opts)) +		return -EINVAL; +	scsi_debug_opts = opts; +	if (scsi_debug_every_nth != 0) +		scsi_debug_cmnd_count = 0; +	return length; +} -		if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO)) -			return -EACCES; -		memcpy(arr, buffer, minLen); -		arr[minLen] = '\0'; -		if (1 != sscanf(arr, "%d", &pos)) -			return -EINVAL; -		scsi_debug_opts = pos; -		if (scsi_debug_every_nth != 0) -                        scsi_debug_cmnd_count = 0; -		return length; -	} -	begin = 0; -	pos = len = sprintf(buffer, "scsi_debug adapter driver, version " +static int scsi_debug_show_info(struct seq_file *m, struct Scsi_Host *host) +{ +	seq_printf(m, "scsi_debug adapter driver, version "  	    "%s [%s]\n"  	    "num_tgts=%d, shared (ram) size=%d MB, opts=0x%x, "  	    "every_nth=%d(curr:%d)\n" @@ -2862,15 +2858,7 @@ static int scsi_debug_proc_info(struct Scsi_Host *host, char *buffer, char **sta  	    scsi_debug_sector_size, sdebug_cylinders_per, sdebug_heads,  	    sdebug_sectors_per, num_aborts, num_dev_resets, num_bus_resets,  	    num_host_resets, dix_reads, dix_writes, dif_errors); -	if (pos < offset) { -		len = 0; -		begin = pos; -	} -	*start = buffer + (offset - begin);	/* Start of wanted data */ -	len -= (offset - begin); -	if (len > length) -		len = length; -	return len; +	return 0;  }  static ssize_t sdebug_delay_show(struct device_driver * ddp, char * buf) @@ -3957,7 +3945,8 @@ write:  static DEF_SCSI_QCMD(scsi_debug_queuecommand)  static struct scsi_host_template sdebug_driver_template = { -	.proc_info =		scsi_debug_proc_info, +	.show_info =		scsi_debug_show_info, +	.write_info =		scsi_debug_write_info,  	.proc_name =		sdebug_proc_name,  	.name =			"SCSI DEBUG",  	.info =			scsi_debug_info,  |