diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-23 11:47:02 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-23 11:47:02 -0700 | 
| commit | 5f05647dd81c11a6a165ccc8f0c1370b16f3bcb0 (patch) | |
| tree | 7851ef1c93aa1aba7ef327ca4b75fd35e6d10f29 /drivers/net/wireless/p54/eeprom.c | |
| parent | 02f36038c568111ad4fc433f6fa760ff5e38fab4 (diff) | |
| parent | ec37a48d1d16c30b655ac5280209edf52a6775d4 (diff) | |
| download | olio-linux-3.10-5f05647dd81c11a6a165ccc8f0c1370b16f3bcb0.tar.xz olio-linux-3.10-5f05647dd81c11a6a165ccc8f0c1370b16f3bcb0.zip  | |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1699 commits)
  bnx2/bnx2x: Unsupported Ethtool operations should return -EINVAL.
  vlan: Calling vlan_hwaccel_do_receive() is always valid.
  tproxy: use the interface primary IP address as a default value for --on-ip
  tproxy: added IPv6 support to the socket match
  cxgb3: function namespace cleanup
  tproxy: added IPv6 support to the TPROXY target
  tproxy: added IPv6 socket lookup function to nf_tproxy_core
  be2net: Changes to use only priority codes allowed by f/w
  tproxy: allow non-local binds of IPv6 sockets if IP_TRANSPARENT is enabled
  tproxy: added tproxy sockopt interface in the IPV6 layer
  tproxy: added udp6_lib_lookup function
  tproxy: added const specifiers to udp lookup functions
  tproxy: split off ipv6 defragmentation to a separate module
  l2tp: small cleanup
  nf_nat: restrict ICMP translation for embedded header
  can: mcp251x: fix generation of error frames
  can: mcp251x: fix endless loop in interrupt handler if CANINTF_MERRF is set
  can-raw: add msg_flags to distinguish local traffic
  9p: client code cleanup
  rds: make local functions/variables static
  ...
Fix up conflicts in net/core/dev.c, drivers/net/pcmcia/smc91c92_cs.c and
drivers/net/wireless/ath/ath9k/debug.c as per David
Diffstat (limited to 'drivers/net/wireless/p54/eeprom.c')
| -rw-r--r-- | drivers/net/wireless/p54/eeprom.c | 25 | 
1 files changed, 21 insertions, 4 deletions
diff --git a/drivers/net/wireless/p54/eeprom.c b/drivers/net/wireless/p54/eeprom.c index 78347041ec4..35b09aa0529 100644 --- a/drivers/net/wireless/p54/eeprom.c +++ b/drivers/net/wireless/p54/eeprom.c @@ -23,6 +23,7 @@  #include <linux/slab.h>  #include <net/mac80211.h> +#include <linux/crc-ccitt.h>  #include "p54.h"  #include "eeprom.h" @@ -260,8 +261,10 @@ static int p54_generate_channel_lists(struct ieee80211_hw *dev)  	list->max_entries = max_channel_num;  	list->channels = kzalloc(sizeof(struct p54_channel_entry) *  				 max_channel_num, GFP_KERNEL); -	if (!list->channels) +	if (!list->channels) { +		ret = -ENOMEM;  		goto free; +	}  	for (i = 0; i < max_channel_num; i++) {  		if (i < priv->iq_autocal_len) { @@ -540,6 +543,7 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)  	int err;  	u8 *end = (u8 *)eeprom + len;  	u16 synth = 0; +	u16 crc16 = ~0;  	wrap = (struct eeprom_pda_wrap *) eeprom;  	entry = (void *)wrap->data + le16_to_cpu(wrap->len); @@ -655,16 +659,29 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)  			}  			break;  		case PDR_END: -			/* make it overrun */ -			entry_len = len; +			crc16 = ~crc_ccitt(crc16, (u8 *) entry, sizeof(*entry)); +			if (crc16 != le16_to_cpup((__le16 *)entry->data)) { +				wiphy_err(dev->wiphy, "eeprom failed checksum " +					 "test!\n"); +				err = -ENOMSG; +				goto err; +			} else { +				goto good_eeprom; +			}  			break;  		default:  			break;  		} -		entry = (void *)entry + (entry_len + 1)*2; +		crc16 = crc_ccitt(crc16, (u8 *)entry, (entry_len + 1) * 2); +		entry = (void *)entry + (entry_len + 1) * 2;  	} +	wiphy_err(dev->wiphy, "unexpected end of eeprom data.\n"); +	err = -ENODATA; +	goto err; + +good_eeprom:  	if (!synth || !priv->iq_autocal || !priv->output_limit ||  	    !priv->curve_data) {  		wiphy_err(dev->wiphy,  |