diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-01 17:51:54 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-01 17:51:54 -0700 | 
| commit | 20b4fb485227404329e41ad15588afad3df23050 (patch) | |
| tree | f3e099f0ab3da8a93b447203e294d2bb22f6dc05 /drivers/net/wireless/atmel.c | |
| parent | b9394d8a657cd3c064fa432aa0905c1b58b38fe9 (diff) | |
| parent | ac3e3c5b1164397656df81b9e9ab4991184d3236 (diff) | |
| download | olio-linux-3.10-20b4fb485227404329e41ad15588afad3df23050.tar.xz olio-linux-3.10-20b4fb485227404329e41ad15588afad3df23050.zip  | |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull VFS updates from Al Viro,
Misc cleanups all over the place, mainly wrt /proc interfaces (switch
create_proc_entry to proc_create(), get rid of the deprecated
create_proc_read_entry() in favor of using proc_create_data() and
seq_file etc).
7kloc removed.
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (204 commits)
  don't bother with deferred freeing of fdtables
  proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h
  proc: Make the PROC_I() and PDE() macros internal to procfs
  proc: Supply a function to remove a proc entry by PDE
  take cgroup_open() and cpuset_open() to fs/proc/base.c
  ppc: Clean up scanlog
  ppc: Clean up rtas_flash driver somewhat
  hostap: proc: Use remove_proc_subtree()
  drm: proc: Use remove_proc_subtree()
  drm: proc: Use minor->index to label things, not PDE->name
  drm: Constify drm_proc_list[]
  zoran: Don't print proc_dir_entry data in debug
  reiserfs: Don't access the proc_dir_entry in r_open(), r_start() r_show()
  proc: Supply an accessor for getting the data from a PDE's parent
  airo: Use remove_proc_subtree()
  rtl8192u: Don't need to save device proc dir PDE
  rtl8187se: Use a dir under /proc/net/r8180/
  proc: Add proc_mkdir_data()
  proc: Move some bits from linux/proc_fs.h to linux/{of.h,signal.h,tty.h}
  proc: Move PDE_NET() to fs/proc/proc_net.c
  ...
Diffstat (limited to 'drivers/net/wireless/atmel.c')
| -rw-r--r-- | drivers/net/wireless/atmel.c | 69 | 
1 files changed, 31 insertions, 38 deletions
diff --git a/drivers/net/wireless/atmel.c b/drivers/net/wireless/atmel.c index 4374079dfc2..23a3498f14d 100644 --- a/drivers/net/wireless/atmel.c +++ b/drivers/net/wireless/atmel.c @@ -63,6 +63,7 @@  #include <net/iw_handler.h>  #include <linux/crc32.h>  #include <linux/proc_fs.h> +#include <linux/seq_file.h>  #include <linux/device.h>  #include <linux/moduleparam.h>  #include <linux/firmware.h> @@ -1409,30 +1410,28 @@ static int atmel_validate_channel(struct atmel_private *priv, int channel)  	return 0;  } -static int atmel_proc_output (char *buf, struct atmel_private *priv) +static int atmel_proc_show(struct seq_file *m, void *v)  { +	struct atmel_private *priv = m->private;  	int i; -	char *p = buf;  	char *s, *r, *c; -	p += sprintf(p, "Driver version:\t\t%d.%d\n", -		     DRIVER_MAJOR, DRIVER_MINOR); +	seq_printf(m, "Driver version:\t\t%d.%d\n", DRIVER_MAJOR, DRIVER_MINOR);  	if (priv->station_state != STATION_STATE_DOWN) { -		p += sprintf(p, "Firmware version:\t%d.%d build %d\n" -				"Firmware location:\t", -			     priv->host_info.major_version, -			     priv->host_info.minor_version, -			     priv->host_info.build_version); +		seq_printf(m, +			   "Firmware version:\t%d.%d build %d\n" +			   "Firmware location:\t", +			   priv->host_info.major_version, +			   priv->host_info.minor_version, +			   priv->host_info.build_version);  		if (priv->card_type != CARD_TYPE_EEPROM) -			p += sprintf(p, "on card\n"); +			seq_puts(m, "on card\n");  		else if (priv->firmware) -			p += sprintf(p, "%s loaded by host\n", -				     priv->firmware_id); +			seq_printf(m, "%s loaded by host\n", priv->firmware_id);  		else -			p += sprintf(p, "%s loaded by hotplug\n", -				     priv->firmware_id); +			seq_printf(m, "%s loaded by hotplug\n", priv->firmware_id);  		switch (priv->card_type) {  		case CARD_TYPE_PARALLEL_FLASH: @@ -1453,12 +1452,12 @@ static int atmel_proc_output (char *buf, struct atmel_private *priv)  			if (priv->reg_domain == channel_table[i].reg_domain)  				r = channel_table[i].name; -		p += sprintf(p, "MAC memory type:\t%s\n", c); -		p += sprintf(p, "Regulatory domain:\t%s\n", r); -		p += sprintf(p, "Host CRC checking:\t%s\n", -			     priv->do_rx_crc ? "On" : "Off"); -		p += sprintf(p, "WPA-capable firmware:\t%s\n", -			     priv->use_wpa ? "Yes" : "No"); +		seq_printf(m, "MAC memory type:\t%s\n", c); +		seq_printf(m, "Regulatory domain:\t%s\n", r); +		seq_printf(m, "Host CRC checking:\t%s\n", +			 priv->do_rx_crc ? "On" : "Off"); +		seq_printf(m, "WPA-capable firmware:\t%s\n", +			 priv->use_wpa ? "Yes" : "No");  	}  	switch (priv->station_state) { @@ -1490,26 +1489,22 @@ static int atmel_proc_output (char *buf, struct atmel_private *priv)  		s = "<unknown>";  	} -	p += sprintf(p, "Current state:\t\t%s\n", s); -	return p - buf; +	seq_printf(m, "Current state:\t\t%s\n", s); +	return 0;  } -static int atmel_read_proc(char *page, char **start, off_t off, -			   int count, int *eof, void *data) +static int atmel_proc_open(struct inode *inode, struct file *file)  { -	struct atmel_private *priv = data; -	int len = atmel_proc_output (page, priv); -	if (len <= off+count) -		*eof = 1; -	*start = page + off; -	len -= off; -	if (len > count) -		len = count; -	if (len < 0) -		len = 0; -	return len; +	return single_open(file, atmel_proc_show, PDE_DATA(inode));  } +static const struct file_operations atmel_proc_fops = { +	.open		= atmel_proc_open, +	.read		= seq_read, +	.llseek		= seq_lseek, +	.release	= seq_release, +}; +  static const struct net_device_ops atmel_netdev_ops = {  	.ndo_open 		= atmel_open,  	.ndo_stop		= atmel_close, @@ -1525,7 +1520,6 @@ struct net_device *init_atmel_card(unsigned short irq, unsigned long port,  				   struct device *sys_dev,  				   int (*card_present)(void *), void *card)  { -	struct proc_dir_entry *ent;  	struct net_device *dev;  	struct atmel_private *priv;  	int rc; @@ -1630,8 +1624,7 @@ struct net_device *init_atmel_card(unsigned short irq, unsigned long port,  	netif_carrier_off(dev); -	ent = create_proc_read_entry ("driver/atmel", 0, NULL, atmel_read_proc, priv); -	if (!ent) +	if (!proc_create_data("driver/atmel", 0, NULL, &atmel_proc_fops, priv));  		printk(KERN_WARNING "atmel: unable to create /proc entry.\n");  	printk(KERN_INFO "%s: Atmel at76c50x. Version %d.%d. MAC %pM\n",  |