diff options
| author | Bruce Allan <bruce.w.allan@intel.com> | 2013-02-20 04:05:39 +0000 | 
|---|---|---|
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2013-03-08 00:16:40 -0800 | 
| commit | f0ff439872e1eab81940d736a5683e93b44865e3 (patch) | |
| tree | caf7f9cde3c0e2d4541ce1d081d5655eb33a5100 /drivers/net/ethernet/intel/e1000e/phy.c | |
| parent | 39ba22b413723e1e3981d915a542ad6c24e3c919 (diff) | |
| download | olio-linux-3.10-f0ff439872e1eab81940d736a5683e93b44865e3.tar.xz olio-linux-3.10-f0ff439872e1eab81940d736a5683e93b44865e3.zip  | |
e1000e: cleanup CODE_INDENT checkpatch errors
ERROR:CODE_INDENT: code indent should use tabs where possible
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/e1000e/phy.c')
| -rw-r--r-- | drivers/net/ethernet/intel/e1000e/phy.c | 81 | 
1 files changed, 40 insertions, 41 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c index 0930c136aa3..c39a65e293f 100644 --- a/drivers/net/ethernet/intel/e1000e/phy.c +++ b/drivers/net/ethernet/intel/e1000e/phy.c @@ -1609,9 +1609,9 @@ s32 e1000_check_polarity_m88(struct e1000_hw *hw)  	ret_val = e1e_rphy(hw, M88E1000_PHY_SPEC_STATUS, &data);  	if (!ret_val) -		phy->cable_polarity = (data & M88E1000_PSSR_REV_POLARITY) -				      ? e1000_rev_polarity_reversed -				      : e1000_rev_polarity_normal; +		phy->cable_polarity = ((data & M88E1000_PSSR_REV_POLARITY) +				       ? e1000_rev_polarity_reversed +				       : e1000_rev_polarity_normal);  	return ret_val;  } @@ -1653,9 +1653,9 @@ s32 e1000_check_polarity_igp(struct e1000_hw *hw)  	ret_val = e1e_rphy(hw, offset, &data);  	if (!ret_val) -		phy->cable_polarity = (data & mask) -				      ? e1000_rev_polarity_reversed -				      : e1000_rev_polarity_normal; +		phy->cable_polarity = ((data & mask) +				       ? e1000_rev_polarity_reversed +				       : e1000_rev_polarity_normal);  	return ret_val;  } @@ -1685,9 +1685,9 @@ s32 e1000_check_polarity_ife(struct e1000_hw *hw)  	ret_val = e1e_rphy(hw, offset, &phy_data);  	if (!ret_val) -		phy->cable_polarity = (phy_data & mask) -		                       ? e1000_rev_polarity_reversed -		                       : e1000_rev_polarity_normal; +		phy->cable_polarity = ((phy_data & mask) +				       ? e1000_rev_polarity_reversed +				       : e1000_rev_polarity_normal);  	return ret_val;  } @@ -1791,8 +1791,8 @@ s32 e1000e_get_cable_length_m88(struct e1000_hw *hw)  	if (ret_val)  		return ret_val; -	index = (phy_data & M88E1000_PSSR_CABLE_LENGTH) >> -	        M88E1000_PSSR_CABLE_LENGTH_SHIFT; +	index = ((phy_data & M88E1000_PSSR_CABLE_LENGTH) >> +		 M88E1000_PSSR_CABLE_LENGTH_SHIFT);  	if (index >= M88E1000_CABLE_LENGTH_TABLE_SIZE - 1)  		return -E1000_ERR_PHY; @@ -1824,10 +1824,10 @@ s32 e1000e_get_cable_length_igp_2(struct e1000_hw *hw)  	u16 cur_agc_index, max_agc_index = 0;  	u16 min_agc_index = IGP02E1000_CABLE_LENGTH_TABLE_SIZE - 1;  	static const u16 agc_reg_array[IGP02E1000_PHY_CHANNEL_NUM] = { -	       IGP02E1000_PHY_AGC_A, -	       IGP02E1000_PHY_AGC_B, -	       IGP02E1000_PHY_AGC_C, -	       IGP02E1000_PHY_AGC_D +		IGP02E1000_PHY_AGC_A, +		IGP02E1000_PHY_AGC_B, +		IGP02E1000_PHY_AGC_C, +		IGP02E1000_PHY_AGC_D  	};  	/* Read the AGC registers for all channels */ @@ -1841,8 +1841,8 @@ s32 e1000e_get_cable_length_igp_2(struct e1000_hw *hw)  		 * that can be put into the lookup table to obtain the  		 * approximate cable length.  		 */ -		cur_agc_index = (phy_data >> IGP02E1000_AGC_LENGTH_SHIFT) & -				IGP02E1000_AGC_LENGTH_MASK; +		cur_agc_index = ((phy_data >> IGP02E1000_AGC_LENGTH_SHIFT) & +				 IGP02E1000_AGC_LENGTH_MASK);  		/* Array index bound check. */  		if ((cur_agc_index >= IGP02E1000_CABLE_LENGTH_TABLE_SIZE) || @@ -1865,8 +1865,8 @@ s32 e1000e_get_cable_length_igp_2(struct e1000_hw *hw)  	agc_value /= (IGP02E1000_PHY_CHANNEL_NUM - 2);  	/* Calculate cable length with the error range of +/- 10 meters. */ -	phy->min_cable_length = ((agc_value - IGP02E1000_AGC_RANGE) > 0) ? -				 (agc_value - IGP02E1000_AGC_RANGE) : 0; +	phy->min_cable_length = (((agc_value - IGP02E1000_AGC_RANGE) > 0) ? +				 (agc_value - IGP02E1000_AGC_RANGE) : 0);  	phy->max_cable_length = agc_value + IGP02E1000_AGC_RANGE;  	phy->cable_length = (phy->min_cable_length + phy->max_cable_length) / 2; @@ -2040,9 +2040,9 @@ s32 e1000_get_phy_info_ife(struct e1000_hw *hw)  			return ret_val;  	} else {  		/* Polarity is forced */ -		phy->cable_polarity = (data & IFE_PSC_FORCE_POLARITY) -		                      ? e1000_rev_polarity_reversed -		                      : e1000_rev_polarity_normal; +		phy->cable_polarity = ((data & IFE_PSC_FORCE_POLARITY) +				       ? e1000_rev_polarity_reversed +				       : e1000_rev_polarity_normal);  	}  	ret_val = e1e_rphy(hw, IFE_PHY_MDIX_CONTROL, &data); @@ -2375,13 +2375,13 @@ s32 e1000e_write_phy_reg_bm(struct e1000_hw *hw, u32 offset, u16 data)  		/* Page is shifted left, PHY expects (page x 32) */  		ret_val = e1000e_write_phy_reg_mdic(hw, page_select, -		                                    (page << page_shift)); +						    (page << page_shift));  		if (ret_val)  			goto release;  	}  	ret_val = e1000e_write_phy_reg_mdic(hw, MAX_PHY_REG_ADDRESS & offset, -	                                    data); +					    data);  release:  	hw->phy.ops.release(hw); @@ -2433,13 +2433,13 @@ s32 e1000e_read_phy_reg_bm(struct e1000_hw *hw, u32 offset, u16 *data)  		/* Page is shifted left, PHY expects (page x 32) */  		ret_val = e1000e_write_phy_reg_mdic(hw, page_select, -		                                    (page << page_shift)); +						    (page << page_shift));  		if (ret_val)  			goto release;  	}  	ret_val = e1000e_read_phy_reg_mdic(hw, MAX_PHY_REG_ADDRESS & offset, -	                                   data); +					   data);  release:  	hw->phy.ops.release(hw);  	return ret_val; @@ -2674,7 +2674,7 @@ static s32 e1000_access_phy_wakeup_reg_bm(struct e1000_hw *hw, u32 offset,  	if (read) {  		/* Read the Wakeup register page value using opcode 0x12 */  		ret_val = e1000e_read_phy_reg_mdic(hw, BM_WUC_DATA_OPCODE, -		                                   data); +						   data);  	} else {  		/* Write the Wakeup register page value using opcode 0x12 */  		ret_val = e1000e_write_phy_reg_mdic(hw, BM_WUC_DATA_OPCODE, @@ -2763,7 +2763,7 @@ static s32 __e1000_read_phy_reg_hv(struct e1000_hw *hw, u32 offset, u16 *data,  	if (page > 0 && page < HV_INTC_FC_PAGE_START) {  		ret_val = e1000_access_phy_debug_regs_hv(hw, offset, -		                                         data, true); +							 data, true);  		goto out;  	} @@ -2786,8 +2786,7 @@ static s32 __e1000_read_phy_reg_hv(struct e1000_hw *hw, u32 offset, u16 *data,  	e_dbg("reading PHY page %d (or 0x%x shifted) reg 0x%x\n", page,  	      page << IGP_PAGE_SHIFT, reg); -	ret_val = e1000e_read_phy_reg_mdic(hw, MAX_PHY_REG_ADDRESS & reg, -	                                  data); +	ret_val = e1000e_read_phy_reg_mdic(hw, MAX_PHY_REG_ADDRESS & reg, data);  out:  	if (!locked)  		hw->phy.ops.release(hw); @@ -2871,7 +2870,7 @@ static s32 __e1000_write_phy_reg_hv(struct e1000_hw *hw, u32 offset, u16 data,  	if (page > 0 && page < HV_INTC_FC_PAGE_START) {  		ret_val = e1000_access_phy_debug_regs_hv(hw, offset, -		                                         &data, false); +							 &data, false);  		goto out;  	} @@ -2910,7 +2909,7 @@ static s32 __e1000_write_phy_reg_hv(struct e1000_hw *hw, u32 offset, u16 data,  	      page << IGP_PAGE_SHIFT, reg);  	ret_val = e1000e_write_phy_reg_mdic(hw, MAX_PHY_REG_ADDRESS & reg, -	                                  data); +					    data);  out:  	if (!locked) @@ -2995,8 +2994,8 @@ static s32 e1000_access_phy_debug_regs_hv(struct e1000_hw *hw, u32 offset,  	u32 data_reg;  	/* This takes care of the difference with desktop vs mobile phy */ -	addr_reg = (hw->phy.type == e1000_phy_82578) ? -	           I82578_ADDR_REG : I82577_ADDR_REG; +	addr_reg = ((hw->phy.type == e1000_phy_82578) ? +		    I82578_ADDR_REG : I82577_ADDR_REG);  	data_reg = addr_reg + 1;  	/* All operations in this function are phy address 2 */ @@ -3050,8 +3049,8 @@ s32 e1000_link_stall_workaround_hv(struct e1000_hw *hw)  	if (ret_val)  		return ret_val; -	data &= BM_CS_STATUS_LINK_UP | BM_CS_STATUS_RESOLVED | -		BM_CS_STATUS_SPEED_MASK; +	data &= (BM_CS_STATUS_LINK_UP | BM_CS_STATUS_RESOLVED | +		 BM_CS_STATUS_SPEED_MASK);  	if (data != (BM_CS_STATUS_LINK_UP | BM_CS_STATUS_RESOLVED |  		     BM_CS_STATUS_SPEED_1000)) @@ -3086,9 +3085,9 @@ s32 e1000_check_polarity_82577(struct e1000_hw *hw)  	ret_val = e1e_rphy(hw, I82577_PHY_STATUS_2, &data);  	if (!ret_val) -		phy->cable_polarity = (data & I82577_PHY_STATUS2_REV_POLARITY) -		                      ? e1000_rev_polarity_reversed -		                      : e1000_rev_polarity_normal; +		phy->cable_polarity = ((data & I82577_PHY_STATUS2_REV_POLARITY) +				       ? e1000_rev_polarity_reversed +				       : e1000_rev_polarity_normal);  	return ret_val;  } @@ -3215,8 +3214,8 @@ s32 e1000_get_cable_length_82577(struct e1000_hw *hw)  	if (ret_val)  		return ret_val; -	length = (phy_data & I82577_DSTATUS_CABLE_LENGTH) >> -	         I82577_DSTATUS_CABLE_LENGTH_SHIFT; +	length = ((phy_data & I82577_DSTATUS_CABLE_LENGTH) >> +		  I82577_DSTATUS_CABLE_LENGTH_SHIFT);  	if (length == E1000_CABLE_LENGTH_UNDEFINED)  		return -E1000_ERR_PHY;  |