diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2010-05-10 11:59:37 +0200 | 
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2010-05-10 14:20:42 +0200 | 
| commit | dbb6be6d5e974c42bbecd183effaa0df69e1dd8b (patch) | |
| tree | 5735cb47e70853d057a9881dd0ce44b83e88fa63 /drivers/acpi/ec.c | |
| parent | 6a867a395558a7f882d041783e4cdea6744ca2bf (diff) | |
| parent | b57f95a38233a2e73b679bea4a5453a1cc2a1cc9 (diff) | |
| download | olio-linux-3.10-dbb6be6d5e974c42bbecd183effaa0df69e1dd8b.tar.xz olio-linux-3.10-dbb6be6d5e974c42bbecd183effaa0df69e1dd8b.zip  | |
Merge branch 'linus' into timers/core
Reason: Further posix_cpu_timer patches depend on mainline changes
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/acpi/ec.c')
| -rw-r--r-- | drivers/acpi/ec.c | 36 | 
1 files changed, 10 insertions, 26 deletions
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 1ac28c6a672..f2234db85da 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -39,6 +39,7 @@  #include <linux/interrupt.h>  #include <linux/list.h>  #include <linux/spinlock.h> +#include <linux/slab.h>  #include <asm/io.h>  #include <acpi/acpi_bus.h>  #include <acpi/acpi_drivers.h> @@ -628,12 +629,12 @@ static u32 acpi_ec_gpe_handler(void *data)  static acpi_status  acpi_ec_space_handler(u32 function, acpi_physical_address address, -		      u32 bits, u64 *value, +		      u32 bits, u64 *value64,  		      void *handler_context, void *region_context)  {  	struct acpi_ec *ec = handler_context; -	int result = 0, i; -	u8 temp = 0; +	int result = 0, i, bytes = bits / 8; +	u8 *value = (u8 *)value64;  	if ((address > 0xFF) || !value || !handler_context)  		return AE_BAD_PARAMETER; @@ -641,32 +642,15 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,  	if (function != ACPI_READ && function != ACPI_WRITE)  		return AE_BAD_PARAMETER; -	if (bits != 8 && acpi_strict) -		return AE_BAD_PARAMETER; - -	if (EC_FLAGS_MSI) +	if (EC_FLAGS_MSI || bits > 8)  		acpi_ec_burst_enable(ec); -	if (function == ACPI_READ) { -		result = acpi_ec_read(ec, address, &temp); -		*value = temp; -	} else { -		temp = 0xff & (*value); -		result = acpi_ec_write(ec, address, temp); -	} - -	for (i = 8; unlikely(bits - i > 0); i += 8) { -		++address; -		if (function == ACPI_READ) { -			result = acpi_ec_read(ec, address, &temp); -			(*value) |= ((u64)temp) << i; -		} else { -			temp = 0xff & ((*value) >> i); -			result = acpi_ec_write(ec, address, temp); -		} -	} +	for (i = 0; i < bytes; ++i, ++address, ++value) +		result = (function == ACPI_READ) ? +			acpi_ec_read(ec, address, value) : +			acpi_ec_write(ec, address, *value); -	if (EC_FLAGS_MSI) +	if (EC_FLAGS_MSI || bits > 8)  		acpi_ec_burst_disable(ec);  	switch (result) {  |