diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-23 18:11:45 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-23 18:11:45 -0700 | 
| commit | f9369910a6225b8d4892c3f20ae740a711cd5ace (patch) | |
| tree | 8650ff79d7607bceb35509c028400ecf1c317de0 /arch/score/kernel/signal.c | |
| parent | 05f144a0d5c2207a0349348127f996e104ad7404 (diff) | |
| parent | 415d04d08fec74b226c92c1fb54ad117c9c6bac4 (diff) | |
| download | olio-linux-3.10-f9369910a6225b8d4892c3f20ae740a711cd5ace.tar.xz olio-linux-3.10-f9369910a6225b8d4892c3f20ae740a711cd5ace.zip  | |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal
Pull first series of signal handling cleanups from Al Viro:
 "This is just the first part of the queue (about a half of it);
  assorted fixes all over the place in signal handling.
  This one ends with all sigsuspend() implementations switched to
  generic one (->saved_sigmask-based).
  With this, a bunch of assorted old buglets are fixed and most of the
  missing bits of NOTIFY_RESUME hookup are in place.  Two more fixes sit
  in arm and um trees respectively, and there's a couple of broken ones
  that need obvious fixes - parisc and avr32 check TIF_NOTIFY_RESUME
  only on one of two codepaths; fixes for that will happen in the next
  series"
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal: (55 commits)
  unicore32: if there's no handler we need to restore sigmask, syscall or no syscall
  xtensa: add handling of TIF_NOTIFY_RESUME
  microblaze: drop 'oldset' argument of do_notify_resume()
  microblaze: handle TIF_NOTIFY_RESUME
  score: add handling of NOTIFY_RESUME to do_notify_resume()
  m68k: add TIF_NOTIFY_RESUME and handle it.
  sparc: kill ancient comment in sparc_sigaction()
  h8300: missing checks of __get_user()/__put_user() return values
  frv: missing checks of __get_user()/__put_user() return values
  cris: missing checks of __get_user()/__put_user() return values
  powerpc: missing checks of __get_user()/__put_user() return values
  sh: missing checks of __get_user()/__put_user() return values
  sparc: missing checks of __get_user()/__put_user() return values
  avr32: struct old_sigaction is never used
  m32r: struct old_sigaction is never used
  xtensa: xtensa_sigaction doesn't exist
  alpha: tidy signal delivery up
  score: don't open-code force_sigsegv()
  cris: don't open-code force_sigsegv()
  blackfin: don't open-code force_sigsegv()
  ...
Diffstat (limited to 'arch/score/kernel/signal.c')
| -rw-r--r-- | arch/score/kernel/signal.c | 29 | 
1 files changed, 15 insertions, 14 deletions
diff --git a/arch/score/kernel/signal.c b/arch/score/kernel/signal.c index aa57440e497..d4a49011c48 100644 --- a/arch/score/kernel/signal.c +++ b/arch/score/kernel/signal.c @@ -28,6 +28,7 @@  #include <linux/ptrace.h>  #include <linux/unistd.h>  #include <linux/uaccess.h> +#include <linux/tracehook.h>  #include <asm/cacheflush.h>  #include <asm/syscalls.h> @@ -152,6 +153,9 @@ score_rt_sigreturn(struct pt_regs *regs)  	stack_t st;  	int sig; +	/* Always make any pending restarted system calls return -EINTR */ +	current_thread_info()->restart_block.fn = do_no_restart_syscall; +  	frame = (struct rt_sigframe __user *) regs->regs[0];  	if (!access_ok(VERIFY_READ, frame, sizeof(*frame)))  		goto badframe; @@ -159,10 +163,7 @@ score_rt_sigreturn(struct pt_regs *regs)  		goto badframe;  	sigdelsetmask(&set, ~_BLOCKABLE); -	spin_lock_irq(¤t->sighand->siglock); -	current->blocked = set; -	recalc_sigpending(); -	spin_unlock_irq(¤t->sighand->siglock); +	set_current_blocked(&set);  	sig = restore_sigcontext(regs, &frame->rs_uc.uc_mcontext);  	if (sig < 0) @@ -236,9 +237,7 @@ static int setup_rt_frame(struct k_sigaction *ka, struct pt_regs *regs,  	return 0;  give_sigsegv: -	if (signr == SIGSEGV) -		ka->sa.sa_handler = SIG_DFL; -	force_sig(SIGSEGV, current); +	force_sigsegv(signr, current);  	return -EFAULT;  } @@ -272,12 +271,8 @@ static int handle_signal(unsigned long sig, siginfo_t *info,  	 */  	ret = setup_rt_frame(ka, regs, sig, oldset, info); -	spin_lock_irq(¤t->sighand->siglock); -	sigorsets(¤t->blocked, ¤t->blocked, &ka->sa.sa_mask); -	if (!(ka->sa.sa_flags & SA_NODEFER)) -		sigaddset(¤t->blocked, sig); -	recalc_sigpending(); -	spin_unlock_irq(¤t->sighand->siglock); +	if (ret == 0) +		block_sigmask(ka, sig);  	return ret;  } @@ -356,6 +351,12 @@ asmlinkage void do_notify_resume(struct pt_regs *regs, void *unused,  				__u32 thread_info_flags)  {  	/* deal with pending signal delivery */ -	if (thread_info_flags & (_TIF_SIGPENDING | _TIF_RESTORE_SIGMASK)) +	if (thread_info_flags & _TIF_SIGPENDING)  		do_signal(regs); +	if (thread_info_flags & _TIF_NOTIFY_RESUME) { +		clear_thread_flag(TIF_NOTIFY_RESUME); +		tracehook_notify_resume(regs); +		if (current->replacement_session_keyring) +			key_replace_session_keyring(); +	}  }  |