diff options
| author | Borislav Petkov <borislav.petkov@amd.com> | 2012-07-20 14:12:21 +0200 | 
|---|---|---|
| committer | H. Peter Anvin <hpa@linux.intel.com> | 2012-08-22 16:15:26 -0700 | 
| commit | e7e632f5ba240fbc313c49ed6559681ea57534e9 (patch) | |
| tree | 90ba39cc1717c9348f287224b09ac09b27aae9b8 | |
| parent | e43f6e67ec1c142550860bbe0b51166c5ee4cac8 (diff) | |
| download | olio-linux-3.10-e7e632f5ba240fbc313c49ed6559681ea57534e9.tar.xz olio-linux-3.10-e7e632f5ba240fbc313c49ed6559681ea57534e9.zip  | |
x86, microcode, AMD: Remove useless get_ucode_data wrapper
get_ucode_data was a trivial memcpy wrapper. Remove it so as not to
obfuscate code unnecessarily with no obvious gain.
No functional change.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Link: http://lkml.kernel.org/r/1344361461-10076-7-git-send-email-bp@amd64.org
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
| -rw-r--r-- | arch/x86/include/asm/microcode.h | 6 | ||||
| -rw-r--r-- | arch/x86/kernel/microcode_amd.c | 4 | 
2 files changed, 2 insertions, 8 deletions
diff --git a/arch/x86/include/asm/microcode.h b/arch/x86/include/asm/microcode.h index 4ebe157bf73..8813be60099 100644 --- a/arch/x86/include/asm/microcode.h +++ b/arch/x86/include/asm/microcode.h @@ -49,12 +49,6 @@ static inline struct microcode_ops * __init init_intel_microcode(void)  #ifdef CONFIG_MICROCODE_AMD  extern struct microcode_ops * __init init_amd_microcode(void);  extern void __exit exit_amd_microcode(void); - -static inline void get_ucode_data(void *to, const u8 *from, size_t n) -{ -	memcpy(to, from, n); -} -  #else  static inline struct microcode_ops * __init init_amd_microcode(void)  { diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c index 82746f942cd..94213387a3d 100644 --- a/arch/x86/kernel/microcode_amd.c +++ b/arch/x86/kernel/microcode_amd.c @@ -183,7 +183,7 @@ static int get_matching_microcode(int cpu, const u8 *ucode_ptr,  	memset(patch, 0, PAGE_SIZE);  	/* all looks ok, get the binary patch */ -	get_ucode_data(patch, ucode_ptr + SECTION_HDR_SIZE, actual_size); +	memcpy(patch, ucode_ptr + SECTION_HDR_SIZE, actual_size);  	return actual_size;  } @@ -238,7 +238,7 @@ static int install_equiv_cpu_table(const u8 *buf)  		return -ENOMEM;  	} -	get_ucode_data(equiv_cpu_table, buf + CONTAINER_HDR_SZ, size); +	memcpy(equiv_cpu_table, buf + CONTAINER_HDR_SZ, size);  	/* add header length */  	return size + CONTAINER_HDR_SZ;  |