diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-09-18 12:50:11 -0700 | 
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2009-09-30 21:47:01 +0200 | 
| commit | 971842677c5a6c1dd15d9a80b67bf0085686e574 (patch) | |
| tree | 748000b70d862e3f6783b3894db6e7a8cbb03594 | |
| parent | c2e32149074501fc12f6e05f85812e07148a2276 (diff) | |
| download | olio-linux-3.10-971842677c5a6c1dd15d9a80b67bf0085686e574.tar.xz olio-linux-3.10-971842677c5a6c1dd15d9a80b67bf0085686e574.zip  | |
MIPS: MSP71xx: request_irq() failure ignored in msp_pcibios_config_access()
Produce an error if request_irq() fails.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: "Ithamar R. Adema" <ithamar.adema@team-embedded.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
| -rw-r--r-- | arch/mips/pci/ops-pmcmsp.c | 5 | 
1 files changed, 4 insertions, 1 deletions
diff --git a/arch/mips/pci/ops-pmcmsp.c b/arch/mips/pci/ops-pmcmsp.c index 109c95ca698..32548b5d68d 100644 --- a/arch/mips/pci/ops-pmcmsp.c +++ b/arch/mips/pci/ops-pmcmsp.c @@ -385,6 +385,7 @@ int msp_pcibios_config_access(unsigned char access_type,  	unsigned long intr;  	unsigned long value;  	static char pciirqflag; +	int ret;  #if defined(CONFIG_PMC_MSP7120_GW) || defined(CONFIG_PMC_MSP7120_EVAL)  	unsigned int	vpe_status;  #endif @@ -402,11 +403,13 @@ int msp_pcibios_config_access(unsigned char access_type,  	 * allocation assigns an interrupt handler to the interrupt.  	 */  	if (pciirqflag == 0) { -		request_irq(MSP_INT_PCI,/* Hardcoded internal MSP7120 wiring */ +		ret = request_irq(MSP_INT_PCI,/* Hardcoded internal MSP7120 wiring */  				bpci_interrupt,  				IRQF_SHARED | IRQF_DISABLED,  				"PMC MSP PCI Host",  				preg); +		if (ret != 0) +			return ret;  		pciirqflag = ~0;  	}  |