diff options
| author | Hans Verkuil <hans.verkuil@cisco.com> | 2012-09-04 11:46:09 -0300 | 
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-09-26 10:48:52 -0300 | 
| commit | 85f5fe3962ca6780e5368feffe32f3b15e953e1f (patch) | |
| tree | e3a5441ee86e62d3ca8423308f32c7a32ae68677 | |
| parent | ec6f4328108f1c83d5ac907c0d978fa886ef9627 (diff) | |
| download | olio-linux-3.10-85f5fe3962ca6780e5368feffe32f3b15e953e1f.tar.xz olio-linux-3.10-85f5fe3962ca6780e5368feffe32f3b15e953e1f.zip  | |
[media] v4l2: make vidioc_(un)subscribe_event const
Write-only ioctls should have a const argument in the ioctl op.
Do this conversion for vidioc_(un)subscribe_event.
Adding const for write-only ioctls was decided during the 2012 Media Workshop.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/media/pci/ivtv/ivtv-ioctl.c | 2 | ||||
| -rw-r--r-- | drivers/media/platform/omap3isp/ispccdc.c | 4 | ||||
| -rw-r--r-- | drivers/media/platform/omap3isp/ispstat.c | 4 | ||||
| -rw-r--r-- | drivers/media/platform/omap3isp/ispstat.h | 4 | ||||
| -rw-r--r-- | drivers/media/v4l2-core/v4l2-ctrls.c | 2 | ||||
| -rw-r--r-- | drivers/media/v4l2-core/v4l2-event.c | 4 | ||||
| -rw-r--r-- | include/media/v4l2-ctrls.h | 2 | ||||
| -rw-r--r-- | include/media/v4l2-event.h | 4 | ||||
| -rw-r--r-- | include/media/v4l2-ioctl.h | 4 | 
9 files changed, 15 insertions, 15 deletions
diff --git a/drivers/media/pci/ivtv/ivtv-ioctl.c b/drivers/media/pci/ivtv/ivtv-ioctl.c index d3b32c2d034..966abb40730 100644 --- a/drivers/media/pci/ivtv/ivtv-ioctl.c +++ b/drivers/media/pci/ivtv/ivtv-ioctl.c @@ -1460,7 +1460,7 @@ static int ivtv_overlay(struct file *file, void *fh, unsigned int on)  	return 0;  } -static int ivtv_subscribe_event(struct v4l2_fh *fh, struct v4l2_event_subscription *sub) +static int ivtv_subscribe_event(struct v4l2_fh *fh, const struct v4l2_event_subscription *sub)  {  	switch (sub->type) {  	case V4L2_EVENT_VSYNC: diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index aa9df9d71a7..60181ab9606 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -1706,7 +1706,7 @@ static long ccdc_ioctl(struct v4l2_subdev *sd, unsigned int cmd, void *arg)  }  static int ccdc_subscribe_event(struct v4l2_subdev *sd, struct v4l2_fh *fh, -				struct v4l2_event_subscription *sub) +				const struct v4l2_event_subscription *sub)  {  	if (sub->type != V4L2_EVENT_FRAME_SYNC)  		return -EINVAL; @@ -1719,7 +1719,7 @@ static int ccdc_subscribe_event(struct v4l2_subdev *sd, struct v4l2_fh *fh,  }  static int ccdc_unsubscribe_event(struct v4l2_subdev *sd, struct v4l2_fh *fh, -				  struct v4l2_event_subscription *sub) +				  const struct v4l2_event_subscription *sub)  {  	return v4l2_event_unsubscribe(fh, sub);  } diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index b8640be692f..d7ac76b5c2a 100644 --- a/drivers/media/platform/omap3isp/ispstat.c +++ b/drivers/media/platform/omap3isp/ispstat.c @@ -1025,7 +1025,7 @@ void omap3isp_stat_dma_isr(struct ispstat *stat)  int omap3isp_stat_subscribe_event(struct v4l2_subdev *subdev,  				  struct v4l2_fh *fh, -				  struct v4l2_event_subscription *sub) +				  const struct v4l2_event_subscription *sub)  {  	struct ispstat *stat = v4l2_get_subdevdata(subdev); @@ -1037,7 +1037,7 @@ int omap3isp_stat_subscribe_event(struct v4l2_subdev *subdev,  int omap3isp_stat_unsubscribe_event(struct v4l2_subdev *subdev,  				    struct v4l2_fh *fh, -				    struct v4l2_event_subscription *sub) +				    const struct v4l2_event_subscription *sub)  {  	return v4l2_event_unsubscribe(fh, sub);  } diff --git a/drivers/media/platform/omap3isp/ispstat.h b/drivers/media/platform/omap3isp/ispstat.h index 9b7c8654dc8..a6fe653eb23 100644 --- a/drivers/media/platform/omap3isp/ispstat.h +++ b/drivers/media/platform/omap3isp/ispstat.h @@ -147,10 +147,10 @@ int omap3isp_stat_init(struct ispstat *stat, const char *name,  void omap3isp_stat_cleanup(struct ispstat *stat);  int omap3isp_stat_subscribe_event(struct v4l2_subdev *subdev,  				  struct v4l2_fh *fh, -				  struct v4l2_event_subscription *sub); +				  const struct v4l2_event_subscription *sub);  int omap3isp_stat_unsubscribe_event(struct v4l2_subdev *subdev,  				    struct v4l2_fh *fh, -				    struct v4l2_event_subscription *sub); +				    const struct v4l2_event_subscription *sub);  int omap3isp_stat_s_stream(struct v4l2_subdev *subdev, int enable);  int omap3isp_stat_busy(struct ispstat *stat); diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index ab287f23680..f40003550b6 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -2699,7 +2699,7 @@ int v4l2_ctrl_log_status(struct file *file, void *fh)  EXPORT_SYMBOL(v4l2_ctrl_log_status);  int v4l2_ctrl_subscribe_event(struct v4l2_fh *fh, -				struct v4l2_event_subscription *sub) +				const struct v4l2_event_subscription *sub)  {  	if (sub->type == V4L2_EVENT_CTRL)  		return v4l2_event_subscribe(fh, sub, 0, &v4l2_ctrl_sub_ev_ops); diff --git a/drivers/media/v4l2-core/v4l2-event.c b/drivers/media/v4l2-core/v4l2-event.c index ef2a33c9404..18a040b935a 100644 --- a/drivers/media/v4l2-core/v4l2-event.c +++ b/drivers/media/v4l2-core/v4l2-event.c @@ -203,7 +203,7 @@ int v4l2_event_pending(struct v4l2_fh *fh)  EXPORT_SYMBOL_GPL(v4l2_event_pending);  int v4l2_event_subscribe(struct v4l2_fh *fh, -			 struct v4l2_event_subscription *sub, unsigned elems, +			 const struct v4l2_event_subscription *sub, unsigned elems,  			 const struct v4l2_subscribed_event_ops *ops)  {  	struct v4l2_subscribed_event *sev, *found_ev; @@ -278,7 +278,7 @@ void v4l2_event_unsubscribe_all(struct v4l2_fh *fh)  EXPORT_SYMBOL_GPL(v4l2_event_unsubscribe_all);  int v4l2_event_unsubscribe(struct v4l2_fh *fh, -			   struct v4l2_event_subscription *sub) +			   const struct v4l2_event_subscription *sub)  {  	struct v4l2_subscribed_event *sev;  	unsigned long flags; diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 7ef6b27d450..6890f5e11ad 100644 --- a/include/media/v4l2-ctrls.h +++ b/include/media/v4l2-ctrls.h @@ -546,7 +546,7 @@ int v4l2_ctrl_log_status(struct file *file, void *fh);  /* Can be used as a vidioc_subscribe_event function that just subscribes     control events. */  int v4l2_ctrl_subscribe_event(struct v4l2_fh *fh, -				struct v4l2_event_subscription *sub); +				const struct v4l2_event_subscription *sub);  /* Can be used as a poll function that just polls for control events. */  unsigned int v4l2_ctrl_poll(struct file *file, struct poll_table_struct *wait); diff --git a/include/media/v4l2-event.h b/include/media/v4l2-event.h index 2885a810a12..e7c5d170a9c 100644 --- a/include/media/v4l2-event.h +++ b/include/media/v4l2-event.h @@ -124,10 +124,10 @@ void v4l2_event_queue(struct video_device *vdev, const struct v4l2_event *ev);  void v4l2_event_queue_fh(struct v4l2_fh *fh, const struct v4l2_event *ev);  int v4l2_event_pending(struct v4l2_fh *fh);  int v4l2_event_subscribe(struct v4l2_fh *fh, -			 struct v4l2_event_subscription *sub, unsigned elems, +			 const struct v4l2_event_subscription *sub, unsigned elems,  			 const struct v4l2_subscribed_event_ops *ops);  int v4l2_event_unsubscribe(struct v4l2_fh *fh, -			   struct v4l2_event_subscription *sub); +			   const struct v4l2_event_subscription *sub);  void v4l2_event_unsubscribe_all(struct v4l2_fh *fh);  #endif /* V4L2_EVENT_H */ diff --git a/include/media/v4l2-ioctl.h b/include/media/v4l2-ioctl.h index 865f95d92ba..3eef4de0ca3 100644 --- a/include/media/v4l2-ioctl.h +++ b/include/media/v4l2-ioctl.h @@ -273,9 +273,9 @@ struct v4l2_ioctl_ops {  				    struct v4l2_dv_timings_cap *cap);  	int (*vidioc_subscribe_event)  (struct v4l2_fh *fh, -					struct v4l2_event_subscription *sub); +					const struct v4l2_event_subscription *sub);  	int (*vidioc_unsubscribe_event)(struct v4l2_fh *fh, -					struct v4l2_event_subscription *sub); +					const struct v4l2_event_subscription *sub);  	/* For other private ioctls */  	long (*vidioc_default)	       (struct file *file, void *fh,  |