diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-10-26 23:15:05 +0800 | 
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2012-10-27 18:17:30 +0200 | 
| commit | 2cad6a8a4c31175578943f087e1dbef9f52e6ec3 (patch) | |
| tree | 0330e57e54075028a76613c9adf46a5a9ea48637 | |
| parent | a362605b341d95e7209ead8052363cb28dda1c44 (diff) | |
| download | olio-linux-3.10-2cad6a8a4c31175578943f087e1dbef9f52e6ec3.tar.xz olio-linux-3.10-2cad6a8a4c31175578943f087e1dbef9f52e6ec3.zip  | |
GPIO: clps711x: use platform_device_unregister in gpio_clps711x_init()
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in error
cases.  All other usage is a bug.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/gpio/gpio-clps711x.c | 3 | 
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c index ad181db7950..ce63b75b13f 100644 --- a/drivers/gpio/gpio-clps711x.c +++ b/drivers/gpio/gpio-clps711x.c @@ -162,8 +162,7 @@ static int __init gpio_clps711x_init(void)  			    GFP_KERNEL);  	if (!gpio) {  		dev_err(&pdev->dev, "GPIO allocating memory error\n"); -		platform_device_del(pdev); -		platform_device_put(pdev); +		platform_device_unregister(pdev);  		return -ENOMEM;  	}  |