From 4c12eeb8b55483e48ef98b8a480e2bbacc9f210d Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sat, 10 Dec 2011 08:44:01 +0000 Subject: Convert cmd_usage() calls in common to use a return value Change all files in common/ to use CMD_RET_USAGE instead of calling cmd_usage() directly. I'm not completely sure about this patch since the code since impact is small (100 byte or so on ARM) and it might need splitting into smaller patches. But for now here it is. Signed-off-by: Simon Glass --- common/cmd_mp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'common/cmd_mp.c') diff --git a/common/cmd_mp.c b/common/cmd_mp.c index b115b5913..4b27be495 100644 --- a/common/cmd_mp.c +++ b/common/cmd_mp.c @@ -29,7 +29,7 @@ cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) unsigned long cpuid; if (argc < 3) - return cmd_usage(cmdtp); + return CMD_RET_USAGE; cpuid = simple_strtoul(argv[1], NULL, 10); if (!is_core_valid(cpuid)) { @@ -46,17 +46,17 @@ cpu_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) else if (strncmp(argv[2], "disable", 7) == 0) return cpu_disable(cpuid); else - return cmd_usage(cmdtp); + return CMD_RET_USAGE; return 0; } /* 4 or greater, make sure its release */ if (strncmp(argv[2], "release", 7) != 0) - return cmd_usage(cmdtp); + return CMD_RET_USAGE; if (cpu_release(cpuid, argc - 3, argv + 3)) - return cmd_usage(cmdtp); + return CMD_RET_USAGE; return 0; } -- cgit v1.2.3-70-g09d2