diff options
Diffstat (limited to 'drivers')
42 files changed, 2102 insertions, 341 deletions
| diff --git a/drivers/block/Makefile b/drivers/block/Makefile index 4e9437838..8697da426 100644 --- a/drivers/block/Makefile +++ b/drivers/block/Makefile @@ -18,5 +18,6 @@ obj-$(CONFIG_SATA_DWC) += sata_dwc.o  obj-$(CONFIG_SATA_SIL3114) += sata_sil3114.o  obj-$(CONFIG_SATA_SIL) += sata_sil.o  obj-$(CONFIG_IDE_SIL680) += sil680.o +obj-$(CONFIG_SANDBOX) += sandbox.o  obj-$(CONFIG_SCSI_SYM53C8XX) += sym53c8xx.o  obj-$(CONFIG_SYSTEMACE) += systemace.o diff --git a/drivers/block/sandbox.c b/drivers/block/sandbox.c new file mode 100644 index 000000000..73f4c4a9e --- /dev/null +++ b/drivers/block/sandbox.c @@ -0,0 +1,124 @@ +/* + * Copyright (C) 2013 Henrik Nordstrom <henrik@henriknordstrom.net> + * + * SPDX-License-Identifier:	GPL-2.0+ + */ + +#include <config.h> +#include <common.h> +#include <part.h> +#include <os.h> +#include <malloc.h> +#include <sandboxblockdev.h> +#include <asm/errno.h> + +static struct host_block_dev host_devices[CONFIG_HOST_MAX_DEVICES]; + +static struct host_block_dev *find_host_device(int dev) +{ +	if (dev >= 0 && dev < CONFIG_HOST_MAX_DEVICES) +		return &host_devices[dev]; + +	return NULL; +} + +static unsigned long host_block_read(int dev, unsigned long start, +				     lbaint_t blkcnt, void *buffer) +{ +	struct host_block_dev *host_dev = find_host_device(dev); + +	if (!host_dev) +		return -1; +	if (os_lseek(host_dev->fd, +		     start * host_dev->blk_dev.blksz, +		     OS_SEEK_SET) == -1) { +		printf("ERROR: Invalid position\n"); +		return -1; +	} +	ssize_t len = os_read(host_dev->fd, buffer, +			      blkcnt * host_dev->blk_dev.blksz); +	if (len >= 0) +		return len / host_dev->blk_dev.blksz; +	return -1; +} + +static unsigned long host_block_write(int dev, unsigned long start, +				      lbaint_t blkcnt, const void *buffer) +{ +	struct host_block_dev *host_dev = find_host_device(dev); +	if (os_lseek(host_dev->fd, +		     start * host_dev->blk_dev.blksz, +		     OS_SEEK_SET) == -1) { +		printf("ERROR: Invalid position\n"); +		return -1; +	} +	ssize_t len = os_write(host_dev->fd, buffer, blkcnt * +			       host_dev->blk_dev.blksz); +	if (len >= 0) +		return len / host_dev->blk_dev.blksz; +	return -1; +} + +int host_dev_bind(int dev, char *filename) +{ +	struct host_block_dev *host_dev = find_host_device(dev); + +	if (!host_dev) +		return -1; +	if (host_dev->blk_dev.priv) { +		os_close(host_dev->fd); +		host_dev->blk_dev.priv = NULL; +	} +	if (host_dev->filename) +		free(host_dev->filename); +	if (filename && *filename) { +		host_dev->filename = strdup(filename); +	} else { +		host_dev->filename = NULL; +		return 0; +	} + +	host_dev->fd = os_open(host_dev->filename, OS_O_RDWR); +	if (host_dev->fd == -1) { +		printf("Failed to access host backing file '%s'\n", +		       host_dev->filename); +		return 1; +	} + +	block_dev_desc_t *blk_dev = &host_dev->blk_dev; +	blk_dev->if_type = IF_TYPE_HOST; +	blk_dev->priv = host_dev; +	blk_dev->blksz = 512; +	blk_dev->lba = os_lseek(host_dev->fd, 0, OS_SEEK_END) / blk_dev->blksz; +	blk_dev->block_read = host_block_read; +	blk_dev->block_write = host_block_write; +	blk_dev->dev = dev; +	blk_dev->part_type = PART_TYPE_UNKNOWN; +	init_part(blk_dev); + +	return 0; +} + +int host_get_dev_err(int dev, block_dev_desc_t **blk_devp) +{ +	struct host_block_dev *host_dev = find_host_device(dev); + +	if (!host_dev) +		return -ENODEV; + +	if (!host_dev->blk_dev.priv) +		return -ENOENT; + +	*blk_devp = &host_dev->blk_dev; +	return 0; +} + +block_dev_desc_t *host_get_dev(int dev) +{ +	block_dev_desc_t *blk_dev; + +	if (host_get_dev_err(dev, &blk_dev)) +		return NULL; + +	return blk_dev; +} diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index 1eb92e541..07011e99a 100644 --- a/drivers/dfu/dfu.c +++ b/drivers/dfu/dfu.c @@ -74,6 +74,11 @@ unsigned char *dfu_free_buf(void)  	return dfu_buf;  } +unsigned long dfu_get_buf_size(void) +{ +	return dfu_buf_size; +} +  unsigned char *dfu_get_buf(void)  {  	char *s; diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile index 1ed26cab3..e793ed994 100644 --- a/drivers/mmc/Makefile +++ b/drivers/mmc/Makefile @@ -28,6 +28,7 @@ obj-$(CONFIG_TEGRA_MMC) += tegra_mmc.o  obj-$(CONFIG_DWMMC) += dw_mmc.o  obj-$(CONFIG_EXYNOS_DWMMC) += exynos_dw_mmc.o  obj-$(CONFIG_ZYNQ_SDHCI) += zynq_sdhci.o +obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o  ifdef CONFIG_SPL_BUILD  obj-$(CONFIG_SPL_MMC_BOOT) += fsl_esdhc_spl.o  else diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 19d9b0b89..4cec5aaa6 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -6,6 +6,7 @@   * SPDX-License-Identifier:	GPL-2.0+   */ +#include <bouncebuf.h>  #include <common.h>  #include <malloc.h>  #include <mmc.h> @@ -41,11 +42,13 @@ static void dwmci_set_idma_desc(struct dwmci_idmac *idmac,  }  static void dwmci_prepare_data(struct dwmci_host *host, -		struct mmc_data *data, struct dwmci_idmac *cur_idmac) +			       struct mmc_data *data, +			       struct dwmci_idmac *cur_idmac, +			       void *bounce_buffer)  {  	unsigned long ctrl;  	unsigned int i = 0, flags, cnt, blk_cnt; -	ulong data_start, data_end, start_addr; +	ulong data_start, data_end;  	blk_cnt = data->blocks; @@ -55,11 +58,6 @@ static void dwmci_prepare_data(struct dwmci_host *host,  	data_start = (ulong)cur_idmac;  	dwmci_writel(host, DWMCI_DBADDR, (unsigned int)cur_idmac); -	if (data->flags == MMC_DATA_READ) -		start_addr = (unsigned int)data->dest; -	else -		start_addr = (unsigned int)data->src; -  	do {  		flags = DWMCI_IDMAC_OWN | DWMCI_IDMAC_CH ;  		flags |= (i == 0) ? DWMCI_IDMAC_FS : 0; @@ -70,7 +68,7 @@ static void dwmci_prepare_data(struct dwmci_host *host,  			cnt = data->blocksize * 8;  		dwmci_set_idma_desc(cur_idmac, flags, cnt, -				start_addr + (i * PAGE_SIZE)); +				    (u32)bounce_buffer + (i * PAGE_SIZE));  		if (blk_cnt <= 8)  			break; @@ -117,6 +115,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,  	u32 retry = 10000;  	u32 mask, ctrl;  	ulong start = get_timer(0); +	struct bounce_buffer bbstate;  	while (dwmci_readl(host, DWMCI_STATUS) & DWMCI_BUSY) {  		if (get_timer(start) > timeout) { @@ -127,8 +126,19 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,  	dwmci_writel(host, DWMCI_RINTSTS, DWMCI_INTMSK_ALL); -	if (data) -		dwmci_prepare_data(host, data, cur_idmac); +	if (data) { +		if (data->flags == MMC_DATA_READ) { +			bounce_buffer_start(&bbstate, (void*)data->dest, +					    data->blocksize * +					    data->blocks, GEN_BB_WRITE); +		} else { +			bounce_buffer_start(&bbstate, (void*)data->src, +					    data->blocksize * +					    data->blocks, GEN_BB_READ); +		} +		dwmci_prepare_data(host, data, cur_idmac, +				   bbstate.bounce_buffer); +	}  	dwmci_writel(host, DWMCI_CMDARG, cmd->cmdarg); @@ -204,6 +214,8 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,  		ctrl = dwmci_readl(host, DWMCI_CTRL);  		ctrl &= ~(DWMCI_DMA_EN);  		dwmci_writel(host, DWMCI_CTRL, ctrl); + +		bounce_buffer_stop(&bbstate);  	}  	udelay(100); @@ -336,9 +348,9 @@ int add_dwmci(struct dwmci_host *host, u32 max_clk, u32 min_clk)  	struct mmc *mmc;  	int err = 0; -	mmc = malloc(sizeof(struct mmc)); +	mmc = calloc(sizeof(struct mmc), 1);  	if (!mmc) { -		printf("mmc malloc fail!\n"); +		printf("mmc calloc fail!\n");  		return -1;  	} diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index e1461a98d..c6a1c23fb 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -877,6 +877,7 @@ static int mmc_startup(struct mmc *mmc)  	mmc->tran_speed = freq * mult; +	mmc->dsr_imp = ((cmd.response[1] >> 12) & 0x1);  	mmc->read_bl_len = 1 << ((cmd.response[1] >> 16) & 0xf);  	if (IS_SD(mmc)) @@ -907,6 +908,14 @@ static int mmc_startup(struct mmc *mmc)  	if (mmc->write_bl_len > MMC_MAX_BLOCK_LEN)  		mmc->write_bl_len = MMC_MAX_BLOCK_LEN; +	if ((mmc->dsr_imp) && (0xffffffff != mmc->dsr)) { +		cmd.cmdidx = MMC_CMD_SET_DSR; +		cmd.cmdarg = (mmc->dsr & 0xffff) << 16; +		cmd.resp_type = MMC_RSP_NONE; +		if (mmc_send_cmd(mmc, &cmd, NULL)) +			printf("MMC: SET_DSR failed\n"); +	} +  	/* Select the card, and put it into Transfer Mode */  	if (!mmc_host_is_spi(mmc)) { /* cmd not supported in spi */  		cmd.cmdidx = MMC_CMD_SELECT_CARD; @@ -1163,6 +1172,9 @@ static int mmc_send_if_cond(struct mmc *mmc)  int mmc_register(struct mmc *mmc)  { +	/* Setup dsr related values */ +	mmc->dsr_imp = 0; +	mmc->dsr = 0xffffffff;  	/* Setup the universal parts of the block interface just once */  	mmc->block_dev.if_type = IF_TYPE_MMC;  	mmc->block_dev.dev = cur_dev_num++; @@ -1280,6 +1292,12 @@ int mmc_init(struct mmc *mmc)  	return err;  } +int mmc_set_dsr(struct mmc *mmc, u16 val) +{ +	mmc->dsr = val; +	return 0; +} +  /*   * CPU and board-specific MMC initializations.  Aliased function   * signals caller to move on diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 46ae9cb52..1e86b92be 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -24,7 +24,8 @@ static void sdhci_reset(struct sdhci_host *host, u8 mask)  	sdhci_writeb(host, mask, SDHCI_SOFTWARE_RESET);  	while (sdhci_readb(host, SDHCI_SOFTWARE_RESET) & mask) {  		if (timeout == 0) { -			printf("Reset 0x%x never completed.\n", (int)mask); +			printf("%s: Reset 0x%x never completed.\n", +			       __func__, (int)mask);  			return;  		}  		timeout--; @@ -79,7 +80,8 @@ static int sdhci_transfer_data(struct sdhci_host *host, struct mmc_data *data,  	do {  		stat = sdhci_readl(host, SDHCI_INT_STATUS);  		if (stat & SDHCI_INT_ERROR) { -			printf("Error detected in status(0x%X)!\n", stat); +			printf("%s: Error detected in status(0x%X)!\n", +			       __func__, stat);  			return -1;  		}  		if (stat & rdy) { @@ -102,7 +104,7 @@ static int sdhci_transfer_data(struct sdhci_host *host, struct mmc_data *data,  		if (timeout-- > 0)  			udelay(10);  		else { -			printf("Transfer data timeout\n"); +			printf("%s: Transfer data timeout\n", __func__);  			return -1;  		}  	} while (!(stat & SDHCI_INT_DATA_END)); @@ -147,7 +149,7 @@ int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,  	while (sdhci_readl(host, SDHCI_PRESENT_STATE) & mask) {  		if (time >= cmd_timeout) { -			printf("MMC: %d busy ", mmc_dev); +			printf("%s: MMC: %d busy ", __func__, mmc_dev);  			if (2 * cmd_timeout <= CONFIG_SDHCI_CMD_MAX_TIMEOUT) {  				cmd_timeout += cmd_timeout;  				printf("timeout increasing to: %u ms.\n", @@ -179,7 +181,7 @@ int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,  	if (data)  		flags |= SDHCI_CMD_DATA; -	/*Set Transfer mode regarding to data flag*/ +	/* Set Transfer mode regarding to data flag */  	if (data != 0) {  		sdhci_writeb(host, 0xe, SDHCI_TIMEOUT_CONTROL);  		mode = SDHCI_TRNS_BLK_CNT_EN; @@ -230,7 +232,7 @@ int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,  		if (host->quirks & SDHCI_QUIRK_BROKEN_R1B)  			return 0;  		else { -			printf("Timeout for status update!\n"); +			printf("%s: Timeout for status update!\n", __func__);  			return TIMEOUT;  		}  	} @@ -307,7 +309,8 @@ static int sdhci_set_clock(struct mmc *mmc, unsigned int clock)  	while (!((clk = sdhci_readw(host, SDHCI_CLOCK_CONTROL))  		& SDHCI_CLOCK_INT_STABLE)) {  		if (timeout == 0) { -			printf("Internal clock never stabilised.\n"); +			printf("%s: Internal clock never stabilised.\n", +			       __func__);  			return -1;  		}  		timeout--; @@ -397,7 +400,8 @@ int sdhci_init(struct mmc *mmc)  	if ((host->quirks & SDHCI_QUIRK_32BIT_DMA_ADDR) && !aligned_buffer) {  		aligned_buffer = memalign(8, 512*1024);  		if (!aligned_buffer) { -			printf("Aligned buffer alloc failed!!!"); +			printf("%s: Aligned buffer alloc failed!!!\n", +			       __func__);  			return -1;  		}  	} @@ -418,8 +422,8 @@ int sdhci_init(struct mmc *mmc)  	}  	/* Enable only interrupts served by the SD controller */ -	sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK -		     , SDHCI_INT_ENABLE); +	sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK, +		     SDHCI_INT_ENABLE);  	/* Mask all sdhci interrupt sources */  	sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE); @@ -433,7 +437,7 @@ int add_sdhci(struct sdhci_host *host, u32 max_clk, u32 min_clk)  	mmc = malloc(sizeof(struct mmc));  	if (!mmc) { -		printf("mmc malloc fail!\n"); +		printf("%s: mmc malloc fail!\n", __func__);  		return -1;  	} @@ -450,7 +454,8 @@ int add_sdhci(struct sdhci_host *host, u32 max_clk, u32 min_clk)  	caps = sdhci_readl(host, SDHCI_CAPABILITIES);  #ifdef CONFIG_MMC_SDMA  	if (!(caps & SDHCI_CAN_DO_SDMA)) { -		printf("Your controller don't support sdma!!\n"); +		printf("%s: Your controller doesn't support SDMA!!\n", +		       __func__);  		return -1;  	}  #endif @@ -467,7 +472,8 @@ int add_sdhci(struct sdhci_host *host, u32 max_clk, u32 min_clk)  		mmc->f_max *= 1000000;  	}  	if (mmc->f_max == 0) { -		printf("Hardware doesn't specify base clock frequency\n"); +		printf("%s: Hardware doesn't specify base clock frequency\n", +		       __func__);  		return -1;  	}  	if (min_clk) diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c new file mode 100644 index 000000000..bc53a5da2 --- /dev/null +++ b/drivers/mmc/socfpga_dw_mmc.c @@ -0,0 +1,68 @@ +/* + * (C) Copyright 2013 Altera Corporation <www.altera.com> + * + * SPDX-License-Identifier:	GPL-2.0+ + */ + +#include <common.h> +#include <malloc.h> +#include <dwmmc.h> +#include <asm/arch/dwmmc.h> +#include <asm/arch/clock_manager.h> +#include <asm/arch/system_manager.h> + +static const struct socfpga_clock_manager *clock_manager_base = +		(void *)SOCFPGA_CLKMGR_ADDRESS; +static const struct socfpga_system_manager *system_manager_base = +		(void *)SOCFPGA_SYSMGR_ADDRESS; + +static char *SOCFPGA_NAME = "SOCFPGA DWMMC"; + +static void socfpga_dwmci_clksel(struct dwmci_host *host) +{ +	unsigned int drvsel; +	unsigned int smplsel; + +	/* Disable SDMMC clock. */ +	clrbits_le32(&clock_manager_base->per_pll_en, +		CLKMGR_PERPLLGRP_EN_SDMMCCLK_MASK); + +	/* Configures drv_sel and smpl_sel */ +	drvsel = CONFIG_SOCFPGA_DWMMC_DRVSEL; +	smplsel = CONFIG_SOCFPGA_DWMMC_SMPSEL; + +	debug("%s: drvsel %d smplsel %d\n", __func__, drvsel, smplsel); +	writel(SYSMGR_SDMMC_CTRL_SET(smplsel, drvsel), +		&system_manager_base->sdmmcgrp_ctrl); + +	debug("%s: SYSMGR_SDMMCGRP_CTRL_REG = 0x%x\n", __func__, +		readl(&system_manager_base->sdmmcgrp_ctrl)); + +	/* Enable SDMMC clock */ +	setbits_le32(&clock_manager_base->per_pll_en, +		CLKMGR_PERPLLGRP_EN_SDMMCCLK_MASK); +} + +int socfpga_dwmmc_init(u32 regbase, int bus_width, int index) +{ +	struct dwmci_host *host = NULL; +	host = calloc(sizeof(struct dwmci_host), 1); +	if (!host) { +		printf("dwmci_host calloc fail!\n"); +		return -1; +	} + +	host->name = SOCFPGA_NAME; +	host->ioaddr = (void *)regbase; +	host->buswidth = bus_width; +	host->clksel = socfpga_dwmci_clksel; +	host->dev_index = index; +	/* fixed clock divide by 4 which due to the SDMMC wrapper */ +	host->bus_hz = CONFIG_SOCFPGA_DWMMC_BUS_HZ; +	host->fifoth_val = MSIZE(0x2) | +		RX_WMARK(CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH / 2 - 1) | +		TX_WMARK(CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH / 2); + +	return add_dwmci(host, host->bus_hz, 400000); +} + diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index e145cd184..02b149cac 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -5,8 +5,6 @@  # SPDX-License-Identifier:	GPL-2.0+  # -ifdef CONFIG_CMD_NAND -  ifdef CONFIG_SPL_BUILD  ifdef CONFIG_SPL_NAND_DRIVERS @@ -69,4 +67,3 @@ obj-$(CONFIG_NAND_FSL_IFC) += fsl_ifc_spl.o  obj-$(CONFIG_NAND_MXC) += mxc_nand_spl.o  endif # drivers -endif # nand diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c index eeaa7e8a4..b29282603 100644 --- a/drivers/mtd/nand/nand_util.c +++ b/drivers/mtd/nand/nand_util.c @@ -315,7 +315,7 @@ int nand_unlock(struct mtd_info *mtd, loff_t start, size_t length,  	int page;  	struct nand_chip *chip = mtd->priv; -	debug("nand_unlock%s: start: %08llx, length: %d!\n", +	debug("nand_unlock%s: start: %08llx, length: %zd!\n",  		allexcept ? " (allexcept)" : "", start, length);  	/* select the NAND device */ diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c index 5e7e6b337..389c4de59 100644 --- a/drivers/mtd/nand/omap_gpmc.c +++ b/drivers/mtd/nand/omap_gpmc.c @@ -283,53 +283,55 @@ static void omap_hwecc_init_bch(struct nand_chip *chip, int32_t mode)  	if (bch->ecc_scheme == OMAP_ECC_BCH8_CODE_HW) {  		wr_mode = BCH_WRAPMODE_1; -	switch (bch->nibbles) { -	case ECC_BCH4_NIBBLES: -		unused_length = 3; -		break; -	case ECC_BCH8_NIBBLES: -		unused_length = 2; -		break; -	case ECC_BCH16_NIBBLES: -		unused_length = 0; -		break; -	} - -	/* -	 * This is ecc_size_config for ELM mode. -	 * Here we are using different settings for read and write access and -	 * also depending on BCH strength. -	 */ -	switch (mode) { -	case NAND_ECC_WRITE: -		/* write access only setup eccsize1 config */ -		val = ((unused_length + bch->nibbles) << 22); -		break; +		switch (bch->nibbles) { +		case ECC_BCH4_NIBBLES: +			unused_length = 3; +			break; +		case ECC_BCH8_NIBBLES: +			unused_length = 2; +			break; +		case ECC_BCH16_NIBBLES: +			unused_length = 0; +			break; +		} -	case NAND_ECC_READ: -	default:  		/* -		 * by default eccsize0 selected for ecc1resultsize -		 * eccsize0 config. +		 * This is ecc_size_config for ELM mode.  Here we are using +		 * different settings for read and write access and also +		 * depending on BCH strength.  		 */ -		val  = (bch->nibbles << 12); -		/* eccsize1 config */ -		val |= (unused_length << 22); -		break; -	} +		switch (mode) { +		case NAND_ECC_WRITE: +			/* write access only setup eccsize1 config */ +			val = ((unused_length + bch->nibbles) << 22); +			break; + +		case NAND_ECC_READ: +		default: +			/* +			 * by default eccsize0 selected for ecc1resultsize +			 * eccsize0 config. +			 */ +			val  = (bch->nibbles << 12); +			/* eccsize1 config */ +			val |= (unused_length << 22); +			break; +		}  	} else { -	/* -	 * This ecc_size_config setting is for BCH sw library. -	 * -	 * Note: we only support BCH8 currently with BCH sw library! -	 * Should be really easy to adobt to BCH4, however some omap3 have -	 * flaws with BCH4. -	 * -	 * Here we are using wrapping mode 6 both for reading and writing, with: -	 *  size0 = 0  (no additional protected byte in spare area) -	 *  size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area) -	 */ -	val = (32 << 22) | (0 << 12); +		/* +		 * This ecc_size_config setting is for BCH sw library. +		 * +		 * Note: we only support BCH8 currently with BCH sw library! +		 * Should be really easy to adobt to BCH4, however some omap3 +		 * have flaws with BCH4. +		 * +		 * Here we are using wrapping mode 6 both for reading and +		 * writing, with: +		 *  size0 = 0  (no additional protected byte in spare area) +		 *  size1 = 32 (skip 32 nibbles = 16 bytes per sector in +		 *		spare area) +		 */ +		val = (32 << 22) | (0 << 12);  	}  	/* ecc size configuration */  	writel(val, &gpmc_cfg->ecc_size_config); @@ -761,7 +763,7 @@ static void __maybe_unused omap_free_bch(struct mtd_info *mtd)  static int omap_select_ecc_scheme(struct nand_chip *nand,  	enum omap_ecc ecc_scheme, unsigned int pagesize, unsigned int oobsize) {  	struct nand_bch_priv	*bch		= nand->priv; -	struct nand_ecclayout	*ecclayout	= nand->ecc.layout; +	struct nand_ecclayout	*ecclayout	= &omap_ecclayout;  	int eccsteps = pagesize / SECTOR_BYTES;  	int i; @@ -774,7 +776,7 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,  		bch_priv.type		= 0;  		nand->ecc.mode		= NAND_ECC_SOFT;  		nand->ecc.layout	= NULL; -		nand->ecc.size		= pagesize; +		nand->ecc.size		= 0;  		bch->ecc_scheme		= OMAP_ECC_HAM1_CODE_SW;  		break; @@ -789,6 +791,7 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,  		bch_priv.control	= NULL;  		bch_priv.type		= 0;  		/* populate ecc specific fields */ +		memset(&nand->ecc, 0, sizeof(struct nand_ecc_ctrl));  		nand->ecc.mode		= NAND_ECC_HW;  		nand->ecc.strength	= 1;  		nand->ecc.size		= SECTOR_BYTES; @@ -798,8 +801,12 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,  		nand->ecc.calculate	= omap_calculate_ecc;  		/* define ecc-layout */  		ecclayout->eccbytes	= nand->ecc.bytes * eccsteps; -		for (i = 0; i < ecclayout->eccbytes; i++) -			ecclayout->eccpos[i] = i + BADBLOCK_MARKER_LENGTH; +		for (i = 0; i < ecclayout->eccbytes; i++) { +			if (nand->options & NAND_BUSWIDTH_16) +				ecclayout->eccpos[i] = i + 2; +			else +				ecclayout->eccpos[i] = i + 1; +		}  		ecclayout->oobfree[0].offset = i + BADBLOCK_MARKER_LENGTH;  		ecclayout->oobfree[0].length = oobsize - ecclayout->eccbytes -  						BADBLOCK_MARKER_LENGTH; @@ -823,6 +830,7 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,  		}  		bch_priv.type = ECC_BCH8;  		/* populate ecc specific fields */ +		memset(&nand->ecc, 0, sizeof(struct nand_ecc_ctrl));  		nand->ecc.mode		= NAND_ECC_HW;  		nand->ecc.strength	= 8;  		nand->ecc.size		= SECTOR_BYTES; @@ -865,6 +873,7 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,  		elm_init();  		bch_priv.type		= ECC_BCH8;  		/* populate ecc specific fields */ +		memset(&nand->ecc, 0, sizeof(struct nand_ecc_ctrl));  		nand->ecc.mode		= NAND_ECC_HW;  		nand->ecc.strength	= 8;  		nand->ecc.size		= SECTOR_BYTES; @@ -891,6 +900,11 @@ static int omap_select_ecc_scheme(struct nand_chip *nand,  		debug("nand: error: ecc scheme not enabled or supported\n");  		return -EINVAL;  	} + +	/* nand_scan_tail() sets ham1 sw ecc; hw ecc layout is set by driver */ +	if (ecc_scheme != OMAP_ECC_HAM1_CODE_SW) +		nand->ecc.layout = ecclayout; +  	return 0;  } @@ -919,6 +933,7 @@ int __maybe_unused omap_nand_switch_ecc(uint32_t hardware, uint32_t eccstrength)  	mtd = &nand_info[nand_curr_device];  	nand = mtd->priv;  	nand->options |= NAND_OWN_BUFFERS; +	nand->options &= ~NAND_SUBPAGE_READ;  	/* Setup the ecc configurations again */  	if (hardware) {  		if (eccstrength == 1) { diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 979e4af7c..e33e8d38e 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -91,7 +91,13 @@ static struct nand_ecclayout onenand_oob_32 = {  	.oobfree	= { {2, 3}, {14, 2}, {18, 3}, {30, 2} }  }; -static const unsigned char ffchars[] = { +/* + * Warning! This array is used with the memcpy_16() function, thus + * it must be aligned to 2 bytes. GCC can make this array unaligned + * as the array is made of unsigned char, which memcpy16() doesn't + * like and will cause unaligned access. + */ +static const unsigned char __aligned(2) ffchars[] = {  	0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,  	0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,	/* 16 */  	0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index 26483a23f..9e18fb41d 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -10,8 +10,8 @@ obj-$(CONFIG_SPL_SPI_LOAD)	+= spi_spl_load.o  obj-$(CONFIG_SPL_SPI_BOOT)	+= fsl_espi_spl.o  endif -obj-$(CONFIG_CMD_SF)        += sf.o -obj-$(CONFIG_SPI_FLASH) += sf_probe.o sf_ops.o +obj-$(CONFIG_CMD_SF) += sf.o +obj-$(CONFIG_SPI_FLASH) += sf_params.o sf_probe.o sf_ops.o  obj-$(CONFIG_SPI_FRAM_RAMTRON) += ramtron.o  obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o  obj-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o diff --git a/drivers/mtd/spi/sf.c b/drivers/mtd/spi/sf.c index d5e175ca0..664e86082 100644 --- a/drivers/mtd/spi/sf.c +++ b/drivers/mtd/spi/sf.c @@ -18,6 +18,10 @@ static int spi_flash_read_write(struct spi_slave *spi,  	unsigned long flags = SPI_XFER_BEGIN;  	int ret; +#ifdef CONFIG_SF_DUAL_FLASH +	if (spi->flags & SPI_XFER_U_PAGE) +		flags |= SPI_XFER_U_PAGE; +#endif  	if (data_len == 0)  		flags |= SPI_XFER_END; diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h index d291746ed..6bcd52204 100644 --- a/drivers/mtd/spi/sf_internal.h +++ b/drivers/mtd/spi/sf_internal.h @@ -10,12 +10,15 @@  #ifndef _SF_INTERNAL_H_  #define _SF_INTERNAL_H_ +#define SPI_FLASH_3B_ADDR_LEN		3 +#define SPI_FLASH_CMD_LEN		(1 + SPI_FLASH_3B_ADDR_LEN)  #define SPI_FLASH_16MB_BOUN		0x1000000 -/* SECT flags */ -#define SECT_4K				(1 << 1) -#define SECT_32K			(1 << 2) -#define E_FSR				(1 << 3) +/* CFI Manufacture ID's */ +#define SPI_FLASH_CFI_MFR_SPANSION	0x01 +#define SPI_FLASH_CFI_MFR_STMICRO	0x20 +#define SPI_FLASH_CFI_MFR_MACRONIX	0xc2 +#define SPI_FLASH_CFI_MFR_WINBOND	0xef  /* Erase commands */  #define CMD_ERASE_4K			0x20 @@ -28,6 +31,7 @@  #define CMD_PAGE_PROGRAM		0x02  #define CMD_WRITE_DISABLE		0x04  #define CMD_READ_STATUS			0x05 +#define CMD_QUAD_PAGE_PROGRAM		0x32  #define CMD_READ_STATUS1		0x35  #define CMD_WRITE_ENABLE		0x06  #define CMD_READ_CONFIG			0x35 @@ -36,6 +40,10 @@  /* Read commands */  #define CMD_READ_ARRAY_SLOW		0x03  #define CMD_READ_ARRAY_FAST		0x0b +#define CMD_READ_DUAL_OUTPUT_FAST	0x3b +#define CMD_READ_DUAL_IO_FAST		0xbb +#define CMD_READ_QUAD_OUTPUT_FAST	0x6b +#define CMD_READ_QUAD_IO_FAST		0xeb  #define CMD_READ_ID			0x9f  /* Bank addr access commands */ @@ -47,8 +55,10 @@  #endif  /* Common status */ -#define STATUS_WIP			0x01 -#define STATUS_PEC			0x80 +#define STATUS_WIP			(1 << 0) +#define STATUS_QEB_WINSPAN		(1 << 1) +#define STATUS_QEB_MXIC			(1 << 6) +#define STATUS_PEC			(1 << 7)  /* Flash timeout values */  #define SPI_FLASH_PROG_TIMEOUT		(2 * CONFIG_SYS_HZ) @@ -86,11 +96,17 @@ int spi_flash_cmd_write(struct spi_slave *spi, const u8 *cmd, size_t cmd_len,  /* Flash erase(sectors) operation, support all possible erase commands */  int spi_flash_cmd_erase_ops(struct spi_flash *flash, u32 offset, size_t len); +/* Read the status register */ +int spi_flash_cmd_read_status(struct spi_flash *flash, u8 *rs); +  /* Program the status register */ -int spi_flash_cmd_write_status(struct spi_flash *flash, u8 sr); +int spi_flash_cmd_write_status(struct spi_flash *flash, u8 ws); + +/* Read the config register */ +int spi_flash_cmd_read_config(struct spi_flash *flash, u8 *rc); -/* Set quad enbale bit */ -int spi_flash_set_qeb(struct spi_flash *flash); +/* Program the config register */ +int spi_flash_cmd_write_config(struct spi_flash *flash, u8 wc);  /* Enable writing on the SPI flash */  static inline int spi_flash_cmd_write_enable(struct spi_flash *flash) diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c index 108665f44..1f1bb3606 100644 --- a/drivers/mtd/spi/sf_ops.c +++ b/drivers/mtd/spi/sf_ops.c @@ -9,6 +9,7 @@   */  #include <common.h> +#include <malloc.h>  #include <spi.h>  #include <spi_flash.h>  #include <watchdog.h> @@ -23,13 +24,28 @@ static void spi_flash_addr(u32 addr, u8 *cmd)  	cmd[3] = addr >> 0;  } -int spi_flash_cmd_write_status(struct spi_flash *flash, u8 sr) +int spi_flash_cmd_read_status(struct spi_flash *flash, u8 *rs) +{ +	int ret; +	u8 cmd; + +	cmd = CMD_READ_STATUS; +	ret = spi_flash_read_common(flash, &cmd, 1, rs, 1); +	if (ret < 0) { +		debug("SF: fail to read status register\n"); +		return ret; +	} + +	return 0; +} + +int spi_flash_cmd_write_status(struct spi_flash *flash, u8 ws)  {  	u8 cmd;  	int ret;  	cmd = CMD_WRITE_STATUS; -	ret = spi_flash_write_common(flash, &cmd, 1, &sr, 1); +	ret = spi_flash_write_common(flash, &cmd, 1, &ws, 1);  	if (ret < 0) {  		debug("SF: fail to write status register\n");  		return ret; @@ -38,6 +54,44 @@ int spi_flash_cmd_write_status(struct spi_flash *flash, u8 sr)  	return 0;  } +#if defined(CONFIG_SPI_FLASH_SPANSION) || defined(CONFIG_SPI_FLASH_WINBOND) +int spi_flash_cmd_read_config(struct spi_flash *flash, u8 *rc) +{ +	int ret; +	u8 cmd; + +	cmd = CMD_READ_CONFIG; +	ret = spi_flash_read_common(flash, &cmd, 1, rc, 1); +	if (ret < 0) { +		debug("SF: fail to read config register\n"); +		return ret; +	} + +	return 0; +} + +int spi_flash_cmd_write_config(struct spi_flash *flash, u8 wc) +{ +	u8 data[2]; +	u8 cmd; +	int ret; + +	ret = spi_flash_cmd_read_status(flash, &data[0]); +	if (ret < 0) +		return ret; + +	cmd = CMD_WRITE_STATUS; +	data[1] = wc; +	ret = spi_flash_write_common(flash, &cmd, 1, &data, 2); +	if (ret) { +		debug("SF: fail to write config register\n"); +		return ret; +	} + +	return 0; +} +#endif +  #ifdef CONFIG_SPI_FLASH_BAR  static int spi_flash_cmd_bankaddr_write(struct spi_flash *flash, u8 bank_sel)  { @@ -65,7 +119,7 @@ static int spi_flash_bank(struct spi_flash *flash, u32 offset)  	u8 bank_sel;  	int ret; -	bank_sel = offset / SPI_FLASH_16MB_BOUN; +	bank_sel = offset / (SPI_FLASH_16MB_BOUN << flash->shift);  	ret = spi_flash_cmd_bankaddr_write(flash, bank_sel);  	if (ret) { @@ -73,7 +127,29 @@ static int spi_flash_bank(struct spi_flash *flash, u32 offset)  		return ret;  	} -	return 0; +	return bank_sel; +} +#endif + +#ifdef CONFIG_SF_DUAL_FLASH +static void spi_flash_dual_flash(struct spi_flash *flash, u32 *addr) +{ +	switch (flash->dual_flash) { +	case SF_DUAL_STACKED_FLASH: +		if (*addr >= (flash->size >> 1)) { +			*addr -= flash->size >> 1; +			flash->spi->flags |= SPI_XFER_U_PAGE; +		} else { +			flash->spi->flags &= ~SPI_XFER_U_PAGE; +		} +		break; +	case SF_DUAL_PARALLEL_FLASH: +		*addr >>= flash->shift; +		break; +	default: +		debug("SF: Unsupported dual_flash=%d\n", flash->dual_flash); +		break; +	}  }  #endif @@ -81,6 +157,7 @@ int spi_flash_cmd_wait_ready(struct spi_flash *flash, unsigned long timeout)  {  	struct spi_slave *spi = flash->spi;  	unsigned long timebase; +	unsigned long flags = SPI_XFER_BEGIN;  	int ret;  	u8 status;  	u8 check_status = 0x0; @@ -92,7 +169,11 @@ int spi_flash_cmd_wait_ready(struct spi_flash *flash, unsigned long timeout)  		check_status = poll_bit;  	} -	ret = spi_xfer(spi, 8, &cmd, NULL, SPI_XFER_BEGIN); +#ifdef CONFIG_SF_DUAL_FLASH +	if (spi->flags & SPI_XFER_U_PAGE) +		flags |= SPI_XFER_U_PAGE; +#endif +	ret = spi_xfer(spi, 8, &cmd, NULL, flags);  	if (ret) {  		debug("SF: fail to read %s status register\n",  		      cmd == CMD_READ_STATUS ? "read" : "flag"); @@ -165,8 +246,8 @@ int spi_flash_write_common(struct spi_flash *flash, const u8 *cmd,  int spi_flash_cmd_erase_ops(struct spi_flash *flash, u32 offset, size_t len)  { -	u32 erase_size; -	u8 cmd[4]; +	u32 erase_size, erase_addr; +	u8 cmd[SPI_FLASH_CMD_LEN];  	int ret = -1;  	erase_size = flash->erase_size; @@ -177,15 +258,21 @@ int spi_flash_cmd_erase_ops(struct spi_flash *flash, u32 offset, size_t len)  	cmd[0] = flash->erase_cmd;  	while (len) { +		erase_addr = offset; + +#ifdef CONFIG_SF_DUAL_FLASH +		if (flash->dual_flash > SF_SINGLE_FLASH) +			spi_flash_dual_flash(flash, &erase_addr); +#endif  #ifdef CONFIG_SPI_FLASH_BAR -		ret = spi_flash_bank(flash, offset); +		ret = spi_flash_bank(flash, erase_addr);  		if (ret < 0)  			return ret;  #endif -		spi_flash_addr(offset, cmd); +		spi_flash_addr(erase_addr, cmd);  		debug("SF: erase %2x %2x %2x %2x (%x)\n", cmd[0], cmd[1], -		      cmd[2], cmd[3], offset); +		      cmd[2], cmd[3], erase_addr);  		ret = spi_flash_write_common(flash, cmd, sizeof(cmd), NULL, 0);  		if (ret < 0) { @@ -204,16 +291,23 @@ int spi_flash_cmd_write_ops(struct spi_flash *flash, u32 offset,  		size_t len, const void *buf)  {  	unsigned long byte_addr, page_size; +	u32 write_addr;  	size_t chunk_len, actual; -	u8 cmd[4]; +	u8 cmd[SPI_FLASH_CMD_LEN];  	int ret = -1;  	page_size = flash->page_size; -	cmd[0] = CMD_PAGE_PROGRAM; +	cmd[0] = flash->write_cmd;  	for (actual = 0; actual < len; actual += chunk_len) { +		write_addr = offset; + +#ifdef CONFIG_SF_DUAL_FLASH +		if (flash->dual_flash > SF_SINGLE_FLASH) +			spi_flash_dual_flash(flash, &write_addr); +#endif  #ifdef CONFIG_SPI_FLASH_BAR -		ret = spi_flash_bank(flash, offset); +		ret = spi_flash_bank(flash, write_addr);  		if (ret < 0)  			return ret;  #endif @@ -223,9 +317,9 @@ int spi_flash_cmd_write_ops(struct spi_flash *flash, u32 offset,  		if (flash->spi->max_write_size)  			chunk_len = min(chunk_len, flash->spi->max_write_size); -		spi_flash_addr(offset, cmd); +		spi_flash_addr(write_addr, cmd); -		debug("PP: 0x%p => cmd = { 0x%02x 0x%02x%02x%02x } chunk_len = %zu\n", +		debug("SF: 0x%p => cmd = { 0x%02x 0x%02x%02x%02x } chunk_len = %zu\n",  		      buf + actual, cmd[0], cmd[1], cmd[2], cmd[3], chunk_len);  		ret = spi_flash_write_common(flash, cmd, sizeof(cmd), @@ -267,41 +361,52 @@ int spi_flash_read_common(struct spi_flash *flash, const u8 *cmd,  int spi_flash_cmd_read_ops(struct spi_flash *flash, u32 offset,  		size_t len, void *data)  { -	u8 cmd[5], bank_sel = 0; -	u32 remain_len, read_len; +	u8 *cmd, cmdsz; +	u32 remain_len, read_len, read_addr; +	int bank_sel = 0;  	int ret = -1;  	/* Handle memory-mapped SPI */  	if (flash->memory_map) { +		ret = spi_claim_bus(flash->spi); +		if (ret) { +			debug("SF: unable to claim SPI bus\n"); +			return ret; +		}  		spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MMAP);  		memcpy(data, flash->memory_map + offset, len);  		spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MMAP_END); +		spi_release_bus(flash->spi);  		return 0;  	} -	cmd[0] = CMD_READ_ARRAY_FAST; -	cmd[4] = 0x00; +	cmdsz = SPI_FLASH_CMD_LEN + flash->dummy_byte; +	cmd = malloc(cmdsz); +	memset(cmd, 0, cmdsz); +	cmd[0] = flash->read_cmd;  	while (len) { -#ifdef CONFIG_SPI_FLASH_BAR -		bank_sel = offset / SPI_FLASH_16MB_BOUN; +		read_addr = offset; -		ret = spi_flash_cmd_bankaddr_write(flash, bank_sel); -		if (ret) { -			debug("SF: fail to set bank%d\n", bank_sel); +#ifdef CONFIG_SF_DUAL_FLASH +		if (flash->dual_flash > SF_SINGLE_FLASH) +			spi_flash_dual_flash(flash, &read_addr); +#endif +#ifdef CONFIG_SPI_FLASH_BAR +		bank_sel = spi_flash_bank(flash, read_addr); +		if (bank_sel < 0)  			return ret; -		}  #endif -		remain_len = (SPI_FLASH_16MB_BOUN * (bank_sel + 1)) - offset; +		remain_len = ((SPI_FLASH_16MB_BOUN << flash->shift) * +				(bank_sel + 1)) - offset;  		if (len < remain_len)  			read_len = len;  		else  			read_len = remain_len; -		spi_flash_addr(offset, cmd); +		spi_flash_addr(read_addr, cmd); -		ret = spi_flash_read_common(flash, cmd, sizeof(cmd), -							data, read_len); +		ret = spi_flash_read_common(flash, cmd, cmdsz, data, read_len);  		if (ret < 0) {  			debug("SF: read failed\n");  			break; diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c new file mode 100644 index 000000000..daf8fe767 --- /dev/null +++ b/drivers/mtd/spi/sf_params.c @@ -0,0 +1,130 @@ +/* + * SPI flash Params table + * + * Copyright (C) 2013 Jagannadha Sutradharudu Teki, Xilinx Inc. + * + * SPDX-License-Identifier:	GPL-2.0+ + */ + +#include <common.h> +#include <spi_flash.h> + +#include "sf_internal.h" + +/* SPI/QSPI flash device params structure */ +const struct spi_flash_params spi_flash_params_table[] = { +#ifdef CONFIG_SPI_FLASH_ATMEL		/* ATMEL */ +	{"AT45DB011D",	   0x1f2200, 0x0,	64 * 1024,     4,	0,		    SECT_4K}, +	{"AT45DB021D",	   0x1f2300, 0x0,	64 * 1024,     8,	0,		    SECT_4K}, +	{"AT45DB041D",	   0x1f2400, 0x0,	64 * 1024,     8,	0,		    SECT_4K}, +	{"AT45DB081D",	   0x1f2500, 0x0,	64 * 1024,    16,	0,		    SECT_4K}, +	{"AT45DB161D",	   0x1f2600, 0x0,	64 * 1024,    32,	0,		    SECT_4K}, +	{"AT45DB321D",	   0x1f2700, 0x0,	64 * 1024,    64,	0,		    SECT_4K}, +	{"AT45DB641D",	   0x1f2800, 0x0,	64 * 1024,   128,	0,		    SECT_4K}, +	{"AT25DF321",      0x1f4701, 0x0,	64 * 1024,    64,	0,		    SECT_4K}, +#endif +#ifdef CONFIG_SPI_FLASH_EON		/* EON */ +	{"EN25Q32B",	   0x1c3016, 0x0,	64 * 1024,    64,	0,			  0}, +	{"EN25Q64",	   0x1c3017, 0x0,	64 * 1024,   128,	0,		    SECT_4K}, +	{"EN25Q128B",	   0x1c3018, 0x0,       64 * 1024,   256,	0,			  0}, +	{"EN25S64",	   0x1c3817, 0x0,	64 * 1024,   128,	0,			  0}, +#endif +#ifdef CONFIG_SPI_FLASH_GIGADEVICE	/* GIGADEVICE */ +	{"GD25Q64B",	   0xc84017, 0x0,	64 * 1024,   128,	0,		    SECT_4K}, +	{"GD25LQ32",	   0xc86016, 0x0,	64 * 1024,    64,	0,		    SECT_4K}, +#endif +#ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */ +	{"MX25L2006E",	   0xc22012, 0x0,	64 * 1024,     4,	0,			  0}, +	{"MX25L4005",	   0xc22013, 0x0,	64 * 1024,     8,	0,			  0}, +	{"MX25L8005",	   0xc22014, 0x0,	64 * 1024,    16,	0,			  0}, +	{"MX25L1605D",	   0xc22015, 0x0,	64 * 1024,    32,	0,			  0}, +	{"MX25L3205D",	   0xc22016, 0x0,	64 * 1024,    64,	0,			  0}, +	{"MX25L6405D",	   0xc22017, 0x0,	64 * 1024,   128,	0,			  0}, +	{"MX25L12805",	   0xc22018, 0x0,	64 * 1024,   256, RD_FULL,		     WR_QPP}, +	{"MX25L25635F",	   0xc22019, 0x0,	64 * 1024,   512, RD_FULL,		     WR_QPP}, +	{"MX25L51235F",	   0xc2201a, 0x0,	64 * 1024,  1024, RD_FULL,		     WR_QPP}, +	{"MX25L12855E",	   0xc22618, 0x0,	64 * 1024,   256, RD_FULL,		     WR_QPP}, +#endif +#ifdef CONFIG_SPI_FLASH_SPANSION	/* SPANSION */ +	{"S25FL008A",	   0x010213, 0x0,	64 * 1024,    16,	0,			  0}, +	{"S25FL016A",	   0x010214, 0x0,	64 * 1024,    32,	0,			  0}, +	{"S25FL032A",	   0x010215, 0x0,	64 * 1024,    64,	0,			  0}, +	{"S25FL064A",	   0x010216, 0x0,	64 * 1024,   128,	0,			  0}, +	{"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64, RD_FULL,		     WR_QPP}, +	{"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256, RD_FULL,		     WR_QPP}, +	{"S25FL032P",	   0x010215, 0x4d00,    64 * 1024,    64, RD_FULL,		     WR_QPP}, +	{"S25FL064P",	   0x010216, 0x4d00,    64 * 1024,   128, RD_FULL,		     WR_QPP}, +	{"S25FL128S_64K",  0x012018, 0x4d01,    64 * 1024,   256, RD_FULL,		     WR_QPP}, +	{"S25FL256S_256K", 0x010219, 0x4d00,    64 * 1024,   512, RD_FULL,		     WR_QPP}, +	{"S25FL256S_64K",  0x010219, 0x4d01,	64 * 1024,   512, RD_FULL,		     WR_QPP}, +	{"S25FL512S_256K", 0x010220, 0x4d00,    64 * 1024,  1024, RD_FULL,		     WR_QPP}, +	{"S25FL512S_64K",  0x010220, 0x4d01,    64 * 1024,  1024, RD_FULL,		     WR_QPP}, +#endif +#ifdef CONFIG_SPI_FLASH_STMICRO		/* STMICRO */ +	{"M25P10",	   0x202011, 0x0,	32 * 1024,     4,	0,			  0}, +	{"M25P20",	   0x202012, 0x0,       64 * 1024,     4,	0,			  0}, +	{"M25P40",	   0x202013, 0x0,       64 * 1024,     8,	0,			  0}, +	{"M25P80",	   0x202014, 0x0,       64 * 1024,    16,	0,			  0}, +	{"M25P16",	   0x202015, 0x0,       64 * 1024,    32,	0,			  0}, +	{"M25P32",	   0x202016, 0x0,       64 * 1024,    64,	0,			  0}, +	{"M25P64",	   0x202017, 0x0,       64 * 1024,   128,	0,			  0}, +	{"M25P128",	   0x202018, 0x0,      256 * 1024,    64,	0,			  0}, +	{"N25Q32",	   0x20ba16, 0x0,       64 * 1024,    64, RD_FULL,	   WR_QPP | SECT_4K}, +	{"N25Q32A",	   0x20bb16, 0x0,       64 * 1024,    64, RD_FULL,	   WR_QPP | SECT_4K}, +	{"N25Q64",	   0x20ba17, 0x0,       64 * 1024,   128, RD_FULL,	   WR_QPP | SECT_4K}, +	{"N25Q64A",	   0x20bb17, 0x0,       64 * 1024,   128, RD_FULL,	   WR_QPP | SECT_4K}, +	{"N25Q128",	   0x20ba18, 0x0,       64 * 1024,   256, RD_FULL,		     WR_QPP}, +	{"N25Q128A",	   0x20bb18, 0x0,       64 * 1024,   256, RD_FULL,		     WR_QPP}, +	{"N25Q256",	   0x20ba19, 0x0,       64 * 1024,   512, RD_FULL,	   WR_QPP | SECT_4K}, +	{"N25Q256A",	   0x20bb19, 0x0,       64 * 1024,   512, RD_FULL,	   WR_QPP | SECT_4K}, +	{"N25Q512",	   0x20ba20, 0x0,       64 * 1024,  1024, RD_FULL, WR_QPP | E_FSR | SECT_4K}, +	{"N25Q512A",	   0x20bb20, 0x0,       64 * 1024,  1024, RD_FULL, WR_QPP | E_FSR | SECT_4K}, +	{"N25Q1024",	   0x20ba21, 0x0,       64 * 1024,  2048, RD_FULL, WR_QPP | E_FSR | SECT_4K}, +	{"N25Q1024A",	   0x20bb21, 0x0,       64 * 1024,  2048, RD_FULL, WR_QPP | E_FSR | SECT_4K}, +#endif +#ifdef CONFIG_SPI_FLASH_SST		/* SST */ +	{"SST25VF040B",	   0xbf258d, 0x0,	64 * 1024,     8,	0,          SECT_4K | SST_WP}, +	{"SST25VF080B",	   0xbf258e, 0x0,	64 * 1024,    16,	0,	    SECT_4K | SST_WP}, +	{"SST25VF016B",	   0xbf2541, 0x0,	64 * 1024,    32,	0,	    SECT_4K | SST_WP}, +	{"SST25VF032B",	   0xbf254a, 0x0,	64 * 1024,    64,	0,	    SECT_4K | SST_WP}, +	{"SST25VF064C",	   0xbf254b, 0x0,	64 * 1024,   128,	0,		     SECT_4K}, +	{"SST25WF512",	   0xbf2501, 0x0,	64 * 1024,     1,	0,	    SECT_4K | SST_WP}, +	{"SST25WF010",	   0xbf2502, 0x0,	64 * 1024,     2,       0,          SECT_4K | SST_WP}, +	{"SST25WF020",	   0xbf2503, 0x0,	64 * 1024,     4,       0,	    SECT_4K | SST_WP}, +	{"SST25WF040",	   0xbf2504, 0x0,	64 * 1024,     8,       0,	    SECT_4K | SST_WP}, +	{"SST25WF080",	   0xbf2505, 0x0,	64 * 1024,    16,       0,	    SECT_4K | SST_WP}, +#endif +#ifdef CONFIG_SPI_FLASH_WINBOND		/* WINBOND */ +	{"W25P80",	   0xef2014, 0x0,	64 * 1024,    16,	0,		           0}, +	{"W25P16",	   0xef2015, 0x0,	64 * 1024,    32,	0,		           0}, +	{"W25P32",	   0xef2016, 0x0,	64 * 1024,    64,	0,		           0}, +	{"W25X40",	   0xef3013, 0x0,	64 * 1024,     8,	0,		     SECT_4K}, +	{"W25X16",	   0xef3015, 0x0,	64 * 1024,    32,	0,		     SECT_4K}, +	{"W25X32",	   0xef3016, 0x0,	64 * 1024,    64,	0,		     SECT_4K}, +	{"W25X64",	   0xef3017, 0x0,	64 * 1024,   128,	0,		     SECT_4K}, +	{"W25Q80BL",	   0xef4014, 0x0,	64 * 1024,    16, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q16CL",	   0xef4015, 0x0,	64 * 1024,    32, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q32BV",	   0xef4016, 0x0,	64 * 1024,    64, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q64CV",	   0xef4017, 0x0,	64 * 1024,   128, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q128BV",	   0xef4018, 0x0,	64 * 1024,   256, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q256",	   0xef4019, 0x0,	64 * 1024,   512, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q80BW",	   0xef5014, 0x0,	64 * 1024,    16, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q16DW",	   0xef6015, 0x0,	64 * 1024,    32, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q32DW",	   0xef6016, 0x0,	64 * 1024,    64, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q64DW",	   0xef6017, 0x0,	64 * 1024,   128, RD_FULL,	    WR_QPP | SECT_4K}, +	{"W25Q128FW",	   0xef6018, 0x0,	64 * 1024,   256, RD_FULL,	    WR_QPP | SECT_4K}, +#endif +	/* +	 * Note: +	 * Below paired flash devices has similar spi_flash params. +	 * (S25FL129P_64K, S25FL128S_64K) +	 * (W25Q80BL, W25Q80BV) +	 * (W25Q16CL, W25Q16DV) +	 * (W25Q32BV, W25Q32FV_SPI) +	 * (W25Q64CV, W25Q64FV_SPI) +	 * (W25Q128BV, W25Q128FV_SPI) +	 * (W25Q32DW, W25Q32FV_QPI) +	 * (W25Q64DW, W25Q64FV_QPI) +	 * (W25Q128FW, W25Q128FV_QPI) +	 */ +}; diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c index c1eb75489..bc3cf6cc6 100644 --- a/drivers/mtd/spi/sf_probe.c +++ b/drivers/mtd/spi/sf_probe.c @@ -19,153 +19,93 @@  DECLARE_GLOBAL_DATA_PTR; -/** - * struct spi_flash_params - SPI/QSPI flash device params structure - * - * @name:		Device name ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO]) - * @jedec:		Device jedec ID (0x[1byte_manuf_id][2byte_dev_id]) - * @ext_jedec:		Device ext_jedec ID - * @sector_size:	Sector size of this device - * @nr_sectors:		No.of sectors on this device - * @flags:		Importent param, for flash specific behaviour - */ -struct spi_flash_params { -	const char *name; -	u32 jedec; -	u16 ext_jedec; -	u32 sector_size; -	u32 nr_sectors; -	u16 flags; +/* Read commands array */ +static u8 spi_read_cmds_array[] = { +	CMD_READ_ARRAY_SLOW, +	CMD_READ_DUAL_OUTPUT_FAST, +	CMD_READ_DUAL_IO_FAST, +	CMD_READ_QUAD_OUTPUT_FAST, +	CMD_READ_QUAD_IO_FAST,  }; -static const struct spi_flash_params spi_flash_params_table[] = { -#ifdef CONFIG_SPI_FLASH_ATMEL		/* ATMEL */ -	{"AT45DB011D",	   0x1f2200, 0x0,	64 * 1024,     4,	       SECT_4K}, -	{"AT45DB021D",	   0x1f2300, 0x0,	64 * 1024,     8,	       SECT_4K}, -	{"AT45DB041D",	   0x1f2400, 0x0,	64 * 1024,     8,	       SECT_4K}, -	{"AT45DB081D",	   0x1f2500, 0x0,	64 * 1024,    16,	       SECT_4K}, -	{"AT45DB161D",	   0x1f2600, 0x0,	64 * 1024,    32,	       SECT_4K}, -	{"AT45DB321D",	   0x1f2700, 0x0,	64 * 1024,    64,	       SECT_4K}, -	{"AT45DB641D",	   0x1f2800, 0x0,	64 * 1024,   128,	       SECT_4K}, -	{"AT25DF321",      0x1f4701, 0x0,	64 * 1024,    64,	       SECT_4K}, -#endif -#ifdef CONFIG_SPI_FLASH_EON		/* EON */ -	{"EN25Q32B",	   0x1c3016, 0x0,	64 * 1024,    64,	             0}, -	{"EN25Q64",	   0x1c3017, 0x0,	64 * 1024,   128,	       SECT_4K}, -	{"EN25Q128B",	   0x1c3018, 0x0,       64 * 1024,   256,	             0}, -	{"EN25S64",	   0x1c3817, 0x0,	64 * 1024,   128,		     0}, -#endif -#ifdef CONFIG_SPI_FLASH_GIGADEVICE	/* GIGADEVICE */ -	{"GD25Q64B",	   0xc84017, 0x0,	64 * 1024,   128,	       SECT_4K}, -	{"GD25LQ32",	   0xc86016, 0x0,	64 * 1024,    64,	       SECT_4K}, -#endif -#ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */ -	{"MX25L4005",	   0xc22013, 0x0,	64 * 1024,     8,	             0}, -	{"MX25L8005",	   0xc22014, 0x0,	64 * 1024,    16,	             0}, -	{"MX25L1605D",	   0xc22015, 0x0,	64 * 1024,    32,	             0}, -	{"MX25L3205D",	   0xc22016, 0x0,	64 * 1024,    64,	             0}, -	{"MX25L6405D",	   0xc22017, 0x0,	64 * 1024,   128,	             0}, -	{"MX25L12805",	   0xc22018, 0x0,	64 * 1024,   256,	             0}, -	{"MX25L25635F",	   0xc22019, 0x0,	64 * 1024,   512,	             0}, -	{"MX25L51235F",	   0xc2201A, 0x0,	64 * 1024,  1024,	             0}, -	{"MX25L12855E",	   0xc22618, 0x0,	64 * 1024,   256,	             0}, +#ifdef CONFIG_SPI_FLASH_MACRONIX +static int spi_flash_set_qeb_mxic(struct spi_flash *flash) +{ +	u8 qeb_status; +	int ret; + +	ret = spi_flash_cmd_read_status(flash, &qeb_status); +	if (ret < 0) +		return ret; + +	if (qeb_status & STATUS_QEB_MXIC) { +		debug("SF: mxic: QEB is already set\n"); +	} else { +		ret = spi_flash_cmd_write_status(flash, STATUS_QEB_MXIC); +		if (ret < 0) +			return ret; +	} + +	return ret; +}  #endif -#ifdef CONFIG_SPI_FLASH_SPANSION	/* SPANSION */ -	{"S25FL008A",	   0x010213, 0x0,	64 * 1024,    16,	             0}, -	{"S25FL016A",	   0x010214, 0x0,	64 * 1024,    32,	             0}, -	{"S25FL032A",	   0x010215, 0x0,	64 * 1024,    64,	             0}, -	{"S25FL064A",	   0x010216, 0x0,	64 * 1024,   128,	             0}, -	{"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64,	             0}, -	{"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256,	             0}, -	{"S25FL032P",	   0x010215, 0x4d00,    64 * 1024,    64,	             0}, -	{"S25FL064P",	   0x010216, 0x4d00,    64 * 1024,   128,	             0}, -	{"S25FL128S_64K",  0x012018, 0x4d01,    64 * 1024,   256,		     0}, -	{"S25FL256S_256K", 0x010219, 0x4d00,    64 * 1024,   512,	             0}, -	{"S25FL256S_64K",  0x010219, 0x4d01,    64 * 1024,   512,	             0}, -	{"S25FL512S_256K", 0x010220, 0x4d00,    64 * 1024,  1024,	             0}, -	{"S25FL512S_64K",  0x010220, 0x4d01,    64 * 1024,  1024,	             0}, + +#if defined(CONFIG_SPI_FLASH_SPANSION) || defined(CONFIG_SPI_FLASH_WINBOND) +static int spi_flash_set_qeb_winspan(struct spi_flash *flash) +{ +	u8 qeb_status; +	int ret; + +	ret = spi_flash_cmd_read_config(flash, &qeb_status); +	if (ret < 0) +		return ret; + +	if (qeb_status & STATUS_QEB_WINSPAN) { +		debug("SF: winspan: QEB is already set\n"); +	} else { +		ret = spi_flash_cmd_write_config(flash, STATUS_QEB_WINSPAN); +		if (ret < 0) +			return ret; +	} + +	return ret; +}  #endif -#ifdef CONFIG_SPI_FLASH_STMICRO		/* STMICRO */ -	{"M25P10",	   0x202011, 0x0,       32 * 1024,     4,	             0}, -	{"M25P20",	   0x202012, 0x0,       64 * 1024,     4,	             0}, -	{"M25P40",	   0x202013, 0x0,       64 * 1024,     8,	             0}, -	{"M25P80",	   0x202014, 0x0,       64 * 1024,    16,	             0}, -	{"M25P16",	   0x202015, 0x0,       64 * 1024,    32,	             0}, -	{"M25P32",	   0x202016, 0x0,       64 * 1024,    64,	             0}, -	{"M25P64",	   0x202017, 0x0,       64 * 1024,   128,	             0}, -	{"M25P128",	   0x202018, 0x0,      256 * 1024,    64,	             0}, -	{"N25Q32",	   0x20ba16, 0x0,       64 * 1024,    64,	       SECT_4K}, -	{"N25Q32A",	   0x20bb16, 0x0,       64 * 1024,    64,	       SECT_4K}, -	{"N25Q64",	   0x20ba17, 0x0,       64 * 1024,   128,	       SECT_4K}, -	{"N25Q64A",	   0x20bb17, 0x0,       64 * 1024,   128,	       SECT_4K}, -	{"N25Q128",	   0x20ba18, 0x0,       64 * 1024,   256,	       SECT_4K}, -	{"N25Q128A",	   0x20bb18, 0x0,       64 * 1024,   256,	       SECT_4K}, -	{"N25Q256",	   0x20ba19, 0x0,       64 * 1024,   512,	       SECT_4K}, -	{"N25Q256A",	   0x20bb19, 0x0,       64 * 1024,   512,	       SECT_4K}, -	{"N25Q512",	   0x20ba20, 0x0,       64 * 1024,  1024,      E_FSR | SECT_4K}, -	{"N25Q512A",	   0x20bb20, 0x0,       64 * 1024,  1024,      E_FSR | SECT_4K}, -	{"N25Q1024",	   0x20ba21, 0x0,       64 * 1024,  2048,      E_FSR | SECT_4K}, -	{"N25Q1024A",	   0x20bb21, 0x0,       64 * 1024,  2048,      E_FSR | SECT_4K}, + +static int spi_flash_set_qeb(struct spi_flash *flash, u8 idcode0) +{ +	switch (idcode0) { +#ifdef CONFIG_SPI_FLASH_MACRONIX +	case SPI_FLASH_CFI_MFR_MACRONIX: +		return spi_flash_set_qeb_mxic(flash);  #endif -#ifdef CONFIG_SPI_FLASH_SST		/* SST */ -	{"SST25VF040B",	   0xbf258d, 0x0,	64 * 1024,     8,     SECT_4K | SST_WP}, -	{"SST25VF080B",	   0xbf258e, 0x0,	64 * 1024,    16,     SECT_4K | SST_WP}, -	{"SST25VF016B",	   0xbf2541, 0x0,	64 * 1024,    32,     SECT_4K | SST_WP}, -	{"SST25VF032B",	   0xbf254a, 0x0,	64 * 1024,    64,     SECT_4K | SST_WP}, -	{"SST25VF064C",	   0xbf254b, 0x0,	64 * 1024,   128,	       SECT_4K}, -	{"SST25WF512",	   0xbf2501, 0x0,	64 * 1024,     1,     SECT_4K | SST_WP}, -	{"SST25WF010",	   0xbf2502, 0x0,	64 * 1024,     2,     SECT_4K | SST_WP}, -	{"SST25WF020",	   0xbf2503, 0x0,	64 * 1024,     4,     SECT_4K | SST_WP}, -	{"SST25WF040",	   0xbf2504, 0x0,	64 * 1024,     8,     SECT_4K | SST_WP}, -	{"SST25WF080",	   0xbf2505, 0x0,	64 * 1024,    16,     SECT_4K | SST_WP}, +#if defined(CONFIG_SPI_FLASH_SPANSION) || defined(CONFIG_SPI_FLASH_WINBOND) +	case SPI_FLASH_CFI_MFR_SPANSION: +	case SPI_FLASH_CFI_MFR_WINBOND: +		return spi_flash_set_qeb_winspan(flash);  #endif -#ifdef CONFIG_SPI_FLASH_WINBOND		/* WINBOND */ -	{"W25P80",	   0xef2014, 0x0,	64 * 1024,    16,		    0}, -	{"W25P16",	   0xef2015, 0x0,	64 * 1024,    32,		    0}, -	{"W25P32",	   0xef2016, 0x0,	64 * 1024,    64,		    0}, -	{"W25X40",	   0xef3013, 0x0,	64 * 1024,     8,	      SECT_4K}, -	{"W25X16",	   0xef3015, 0x0,	64 * 1024,    32,	      SECT_4K}, -	{"W25X32",	   0xef3016, 0x0,	64 * 1024,    64,	      SECT_4K}, -	{"W25X64",	   0xef3017, 0x0,	64 * 1024,   128,	      SECT_4K}, -	{"W25Q80BL",	   0xef4014, 0x0,	64 * 1024,    16,	      SECT_4K}, -	{"W25Q16CL",	   0xef4015, 0x0,	64 * 1024,    32,	      SECT_4K}, -	{"W25Q32BV",	   0xef4016, 0x0,	64 * 1024,    64,	      SECT_4K}, -	{"W25Q64CV",	   0xef4017, 0x0,	64 * 1024,   128,	      SECT_4K}, -	{"W25Q128BV",	   0xef4018, 0x0,	64 * 1024,   256,	      SECT_4K}, -	{"W25Q256",	   0xef4019, 0x0,	64 * 1024,   512,	      SECT_4K}, -	{"W25Q80BW",	   0xef5014, 0x0,	64 * 1024,    16,	      SECT_4K}, -	{"W25Q16DW",	   0xef6015, 0x0,	64 * 1024,    32,	      SECT_4K}, -	{"W25Q32DW",	   0xef6016, 0x0,	64 * 1024,    64,	      SECT_4K}, -	{"W25Q64DW",	   0xef6017, 0x0,	64 * 1024,   128,	      SECT_4K}, -	{"W25Q128FW",	   0xef6018, 0x0,	64 * 1024,   256,	      SECT_4K}, +#ifdef CONFIG_SPI_FLASH_STMICRO +	case SPI_FLASH_CFI_MFR_STMICRO: +		debug("SF: QEB is volatile for %02x flash\n", idcode0); +		return 0;  #endif -	/* -	 * Note: -	 * Below paired flash devices has similar spi_flash params. -	 * (S25FL129P_64K, S25FL128S_64K) -	 * (W25Q80BL, W25Q80BV) -	 * (W25Q16CL, W25Q16DV) -	 * (W25Q32BV, W25Q32FV_SPI) -	 * (W25Q64CV, W25Q64FV_SPI) -	 * (W25Q128BV, W25Q128FV_SPI) -	 * (W25Q32DW, W25Q32FV_QPI) -	 * (W25Q64DW, W25Q64FV_QPI) -	 * (W25Q128FW, W25Q128FV_QPI) -	 */ -}; +	default: +		printf("SF: Need set QEB func for %02x flash\n", idcode0); +		return -1; +	} +}  static struct spi_flash *spi_flash_validate_params(struct spi_slave *spi,  		u8 *idcode)  {  	const struct spi_flash_params *params;  	struct spi_flash *flash; -	int i; +	u8 cmd;  	u16 jedec = idcode[1] << 8 | idcode[2];  	u16 ext_jedec = idcode[3] << 8 | idcode[4]; -	/* Get the flash id (jedec = manuf_id + dev_id, ext_jedec) */ -	for (i = 0; i < ARRAY_SIZE(spi_flash_params_table); i++) { -		params = &spi_flash_params_table[i]; +	params = spi_flash_params_table; +	for (; params->name != NULL; params++) {  		if ((params->jedec >> 16) == idcode[0]) {  			if ((params->jedec & 0xFFFF) == jedec) {  				if (params->ext_jedec == 0) @@ -176,7 +116,7 @@ static struct spi_flash *spi_flash_validate_params(struct spi_slave *spi,  		}  	} -	if (i == ARRAY_SIZE(spi_flash_params_table)) { +	if (!params->name) {  		printf("SF: Unsupported flash IDs: ");  		printf("manuf %02x, jedec %04x, ext_jedec %04x\n",  		       idcode[0], jedec, ext_jedec); @@ -194,6 +134,7 @@ static struct spi_flash *spi_flash_validate_params(struct spi_slave *spi,  	flash->spi = spi;  	flash->name = params->name;  	flash->memory_map = spi->memory_map; +	flash->dual_flash = flash->spi->option;  	/* Assign spi_flash ops */  	flash->write = spi_flash_cmd_write_ops; @@ -205,23 +146,74 @@ static struct spi_flash *spi_flash_validate_params(struct spi_slave *spi,  	flash->read = spi_flash_cmd_read_ops;  	/* Compute the flash size */ -	flash->page_size = (ext_jedec == 0x4d00) ? 512 : 256; -	flash->sector_size = params->sector_size; -	flash->size = flash->sector_size * params->nr_sectors; +	flash->shift = (flash->dual_flash & SF_DUAL_PARALLEL_FLASH) ? 1 : 0; +	flash->page_size = ((ext_jedec == 0x4d00) ? 512 : 256) << flash->shift; +	flash->sector_size = params->sector_size << flash->shift; +	flash->size = flash->sector_size * params->nr_sectors << flash->shift; +#ifdef CONFIG_SF_DUAL_FLASH +	if (flash->dual_flash & SF_DUAL_STACKED_FLASH) +		flash->size <<= 1; +#endif  	/* Compute erase sector and command */  	if (params->flags & SECT_4K) {  		flash->erase_cmd = CMD_ERASE_4K; -		flash->erase_size = 4096; +		flash->erase_size = 4096 << flash->shift;  	} else if (params->flags & SECT_32K) {  		flash->erase_cmd = CMD_ERASE_32K; -		flash->erase_size = 32768; +		flash->erase_size = 32768 << flash->shift;  	} else {  		flash->erase_cmd = CMD_ERASE_64K;  		flash->erase_size = flash->sector_size;  	} -	/* Poll cmd seclection */ +	/* Look for the fastest read cmd */ +	cmd = fls(params->e_rd_cmd & flash->spi->op_mode_rx); +	if (cmd) { +		cmd = spi_read_cmds_array[cmd - 1]; +		flash->read_cmd = cmd; +	} else { +		/* Go for default supported read cmd */ +		flash->read_cmd = CMD_READ_ARRAY_FAST; +	} + +	/* Not require to look for fastest only two write cmds yet */ +	if (params->flags & WR_QPP && flash->spi->op_mode_tx & SPI_OPM_TX_QPP) +		flash->write_cmd = CMD_QUAD_PAGE_PROGRAM; +	else +		/* Go for default supported write cmd */ +		flash->write_cmd = CMD_PAGE_PROGRAM; + +	/* Set the quad enable bit - only for quad commands */ +	if ((flash->read_cmd == CMD_READ_QUAD_OUTPUT_FAST) || +	    (flash->read_cmd == CMD_READ_QUAD_IO_FAST) || +	    (flash->write_cmd == CMD_QUAD_PAGE_PROGRAM)) { +		if (spi_flash_set_qeb(flash, idcode[0])) { +			debug("SF: Fail to set QEB for %02x\n", idcode[0]); +			return NULL; +		} +	} + +	/* Read dummy_byte: dummy byte is determined based on the +	 * dummy cycles of a particular command. +	 * Fast commands - dummy_byte = dummy_cycles/8 +	 * I/O commands- dummy_byte = (dummy_cycles * no.of lines)/8 +	 * For I/O commands except cmd[0] everything goes on no.of lines +	 * based on particular command but incase of fast commands except +	 * data all go on single line irrespective of command. +	 */ +	switch (flash->read_cmd) { +	case CMD_READ_QUAD_IO_FAST: +		flash->dummy_byte = 2; +		break; +	case CMD_READ_ARRAY_SLOW: +		flash->dummy_byte = 0; +		break; +	default: +		flash->dummy_byte = 1; +	} + +	/* Poll cmd selection */  	flash->poll_cmd = CMD_READ_STATUS;  #ifdef CONFIG_SPI_FLASH_STMICRO  	if (params->flags & E_FSR) @@ -338,7 +330,10 @@ static struct spi_flash *spi_flash_probe_slave(struct spi_slave *spi)  	puts("\n");  #endif  #ifndef CONFIG_SPI_FLASH_BAR -	if (flash->size > SPI_FLASH_16MB_BOUN) { +	if (((flash->dual_flash == SF_SINGLE_FLASH) && +	     (flash->size > SPI_FLASH_16MB_BOUN)) || +	     ((flash->dual_flash > SF_SINGLE_FLASH) && +	     (flash->size > SPI_FLASH_16MB_BOUN << 1))) {  		puts("SF: Warning - Only lower 16MiB accessible,");  		puts(" Full access #define CONFIG_SPI_FLASH_BAR\n");  	} diff --git a/drivers/mtd/ubi/Makefile b/drivers/mtd/ubi/Makefile index e1f3a241a..56c282347 100644 --- a/drivers/mtd/ubi/Makefile +++ b/drivers/mtd/ubi/Makefile @@ -5,9 +5,6 @@  # SPDX-License-Identifier:	GPL-2.0+  # -ifdef CONFIG_CMD_UBI  obj-y += build.o vtbl.o vmt.o upd.o kapi.o eba.o io.o wl.o scan.o crc32.o -  obj-y += misc.o  obj-y += debug.o -endif diff --git a/drivers/net/fm/init.c b/drivers/net/fm/init.c index cd787f4ee..74c72d3ff 100644 --- a/drivers/net/fm/init.c +++ b/drivers/net/fm/init.c @@ -276,13 +276,64 @@ static void ft_fixup_port(void *blob, struct fm_eth_info *info, char *prop)  		"status", "disabled", strlen("disabled") + 1, 1);  } +#ifdef CONFIG_SYS_FMAN_V3 +static int ft_fixup_xgec(void *blob, struct fm_eth_info *info) +{ +	int off, i, ci; +#define FM1_10GEC3_RX_PORT_ADDR	(CONFIG_SYS_CCSRBAR_PHYS + 0x488000) +#define FM1_10GEC3_TX_PORT_ADDR	(CONFIG_SYS_CCSRBAR_PHYS + 0x4a8000) +#define FM1_10GEC3_MAC_ADDR	(CONFIG_SYS_CCSRBAR_PHYS + 0x4e0000) + +	if ((info->port == FM1_10GEC3) || (info->port == FM1_10GEC4)) { +		ci = (info->port == FM1_10GEC3) ? 2 : 3; +		i = (info->port == FM1_10GEC3) ? 0 : 1; + +		off = fdt_node_offset_by_compat_reg(blob, "fsl,fman-port-1g-rx", +						    FM1_10GEC3_RX_PORT_ADDR + +						    i * 0x1000); +		if (off > 0) { +			fdt_setprop(blob, off, "cell-index", &ci, sizeof(int)); +			fdt_setprop(blob, off, "compatible", +				    "fsl,fman-port-10g-rx", 20); +		} else { +			goto err; +		} + +		off = fdt_node_offset_by_compat_reg(blob, "fsl,fman-port-1g-tx", +						    FM1_10GEC3_TX_PORT_ADDR + +						    i * 0x1000); +		if (off > 0) { +			fdt_setprop(blob, off, "cell-index", &ci, sizeof(int)); +			fdt_setprop(blob, off, "compatible", +				    "fsl,fman-port-10g-tx", 20); +		} else { +			goto err; +		} + +		off = fdt_node_offset_by_compat_reg(blob, "fsl,fman-memac", +						    FM1_10GEC3_MAC_ADDR + +						    i * 0x2000); +		if (off > 0) +			fdt_setprop(blob, off, "cell-index", &ci, sizeof(int)); +		else +			goto err; +	} +	return 0; +err: +	printf("WARNING: Fail to find the node\n"); +	return -1; +} +#endif +  void fdt_fixup_fman_ethernet(void *blob)  {  	int i;  #ifdef CONFIG_SYS_FMAN_V3 -	for (i = 0; i < ARRAY_SIZE(fm_info); i++) +	for (i = 0; i < ARRAY_SIZE(fm_info); i++) {  		ft_fixup_port(blob, &fm_info[i], "fsl,fman-memac"); +		ft_fixup_xgec(blob, &fm_info[i]); +	}  #else  	for (i = 0; i < ARRAY_SIZE(fm_info); i++) {  		if (fm_info[i].type == FM_ETH_1G_E) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index b20b4df98..32c2ab994 100644 --- a/drivers/net/phy/atheros.c +++ b/drivers/net/phy/atheros.c @@ -50,7 +50,7 @@ static struct phy_driver AR8021_driver =  {  static struct phy_driver AR8031_driver =  {  	.name = "AR8031/AR8033",  	.uid = 0x4dd074, -	.mask = 0x4fffff, +	.mask = 0xffffffef,  	.features = PHY_GBIT_FEATURES,  	.config = ar8021_config,  	.startup = genphy_startup, @@ -60,7 +60,7 @@ static struct phy_driver AR8031_driver =  {  static struct phy_driver AR8035_driver =  {  	.name = "AR8035",  	.uid = 0x4dd072, -	.mask = 0x4fffff, +	.mask = 0xffffffef,  	.features = PHY_GBIT_FEATURES,  	.config = ar8035_config,  	.startup = genphy_startup, diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h index 8aa71098c..331c07cb5 100644 --- a/drivers/net/sh_eth.h +++ b/drivers/net/sh_eth.h @@ -287,7 +287,9 @@ static const u16 sh_eth_offset_fast_sh4[SH_ETH_MAX_REGISTER_OFFSET] = {  #if defined(CONFIG_CPU_SH7763) || defined(CONFIG_CPU_SH7734)  #define SH_ETH_TYPE_GETHER  #define BASE_IO_ADDR	0xfee00000 -#elif defined(CONFIG_CPU_SH7757) || defined(CONFIG_CPU_SH7752) +#elif defined(CONFIG_CPU_SH7757) || \ +	defined(CONFIG_CPU_SH7752) || \ +	defined(CONFIG_CPU_SH7753)  #if defined(CONFIG_SH_ETHER_USE_GETHER)  #define SH_ETH_TYPE_GETHER  #define BASE_IO_ADDR	0xfee00000 @@ -356,7 +358,9 @@ enum DMAC_T_BIT {  /* GECMR */  enum GECMR_BIT { -#if defined(CONFIG_CPU_SH7757) || defined(CONFIG_CPU_SH7752) +#if defined(CONFIG_CPU_SH7757) || \ +	defined(CONFIG_CPU_SH7752) || \ +	defined(CONFIG_CPU_SH7753)  	GECMR_1000B = 0x20, GECMR_100B = 0x01, GECMR_10B = 0x00,  #else  	GECMR_1000B = 0x01, GECMR_100B = 0x04, GECMR_10B = 0x00, diff --git a/drivers/power/fuel_gauge/fg_max17042.c b/drivers/power/fuel_gauge/fg_max17042.c index c285747f3..154ca6a69 100644 --- a/drivers/power/fuel_gauge/fg_max17042.c +++ b/drivers/power/fuel_gauge/fg_max17042.c @@ -20,21 +20,30 @@ static int fg_write_regs(struct pmic *p, u8 addr, u16 *data, int num)  	int ret = 0;  	int i; -	for (i = 0; i < num; i++, addr++) -		ret |= pmic_reg_write(p, addr, *(data + i)); +	for (i = 0; i < num; i++, addr++) { +		ret = pmic_reg_write(p, addr, *(data + i)); +		if (ret) +			return ret; +	} -	return ret; +	return 0;  }  static int fg_read_regs(struct pmic *p, u8 addr, u16 *data, int num)  { +	unsigned int dat;  	int ret = 0;  	int i; -	for (i = 0; i < num; i++, addr++) -		ret |= pmic_reg_read(p, addr, (u32 *) (data + i)); +	for (i = 0; i < num; i++, addr++) { +		ret = pmic_reg_read(p, addr, &dat); +		if (ret) +			return ret; -	return ret; +		*(data + i) = (u16)dat; +	} + +	return 0;  }  static int fg_write_and_verify(struct pmic *p, u8 addr, u16 data) @@ -57,9 +66,13 @@ static int fg_write_and_verify(struct pmic *p, u8 addr, u16 data)  static void por_fuelgauge_init(struct pmic *p)  {  	u16 r_data0[16], r_data1[16], r_data2[16]; -	u32 rewrite_count = 5, i = 0; -	unsigned int val; -	int ret = 0; +	u32 rewrite_count = 5; +	u32 check_count; +	u32 lock_count; +	u32 i = 0; +	u32 val; +	s32 ret = 0; +	char *status_msg;  	/* Delay 500 ms */  	mdelay(500); @@ -67,29 +80,55 @@ static void por_fuelgauge_init(struct pmic *p)  	pmic_reg_write(p, MAX17042_CONFIG, 0x2310);  rewrite_model: +	check_count = 5; +	lock_count = 5; + +	if (!rewrite_count--) { +		status_msg = "init failed!"; +		goto error; +	} +  	/* Unlock Model Access */  	pmic_reg_write(p, MAX17042_MLOCKReg1, MODEL_UNLOCK1);  	pmic_reg_write(p, MAX17042_MLOCKReg2, MODEL_UNLOCK2);  	/* Write/Read/Verify the Custom Model */ -	ret |= fg_write_regs(p, MAX17042_MODEL1, cell_character0, +	ret = fg_write_regs(p, MAX17042_MODEL1, cell_character0,  			     ARRAY_SIZE(cell_character0)); -	ret |= fg_write_regs(p, MAX17042_MODEL2, cell_character1, +	if (ret) +		goto rewrite_model; + +	ret = fg_write_regs(p, MAX17042_MODEL2, cell_character1,  			     ARRAY_SIZE(cell_character1)); -	ret |= fg_write_regs(p, MAX17042_MODEL3, cell_character2, +	if (ret) +		goto rewrite_model; + +	ret = fg_write_regs(p, MAX17042_MODEL3, cell_character2,  			     ARRAY_SIZE(cell_character2)); +	if (ret) +		goto rewrite_model; -	if (ret) { -		printf("%s: Cell parameters write failed!\n", __func__); -		return; +check_model: +	if (!check_count--) { +		if (rewrite_count) +			goto rewrite_model; +		else +			status_msg = "check failed!"; + +		goto error;  	} -	ret |= fg_read_regs(p, MAX17042_MODEL1, r_data0, ARRAY_SIZE(r_data0)); -	ret |= fg_read_regs(p, MAX17042_MODEL2, r_data1, ARRAY_SIZE(r_data1)); -	ret |= fg_read_regs(p, MAX17042_MODEL3, r_data2, ARRAY_SIZE(r_data2)); +	ret = fg_read_regs(p, MAX17042_MODEL1, r_data0, ARRAY_SIZE(r_data0)); +	if (ret) +		goto check_model; + +	ret = fg_read_regs(p, MAX17042_MODEL2, r_data1, ARRAY_SIZE(r_data1)); +	if (ret) +		goto check_model; +	ret = fg_read_regs(p, MAX17042_MODEL3, r_data2, ARRAY_SIZE(r_data2));  	if (ret) -		printf("%s: Cell parameters read failed!\n", __func__); +		goto check_model;  	for (i = 0; i < 16; i++) {  		if ((cell_character0[i] != r_data0[i]) @@ -98,29 +137,37 @@ rewrite_model:  			goto rewrite_model;  		} +lock_model: +	if (!lock_count--) { +		if (rewrite_count) +			goto rewrite_model; +		else +			status_msg = "lock failed!"; + +		goto error; +	} +  	/* Lock model access */  	pmic_reg_write(p, MAX17042_MLOCKReg1, MODEL_LOCK1);  	pmic_reg_write(p, MAX17042_MLOCKReg2, MODEL_LOCK2);  	/* Verify the model access is locked */ -	ret |= fg_read_regs(p, MAX17042_MODEL1, r_data0, ARRAY_SIZE(r_data0)); -	ret |= fg_read_regs(p, MAX17042_MODEL2, r_data1, ARRAY_SIZE(r_data1)); -	ret |= fg_read_regs(p, MAX17042_MODEL3, r_data2, ARRAY_SIZE(r_data2)); +	ret = fg_read_regs(p, MAX17042_MODEL1, r_data0, ARRAY_SIZE(r_data0)); +	if (ret) +		goto lock_model; -	if (ret) { -		printf("%s: Cell parameters read failed!\n", __func__); -		return; -	} +	ret = fg_read_regs(p, MAX17042_MODEL2, r_data1, ARRAY_SIZE(r_data1)); +	if (ret) +		goto lock_model; + +	ret = fg_read_regs(p, MAX17042_MODEL3, r_data2, ARRAY_SIZE(r_data2)); +	if (ret) +		goto lock_model;  	for (i = 0; i < ARRAY_SIZE(r_data0); i++) {  		/* Check if model locked */ -		if (r_data0[i] || r_data1[i] || r_data2[i]) { -			/* Rewrite model data - prevent from endless loop */ -			if (rewrite_count--) { -				puts("FG - Lock model access failed!\n"); -				goto rewrite_model; -			} -		} +		if (r_data0[i] || r_data1[i] || r_data2[i]) +			goto lock_model;  	}  	/* Write Custom Parameters */ @@ -137,6 +184,11 @@ rewrite_model:  	/* Delay at least 350 ms */  	mdelay(350); + +	status_msg = "OK!"; +error: +	debug("%s: model init status: %s\n", p->name, status_msg); +	return;  }  static int power_update_battery(struct pmic *p, struct pmic *bat) @@ -178,7 +230,7 @@ static int power_check_battery(struct pmic *p, struct pmic *bat)  	ret |= pmic_reg_read(p, MAX17042_STATUS, &val);  	debug("fg status: 0x%x\n", val); -	if (val == MAX17042_POR) +	if (val & MAX17042_POR)  		por_fuelgauge_init(p);  	ret |= pmic_reg_read(p, MAX17042_VERSION, &val); diff --git a/drivers/serial/lpc32xx_hsuart.c b/drivers/serial/lpc32xx_hsuart.c index 9c7c6213a..c8926a894 100644 --- a/drivers/serial/lpc32xx_hsuart.c +++ b/drivers/serial/lpc32xx_hsuart.c @@ -38,6 +38,9 @@ static int lpc32xx_serial_getc(void)  static void lpc32xx_serial_putc(const char c)  { +	if (c == '\n') +		serial_putc('\r'); +  	writel(c, &hsuart->tx);  	/* Wait for character to be sent */ diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 181c81815..fbc37b27e 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -56,9 +56,8 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)  		;  	serial_out(CONFIG_SYS_NS16550_IER, &com_port->ier); -#if (defined(CONFIG_OMAP) && !defined(CONFIG_OMAP3_ZOOM2)) || \ -			defined(CONFIG_AM33XX) || defined(CONFIG_TI81XX) || \ -			defined(CONFIG_AM43XX) +#if defined(CONFIG_OMAP) || defined(CONFIG_AM33XX) || \ +			defined(CONFIG_TI81XX) || defined(CONFIG_AM43XX)  	serial_out(0x7, &com_port->mdr1);	/* mode select reset TL16C750*/  #endif  	serial_out(UART_LCR_BKSE | UART_LCRVAL, &com_port->lcr); diff --git a/drivers/serial/serial_sh.h b/drivers/serial/serial_sh.h index 556b86815..f5e9854d1 100644 --- a/drivers/serial/serial_sh.h +++ b/drivers/serial/serial_sh.h @@ -143,7 +143,9 @@ struct uart_port {  #elif defined(CONFIG_H8S2678)  # define SCSCR_INIT(port)          0x30 /* TIE=0,RIE=0,TE=1,RE=1 */  # define H8300_SCI_DR(ch) (*(volatile char *)(P1DR + h8300_sci_pins[ch].port)) -#elif defined(CONFIG_CPU_SH7757) || defined(CONFIG_CPU_SH7752) +#elif defined(CONFIG_CPU_SH7757) || \ +	defined(CONFIG_CPU_SH7752) || \ +	defined(CONFIG_CPU_SH7753)  # define SCSPTR0 0xfe4b0020  # define SCSPTR1 0xfe4b0020  # define SCSPTR2 0xfe4b0020 diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile index ed4ecd754..81b6af669 100644 --- a/drivers/spi/Makefile +++ b/drivers/spi/Makefile @@ -19,6 +19,7 @@ obj-$(CONFIG_CF_SPI) += cf_spi.o  obj-$(CONFIG_CF_QSPI) += cf_qspi.o  obj-$(CONFIG_DAVINCI_SPI) += davinci_spi.o  obj-$(CONFIG_EXYNOS_SPI) += exynos_spi.o +obj-$(CONFIG_FTSSP010_SPI) += ftssp010_spi.o  obj-$(CONFIG_ICH_SPI) +=  ich.o  obj-$(CONFIG_KIRKWOOD_SPI) += kirkwood_spi.o  obj-$(CONFIG_MPC52XX_SPI) += mpc52xx_spi.o @@ -30,6 +31,7 @@ obj-$(CONFIG_OMAP3_SPI) += omap3_spi.o  obj-$(CONFIG_SANDBOX_SPI) += sandbox_spi.o  obj-$(CONFIG_SOFT_SPI) += soft_spi.o  obj-$(CONFIG_SH_SPI) += sh_spi.o +obj-$(CONFIG_SH_QSPI) += sh_qspi.o  obj-$(CONFIG_FSL_ESPI) += fsl_espi.o  obj-$(CONFIG_FDT_SPI) += fdt_spi.o  obj-$(CONFIG_TEGRA20_SFLASH) += tegra20_sflash.o diff --git a/drivers/spi/ftssp010_spi.c b/drivers/spi/ftssp010_spi.c new file mode 100644 index 000000000..aa3b5a01c --- /dev/null +++ b/drivers/spi/ftssp010_spi.c @@ -0,0 +1,508 @@ +/* + * (C) Copyright 2013 + * Faraday Technology Corporation. <http://www.faraday-tech.com/tw/> + * Kuo-Jung Su <dantesu@gmail.com> + * + * SPDX-License-Identifier:     GPL-2.0+ + */ + +#include <common.h> +#include <linux/compat.h> +#include <asm/io.h> +#include <malloc.h> +#include <spi.h> + +#ifndef CONFIG_FTSSP010_BASE_LIST +#define CONFIG_FTSSP010_BASE_LIST   { CONFIG_FTSSP010_BASE } +#endif + +#ifndef CONFIG_FTSSP010_GPIO_BASE +#define CONFIG_FTSSP010_GPIO_BASE   0 +#endif + +#ifndef CONFIG_FTSSP010_GPIO_LIST +#define CONFIG_FTSSP010_GPIO_LIST   { CONFIG_FTSSP010_GPIO_BASE } +#endif + +#ifndef CONFIG_FTSSP010_CLOCK +#define CONFIG_FTSSP010_CLOCK       clk_get_rate("SSP"); +#endif + +#ifndef CONFIG_FTSSP010_TIMEOUT +#define CONFIG_FTSSP010_TIMEOUT     100 +#endif + +/* FTSSP010 chip registers */ +struct ftssp010_regs { +	uint32_t cr[3];/* control register */ +	uint32_t sr;   /* status register */ +	uint32_t icr;  /* interrupt control register */ +	uint32_t isr;  /* interrupt status register */ +	uint32_t dr;   /* data register */ +	uint32_t rsvd[17]; +	uint32_t revr; /* revision register */ +	uint32_t fear; /* feature register */ +}; + +/* Control Register 0  */ +#define CR0_FFMT_MASK       (7 << 12) +#define CR0_FFMT_SSP        (0 << 12) +#define CR0_FFMT_SPI        (1 << 12) +#define CR0_FFMT_MICROWIRE  (2 << 12) +#define CR0_FFMT_I2S        (3 << 12) +#define CR0_FFMT_AC97       (4 << 12) +#define CR0_FLASH           (1 << 11) +#define CR0_FSDIST(x)       (((x) & 0x03) << 8) +#define CR0_LOOP            (1 << 7)  /* loopback mode */ +#define CR0_LSB             (1 << 6)  /* LSB */ +#define CR0_FSPO            (1 << 5)  /* fs atcive low (I2S only) */ +#define CR0_FSJUSTIFY       (1 << 4) +#define CR0_OPM_SLAVE       (0 << 2) +#define CR0_OPM_MASTER      (3 << 2) +#define CR0_OPM_I2S_MSST    (3 << 2)  /* master stereo mode */ +#define CR0_OPM_I2S_MSMO    (2 << 2)  /* master mono mode */ +#define CR0_OPM_I2S_SLST    (1 << 2)  /* slave stereo mode */ +#define CR0_OPM_I2S_SLMO    (0 << 2)  /* slave mono mode */ +#define CR0_SCLKPO          (1 << 1)  /* clock polarity */ +#define CR0_SCLKPH          (1 << 0)  /* clock phase */ + +/* Control Register 1 */ +#define CR1_PDL(x)   (((x) & 0xff) << 24) /* padding length */ +#define CR1_SDL(x)   ((((x) - 1) & 0x1f) << 16) /* data length */ +#define CR1_DIV(x)   (((x) - 1) & 0xffff) /* clock divider */ + +/* Control Register 2 */ +#define CR2_CS(x)    (((x) & 3) << 10) /* CS/FS select */ +#define CR2_FS       (1 << 9) /* CS/FS signal level */ +#define CR2_TXEN     (1 << 8) /* tx enable */ +#define CR2_RXEN     (1 << 7) /* rx enable */ +#define CR2_RESET    (1 << 6) /* chip reset */ +#define CR2_TXFC     (1 << 3) /* tx fifo Clear */ +#define CR2_RXFC     (1 << 2) /* rx fifo Clear */ +#define CR2_TXDOE    (1 << 1) /* tx data output enable */ +#define CR2_EN       (1 << 0) /* chip enable */ + +/* Status Register */ +#define SR_RFF       (1 << 0) /* rx fifo full */ +#define SR_TFNF      (1 << 1) /* tx fifo not full */ +#define SR_BUSY      (1 << 2) /* chip busy */ +#define SR_RFVE(reg) (((reg) >> 4) & 0x1f)  /* rx fifo valid entries */ +#define SR_TFVE(reg) (((reg) >> 12) & 0x1f) /* tx fifo valid entries */ + +/* Feature Register */ +#define FEAR_BITS(reg)   ((((reg) >>  0) & 0xff) + 1) /* data width */ +#define FEAR_RFSZ(reg)   ((((reg) >>  8) & 0xff) + 1) /* rx fifo size */ +#define FEAR_TFSZ(reg)   ((((reg) >> 16) & 0xff) + 1) /* tx fifo size */ +#define FEAR_AC97        (1 << 24) +#define FEAR_I2S         (1 << 25) +#define FEAR_SPI_MWR     (1 << 26) +#define FEAR_SSP         (1 << 27) +#define FEAR_SPDIF       (1 << 28) + +/* FTGPIO010 chip registers */ +struct ftgpio010_regs { +	uint32_t out;     /* 0x00: Data Output */ +	uint32_t in;      /* 0x04: Data Input */ +	uint32_t dir;     /* 0x08: Direction */ +	uint32_t bypass;  /* 0x0c: Bypass */ +	uint32_t set;     /* 0x10: Data Set */ +	uint32_t clr;     /* 0x14: Data Clear */ +	uint32_t pull_up; /* 0x18: Pull-Up Enabled */ +	uint32_t pull_st; /* 0x1c: Pull State (0=pull-down, 1=pull-up) */ +}; + +struct ftssp010_gpio { +	struct ftgpio010_regs *regs; +	uint32_t pin; +}; + +struct ftssp010_spi { +	struct spi_slave slave; +	struct ftssp010_gpio gpio; +	struct ftssp010_regs *regs; +	uint32_t fifo; +	uint32_t mode; +	uint32_t div; +	uint32_t clk; +	uint32_t speed; +	uint32_t revision; +}; + +static inline struct ftssp010_spi *to_ftssp010_spi(struct spi_slave *slave) +{ +	return container_of(slave, struct ftssp010_spi, slave); +} + +static int get_spi_chip(int bus, struct ftssp010_spi *chip) +{ +	uint32_t fear, base[] = CONFIG_FTSSP010_BASE_LIST; + +	if (bus >= ARRAY_SIZE(base) || !base[bus]) +		return -1; + +	chip->regs = (struct ftssp010_regs *)base[bus]; + +	chip->revision = readl(&chip->regs->revr); + +	fear = readl(&chip->regs->fear); +	chip->fifo = min_t(uint32_t, FEAR_TFSZ(fear), FEAR_RFSZ(fear)); + +	return 0; +} + +static int get_spi_gpio(int bus, struct ftssp010_gpio *chip) +{ +	uint32_t base[] = CONFIG_FTSSP010_GPIO_LIST; + +	if (bus >= ARRAY_SIZE(base) || !base[bus]) +		return -1; + +	chip->regs = (struct ftgpio010_regs *)(base[bus] & 0xfff00000); +	chip->pin = base[bus] & 0x1f; + +	/* make it an output pin */ +	setbits_le32(&chip->regs->dir, 1 << chip->pin); + +	return 0; +} + +static int ftssp010_wait(struct ftssp010_spi *chip) +{ +	struct ftssp010_regs *regs = chip->regs; +	int ret = -1; +	ulong t; + +	/* wait until device idle */ +	for (t = get_timer(0); get_timer(t) < CONFIG_FTSSP010_TIMEOUT; ) { +		if (readl(®s->sr) & SR_BUSY) +			continue; +		ret = 0; +		break; +	} + +	if (ret) +		puts("ftspi010: busy timeout\n"); + +	return ret; +} + +static int ftssp010_wait_tx(struct ftssp010_spi *chip) +{ +	struct ftssp010_regs *regs = chip->regs; +	int ret = -1; +	ulong t; + +	/* wait until tx fifo not full */ +	for (t = get_timer(0); get_timer(t) < CONFIG_FTSSP010_TIMEOUT; ) { +		if (!(readl(®s->sr) & SR_TFNF)) +			continue; +		ret = 0; +		break; +	} + +	if (ret) +		puts("ftssp010: tx timeout\n"); + +	return ret; +} + +static int ftssp010_wait_rx(struct ftssp010_spi *chip) +{ +	struct ftssp010_regs *regs = chip->regs; +	int ret = -1; +	ulong t; + +	/* wait until rx fifo not empty */ +	for (t = get_timer(0); get_timer(t) < CONFIG_FTSSP010_TIMEOUT; ) { +		if (!SR_RFVE(readl(®s->sr))) +			continue; +		ret = 0; +		break; +	} + +	if (ret) +		puts("ftssp010: rx timeout\n"); + +	return ret; +} + +static int ftssp010_spi_work_transfer_v2(struct ftssp010_spi *chip, +	const void *tx_buf, void *rx_buf, int len, uint flags) +{ +	struct ftssp010_regs *regs = chip->regs; +	const uint8_t *txb = tx_buf; +	uint8_t       *rxb = rx_buf; + +	while (len > 0) { +		int i, depth = min(chip->fifo >> 2, len); +		uint32_t xmsk = 0; + +		if (tx_buf) { +			for (i = 0; i < depth; ++i) { +				ftssp010_wait_tx(chip); +				writel(*txb++, ®s->dr); +			} +			xmsk |= CR2_TXEN | CR2_TXDOE; +			if ((readl(®s->cr[2]) & xmsk) != xmsk) +				setbits_le32(®s->cr[2], xmsk); +		} +		if (rx_buf) { +			xmsk |= CR2_RXEN; +			if ((readl(®s->cr[2]) & xmsk) != xmsk) +				setbits_le32(®s->cr[2], xmsk); +			for (i = 0; i < depth; ++i) { +				ftssp010_wait_rx(chip); +				*rxb++ = (uint8_t)readl(®s->dr); +			} +		} + +		len -= depth; +	} + +	return 0; +} + +static int ftssp010_spi_work_transfer_v1(struct ftssp010_spi *chip, +	const void *tx_buf, void *rx_buf, int len, uint flags) +{ +	struct ftssp010_regs *regs = chip->regs; +	const uint8_t *txb = tx_buf; +	uint8_t       *rxb = rx_buf; + +	while (len > 0) { +		int i, depth = min(chip->fifo >> 2, len); +		uint32_t tmp; + +		for (i = 0; i < depth; ++i) { +			ftssp010_wait_tx(chip); +			writel(txb ? (*txb++) : 0, ®s->dr); +		} +		for (i = 0; i < depth; ++i) { +			ftssp010_wait_rx(chip); +			tmp = readl(®s->dr); +			if (rxb) +				*rxb++ = (uint8_t)tmp; +		} + +		len -= depth; +	} + +	return 0; +} + +static void ftssp010_cs_set(struct ftssp010_spi *chip, int high) +{ +	struct ftssp010_regs *regs = chip->regs; +	struct ftssp010_gpio *gpio = &chip->gpio; +	uint32_t mask; + +	/* cs pull high/low */ +	if (chip->revision >= 0x11900) { +		mask = CR2_CS(chip->slave.cs) | (high ? CR2_FS : 0); +		writel(mask, ®s->cr[2]); +	} else if (gpio->regs) { +		mask = 1 << gpio->pin; +		if (high) +			writel(mask, &gpio->regs->set); +		else +			writel(mask, &gpio->regs->clr); +	} + +	/* extra delay for signal propagation */ +	udelay_masked(1); +} + +/* + * Determine if a SPI chipselect is valid. + * This function is provided by the board if the low-level SPI driver + * needs it to determine if a given chipselect is actually valid. + * + * Returns: 1 if bus:cs identifies a valid chip on this board, 0 + * otherwise. + */ +int spi_cs_is_valid(unsigned int bus, unsigned int cs) +{ +	struct ftssp010_spi chip; + +	if (get_spi_chip(bus, &chip)) +		return 0; + +	if (!cs) +		return 1; +	else if ((cs < 4) && (chip.revision >= 0x11900)) +		return 1; + +	return 0; +} + +/* + * Activate a SPI chipselect. + * This function is provided by the board code when using a driver + * that can't control its chipselects automatically (e.g. + * common/soft_spi.c). When called, it should activate the chip select + * to the device identified by "slave". + */ +void spi_cs_activate(struct spi_slave *slave) +{ +	struct ftssp010_spi *chip = to_ftssp010_spi(slave); +	struct ftssp010_regs *regs = chip->regs; + +	/* cs pull */ +	if (chip->mode & SPI_CS_HIGH) +		ftssp010_cs_set(chip, 1); +	else +		ftssp010_cs_set(chip, 0); + +	/* chip enable + fifo clear */ +	setbits_le32(®s->cr[2], CR2_EN | CR2_TXFC | CR2_RXFC); +} + +/* + * Deactivate a SPI chipselect. + * This function is provided by the board code when using a driver + * that can't control its chipselects automatically (e.g. + * common/soft_spi.c). When called, it should deactivate the chip + * select to the device identified by "slave". + */ +void spi_cs_deactivate(struct spi_slave *slave) +{ +	struct ftssp010_spi *chip = to_ftssp010_spi(slave); + +	/* wait until chip idle */ +	ftssp010_wait(chip); + +	/* cs pull */ +	if (chip->mode & SPI_CS_HIGH) +		ftssp010_cs_set(chip, 0); +	else +		ftssp010_cs_set(chip, 1); +} + +void spi_init(void) +{ +	/* nothing to do */ +} + +struct spi_slave *spi_setup_slave(uint bus, uint cs, uint max_hz, uint mode) +{ +	struct ftssp010_spi *chip; + +	if (mode & SPI_3WIRE) { +		puts("ftssp010: can't do 3-wire\n"); +		return NULL; +	} + +	if (mode & SPI_SLAVE) { +		puts("ftssp010: can't do slave mode\n"); +		return NULL; +	} + +	if (mode & SPI_PREAMBLE) { +		puts("ftssp010: can't skip preamble bytes\n"); +		return NULL; +	} + +	if (!spi_cs_is_valid(bus, cs)) { +		puts("ftssp010: invalid (bus, cs)\n"); +		return NULL; +	} + +	chip = spi_alloc_slave(struct ftssp010_spi, bus, cs); +	if (!chip) +		return NULL; + +	if (get_spi_chip(bus, chip)) +		goto free_out; + +	if (chip->revision < 0x11900 && get_spi_gpio(bus, &chip->gpio)) { +		puts("ftssp010: Before revision 1.19.0, its clock & cs are\n" +		"controlled by tx engine which is not synced with rx engine,\n" +		"so the clock & cs might be shutdown before rx engine\n" +		"finishs its jobs.\n" +		"If possible, please add a dedicated gpio for it.\n"); +	} + +	chip->mode = mode; +	chip->clk = CONFIG_FTSSP010_CLOCK; +	chip->div = 2; +	if (max_hz) { +		while (chip->div < 0xffff) { +			if ((chip->clk / (2 * chip->div)) <= max_hz) +				break; +			chip->div += 1; +		} +	} +	chip->speed = chip->clk / (2 * chip->div); + +	return &chip->slave; + +free_out: +	free(chip); +	return NULL; +} + +void spi_free_slave(struct spi_slave *slave) +{ +	free(slave); +} + +int spi_claim_bus(struct spi_slave *slave) +{ +	struct ftssp010_spi *chip = to_ftssp010_spi(slave); +	struct ftssp010_regs *regs = chip->regs; + +	writel(CR1_SDL(8) | CR1_DIV(chip->div), ®s->cr[1]); + +	if (chip->revision >= 0x11900) { +		writel(CR0_OPM_MASTER | CR0_FFMT_SPI | CR0_FSPO | CR0_FLASH, +		       ®s->cr[0]); +		writel(CR2_TXFC | CR2_RXFC, +		       ®s->cr[2]); +	} else { +		writel(CR0_OPM_MASTER | CR0_FFMT_SPI | CR0_FSPO, +		       ®s->cr[0]); +		writel(CR2_TXFC | CR2_RXFC | CR2_EN | CR2_TXDOE, +		       ®s->cr[2]); +	} + +	if (chip->mode & SPI_LOOP) +		setbits_le32(®s->cr[0], CR0_LOOP); + +	if (chip->mode & SPI_CPOL) +		setbits_le32(®s->cr[0], CR0_SCLKPO); + +	if (chip->mode & SPI_CPHA) +		setbits_le32(®s->cr[0], CR0_SCLKPH); + +	spi_cs_deactivate(slave); + +	return 0; +} + +void spi_release_bus(struct spi_slave *slave) +{ +	struct ftssp010_spi *chip = to_ftssp010_spi(slave); +	struct ftssp010_regs *regs = chip->regs; + +	writel(0, ®s->cr[2]); +} + +int spi_xfer(struct spi_slave *slave, unsigned int bitlen, +			 const void *dout, void *din, unsigned long flags) +{ +	struct ftssp010_spi *chip = to_ftssp010_spi(slave); +	uint32_t len = bitlen >> 3; + +	if (flags & SPI_XFER_BEGIN) +		spi_cs_activate(slave); + +	if (chip->revision >= 0x11900) +		ftssp010_spi_work_transfer_v2(chip, dout, din, len, flags); +	else +		ftssp010_spi_work_transfer_v1(chip, dout, din, len, flags); + +	if (flags & SPI_XFER_END) +		spi_cs_deactivate(slave); + +	return 0; +} diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c new file mode 100644 index 000000000..77ede6bba --- /dev/null +++ b/drivers/spi/sh_qspi.c @@ -0,0 +1,278 @@ +/* + * SH QSPI (Quad SPI) driver + * + * Copyright (C) 2013 Renesas Electronics Corporation + * Copyright (C) 2013 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> + * + * SPDX-License-Identifier:	GPL-2.0 + */ + +#include <common.h> +#include <malloc.h> +#include <spi.h> +#include <asm/arch/rmobile.h> +#include <asm/io.h> + +/* SH QSPI register bit masks <REG>_<BIT> */ +#define SPCR_MSTR	0x08 +#define SPCR_SPE	0x40 +#define SPSR_SPRFF	0x80 +#define SPSR_SPTEF	0x20 +#define SPPCR_IO3FV	0x04 +#define SPPCR_IO2FV	0x02 +#define SPPCR_IO1FV	0x01 +#define SPBDCR_RXBC0	(1 << 0) +#define SPCMD_SCKDEN	(1 << 15) +#define SPCMD_SLNDEN	(1 << 14) +#define SPCMD_SPNDEN	(1 << 13) +#define SPCMD_SSLKP	(1 << 7) +#define SPCMD_BRDV0	(1 << 2) +#define SPCMD_INIT1	SPCMD_SCKDEN | SPCMD_SLNDEN | \ +			SPCMD_SPNDEN | SPCMD_SSLKP | \ +			SPCMD_BRDV0 +#define SPCMD_INIT2	SPCMD_SPNDEN | SPCMD_SSLKP | \ +			SPCMD_BRDV0 +#define SPBFCR_TXRST	(1 << 7) +#define SPBFCR_RXRST	(1 << 6) + +/* SH QSPI register set */ +struct sh_qspi_regs { +	unsigned char spcr; +	unsigned char sslp; +	unsigned char sppcr; +	unsigned char spsr; +	unsigned long spdr; +	unsigned char spscr; +	unsigned char spssr; +	unsigned char spbr; +	unsigned char spdcr; +	unsigned char spckd; +	unsigned char sslnd; +	unsigned char spnd; +	unsigned char dummy0; +	unsigned short spcmd0; +	unsigned short spcmd1; +	unsigned short spcmd2; +	unsigned short spcmd3; +	unsigned char spbfcr; +	unsigned char dummy1; +	unsigned short spbdcr; +	unsigned long spbmul0; +	unsigned long spbmul1; +	unsigned long spbmul2; +	unsigned long spbmul3; +}; + +struct sh_qspi_slave { +	struct spi_slave	slave; +	struct sh_qspi_regs	*regs; +}; + +static inline struct sh_qspi_slave *to_sh_qspi(struct spi_slave *slave) +{ +	return container_of(slave, struct sh_qspi_slave, slave); +} + +static void sh_qspi_init(struct sh_qspi_slave *ss) +{ +	/* QSPI initialize */ +	/* Set master mode only */ +	writeb(SPCR_MSTR, &ss->regs->spcr); + +	/* Set SSL signal level */ +	writeb(0x00, &ss->regs->sslp); + +	/* Set MOSI signal value when transfer is in idle state */ +	writeb(SPPCR_IO3FV|SPPCR_IO2FV, &ss->regs->sppcr); + +	/* Set bit rate. See 58.3.8 Quad Serial Peripheral Interface */ +	writeb(0x01, &ss->regs->spbr); + +	/* Disable Dummy Data Transmission */ +	writeb(0x00, &ss->regs->spdcr); + +	/* Set clock delay value */ +	writeb(0x00, &ss->regs->spckd); + +	/* Set SSL negation delay value */ +	writeb(0x00, &ss->regs->sslnd); + +	/* Set next-access delay value */ +	writeb(0x00, &ss->regs->spnd); + +	/* Set equence command */ +	writew(SPCMD_INIT2, &ss->regs->spcmd0); + +	/* Reset transfer and receive Buffer */ +	setbits_8(&ss->regs->spbfcr, SPBFCR_TXRST|SPBFCR_RXRST); + +	/* Clear transfer and receive Buffer control bit */ +	clrbits_8(&ss->regs->spbfcr, SPBFCR_TXRST|SPBFCR_RXRST); + +	/* Set equence control method. Use equence0 only */ +	writeb(0x00, &ss->regs->spscr); + +	/* Enable SPI function */ +	setbits_8(&ss->regs->spcr, SPCR_SPE); +} + +int spi_cs_is_valid(unsigned int bus, unsigned int cs) +{ +	return 1; +} + +void spi_cs_activate(struct spi_slave *slave) +{ +	struct sh_qspi_slave *ss = to_sh_qspi(slave); + +	/* Set master mode only */ +	writeb(SPCR_MSTR, &ss->regs->spcr); + +	/* Set command */ +	writew(SPCMD_INIT1, &ss->regs->spcmd0); + +	/* Reset transfer and receive Buffer */ +	setbits_8(&ss->regs->spbfcr, SPBFCR_TXRST|SPBFCR_RXRST); + +	/* Clear transfer and receive Buffer control bit */ +	clrbits_8(&ss->regs->spbfcr, SPBFCR_TXRST|SPBFCR_RXRST); + +	/* Set equence control method. Use equence0 only */ +	writeb(0x00, &ss->regs->spscr); + +	/* Enable SPI function */ +	setbits_8(&ss->regs->spcr, SPCR_SPE); +} + +void spi_cs_deactivate(struct spi_slave *slave) +{ +	struct sh_qspi_slave *ss = to_sh_qspi(slave); + +	/* Disable SPI Function */ +	clrbits_8(&ss->regs->spcr, SPCR_SPE); +} + +void spi_init(void) +{ +	/* nothing to do */ +} + +struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs, +		unsigned int max_hz, unsigned int mode) +{ +	struct sh_qspi_slave *ss; + +	if (!spi_cs_is_valid(bus, cs)) +		return NULL; + +	ss = spi_alloc_slave(struct sh_qspi_slave, bus, cs); +	if (!ss) { +		printf("SPI_error: Fail to allocate sh_qspi_slave\n"); +		return NULL; +	} + +	ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE; + +	/* Init SH QSPI */ +	sh_qspi_init(ss); + +	return &ss->slave; +} + +void spi_free_slave(struct spi_slave *slave) +{ +	struct sh_qspi_slave *spi = to_sh_qspi(slave); + +	free(spi); +} + +int spi_claim_bus(struct spi_slave *slave) +{ +	return 0; +} + +void spi_release_bus(struct spi_slave *slave) +{ +} + +int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, +	     void *din, unsigned long flags) +{ +	struct sh_qspi_slave *ss = to_sh_qspi(slave); +	unsigned long nbyte; +	int ret = 0; +	unsigned char dtdata = 0, drdata; +	unsigned char *tdata = &dtdata, *rdata = &drdata; +	unsigned long *spbmul0 = &ss->regs->spbmul0; + +	if (dout == NULL && din == NULL) { +		if (flags & SPI_XFER_END) +			spi_cs_deactivate(slave); +		return 0; +	} + +	if (bitlen % 8) { +		printf("%s: bitlen is not 8bit alined %d", __func__, bitlen); +		return 1; +	} + +	nbyte = bitlen / 8; + +	if (flags & SPI_XFER_BEGIN) { +		spi_cs_activate(slave); + +		/* Set 1048576 byte */ +		writel(0x100000, spbmul0); +	} + +	if (flags & SPI_XFER_END) +		writel(nbyte, spbmul0); + +	if (dout != NULL) +		tdata = (unsigned char *)dout; + +	if (din != NULL) +		rdata = din; + +	while (nbyte > 0) { +		while (!(readb(&ss->regs->spsr) & SPSR_SPTEF)) { +			if (ctrlc()) { +				puts("abort\n"); +				return 1; +			} +			udelay(10); +		} + +		writeb(*tdata, (unsigned char *)(&ss->regs->spdr)); + +		while ((readw(&ss->regs->spbdcr) != SPBDCR_RXBC0)) { +			if (ctrlc()) { +				puts("abort\n"); +				return 1; +			} +			udelay(1); +		} + +		while (!(readb(&ss->regs->spsr) & SPSR_SPRFF)) { +			if (ctrlc()) { +				puts("abort\n"); +				return 1; +			} +			udelay(10); +		} + +		*rdata = readb((unsigned char *)(&ss->regs->spdr)); + +		if (dout != NULL) +			tdata++; +		if (din != NULL) +			rdata++; + +		nbyte--; +	} + +	if (flags & SPI_XFER_END) +		spi_cs_deactivate(slave); + +	return ret; +} diff --git a/drivers/spi/sh_spi.c b/drivers/spi/sh_spi.c index 744afe329..7ca5e363d 100644 --- a/drivers/spi/sh_spi.c +++ b/drivers/spi/sh_spi.c @@ -151,7 +151,6 @@ static int sh_spi_send(struct sh_spi *ss, const unsigned char *tx_data,  {  	int i, cur_len, ret = 0;  	int remain = (int)len; -	unsigned long tmp;  	if (len >= SH_SPI_FIFO_SIZE)  		sh_spi_set_bit(SH_SPI_SSA, &ss->regs->cr1); @@ -183,9 +182,7 @@ static int sh_spi_send(struct sh_spi *ss, const unsigned char *tx_data,  	}  	if (flags & SPI_XFER_END) { -		tmp = sh_spi_read(&ss->regs->cr1); -		tmp = tmp & ~(SH_SPI_SSD | SH_SPI_SSDB); -		sh_spi_write(tmp, &ss->regs->cr1); +		sh_spi_clear_bit(SH_SPI_SSD | SH_SPI_SSDB, &ss->regs->cr1);  		sh_spi_set_bit(SH_SPI_SSA, &ss->regs->cr1);  		udelay(100);  		write_fifo_empty_wait(ss); @@ -198,16 +195,13 @@ static int sh_spi_receive(struct sh_spi *ss, unsigned char *rx_data,  			  unsigned int len, unsigned long flags)  {  	int i; -	unsigned long tmp;  	if (len > SH_SPI_MAX_BYTE)  		sh_spi_write(SH_SPI_MAX_BYTE, &ss->regs->cr3);  	else  		sh_spi_write(len, &ss->regs->cr3); -	tmp = sh_spi_read(&ss->regs->cr1); -	tmp = tmp & ~(SH_SPI_SSD | SH_SPI_SSDB); -	sh_spi_write(tmp, &ss->regs->cr1); +	sh_spi_clear_bit(SH_SPI_SSD | SH_SPI_SSDB, &ss->regs->cr1);  	sh_spi_set_bit(SH_SPI_SSA, &ss->regs->cr1);  	for (i = 0; i < len; i++) { diff --git a/drivers/spi/tegra114_spi.c b/drivers/spi/tegra114_spi.c index 4d2af483d..810fa4718 100644 --- a/drivers/spi/tegra114_spi.c +++ b/drivers/spi/tegra114_spi.c @@ -289,9 +289,6 @@ int tegra114_spi_xfer(struct spi_slave *slave, unsigned int bitlen,  	reg = readl(®s->fifo_status);  	writel(reg, ®s->fifo_status); -	/* clear ready bit */ -	setbits_le32(®s->xfer_status, SPI_XFER_STS_RDY); -  	clrsetbits_le32(®s->command1, SPI_CMD1_CS_SW_VAL,  			SPI_CMD1_RX_EN | SPI_CMD1_TX_EN | SPI_CMD1_LSBY_FE |  			(slave->cs << SPI_CMD1_CS_SEL_SHIFT)); @@ -305,7 +302,6 @@ int tegra114_spi_xfer(struct spi_slave *slave, unsigned int bitlen,  	/* handle data in 32-bit chunks */  	while (num_bytes > 0) {  		int bytes; -		int is_read = 0;  		int tm, i;  		tmpdout = 0; @@ -319,6 +315,9 @@ int tegra114_spi_xfer(struct spi_slave *slave, unsigned int bitlen,  		num_bytes -= bytes; +		/* clear ready bit */ +		setbits_le32(®s->xfer_status, SPI_XFER_STS_RDY); +  		clrsetbits_le32(®s->command1,  				SPI_CMD1_BIT_LEN_MASK << SPI_CMD1_BIT_LEN_SHIFT,  				(bytes * 8 - 1) << SPI_CMD1_BIT_LEN_SHIFT); @@ -329,20 +328,14 @@ int tegra114_spi_xfer(struct spi_slave *slave, unsigned int bitlen,  		 * Wait for SPI transmit FIFO to empty, or to time out.  		 * The RX FIFO status will be read and cleared last  		 */ -		for (tm = 0, is_read = 0; tm < SPI_TIMEOUT; ++tm) { +		for (tm = 0; tm < SPI_TIMEOUT; ++tm) {  			u32 fifo_status, xfer_status; -			fifo_status = readl(®s->fifo_status); - -			/* We can exit when we've had both RX and TX activity */ -			if (is_read && -			    (fifo_status & SPI_FIFO_STS_TX_FIFO_EMPTY)) -				break; -  			xfer_status = readl(®s->xfer_status);  			if (!(xfer_status & SPI_XFER_STS_RDY))  				continue; +			fifo_status = readl(®s->fifo_status);  			if (fifo_status & SPI_FIFO_STS_ERR) {  				debug("%s: got a fifo error: ", __func__);  				if (fifo_status & SPI_FIFO_STS_TX_FIFO_OVF) @@ -367,7 +360,6 @@ int tegra114_spi_xfer(struct spi_slave *slave, unsigned int bitlen,  			if (!(fifo_status & SPI_FIFO_STS_RX_FIFO_EMPTY)) {  				tmpdin = readl(®s->rx_fifo); -				is_read = 1;  				/* swap bytes read in */  				if (din != NULL) { @@ -377,6 +369,9 @@ int tegra114_spi_xfer(struct spi_slave *slave, unsigned int bitlen,  					}  					din += bytes;  				} + +				/* We can exit when we've had both RX and TX */ +				break;  			}  		} diff --git a/drivers/tpm/Makefile b/drivers/tpm/Makefile index 2f2353f80..150570ee7 100644 --- a/drivers/tpm/Makefile +++ b/drivers/tpm/Makefile @@ -8,3 +8,4 @@ obj-$(CONFIG_TPM_ATMEL_TWI) += tpm_atmel_twi.o  obj-$(CONFIG_TPM_TIS_I2C) += tpm.o  obj-$(CONFIG_TPM_TIS_I2C) += tpm_tis_i2c.o  obj-$(CONFIG_TPM_TIS_LPC) += tpm_tis_lpc.o +obj-$(CONFIG_TPM_TIS_SANDBOX) += tpm_tis_sandbox.o diff --git a/drivers/tpm/tpm_tis_sandbox.c b/drivers/tpm/tpm_tis_sandbox.c new file mode 100644 index 000000000..ed4b03912 --- /dev/null +++ b/drivers/tpm/tpm_tis_sandbox.c @@ -0,0 +1,260 @@ +/* + * Copyright (c) 2013 Google, Inc + * + * SPDX-License-Identifier:	GPL-2.0+ + */ + +#include <common.h> +#include <asm/state.h> +#include <asm/unaligned.h> +#include <linux/crc8.h> + +/* TPM NVRAM location indices. */ +#define FIRMWARE_NV_INDEX		0x1007 +#define KERNEL_NV_INDEX			0x1008 + +#define NV_DATA_PUBLIC_PERMISSIONS_OFFSET	60 + +/* Kernel TPM space - KERNEL_NV_INDEX, locked with physical presence */ +#define ROLLBACK_SPACE_KERNEL_VERSION	2 +#define ROLLBACK_SPACE_KERNEL_UID	0x4752574C  /* 'GRWL' */ + +struct rollback_space_kernel { +	/* Struct version, for backwards compatibility */ +	uint8_t struct_version; +	/* Unique ID to detect space redefinition */ +	uint32_t uid; +	/* Kernel versions */ +	uint32_t kernel_versions; +	/* Reserved for future expansion */ +	uint8_t reserved[3]; +	/* Checksum (v2 and later only) */ +	uint8_t crc8; +} __packed rollback_space_kernel; + +/* + * These numbers derive from adding the sizes of command fields as shown in + * the TPM commands manual. + */ +#define TPM_REQUEST_HEADER_LENGTH	10 +#define TPM_RESPONSE_HEADER_LENGTH	10 + +/* These are the different non-volatile spaces that we emulate */ +enum { +	NV_GLOBAL_LOCK, +	NV_SEQ_FIRMWARE, +	NV_SEQ_KERNEL, +	NV_SEQ_COUNT, +}; + +/* Size of each non-volatile space */ +#define NV_DATA_SIZE		0x20 + +/* + * Information about our TPM emulation. This is preserved in the sandbox + * state file if enabled. + */ +static struct tpm_state { +	uint8_t nvdata[NV_SEQ_COUNT][NV_DATA_SIZE]; +} state; + +/** + * sandbox_tpm_read_state() - read the sandbox EC state from the state file + * + * If data is available, then blob and node will provide access to it. If + * not this function sets up an empty TPM. + * + * @blob: Pointer to device tree blob, or NULL if no data to read + * @node: Node offset to read from + */ +static int sandbox_tpm_read_state(const void *blob, int node) +{ +	const char *prop; +	int len; +	int i; + +	if (!blob) +		return 0; + +	for (i = 0; i < NV_SEQ_COUNT; i++) { +		char prop_name[20]; + +		sprintf(prop_name, "nvdata%d", i); +		prop = fdt_getprop(blob, node, prop_name, &len); +		if (prop && len == NV_DATA_SIZE) +			memcpy(state.nvdata[i], prop, NV_DATA_SIZE); +	} + +	return 0; +} + +/** + * cros_ec_write_state() - Write out our state to the state file + * + * The caller will ensure that there is a node ready for the state. The node + * may already contain the old state, in which case it is overridden. + * + * @blob: Device tree blob holding state + * @node: Node to write our state into + */ +static int sandbox_tpm_write_state(void *blob, int node) +{ +	int i; + +	/* +	 * We are guaranteed enough space to write basic properties. +	 * We could use fdt_add_subnode() to put each set of data in its +	 * own node - perhaps useful if we add access informaiton to each. +	 */ +	for (i = 0; i < NV_SEQ_COUNT; i++) { +		char prop_name[20]; + +		sprintf(prop_name, "nvdata%d", i); +		fdt_setprop(blob, node, prop_name, state.nvdata[i], +			    NV_DATA_SIZE); +	} + +	return 0; +} + +SANDBOX_STATE_IO(sandbox_tpm, "google,sandbox-tpm", sandbox_tpm_read_state, +		 sandbox_tpm_write_state); + +static int index_to_seq(uint32_t index) +{ +	switch (index) { +	case FIRMWARE_NV_INDEX: +		return NV_SEQ_FIRMWARE; +	case KERNEL_NV_INDEX: +		return NV_SEQ_KERNEL; +	case 0: +		return NV_GLOBAL_LOCK; +	} + +	printf("Invalid nv index %#x\n", index); +	return -1; +} + +int tis_sendrecv(const u8 *sendbuf, size_t send_size, +		 u8 *recvbuf, size_t *recv_len) +{ +	struct tpm_state *tpm = &state; +	uint32_t code, index, length, type; +	uint8_t *data; +	int seq; + +	code = get_unaligned_be32(sendbuf + sizeof(uint16_t) + +				  sizeof(uint32_t)); +	printf("tpm: %zd bytes, recv_len %zd, cmd = %x\n", send_size, +	       *recv_len, code); +	print_buffer(0, sendbuf, 1, send_size, 0); +	switch (code) { +	case 0x65: /* get flags */ +		type = get_unaligned_be32(sendbuf + 14); +		switch (type) { +		case 4: +			index = get_unaligned_be32(sendbuf + 18); +			printf("Get flags index %#02x\n", index); +			*recv_len = 22; +			memset(recvbuf, '\0', *recv_len); +			put_unaligned_be32(22, recvbuf + +					   TPM_RESPONSE_HEADER_LENGTH); +			data = recvbuf + TPM_RESPONSE_HEADER_LENGTH + +					sizeof(uint32_t); +			switch (index) { +			case FIRMWARE_NV_INDEX: +				break; +			case KERNEL_NV_INDEX: +				/* TPM_NV_PER_PPWRITE */ +				put_unaligned_be32(1, data + +					NV_DATA_PUBLIC_PERMISSIONS_OFFSET); +				break; +			} +			break; +		case 0x11: /* TPM_CAP_NV_INDEX */ +			index = get_unaligned_be32(sendbuf + 18); +			printf("Get cap nv index %#02x\n", index); +			put_unaligned_be32(22, recvbuf + +					   TPM_RESPONSE_HEADER_LENGTH); +			break; +		default: +			printf("   ** Unknown 0x65 command type %#02x\n", +			       type); +			return -1; +		} +		break; +	case 0xcd: /* nvwrite */ +		index = get_unaligned_be32(sendbuf + 10); +		length = get_unaligned_be32(sendbuf + 18); +		seq = index_to_seq(index); +		if (seq < 0) +			return -1; +		printf("tpm: nvwrite index=%#02x, len=%#02x\n", index, length); +		memcpy(&tpm->nvdata[seq], sendbuf + 22, length); +		*recv_len = 12; +		memset(recvbuf, '\0', *recv_len); +		break; +	case 0xcf: /* nvread */ +		index = get_unaligned_be32(sendbuf + 10); +		length = get_unaligned_be32(sendbuf + 18); +		seq = index_to_seq(index); +		if (seq < 0) +			return -1; +		printf("tpm: nvread index=%#02x, len=%#02x\n", index, length); +		*recv_len = TPM_RESPONSE_HEADER_LENGTH + sizeof(uint32_t) + +					length; +		memset(recvbuf, '\0', *recv_len); +		put_unaligned_be32(length, recvbuf + +				   TPM_RESPONSE_HEADER_LENGTH); +		if (seq == NV_SEQ_KERNEL) { +			struct rollback_space_kernel rsk; + +			data = recvbuf + TPM_RESPONSE_HEADER_LENGTH + +					sizeof(uint32_t); +			rsk.struct_version = 2; +			rsk.uid = ROLLBACK_SPACE_KERNEL_UID; +			rsk.kernel_versions = 0; +			rsk.crc8 = crc8((unsigned char *)&rsk, +					offsetof(struct rollback_space_kernel, +						 crc8)); +			memcpy(data, &rsk, sizeof(rsk)); +		} else { +			memcpy(recvbuf + TPM_RESPONSE_HEADER_LENGTH + +			       sizeof(uint32_t), &tpm->nvdata[seq], length); +		} +		break; +	case 0x14: /* tpm extend */ +	case 0x15: /* pcr read */ +	case 0x5d: /* force clear */ +	case 0x6f: /* physical enable */ +	case 0x72: /* physical set deactivated */ +	case 0x99: /* startup */ +	case 0x4000000a:  /* assert physical presence */ +		*recv_len = 12; +		memset(recvbuf, '\0', *recv_len); +		break; +	default: +		printf("Unknown tpm command %02x\n", code); +		return -1; +	} + +	return 0; +} + +int tis_open(void) +{ +	printf("%s\n", __func__); +	return 0; +} + +int tis_close(void) +{ +	printf("%s\n", __func__); +	return 0; +} + +int tis_init(void) +{ +	printf("%s\n", __func__); +	return 0; +} diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile index f52d3f450..f13b172a6 100644 --- a/drivers/usb/gadget/Makefile +++ b/drivers/usb/gadget/Makefile @@ -5,12 +5,8 @@  # SPDX-License-Identifier:	GPL-2.0+  # -# if defined(CONFIG_USB_GADGET) || defined(CONFIG_USB_ETHER) -#   Everytime you forget how crufty makefiles can get things like -#   this remind you... -ifneq (,$(CONFIG_USB_GADGET)$(CONFIG_USB_ETHER)) -obj-y += epautoconf.o config.o usbstring.o -endif +obj-$(CONFIG_USB_GADGET) += epautoconf.o config.o usbstring.o +obj-$(CONFIG_USB_ETHER) += epautoconf.o config.o usbstring.o  # new USB gadget layer dependencies  ifdef CONFIG_USB_GADGET diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c index 37d04a192..a045864d7 100644 --- a/drivers/usb/gadget/f_dfu.c +++ b/drivers/usb/gadget/f_dfu.c @@ -40,6 +40,7 @@ struct f_dfu {  	/* Send/received block number is handy for data integrity check */  	int                             blk_seq_num; +	unsigned int                    poll_timeout;  };  typedef int (*dfu_state_fn) (struct f_dfu *, @@ -128,6 +129,33 @@ static struct usb_gadget_strings *dfu_strings[] = {  	NULL,  }; +static void dfu_set_poll_timeout(struct dfu_status *dstat, unsigned int ms) +{ +	/* +	 * The bwPollTimeout DFU_GETSTATUS request payload provides information +	 * about minimum time, in milliseconds, that the host should wait before +	 * sending a subsequent DFU_GETSTATUS request +	 * +	 * This permits the device to vary the delay depending on its need to +	 * erase or program the memory +	 * +	 */ + +	unsigned char *p = (unsigned char *)&ms; + +	if (!ms || (ms & ~DFU_POLL_TIMEOUT_MASK)) { +		dstat->bwPollTimeout[0] = 0; +		dstat->bwPollTimeout[1] = 0; +		dstat->bwPollTimeout[2] = 0; + +		return; +	} + +	dstat->bwPollTimeout[0] = *p++; +	dstat->bwPollTimeout[1] = *p++; +	dstat->bwPollTimeout[2] = *p; +} +  /*-------------------------------------------------------------------------*/  static void dnload_request_complete(struct usb_ep *ep, struct usb_request *req) @@ -157,11 +185,15 @@ static void handle_getstatus(struct usb_request *req)  		break;  	} +	dfu_set_poll_timeout(dstat, 0); + +	if (f_dfu->poll_timeout) +		if (!(f_dfu->blk_seq_num % +		      (dfu_get_buf_size() / DFU_USB_BUFSIZ))) +			dfu_set_poll_timeout(dstat, f_dfu->poll_timeout); +  	/* send status response */  	dstat->bStatus = f_dfu->dfu_status; -	dstat->bwPollTimeout[0] = 0; -	dstat->bwPollTimeout[1] = 0; -	dstat->bwPollTimeout[2] = 0;  	dstat->bState = f_dfu->dfu_state;  	dstat->iString = 0;  } @@ -723,8 +755,9 @@ static int dfu_bind_config(struct usb_configuration *c)  	f_dfu->usb_function.unbind = dfu_unbind;  	f_dfu->usb_function.set_alt = dfu_set_alt;  	f_dfu->usb_function.disable = dfu_disable; -	f_dfu->usb_function.strings = dfu_generic_strings, -	f_dfu->usb_function.setup = dfu_handle, +	f_dfu->usb_function.strings = dfu_generic_strings; +	f_dfu->usb_function.setup = dfu_handle; +	f_dfu->poll_timeout = DFU_DEFAULT_POLL_TIMEOUT;  	status = usb_add_function(c, &f_dfu->usb_function);  	if (status) diff --git a/drivers/usb/gadget/f_dfu.h b/drivers/usb/gadget/f_dfu.h index cc2c45567..0c29954ad 100644 --- a/drivers/usb/gadget/f_dfu.h +++ b/drivers/usb/gadget/f_dfu.h @@ -82,4 +82,6 @@ struct dfu_function_descriptor {  	__le16				wTransferSize;  	__le16				bcdDFUVersion;  } __packed; + +#define DFU_POLL_TIMEOUT_MASK           (0xFFFFFFUL)  #endif /* __F_DFU_H_ */ diff --git a/drivers/usb/gadget/fotg210.c b/drivers/usb/gadget/fotg210.c index 6e19db15f..3acf6a1f4 100644 --- a/drivers/usb/gadget/fotg210.c +++ b/drivers/usb/gadget/fotg210.c @@ -245,6 +245,7 @@ static int fotg210_dma(struct fotg210_ep *ep, struct fotg210_request *req)  		if (ep->id == 0) {  			/* Wait until cx/ep0 fifo empty */  			fotg210_cxwait(chip, CXFIFO_CXFIFOE); +			udelay(1);  			writel(DMAFIFO_CX, ®s->dma_fifo);  		} else {  			/* Wait until epx fifo empty */ @@ -847,6 +848,13 @@ int usb_gadget_handle_interrupts(void)  	/* CX interrupts */  	if (gisr & GISR_GRP0) {  		st = readl(®s->gisr0); +		/* +		 * Write 1 and then 0 works for both W1C & RW. +		 * +		 * HW v1.11.0+: It's a W1C register (write 1 clear) +		 * HW v1.10.0-: It's a R/W register (write 0 clear) +		 */ +		writel(st & GISR0_CXABORT, ®s->gisr0);  		writel(0, ®s->gisr0);  		if (st & GISR0_CXERR) @@ -873,6 +881,13 @@ int usb_gadget_handle_interrupts(void)  	/* Device Status Interrupts */  	if (gisr & GISR_GRP2) {  		st = readl(®s->gisr2); +		/* +		 * Write 1 and then 0 works for both W1C & RW. +		 * +		 * HW v1.11.0+: It's a W1C register (write 1 clear) +		 * HW v1.10.0-: It's a R/W register (write 0 clear) +		 */ +		writel(st, ®s->gisr2);  		writel(0, ®s->gisr2);  		if (st & GISR2_RESET) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 66b4de0b2..9356878eb 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -88,6 +88,8 @@ static int exynos_usb_parse_dt(const void *blob, struct exynos_ehci *exynos)  /* Setup the EHCI host controller. */  static void setup_usb_phy(struct exynos_usb_phy *usb)  { +	u32 hsic_ctrl; +  	set_usbhost_mode(USB20_PHY_CFG_HOST_LINK_EN);  	set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_EN); @@ -112,6 +114,32 @@ static void setup_usb_phy(struct exynos_usb_phy *usb)  	clrbits_le32(&usb->usbphyctrl0,  			HOST_CTRL0_LINKSWRST |  			HOST_CTRL0_UTMISWRST); + +	/* HSIC Phy Setting */ +	hsic_ctrl = (HSIC_CTRL_FORCESUSPEND | +			HSIC_CTRL_FORCESLEEP | +			HSIC_CTRL_SIDDQ); + +	clrbits_le32(&usb->hsicphyctrl1, hsic_ctrl); +	clrbits_le32(&usb->hsicphyctrl2, hsic_ctrl); + +	hsic_ctrl = (((HSIC_CTRL_REFCLKDIV_12 & HSIC_CTRL_REFCLKDIV_MASK) +				<< HSIC_CTRL_REFCLKDIV_SHIFT) +			| ((HSIC_CTRL_REFCLKSEL & HSIC_CTRL_REFCLKSEL_MASK) +				<< HSIC_CTRL_REFCLKSEL_SHIFT) +			| HSIC_CTRL_UTMISWRST); + +	setbits_le32(&usb->hsicphyctrl1, hsic_ctrl); +	setbits_le32(&usb->hsicphyctrl2, hsic_ctrl); + +	udelay(10); + +	clrbits_le32(&usb->hsicphyctrl1, HSIC_CTRL_PHYSWRST | +					HSIC_CTRL_UTMISWRST); + +	clrbits_le32(&usb->hsicphyctrl2, HSIC_CTRL_PHYSWRST | +					HSIC_CTRL_UTMISWRST); +  	udelay(20);  	/* EHCI Ctrl setting */ @@ -125,6 +153,8 @@ static void setup_usb_phy(struct exynos_usb_phy *usb)  /* Reset the EHCI host controller. */  static void reset_usb_phy(struct exynos_usb_phy *usb)  { +	u32 hsic_ctrl; +  	/* HOST_PHY reset */  	setbits_le32(&usb->usbphyctrl0,  			HOST_CTRL0_PHYSWRST | @@ -133,6 +163,15 @@ static void reset_usb_phy(struct exynos_usb_phy *usb)  			HOST_CTRL0_FORCESUSPEND |  			HOST_CTRL0_FORCESLEEP); +	/* HSIC Phy reset */ +	hsic_ctrl = (HSIC_CTRL_FORCESUSPEND | +			HSIC_CTRL_FORCESLEEP | +			HSIC_CTRL_SIDDQ | +			HSIC_CTRL_PHYSWRST); + +	setbits_le32(&usb->hsicphyctrl1, hsic_ctrl); +	setbits_le32(&usb->hsicphyctrl2, hsic_ctrl); +  	set_usbhost_phy_ctrl(POWER_USB_HOST_PHY_CTRL_DISABLE);  } @@ -164,6 +203,8 @@ int ehci_hcd_init(int index, enum usb_init_type init,  	setup_usb_phy(ctx->usb); +	board_usb_init(index, init); +  	*hccr = ctx->hcd;  	*hcor = (struct ehci_hcor *)((uint32_t) *hccr  				+ HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase))); diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 8bd1eb8a9..17187caed 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c @@ -201,6 +201,9 @@ static int ehci_shutdown(struct ehci_ctrl *ctrl)  	int i, ret = 0;  	uint32_t cmd, reg; +	if (!ctrl || !ctrl->hcor) +		return -EINVAL; +  	cmd = ehci_readl(&ctrl->hcor->or_usbcmd);  	cmd &= ~(CMD_PSE | CMD_ASE);  	ehci_writel(&ctrl->hcor->or_usbcmd, cmd); @@ -945,7 +948,7 @@ int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)  #endif  	/* Set the high address word (aka segment) for 64-bit controller */  	if (ehci_readl(&ehcic[index].hccr->cr_hccparams) & 1) -		ehci_writel(ehcic[index].hcor->or_ctrldssegment, 0); +		ehci_writel(&ehcic[index].hcor->or_ctrldssegment, 0);  	qh_list = &ehcic[index].qh_list; diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c index 7a1ffe5e2..991b19998 100644 --- a/drivers/usb/host/ehci-pci.c +++ b/drivers/usb/host/ehci-pci.c @@ -54,9 +54,31 @@ static pci_dev_t ehci_find_class(int index)  					bdf += PCI_BDF(0, 0, 1)) {  				pci_read_config_dword(bdf, PCI_CLASS_REVISION,  						      &class); -				if ((class >> 8 == PCI_CLASS_SERIAL_USB_EHCI) -						&& !index--) -					return bdf; +				class >>= 8; +				/* +				 * Here be dragons! In case we have multiple +				 * PCI EHCI controllers, this function will +				 * be called multiple times as well. This +				 * function will scan the PCI busses, always +				 * starting from bus 0, device 0, function 0, +				 * until it finds an USB controller. The USB +				 * stack gives us an 'index' of a controller +				 * that is currently being registered, which +				 * is a number, starting from 0 and growing +				 * in ascending order as controllers are added. +				 * To avoid probing the same controller in tne +				 * subsequent runs of this function, we will +				 * skip 'index - 1' detected controllers and +				 * report the index'th controller. +				 */ +				if (class != PCI_CLASS_SERIAL_USB_EHCI) +					continue; +				if (index) { +					index--; +					continue; +				} +				/* Return index'th controller. */ +				return bdf;  			}  		}  	} diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c index 22ac1429b..cefd2dc14 100644 --- a/drivers/video/ipu_disp.c +++ b/drivers/video/ipu_disp.c @@ -889,7 +889,7 @@ int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk,  	debug("panel size = %d x %d\n", width, height);  	if ((v_sync_width == 0) || (h_sync_width == 0)) -		return EINVAL; +		return -EINVAL;  	adapt_panel_to_ipu_restricitions(&pixel_clk, width, height,  					 h_start_width, h_end_width, diff --git a/drivers/video/ipu_regs.h b/drivers/video/ipu_regs.h index 73e57ea99..21e9c99e0 100644 --- a/drivers/video/ipu_regs.h +++ b/drivers/video/ipu_regs.h @@ -171,7 +171,7 @@ struct ipu_cm {  	u32 gpr;  	u32 reserved0[26];  	u32 ch_db_mode_sel[2]; -	u32 reserved1[16]; +	u32 reserved1[4];  	u32 alt_ch_db_mode_sel[2];  	u32 reserved2[2];  	u32 ch_trb_mode_sel[2]; @@ -188,7 +188,7 @@ struct ipu_idmac {  	u32 sub_addr[5];  	u32 bndm_en[2];  	u32 sc_cord[2]; -	u32 reserved[45]; +	u32 reserved[44];  	u32 ch_busy[2];  }; |