diff options
| -rw-r--r-- | README | 3 | ||||
| -rw-r--r-- | arch/powerpc/cpu/mpc8xxx/ddr/Makefile | 3 | ||||
| -rw-r--r-- | arch/powerpc/cpu/mpc8xxx/ddr/ddr.h | 40 | ||||
| -rw-r--r-- | arch/powerpc/cpu/mpc8xxx/ddr/interactive.c | 1691 | ||||
| -rw-r--r-- | arch/powerpc/cpu/mpc8xxx/ddr/main.c | 9 | ||||
| -rw-r--r-- | doc/README.fsl-ddr | 150 | ||||
| -rw-r--r-- | include/configs/p1_p2_rdb_pc.h | 2 | 
7 files changed, 1880 insertions, 18 deletions
| @@ -3099,6 +3099,9 @@ Low Level (hardware related) configuration options:  		parameters are extracted from datasheet and hard-coded into  		header files or board specific files. +- CONFIG_FSL_DDR_INTERACTIVE +		Enable interactive DDR debugging. See doc/README.fsl-ddr. +  - CONFIG_SYS_83XX_DDR_USES_CS0  		Only for 83xx systems. If specified, then DDR should  		be configured using CS0 and CS1 instead of CS2 and CS3. diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/Makefile b/arch/powerpc/cpu/mpc8xxx/ddr/Makefile index d1b4c4b47..29523aa91 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/Makefile +++ b/arch/powerpc/cpu/mpc8xxx/ddr/Makefile @@ -1,5 +1,5 @@  # -# Copyright 2008 Freescale Semiconductor, Inc. +# Copyright 2008-2011 Freescale Semiconductor, Inc.  #  # This program is free software; you can redistribute it and/or  # modify it under the terms of the GNU General Public License @@ -30,6 +30,7 @@ COBJS-$(CONFIG_FSL_DDR2)	+= ddr2_dimm_params.o  COBJS-$(CONFIG_FSL_DDR3)	+= ddr3_dimm_params.o  endif +COBJS-$(CONFIG_FSL_DDR_INTERACTIVE) += interactive.o  SRCS	:= $(START:.o=.S) $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)  OBJS	:= $(addprefix $(obj),$(SOBJS-y) $(COBJS-y)) diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/ddr.h b/arch/powerpc/cpu/mpc8xxx/ddr/ddr.h index f59aa33b2..c8b0f9167 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/ddr.h +++ b/arch/powerpc/cpu/mpc8xxx/ddr/ddr.h @@ -56,32 +56,46 @@ typedef struct {  #define STEP_PROGRAM_REGS            (1 << 6)  #define STEP_ALL                     0xFFF -extern unsigned long long +unsigned long long  fsl_ddr_compute(fsl_ddr_info_t *pinfo, unsigned int start_step,  				       unsigned int size_only); -extern const char * step_to_string(unsigned int step); +const char *step_to_string(unsigned int step); -extern unsigned int -compute_fsl_memctl_config_regs(const memctl_options_t *popts, +unsigned int compute_fsl_memctl_config_regs(const memctl_options_t *popts,  			       fsl_ddr_cfg_regs_t *ddr,  			       const common_timing_params_t *common_dimm,  			       const dimm_params_t *dimm_parameters,  			       unsigned int dbw_capacity_adjust,  			       unsigned int size_only); -extern unsigned int -compute_lowest_common_dimm_parameters(const dimm_params_t *dimm_params, -				      common_timing_params_t *outpdimm, -				      unsigned int number_of_dimms); -extern unsigned int populate_memctl_options(int all_DIMMs_registered, +unsigned int compute_lowest_common_dimm_parameters( +				const dimm_params_t *dimm_params, +				common_timing_params_t *outpdimm, +				unsigned int number_of_dimms); +unsigned int populate_memctl_options(int all_DIMMs_registered,  				memctl_options_t *popts,  				dimm_params_t *pdimm,  				unsigned int ctrl_num); -extern void check_interleaving_options(fsl_ddr_info_t *pinfo); +void check_interleaving_options(fsl_ddr_info_t *pinfo); -extern unsigned int mclk_to_picos(unsigned int mclk); -extern unsigned int get_memory_clk_period_ps(void); -extern unsigned int picos_to_mclk(unsigned int picos); +unsigned int mclk_to_picos(unsigned int mclk); +unsigned int get_memory_clk_period_ps(void); +unsigned int picos_to_mclk(unsigned int picos); +void fsl_ddr_set_lawbar( +		const common_timing_params_t *memctl_common_params, +		unsigned int memctl_interleaved, +		unsigned int ctrl_num); + +unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo); +void fsl_ddr_get_spd(generic_spd_eeprom_t *ctrl_dimms_spd, +			   unsigned int ctrl_num); + +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]); +unsigned int check_fsl_memctl_config_regs(const fsl_ddr_cfg_regs_t *ddr); + +/* processor specific function */ +void fsl_ddr_set_memctl_regs(const fsl_ddr_cfg_regs_t *regs, +				   unsigned int ctrl_num);  /* board specific function */  int fsl_ddr_get_dimm_params(dimm_params_t *pdimm, diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c new file mode 100644 index 000000000..d7d66ef49 --- /dev/null +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c @@ -0,0 +1,1691 @@ +/* + * Copyright 2010-2011 Freescale Semiconductor, Inc. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * Version 2 or any later versionas published by the Free Software Foundation. + */ + +/* + * Generic driver for Freescale DDR/DDR2/DDR3 memory controller. + * Based on code from spd_sdram.c + * Author: James Yang [at freescale.com] + *         York Sun [at freescale.com] + */ + +#include <common.h> +#include <linux/ctype.h> +#include <asm/types.h> + +#include <asm/fsl_ddr_sdram.h> +#include "ddr.h" + +/* Option parameter Structures */ +struct options_string { +	const char *option_name; +	size_t offset; +	unsigned int size; +	const char printhex; +}; + +static unsigned int picos_to_mhz(unsigned int picos) +{ +	return 1000000 / picos; +} + +static void print_option_table(const struct options_string *table, +			 int table_size, +			 const void *base) +{ +	unsigned int i; +	unsigned int *ptr; +	unsigned long long *ptr_l; + +	for (i = 0; i < table_size; i++) { +		switch (table[i].size) { +		case 4: +			ptr = (unsigned int *) (base + table[i].offset); +			if (table[i].printhex) { +				printf("%s = 0x%08X\n", +					table[i].option_name, *ptr); +			} else { +				printf("%s = %u\n", +					table[i].option_name, *ptr); +			} +			break; +		case 8: +			ptr_l = (unsigned long long *) (base + table[i].offset); +			printf("%s = %llu\n", +				table[i].option_name, *ptr_l); +			break; +		default: +			printf("Unrecognized size!\n"); +			break; +		} +	} +} + +static int handle_option_table(const struct options_string *table, +			 int table_size, +			 void *base, +			 const char *opt, +			 const char *val) +{ +	unsigned int i; +	unsigned int value, *ptr; +	unsigned long long value_l, *ptr_l; + +	for (i = 0; i < table_size; i++) { +		if (strcmp(table[i].option_name, opt) != 0) +			continue; +		switch (table[i].size) { +		case 4: +			value = simple_strtoul(val, NULL, 0); +			ptr = base + table[i].offset; +			*ptr = value; +			break; +		case 8: +			value_l = simple_strtoull(val, NULL, 0); +			ptr_l = base + table[i].offset; +			*ptr_l = value_l; +			break; +		default: +			printf("Unrecognized size!\n"); +			break; +		} +		return 1; +	} + +	return 0; +} + +static void fsl_ddr_generic_edit(void *pdata, +			   void *pend, +			   unsigned int element_size, +			   unsigned int element_num, +			   unsigned int value) +{ +	char *pcdata = (char *)pdata;		/* BIG ENDIAN ONLY */ + +	pcdata += element_num * element_size; +	if ((pcdata + element_size) > (char *) pend) { +		printf("trying to write past end of data\n"); +		return; +	} + +	switch (element_size) { +	case 1: +		__raw_writeb(value, pcdata); +		break; +	case 2: +		__raw_writew(value, pcdata); +		break; +	case 4: +		__raw_writel(value, pcdata); +		break; +	default: +		printf("unexpected element size %u\n", element_size); +		break; +	} +} + +static void fsl_ddr_spd_edit(fsl_ddr_info_t *pinfo, +		       unsigned int ctrl_num, +		       unsigned int dimm_num, +		       unsigned int element_num, +		       unsigned int value) +{ +	generic_spd_eeprom_t *pspd; + +	pspd = &(pinfo->spd_installed_dimms[ctrl_num][dimm_num]); +	fsl_ddr_generic_edit(pspd, pspd + 1, 1, element_num, value); +} + +#define COMMON_TIMING(x) {#x, offsetof(common_timing_params_t, x), \ +	sizeof((common_timing_params_t *)0)->x, 0} + +static void lowest_common_dimm_parameters_edit(fsl_ddr_info_t *pinfo, +					unsigned int ctrl_num, +					const char *optname_str, +					const char *value_str) +{ +	common_timing_params_t *p = &pinfo->common_timing_params[ctrl_num]; + +	static const struct options_string options[] = { +		COMMON_TIMING(tCKmin_X_ps), +		COMMON_TIMING(tCKmax_ps), +		COMMON_TIMING(tCKmax_max_ps), +		COMMON_TIMING(tRCD_ps), +		COMMON_TIMING(tRP_ps), +		COMMON_TIMING(tRAS_ps), +		COMMON_TIMING(tWR_ps), +		COMMON_TIMING(tWTR_ps), +		COMMON_TIMING(tRFC_ps), +		COMMON_TIMING(tRRD_ps), +		COMMON_TIMING(tRC_ps), +		COMMON_TIMING(refresh_rate_ps), +		COMMON_TIMING(tIS_ps), +		COMMON_TIMING(tIH_ps), +		COMMON_TIMING(tDS_ps), +		COMMON_TIMING(tDH_ps), +		COMMON_TIMING(tRTP_ps), +		COMMON_TIMING(tDQSQ_max_ps), +		COMMON_TIMING(tQHS_ps), +		COMMON_TIMING(ndimms_present), +		COMMON_TIMING(lowest_common_SPD_caslat), +		COMMON_TIMING(highest_common_derated_caslat), +		COMMON_TIMING(additive_latency), +		COMMON_TIMING(all_DIMMs_burst_lengths_bitmask), +		COMMON_TIMING(all_DIMMs_registered), +		COMMON_TIMING(all_DIMMs_unbuffered), +		COMMON_TIMING(all_DIMMs_ECC_capable), +		COMMON_TIMING(total_mem), +		COMMON_TIMING(base_address), +	}; +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	if (handle_option_table(options, n_opts, p, optname_str, value_str)) +		return; + +	printf("Error: couldn't find option string %s\n", optname_str); +} + +#define DIMM_PARM(x) {#x, offsetof(dimm_params_t, x), \ +	sizeof((dimm_params_t *)0)->x, 0} + +static void fsl_ddr_dimm_parameters_edit(fsl_ddr_info_t *pinfo, +				   unsigned int ctrl_num, +				   unsigned int dimm_num, +				   const char *optname_str, +				   const char *value_str) +{ +	dimm_params_t *p = &(pinfo->dimm_params[ctrl_num][dimm_num]); + +	static const struct options_string options[] = { +		DIMM_PARM(n_ranks), +		DIMM_PARM(data_width), +		DIMM_PARM(primary_sdram_width), +		DIMM_PARM(ec_sdram_width), +		DIMM_PARM(registered_dimm), + +		DIMM_PARM(n_row_addr), +		DIMM_PARM(n_col_addr), +		DIMM_PARM(edc_config), +		DIMM_PARM(n_banks_per_sdram_device), +		DIMM_PARM(burst_lengths_bitmask), +		DIMM_PARM(row_density), + +		DIMM_PARM(tCKmin_X_ps), +		DIMM_PARM(tCKmin_X_minus_1_ps), +		DIMM_PARM(tCKmin_X_minus_2_ps), +		DIMM_PARM(tCKmax_ps), + +		DIMM_PARM(caslat_X), +		DIMM_PARM(caslat_X_minus_1), +		DIMM_PARM(caslat_X_minus_2), + +		DIMM_PARM(caslat_lowest_derated), + +		DIMM_PARM(tRCD_ps), +		DIMM_PARM(tRP_ps), +		DIMM_PARM(tRAS_ps), +		DIMM_PARM(tWR_ps), +		DIMM_PARM(tWTR_ps), +		DIMM_PARM(tRFC_ps), +		DIMM_PARM(tRRD_ps), +		DIMM_PARM(tRC_ps), +		DIMM_PARM(refresh_rate_ps), + +		DIMM_PARM(tIS_ps), +		DIMM_PARM(tIH_ps), +		DIMM_PARM(tDS_ps), +		DIMM_PARM(tDH_ps), +		DIMM_PARM(tRTP_ps), +		DIMM_PARM(tDQSQ_max_ps), +		DIMM_PARM(tQHS_ps), + +		DIMM_PARM(rank_density), +		DIMM_PARM(capacity), +		DIMM_PARM(base_address), +	}; + +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	if (handle_option_table(options, n_opts, p, optname_str, value_str)) +		return; + +	printf("couldn't find option string %s\n", optname_str); +} + +static void print_dimm_parameters(const dimm_params_t *pdimm) +{ +	static const struct options_string options[] = { +		DIMM_PARM(n_ranks), +		DIMM_PARM(data_width), +		DIMM_PARM(primary_sdram_width), +		DIMM_PARM(ec_sdram_width), +		DIMM_PARM(registered_dimm), + +		DIMM_PARM(n_row_addr), +		DIMM_PARM(n_col_addr), +		DIMM_PARM(edc_config), +		DIMM_PARM(n_banks_per_sdram_device), + +		DIMM_PARM(tCKmin_X_ps), +		DIMM_PARM(tCKmin_X_minus_1_ps), +		DIMM_PARM(tCKmin_X_minus_2_ps), +		DIMM_PARM(tCKmax_ps), + +		DIMM_PARM(caslat_X), +		DIMM_PARM(tAA_ps), +		DIMM_PARM(caslat_X_minus_1), +		DIMM_PARM(caslat_X_minus_2), +		DIMM_PARM(caslat_lowest_derated), + +		DIMM_PARM(tRCD_ps), +		DIMM_PARM(tRP_ps), +		DIMM_PARM(tRAS_ps), +		DIMM_PARM(tWR_ps), +		DIMM_PARM(tWTR_ps), +		DIMM_PARM(tRFC_ps), +		DIMM_PARM(tRRD_ps), +		DIMM_PARM(tRC_ps), +		DIMM_PARM(refresh_rate_ps), + +		DIMM_PARM(tIS_ps), +		DIMM_PARM(tIH_ps), +		DIMM_PARM(tDS_ps), +		DIMM_PARM(tDH_ps), +		DIMM_PARM(tRTP_ps), +		DIMM_PARM(tDQSQ_max_ps), +		DIMM_PARM(tQHS_ps), +	}; +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	if (pdimm->n_ranks == 0) { +		printf("DIMM not present\n"); +		return; +	} +	printf("DIMM organization parameters:\n"); +	printf("module part name = %s\n", pdimm->mpart); +	printf("rank_density = %llu bytes (%llu megabytes)\n", +	       pdimm->rank_density, pdimm->rank_density / 0x100000); +	printf("capacity = %llu bytes (%llu megabytes)\n", +	       pdimm->capacity, pdimm->capacity / 0x100000); +	printf("burst_lengths_bitmask = %02X\n", +	       pdimm->burst_lengths_bitmask); +	printf("base_addresss = %llu (%08llX %08llX)\n", +	       pdimm->base_address, +	       (pdimm->base_address >> 32), +	       pdimm->base_address & 0xFFFFFFFF); +	print_option_table(options, n_opts, pdimm); +} + +static void print_lowest_common_dimm_parameters( +		const common_timing_params_t *plcd_dimm_params) +{ +	static const struct options_string options[] = { +		COMMON_TIMING(tCKmax_max_ps), +		COMMON_TIMING(tRCD_ps), +		COMMON_TIMING(tRP_ps), +		COMMON_TIMING(tRAS_ps), +		COMMON_TIMING(tWR_ps), +		COMMON_TIMING(tWTR_ps), +		COMMON_TIMING(tRFC_ps), +		COMMON_TIMING(tRRD_ps), +		COMMON_TIMING(tRC_ps), +		COMMON_TIMING(refresh_rate_ps), +		COMMON_TIMING(tIS_ps), +		COMMON_TIMING(tDS_ps), +		COMMON_TIMING(tDH_ps), +		COMMON_TIMING(tRTP_ps), +		COMMON_TIMING(tDQSQ_max_ps), +		COMMON_TIMING(tQHS_ps), +		COMMON_TIMING(lowest_common_SPD_caslat), +		COMMON_TIMING(highest_common_derated_caslat), +		COMMON_TIMING(additive_latency), +		COMMON_TIMING(ndimms_present), +		COMMON_TIMING(all_DIMMs_registered), +		COMMON_TIMING(all_DIMMs_unbuffered), +		COMMON_TIMING(all_DIMMs_ECC_capable), +	}; +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	/* Clock frequencies */ +	printf("tCKmin_X_ps = %u (%u MHz)\n", +	       plcd_dimm_params->tCKmin_X_ps, +	       picos_to_mhz(plcd_dimm_params->tCKmin_X_ps)); +	printf("tCKmax_ps = %u (%u MHz)\n", +	       plcd_dimm_params->tCKmax_ps, +	       picos_to_mhz(plcd_dimm_params->tCKmax_ps)); +	printf("all_DIMMs_burst_lengths_bitmask = %02X\n", +	       plcd_dimm_params->all_DIMMs_burst_lengths_bitmask); + +	print_option_table(options, n_opts, plcd_dimm_params); + +	printf("total_mem = %llu (%llu megabytes)\n", +	       plcd_dimm_params->total_mem, +	       plcd_dimm_params->total_mem / 0x100000); +	printf("base_address = %llu (%llu megabytes)\n", +	       plcd_dimm_params->base_address, +	       plcd_dimm_params->base_address / 0x100000); +} + +#define CTRL_OPTIONS(x) {#x, offsetof(memctl_options_t, x), \ +	sizeof((memctl_options_t *)0)->x, 0} +#define CTRL_OPTIONS_CS(x, y) {"cs" #x "_" #y, \ +	offsetof(memctl_options_t, cs_local_opts[x].y), \ +	sizeof((memctl_options_t *)0)->cs_local_opts[x].y, 0} + +static void fsl_ddr_options_edit(fsl_ddr_info_t *pinfo, +			   unsigned int ctl_num, +			   const char *optname_str, +			   const char *value_str) +{ +	memctl_options_t *p = &(pinfo->memctl_opts[ctl_num]); +	/* +	 * This array all on the stack and *computed* each time this +	 * function is rung. +	 */ +	static const struct options_string options[] = { +		CTRL_OPTIONS_CS(0, odt_rd_cfg), +		CTRL_OPTIONS_CS(0, odt_wr_cfg), +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 1) +		CTRL_OPTIONS_CS(1, odt_rd_cfg), +		CTRL_OPTIONS_CS(1, odt_wr_cfg), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CTRL_OPTIONS_CS(2, odt_rd_cfg), +		CTRL_OPTIONS_CS(2, odt_wr_cfg), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CTRL_OPTIONS_CS(3, odt_rd_cfg), +		CTRL_OPTIONS_CS(3, odt_wr_cfg), +#endif +#if defined(CONFIG_FSL_DDR3) +		CTRL_OPTIONS_CS(0, odt_rtt_norm), +		CTRL_OPTIONS_CS(0, odt_rtt_wr), +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 1) +		CTRL_OPTIONS_CS(1, odt_rtt_norm), +		CTRL_OPTIONS_CS(1, odt_rtt_wr), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CTRL_OPTIONS_CS(2, odt_rtt_norm), +		CTRL_OPTIONS_CS(2, odt_rtt_wr), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CTRL_OPTIONS_CS(3, odt_rtt_norm), +		CTRL_OPTIONS_CS(3, odt_rtt_wr), +#endif +#endif +		CTRL_OPTIONS(memctl_interleaving), +		CTRL_OPTIONS(memctl_interleaving_mode), +		CTRL_OPTIONS(ba_intlv_ctl), +		CTRL_OPTIONS(ECC_mode), +		CTRL_OPTIONS(ECC_init_using_memctl), +		CTRL_OPTIONS(DQS_config), +		CTRL_OPTIONS(self_refresh_in_sleep), +		CTRL_OPTIONS(dynamic_power), +		CTRL_OPTIONS(data_bus_width), +		CTRL_OPTIONS(burst_length), +		CTRL_OPTIONS(cas_latency_override), +		CTRL_OPTIONS(cas_latency_override_value), +		CTRL_OPTIONS(use_derated_caslat), +		CTRL_OPTIONS(additive_latency_override), +		CTRL_OPTIONS(additive_latency_override_value), +		CTRL_OPTIONS(clk_adjust), +		CTRL_OPTIONS(cpo_override), +		CTRL_OPTIONS(write_data_delay), +		CTRL_OPTIONS(half_strength_driver_enable), + +		/* +		 * These can probably be changed to 2T_EN and 3T_EN +		 * (using a leading numerical character) without problem +		 */ +		CTRL_OPTIONS(twoT_en), +		CTRL_OPTIONS(threeT_en), +		CTRL_OPTIONS(ap_en), +		CTRL_OPTIONS(bstopre), +		CTRL_OPTIONS(wrlvl_override), +		CTRL_OPTIONS(wrlvl_sample), +		CTRL_OPTIONS(wrlvl_start), +		CTRL_OPTIONS(rcw_override), +		CTRL_OPTIONS(rcw_1), +		CTRL_OPTIONS(rcw_2), +		CTRL_OPTIONS(tCKE_clock_pulse_width_ps), +		CTRL_OPTIONS(tFAW_window_four_activates_ps), +		CTRL_OPTIONS(trwt_override), +		CTRL_OPTIONS(trwt), +	}; + +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	if (handle_option_table(options, n_opts, p, +					optname_str, value_str)) +		return; + +	printf("couldn't find option string %s\n", optname_str); +} + +#define CFG_REGS(x) {#x, offsetof(fsl_ddr_cfg_regs_t, x), \ +	sizeof((fsl_ddr_cfg_regs_t *)0)->x, 1} +#define CFG_REGS_CS(x, y) {"cs" #x "_" #y, \ +	offsetof(fsl_ddr_cfg_regs_t, cs[x].y), \ +	sizeof((fsl_ddr_cfg_regs_t *)0)->cs[x].y, 1} + +static void print_fsl_memctl_config_regs(const fsl_ddr_cfg_regs_t *ddr) +{ +	unsigned int i; +	static const struct options_string options[] = { +		CFG_REGS_CS(0, bnds), +		CFG_REGS_CS(0, config), +		CFG_REGS_CS(0, config_2), +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 1) +		CFG_REGS_CS(1, bnds), +		CFG_REGS_CS(1, config), +		CFG_REGS_CS(1, config_2), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CFG_REGS_CS(2, bnds), +		CFG_REGS_CS(2, config), +		CFG_REGS_CS(2, config_2), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CFG_REGS_CS(3, bnds), +		CFG_REGS_CS(3, config), +		CFG_REGS_CS(3, config_2), +#endif +		CFG_REGS(timing_cfg_3), +		CFG_REGS(timing_cfg_0), +		CFG_REGS(timing_cfg_1), +		CFG_REGS(timing_cfg_2), +		CFG_REGS(ddr_sdram_cfg), +		CFG_REGS(ddr_sdram_cfg_2), +		CFG_REGS(ddr_sdram_mode), +		CFG_REGS(ddr_sdram_mode_2), +		CFG_REGS(ddr_sdram_mode_3), +		CFG_REGS(ddr_sdram_mode_4), +		CFG_REGS(ddr_sdram_mode_5), +		CFG_REGS(ddr_sdram_mode_6), +		CFG_REGS(ddr_sdram_mode_7), +		CFG_REGS(ddr_sdram_mode_8), +		CFG_REGS(ddr_sdram_interval), +		CFG_REGS(ddr_data_init), +		CFG_REGS(ddr_sdram_clk_cntl), +		CFG_REGS(ddr_init_addr), +		CFG_REGS(ddr_init_ext_addr), +		CFG_REGS(timing_cfg_4), +		CFG_REGS(timing_cfg_5), +		CFG_REGS(ddr_zq_cntl), +		CFG_REGS(ddr_wrlvl_cntl), +		CFG_REGS(ddr_sr_cntr), +		CFG_REGS(ddr_sdram_rcw_1), +		CFG_REGS(ddr_sdram_rcw_2), +		CFG_REGS(ddr_cdr1), +		CFG_REGS(ddr_cdr2), +		CFG_REGS(err_disable), +		CFG_REGS(err_int_en), +	}; +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	print_option_table(options, n_opts, ddr); + +	for (i = 0; i < 32; i++) +		printf("debug_%02d = 0x%08X\n", i+1, ddr->debug[i]); +} + +static void fsl_ddr_regs_edit(fsl_ddr_info_t *pinfo, +			unsigned int ctrl_num, +			const char *regname, +			const char *value_str) +{ +	unsigned int i; +	fsl_ddr_cfg_regs_t *ddr; +	char buf[20]; +	static const struct options_string options[] = { +		CFG_REGS_CS(0, bnds), +		CFG_REGS_CS(0, config), +		CFG_REGS_CS(0, config_2), +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 1) +		CFG_REGS_CS(1, bnds), +		CFG_REGS_CS(1, config), +		CFG_REGS_CS(1, config_2), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CFG_REGS_CS(2, bnds), +		CFG_REGS_CS(2, config), +		CFG_REGS_CS(2, config_2), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 3) +		CFG_REGS_CS(3, bnds), +		CFG_REGS_CS(3, config), +		CFG_REGS_CS(3, config_2), +#endif +		CFG_REGS(timing_cfg_3), +		CFG_REGS(timing_cfg_0), +		CFG_REGS(timing_cfg_1), +		CFG_REGS(timing_cfg_2), +		CFG_REGS(ddr_sdram_cfg), +		CFG_REGS(ddr_sdram_cfg_2), +		CFG_REGS(ddr_sdram_mode), +		CFG_REGS(ddr_sdram_mode_2), +		CFG_REGS(ddr_sdram_mode_3), +		CFG_REGS(ddr_sdram_mode_4), +		CFG_REGS(ddr_sdram_mode_5), +		CFG_REGS(ddr_sdram_mode_6), +		CFG_REGS(ddr_sdram_mode_7), +		CFG_REGS(ddr_sdram_mode_8), +		CFG_REGS(ddr_sdram_interval), +		CFG_REGS(ddr_data_init), +		CFG_REGS(ddr_sdram_clk_cntl), +		CFG_REGS(ddr_init_addr), +		CFG_REGS(ddr_init_ext_addr), +		CFG_REGS(timing_cfg_4), +		CFG_REGS(timing_cfg_5), +		CFG_REGS(ddr_zq_cntl), +		CFG_REGS(ddr_wrlvl_cntl), +		CFG_REGS(ddr_sr_cntr), +		CFG_REGS(ddr_sdram_rcw_1), +		CFG_REGS(ddr_sdram_rcw_2), +		CFG_REGS(ddr_cdr1), +		CFG_REGS(ddr_cdr2), +		CFG_REGS(err_disable), +		CFG_REGS(err_int_en), +		CFG_REGS(ddr_sdram_rcw_2), +		CFG_REGS(ddr_sdram_rcw_2), + +	}; +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	debug("fsl_ddr_regs_edit: ctrl_num = %u, " +		"regname = %s, value = %s\n", +		ctrl_num, regname, value_str); +	if (ctrl_num > CONFIG_NUM_DDR_CONTROLLERS) +		return; + +	ddr = &(pinfo->fsl_ddr_config_reg[ctrl_num]); + +	if (handle_option_table(options, n_opts, ddr, regname, value_str)) +		return; + +	for (i = 0; i < 32; i++) { +		unsigned int value = simple_strtoul(value_str, NULL, 0); +		sprintf(buf, "debug_%u", i + 1); +		if (strcmp(buf, regname) == 0) { +			ddr->debug[i] = value; +			return; +		} +	} +	printf("Error: couldn't find register string %s\n", regname); +} + +#define CTRL_OPTIONS_HEX(x) {#x, offsetof(memctl_options_t, x), \ +	sizeof((memctl_options_t *)0)->x, 1} + +static void print_memctl_options(const memctl_options_t *popts) +{ +	static const struct options_string options[] = { +		CTRL_OPTIONS_CS(0, odt_rd_cfg), +		CTRL_OPTIONS_CS(0, odt_wr_cfg), +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 1) +		CTRL_OPTIONS_CS(1, odt_rd_cfg), +		CTRL_OPTIONS_CS(1, odt_wr_cfg), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CTRL_OPTIONS_CS(2, odt_rd_cfg), +		CTRL_OPTIONS_CS(2, odt_wr_cfg), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 3) +		CTRL_OPTIONS_CS(3, odt_rd_cfg), +		CTRL_OPTIONS_CS(3, odt_wr_cfg), +#endif +#if defined(CONFIG_FSL_DDR3) +		CTRL_OPTIONS_CS(0, odt_rtt_norm), +		CTRL_OPTIONS_CS(0, odt_rtt_wr), +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 1) +		CTRL_OPTIONS_CS(1, odt_rtt_norm), +		CTRL_OPTIONS_CS(1, odt_rtt_wr), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 2) +		CTRL_OPTIONS_CS(2, odt_rtt_norm), +		CTRL_OPTIONS_CS(2, odt_rtt_wr), +#endif +#if (CONFIG_CHIP_SELECTS_PER_CTRL > 3) +		CTRL_OPTIONS_CS(3, odt_rtt_norm), +		CTRL_OPTIONS_CS(3, odt_rtt_wr), +#endif +#endif +		CTRL_OPTIONS(memctl_interleaving), +		CTRL_OPTIONS(memctl_interleaving_mode), +		CTRL_OPTIONS_HEX(ba_intlv_ctl), +		CTRL_OPTIONS(ECC_mode), +		CTRL_OPTIONS(ECC_init_using_memctl), +		CTRL_OPTIONS(DQS_config), +		CTRL_OPTIONS(self_refresh_in_sleep), +		CTRL_OPTIONS(dynamic_power), +		CTRL_OPTIONS(data_bus_width), +		CTRL_OPTIONS(burst_length), +		CTRL_OPTIONS(cas_latency_override), +		CTRL_OPTIONS(cas_latency_override_value), +		CTRL_OPTIONS(use_derated_caslat), +		CTRL_OPTIONS(additive_latency_override), +		CTRL_OPTIONS(additive_latency_override_value), +		CTRL_OPTIONS(clk_adjust), +		CTRL_OPTIONS(cpo_override), +		CTRL_OPTIONS(write_data_delay), +		CTRL_OPTIONS(half_strength_driver_enable), +		/* +		 * These can probably be changed to 2T_EN and 3T_EN +		 * (using a leading numerical character) without problem +		 */ +		CTRL_OPTIONS(twoT_en), +		CTRL_OPTIONS(threeT_en), +		CTRL_OPTIONS(registered_dimm_en), +		CTRL_OPTIONS(ap_en), +		CTRL_OPTIONS(bstopre), +		CTRL_OPTIONS(wrlvl_override), +		CTRL_OPTIONS(wrlvl_sample), +		CTRL_OPTIONS(wrlvl_start), +		CTRL_OPTIONS(rcw_override), +		CTRL_OPTIONS(rcw_1), +		CTRL_OPTIONS(rcw_2), +		CTRL_OPTIONS(tCKE_clock_pulse_width_ps), +		CTRL_OPTIONS(tFAW_window_four_activates_ps), +		CTRL_OPTIONS(trwt_override), +		CTRL_OPTIONS(trwt), +	}; +	static const unsigned int n_opts = ARRAY_SIZE(options); + +	print_option_table(options, n_opts, popts); +} + +#ifdef CONFIG_FSL_DDR1 +void ddr1_spd_dump(const ddr1_spd_eeprom_t *spd) +{ +	unsigned int i; + +	printf("%-3d    : %02x %s\n", 0, spd->info_size, +	       " spd->info_size,   *  0 # bytes written into serial memory *"); +	printf("%-3d    : %02x %s\n", 1, spd->chip_size, +	       " spd->chip_size,   *  1 Total # bytes of SPD memory device *"); +	printf("%-3d    : %02x %s\n", 2, spd->mem_type, +	       " spd->mem_type,    *  2 Fundamental memory type *"); +	printf("%-3d    : %02x %s\n", 3, spd->nrow_addr, +	       " spd->nrow_addr,   *  3 # of Row Addresses on this assembly *"); +	printf("%-3d    : %02x %s\n", 4, spd->ncol_addr, +	       " spd->ncol_addr,   *  4 # of Column Addrs on this assembly *"); +	printf("%-3d    : %02x %s\n", 5, spd->nrows, +	       " spd->nrows        *  5 # of DIMM Banks *"); +	printf("%-3d    : %02x %s\n", 6, spd->dataw_lsb, +	       " spd->dataw_lsb,   *  6 Data Width lsb of this assembly *"); +	printf("%-3d    : %02x %s\n", 7, spd->dataw_msb, +	       " spd->dataw_msb,   *  7 Data Width msb of this assembly *"); +	printf("%-3d    : %02x %s\n", 8, spd->voltage, +	       " spd->voltage,     *  8 Voltage intf std of this assembly *"); +	printf("%-3d    : %02x %s\n", 9, spd->clk_cycle, +	       " spd->clk_cycle,   *  9 SDRAM Cycle time at CL=X *"); +	printf("%-3d    : %02x %s\n", 10, spd->clk_access, +	       " spd->clk_access,  * 10 SDRAM Access from Clock at CL=X *"); +	printf("%-3d    : %02x %s\n", 11, spd->config, +	       " spd->config,      * 11 DIMM Configuration type *"); +	printf("%-3d    : %02x %s\n", 12, spd->refresh, +	       " spd->refresh,     * 12 Refresh Rate/Type *"); +	printf("%-3d    : %02x %s\n", 13, spd->primw, +	       " spd->primw,       * 13 Primary SDRAM Width *"); +	printf("%-3d    : %02x %s\n", 14, spd->ecw, +	       " spd->ecw,         * 14 Error Checking SDRAM width *"); +	printf("%-3d    : %02x %s\n", 15, spd->min_delay, +	       " spd->min_delay,   * 15 Back to Back Random Access *"); +	printf("%-3d    : %02x %s\n", 16, spd->burstl, +	       " spd->burstl,      * 16 Burst Lengths Supported *"); +	printf("%-3d    : %02x %s\n", 17, spd->nbanks, +	       " spd->nbanks,      * 17 # of Banks on Each SDRAM Device *"); +	printf("%-3d    : %02x %s\n", 18, spd->cas_lat, +	       " spd->cas_lat,     * 18 CAS# Latencies Supported *"); +	printf("%-3d    : %02x %s\n", 19, spd->cs_lat, +	       " spd->cs_lat,      * 19 Chip Select Latency *"); +	printf("%-3d    : %02x %s\n", 20, spd->write_lat, +	       " spd->write_lat,   * 20 Write Latency/Recovery *"); +	printf("%-3d    : %02x %s\n", 21, spd->mod_attr, +	       " spd->mod_attr,    * 21 SDRAM Module Attributes *"); +	printf("%-3d    : %02x %s\n", 22, spd->dev_attr, +	       " spd->dev_attr,    * 22 SDRAM Device Attributes *"); +	printf("%-3d    : %02x %s\n", 23, spd->clk_cycle2, +	       " spd->clk_cycle2,  * 23 Min SDRAM Cycle time at CL=X-1 *"); +	printf("%-3d    : %02x %s\n", 24, spd->clk_access2, +	       " spd->clk_access2, * 24 SDRAM Access from Clock at CL=X-1 *"); +	printf("%-3d    : %02x %s\n", 25, spd->clk_cycle3, +	       " spd->clk_cycle3,  * 25 Min SDRAM Cycle time at CL=X-2 *"); +	printf("%-3d    : %02x %s\n", 26, spd->clk_access3, +	       " spd->clk_access3, * 26 Max Access from Clock at CL=X-2 *"); +	printf("%-3d    : %02x %s\n", 27, spd->trp, +	       " spd->trp,         * 27 Min Row Precharge Time (tRP)*"); +	printf("%-3d    : %02x %s\n", 28, spd->trrd, +	       " spd->trrd,        * 28 Min Row Active to Row Active (tRRD) *"); +	printf("%-3d    : %02x %s\n", 29, spd->trcd, +	       " spd->trcd,        * 29 Min RAS to CAS Delay (tRCD) *"); +	printf("%-3d    : %02x %s\n", 30, spd->tras, +	       " spd->tras,        * 30 Minimum RAS Pulse Width (tRAS) *"); +	printf("%-3d    : %02x %s\n", 31, spd->bank_dens, +	       " spd->bank_dens,   * 31 Density of each bank on module *"); +	printf("%-3d    : %02x %s\n", 32, spd->ca_setup, +	       " spd->ca_setup,    * 32 Cmd + Addr signal input setup time *"); +	printf("%-3d    : %02x %s\n", 33, spd->ca_hold, +	       " spd->ca_hold,     * 33 Cmd and Addr signal input hold time *"); +	printf("%-3d    : %02x %s\n", 34, spd->data_setup, +	       " spd->data_setup,  * 34 Data signal input setup time *"); +	printf("%-3d    : %02x %s\n", 35, spd->data_hold, +	       " spd->data_hold,   * 35 Data signal input hold time *"); +	printf("%-3d    : %02x %s\n", 36, spd->res_36_40[0], +	       " spd->res_36_40[0], * 36 Reserved / tWR *"); +	printf("%-3d    : %02x %s\n", 37, spd->res_36_40[1], +	       " spd->res_36_40[1], * 37 Reserved / tWTR *"); +	printf("%-3d    : %02x %s\n", 38, spd->res_36_40[2], +	       " spd->res_36_40[2], * 38 Reserved / tRTP *"); +	printf("%-3d    : %02x %s\n", 39, spd->res_36_40[3], +	       " spd->res_36_40[3], * 39 Reserved / mem_probe *"); +	printf("%-3d    : %02x %s\n", 40, spd->res_36_40[4], +	       " spd->res_36_40[4], * 40 Reserved / trc,trfc extensions *"); +	printf("%-3d    : %02x %s\n", 41, spd->trc, +	       " spd->trc,         * 41 Min Active to Auto refresh time tRC *"); +	printf("%-3d    : %02x %s\n", 42, spd->trfc, +	       " spd->trfc,        * 42 Min Auto to Active period tRFC *"); +	printf("%-3d    : %02x %s\n", 43, spd->tckmax, +	       " spd->tckmax,      * 43 Max device cycle time tCKmax *"); +	printf("%-3d    : %02x %s\n", 44, spd->tdqsq, +	       " spd->tdqsq,       * 44 Max DQS to DQ skew *"); +	printf("%-3d    : %02x %s\n", 45, spd->tqhs, +	       " spd->tqhs,        * 45 Max Read DataHold skew tQHS *"); +	printf("%-3d    : %02x %s\n", 46, spd->res_46, +	       " spd->res_46,  * 46 Reserved/ PLL Relock time *"); +	printf("%-3d    : %02x %s\n", 47, spd->dimm_height, +	       " spd->dimm_height  * 47 SDRAM DIMM Height *"); + +	printf("%-3d-%3d: ",  48, 61); + +	for (i = 0; i < 14; i++) +		printf("%02x", spd->res_48_61[i]); + +	printf(" * 48-61 IDD in SPD and Reserved space *\n"); + +	printf("%-3d    : %02x %s\n", 62, spd->spd_rev, +	       " spd->spd_rev,     * 62 SPD Data Revision Code *"); +	printf("%-3d    : %02x %s\n", 63, spd->cksum, +	       " spd->cksum,       * 63 Checksum for bytes 0-62 *"); +	printf("%-3d-%3d: ",  64, 71); + +	for (i = 0; i < 8; i++) +		printf("%02x", spd->mid[i]); + +	printf("* 64 Mfr's JEDEC ID code per JEP-108E *\n"); +	printf("%-3d    : %02x %s\n", 72, spd->mloc, +	       " spd->mloc,        * 72 Manufacturing Location *"); + +	printf("%-3d-%3d: >>",  73, 90); + +	for (i = 0; i < 18; i++) +		printf("%c", spd->mpart[i]); + +	printf("<<* 73 Manufacturer's Part Number *\n"); + +	printf("%-3d-%3d: %02x %02x %s\n", 91, 92, spd->rev[0], spd->rev[1], +	       "* 91 Revision Code *"); +	printf("%-3d-%3d: %02x %02x %s\n", 93, 94, spd->mdate[0], spd->mdate[1], +	       "* 93 Manufacturing Date *"); +	printf("%-3d-%3d: ", 95, 98); + +	for (i = 0; i < 4; i++) +		printf("%02x", spd->sernum[i]); + +	printf("* 95 Assembly Serial Number *\n"); + +	printf("%-3d-%3d: ", 99, 127); + +	for (i = 0; i < 27; i++) +		printf("%02x", spd->mspec[i]); + +	printf("* 99 Manufacturer Specific Data *\n"); +} +#endif + +#ifdef CONFIG_FSL_DDR2 +void ddr2_spd_dump(const ddr2_spd_eeprom_t *spd) +{ +	unsigned int i; + +	printf("%-3d    : %02x %s\n", 0, spd->info_size, +	       " spd->info_size,   *  0 # bytes written into serial memory *"); +	printf("%-3d    : %02x %s\n", 1, spd->chip_size, +	       " spd->chip_size,   *  1 Total # bytes of SPD memory device *"); +	printf("%-3d    : %02x %s\n", 2, spd->mem_type, +	       " spd->mem_type,    *  2 Fundamental memory type *"); +	printf("%-3d    : %02x %s\n", 3, spd->nrow_addr, +	       " spd->nrow_addr,   *  3 # of Row Addresses on this assembly *"); +	printf("%-3d    : %02x %s\n", 4, spd->ncol_addr, +	       " spd->ncol_addr,   *  4 # of Column Addrs on this assembly *"); +	printf("%-3d    : %02x %s\n", 5, spd->mod_ranks, +	       " spd->mod_ranks    *  5 # of Module Rows on this assembly *"); +	printf("%-3d    : %02x %s\n", 6, spd->dataw, +	       " spd->dataw,       *  6 Data Width of this assembly *"); +	printf("%-3d    : %02x %s\n", 7, spd->res_7, +	       " spd->res_7,       *  7 Reserved *"); +	printf("%-3d    : %02x %s\n", 8, spd->voltage, +	       " spd->voltage,     *  8 Voltage intf std of this assembly *"); +	printf("%-3d    : %02x %s\n", 9, spd->clk_cycle, +	       " spd->clk_cycle,   *  9 SDRAM Cycle time at CL=X *"); +	printf("%-3d    : %02x %s\n", 10, spd->clk_access, +	       " spd->clk_access,  * 10 SDRAM Access from Clock at CL=X *"); +	printf("%-3d    : %02x %s\n", 11, spd->config, +	       " spd->config,      * 11 DIMM Configuration type *"); +	printf("%-3d    : %02x %s\n", 12, spd->refresh, +	       " spd->refresh,     * 12 Refresh Rate/Type *"); +	printf("%-3d    : %02x %s\n", 13, spd->primw, +	       " spd->primw,       * 13 Primary SDRAM Width *"); +	printf("%-3d    : %02x %s\n", 14, spd->ecw, +	       " spd->ecw,         * 14 Error Checking SDRAM width *"); +	printf("%-3d    : %02x %s\n", 15, spd->res_15, +	       " spd->res_15,      * 15 Reserved *"); +	printf("%-3d    : %02x %s\n", 16, spd->burstl, +	       " spd->burstl,      * 16 Burst Lengths Supported *"); +	printf("%-3d    : %02x %s\n", 17, spd->nbanks, +	       " spd->nbanks,      * 17 # of Banks on Each SDRAM Device *"); +	printf("%-3d    : %02x %s\n", 18, spd->cas_lat, +	       " spd->cas_lat,     * 18 CAS# Latencies Supported *"); +	printf("%-3d    : %02x %s\n", 19, spd->mech_char, +	       " spd->mech_char,   * 19 Mechanical Characteristics *"); +	printf("%-3d    : %02x %s\n", 20, spd->dimm_type, +	       " spd->dimm_type,   * 20 DIMM type *"); +	printf("%-3d    : %02x %s\n", 21, spd->mod_attr, +	       " spd->mod_attr,    * 21 SDRAM Module Attributes *"); +	printf("%-3d    : %02x %s\n", 22, spd->dev_attr, +	       " spd->dev_attr,    * 22 SDRAM Device Attributes *"); +	printf("%-3d    : %02x %s\n", 23, spd->clk_cycle2, +	       " spd->clk_cycle2,  * 23 Min SDRAM Cycle time at CL=X-1 *"); +	printf("%-3d    : %02x %s\n", 24, spd->clk_access2, +	       " spd->clk_access2, * 24 SDRAM Access from Clock at CL=X-1 *"); +	printf("%-3d    : %02x %s\n", 25, spd->clk_cycle3, +	       " spd->clk_cycle3,  * 25 Min SDRAM Cycle time at CL=X-2 *"); +	printf("%-3d    : %02x %s\n", 26, spd->clk_access3, +	       " spd->clk_access3, * 26 Max Access from Clock at CL=X-2 *"); +	printf("%-3d    : %02x %s\n", 27, spd->trp, +	       " spd->trp,         * 27 Min Row Precharge Time (tRP)*"); +	printf("%-3d    : %02x %s\n", 28, spd->trrd, +	       " spd->trrd,        * 28 Min Row Active to Row Active (tRRD) *"); +	printf("%-3d    : %02x %s\n", 29, spd->trcd, +	       " spd->trcd,        * 29 Min RAS to CAS Delay (tRCD) *"); +	printf("%-3d    : %02x %s\n", 30, spd->tras, +	       " spd->tras,        * 30 Minimum RAS Pulse Width (tRAS) *"); +	printf("%-3d    : %02x %s\n", 31, spd->rank_dens, +	       " spd->rank_dens,   * 31 Density of each rank on module *"); +	printf("%-3d    : %02x %s\n", 32, spd->ca_setup, +	       " spd->ca_setup,    * 32 Cmd + Addr signal input setup time *"); +	printf("%-3d    : %02x %s\n", 33, spd->ca_hold, +	       " spd->ca_hold,     * 33 Cmd and Addr signal input hold time *"); +	printf("%-3d    : %02x %s\n", 34, spd->data_setup, +	       " spd->data_setup,  * 34 Data signal input setup time *"); +	printf("%-3d    : %02x %s\n", 35, spd->data_hold, +	       " spd->data_hold,   * 35 Data signal input hold time *"); +	printf("%-3d    : %02x %s\n", 36, spd->twr, +	       " spd->twr,         * 36 Write Recovery time tWR *"); +	printf("%-3d    : %02x %s\n", 37, spd->twtr, +	       " spd->twtr,        * 37 Int write to read delay tWTR *"); +	printf("%-3d    : %02x %s\n", 38, spd->trtp, +	       " spd->trtp,        * 38 Int read to precharge delay tRTP *"); +	printf("%-3d    : %02x %s\n", 39, spd->mem_probe, +	       " spd->mem_probe,   * 39 Mem analysis probe characteristics *"); +	printf("%-3d    : %02x %s\n", 40, spd->trctrfc_ext, +	       " spd->trctrfc_ext, * 40 Extensions to trc and trfc *"); +	printf("%-3d    : %02x %s\n", 41, spd->trc, +	       " spd->trc,         * 41 Min Active to Auto refresh time tRC *"); +	printf("%-3d    : %02x %s\n", 42, spd->trfc, +	       " spd->trfc,        * 42 Min Auto to Active period tRFC *"); +	printf("%-3d    : %02x %s\n", 43, spd->tckmax, +	       " spd->tckmax,      * 43 Max device cycle time tCKmax *"); +	printf("%-3d    : %02x %s\n", 44, spd->tdqsq, +	       " spd->tdqsq,       * 44 Max DQS to DQ skew *"); +	printf("%-3d    : %02x %s\n", 45, spd->tqhs, +	       " spd->tqhs,        * 45 Max Read DataHold skew tQHS *"); +	printf("%-3d    : %02x %s\n", 46, spd->pll_relock, +	       " spd->pll_relock,  * 46 PLL Relock time *"); +	printf("%-3d    : %02x %s\n", 47, spd->Tcasemax, +	       " spd->Tcasemax,    * 47 Tcasemax *"); +	printf("%-3d    : %02x %s\n", 48, spd->psiTAdram, +	       " spd->psiTAdram,   * 48 Thermal Resistance of DRAM Package " +	       "from Top (Case) to Ambient (Psi T-A DRAM) *"); +	printf("%-3d    : %02x %s\n", 49, spd->dt0_mode, +	       " spd->dt0_mode,    * 49 DRAM Case Temperature Rise from " +	       "Ambient due to Activate-Precharge/Mode Bits " +	       "(DT0/Mode Bits) *)"); +	printf("%-3d    : %02x %s\n", 50, spd->dt2n_dt2q, +	       " spd->dt2n_dt2q,   * 50 DRAM Case Temperature Rise from " +	       "Ambient due to Precharge/Quiet Standby " +	       "(DT2N/DT2Q) *"); +	printf("%-3d    : %02x %s\n", 51, spd->dt2p, +	       " spd->dt2p,        * 51 DRAM Case Temperature Rise from " +	       "Ambient due to Precharge Power-Down (DT2P) *"); +	printf("%-3d    : %02x %s\n", 52, spd->dt3n, +	       " spd->dt3n,        * 52 DRAM Case Temperature Rise from " +	       "Ambient due to Active Standby (DT3N) *"); +	printf("%-3d    : %02x %s\n", 53, spd->dt3pfast, +	       " spd->dt3pfast,    * 53 DRAM Case Temperature Rise from " +	       "Ambient due to Active Power-Down with Fast PDN Exit " +	       "(DT3Pfast) *"); +	printf("%-3d    : %02x %s\n", 54, spd->dt3pslow, +	       " spd->dt3pslow,    * 54 DRAM Case Temperature Rise from " +	       "Ambient due to Active Power-Down with Slow PDN Exit " +	       "(DT3Pslow) *"); +	printf("%-3d    : %02x %s\n", 55, spd->dt4r_dt4r4w, +	       " spd->dt4r_dt4r4w, * 55 DRAM Case Temperature Rise from " +	       "Ambient due to Page Open Burst Read/DT4R4W Mode Bit " +	       "(DT4R/DT4R4W Mode Bit) *"); +	printf("%-3d    : %02x %s\n", 56, spd->dt5b, +	       " spd->dt5b,        * 56 DRAM Case Temperature Rise from " +	       "Ambient due to Burst Refresh (DT5B) *"); +	printf("%-3d    : %02x %s\n", 57, spd->dt7, +	       " spd->dt7,         * 57 DRAM Case Temperature Rise from " +	       "Ambient due to Bank Interleave Reads with " +	       "Auto-Precharge (DT7) *"); +	printf("%-3d    : %02x %s\n", 58, spd->psiTApll, +	       " spd->psiTApll,    * 58 Thermal Resistance of PLL Package form" +	       " Top (Case) to Ambient (Psi T-A PLL) *"); +	printf("%-3d    : %02x %s\n", 59, spd->psiTAreg, +	       " spd->psiTAreg,    * 59 Thermal Reisitance of Register Package" +	       " from Top (Case) to Ambient (Psi T-A Register) *"); +	printf("%-3d    : %02x %s\n", 60, spd->dtpllactive, +	       " spd->dtpllactive, * 60 PLL Case Temperature Rise from " +	       "Ambient due to PLL Active (DT PLL Active) *"); +	printf("%-3d    : %02x %s\n", 61, spd->dtregact, +	       " spd->dtregact,    " +	       "* 61 Register Case Temperature Rise from Ambient due to " +	       "Register Active/Mode Bit (DT Register Active/Mode Bit) *"); +	printf("%-3d    : %02x %s\n", 62, spd->spd_rev, +	       " spd->spd_rev,     * 62 SPD Data Revision Code *"); +	printf("%-3d    : %02x %s\n", 63, spd->cksum, +	       " spd->cksum,       * 63 Checksum for bytes 0-62 *"); + +	printf("%-3d-%3d: ",  64, 71); + +	for (i = 0; i < 8; i++) +		printf("%02x", spd->mid[i]); + +	printf("* 64 Mfr's JEDEC ID code per JEP-108E *\n"); + +	printf("%-3d    : %02x %s\n", 72, spd->mloc, +	       " spd->mloc,        * 72 Manufacturing Location *"); + +	printf("%-3d-%3d: >>",  73, 90); +	for (i = 0; i < 18; i++) +		printf("%c", spd->mpart[i]); + + +	printf("<<* 73 Manufacturer's Part Number *\n"); + +	printf("%-3d-%3d: %02x %02x %s\n", 91, 92, spd->rev[0], spd->rev[1], +	       "* 91 Revision Code *"); +	printf("%-3d-%3d: %02x %02x %s\n", 93, 94, spd->mdate[0], spd->mdate[1], +	       "* 93 Manufacturing Date *"); +	printf("%-3d-%3d: ", 95, 98); + +	for (i = 0; i < 4; i++) +		printf("%02x", spd->sernum[i]); + +	printf("* 95 Assembly Serial Number *\n"); + +	printf("%-3d-%3d: ", 99, 127); +	for (i = 0; i < 27; i++) +		printf("%02x", spd->mspec[i]); + + +	printf("* 99 Manufacturer Specific Data *\n"); +} +#endif + +#ifdef CONFIG_FSL_DDR3 +void ddr3_spd_dump(const ddr3_spd_eeprom_t *spd) +{ +	unsigned int i; + +	/* General Section: Bytes 0-59 */ + +#define PRINT_NXS(x, y, z...) printf("%-3d    : %02x " z "\n", x, y); +#define PRINT_NNXXS(n0, n1, x0, x1, s) \ +	printf("%-3d-%3d: %02x %02x " s "\n", n0, n1, x0, x1); + +	PRINT_NXS(0, spd->info_size_crc, +		"info_size_crc  bytes written into serial memory, " +		"CRC coverage"); +	PRINT_NXS(1, spd->spd_rev, +		"spd_rev        SPD Revision"); +	PRINT_NXS(2, spd->mem_type, +		"mem_type       Key Byte / DRAM Device Type"); +	PRINT_NXS(3, spd->module_type, +		"module_type    Key Byte / Module Type"); +	PRINT_NXS(4, spd->density_banks, +		"density_banks  SDRAM Density and Banks"); +	PRINT_NXS(5, spd->addressing, +		"addressing     SDRAM Addressing"); +	PRINT_NXS(6, spd->module_vdd, +		"module_vdd     Module Nominal Voltage, VDD"); +	PRINT_NXS(7, spd->organization, +		"organization   Module Organization"); +	PRINT_NXS(8, spd->bus_width, +		"bus_width      Module Memory Bus Width"); +	PRINT_NXS(9, spd->ftb_div, +		"ftb_div        Fine Timebase (FTB) Dividend / Divisor"); +	PRINT_NXS(10, spd->mtb_dividend, +		"mtb_dividend   Medium Timebase (MTB) Dividend"); +	PRINT_NXS(11, spd->mtb_divisor, +		"mtb_divisor    Medium Timebase (MTB) Divisor"); +	PRINT_NXS(12, spd->tCK_min, +		"tCK_min        SDRAM Minimum Cycle Time"); +	PRINT_NXS(13, spd->res_13, +		"res_13         Reserved"); +	PRINT_NXS(14, spd->caslat_lsb, +		"caslat_lsb     CAS Latencies Supported, LSB"); +	PRINT_NXS(15, spd->caslat_msb, +		"caslat_msb     CAS Latencies Supported, MSB"); +	PRINT_NXS(16, spd->tAA_min, +		"tAA_min        Min CAS Latency Time"); +	PRINT_NXS(17, spd->tWR_min, +		"tWR_min        Min Write REcovery Time"); +	PRINT_NXS(18, spd->tRCD_min, +		"tRCD_min       Min RAS# to CAS# Delay Time"); +	PRINT_NXS(19, spd->tRRD_min, +		"tRRD_min       Min Row Active to Row Active Delay Time"); +	PRINT_NXS(20, spd->tRP_min, +		"tRP_min        Min Row Precharge Delay Time"); +	PRINT_NXS(21, spd->tRAS_tRC_ext, +		"tRAS_tRC_ext   Upper Nibbles for tRAS and tRC"); +	PRINT_NXS(22, spd->tRAS_min_lsb, +		"tRAS_min_lsb   Min Active to Precharge Delay Time, LSB"); +	PRINT_NXS(23, spd->tRC_min_lsb, +		"tRC_min_lsb    Min Active to Active/Refresh Delay Time, LSB"); +	PRINT_NXS(24, spd->tRFC_min_lsb, +		"tRFC_min_lsb   Min Refresh Recovery Delay Time LSB"); +	PRINT_NXS(25, spd->tRFC_min_msb, +		"tRFC_min_msb   Min Refresh Recovery Delay Time MSB"); +	PRINT_NXS(26, spd->tWTR_min, +		"tWTR_min       Min Internal Write to Read Command Delay Time"); +	PRINT_NXS(27, spd->tRTP_min, +		"tRTP_min " +		"Min Internal Read to Precharge Command Delay Time"); +	PRINT_NXS(28, spd->tFAW_msb, +		"tFAW_msb       Upper Nibble for tFAW"); +	PRINT_NXS(29, spd->tFAW_min, +		"tFAW_min       Min Four Activate Window Delay Time"); +	PRINT_NXS(30, spd->opt_features, +		"opt_features   SDRAM Optional Features"); +	PRINT_NXS(31, spd->therm_ref_opt, +		"therm_ref_opt  SDRAM Thermal and Refresh Opts"); +	PRINT_NXS(32, spd->therm_sensor, +		"therm_sensor  SDRAM Thermal Sensor"); +	PRINT_NXS(33, spd->device_type, +		"device_type  SDRAM Device Type"); + +	printf("%-3d-%3d: ",  34, 59);  /* Reserved, General Section */ + +	for (i = 34; i <= 59; i++) +		printf("%02x ", spd->res_34_59[i - 34]); + +	puts("\n"); + +	switch (spd->module_type) { +	case 0x02:  /* UDIMM */ +	case 0x03:  /* SO-DIMM */ +	case 0x04:  /* Micro-DIMM */ +	case 0x06:  /* Mini-UDIMM */ +		PRINT_NXS(60, spd->mod_section.unbuffered.mod_height, +			"mod_height    (Unbuffered) Module Nominal Height"); +		PRINT_NXS(61, spd->mod_section.unbuffered.mod_thickness, +			"mod_thickness (Unbuffered) Module Maximum Thickness"); +		PRINT_NXS(62, spd->mod_section.unbuffered.ref_raw_card, +			"ref_raw_card  (Unbuffered) Reference Raw Card Used"); +		PRINT_NXS(63, spd->mod_section.unbuffered.addr_mapping, +			"addr_mapping  (Unbuffered) Address mapping from " +			"Edge Connector to DRAM"); +		break; +	case 0x01:  /* RDIMM */ +	case 0x05:  /* Mini-RDIMM */ +		PRINT_NXS(60, spd->mod_section.registered.mod_height, +			"mod_height    (Registered) Module Nominal Height"); +		PRINT_NXS(61, spd->mod_section.registered.mod_thickness, +			"mod_thickness (Registered) Module Maximum Thickness"); +		PRINT_NXS(62, spd->mod_section.registered.ref_raw_card, +			"ref_raw_card  (Registered) Reference Raw Card Used"); +		PRINT_NXS(63, spd->mod_section.registered.modu_attr, +			"modu_attr     (Registered) DIMM Module Attributes"); +		PRINT_NXS(64, spd->mod_section.registered.thermal, +			"thermal       (Registered) Thermal Heat " +			"Spreader Solution"); +		PRINT_NXS(65, spd->mod_section.registered.reg_id_lo, +			"reg_id_lo     (Registered) Register Manufacturer ID " +			"Code, LSB"); +		PRINT_NXS(66, spd->mod_section.registered.reg_id_hi, +			"reg_id_hi     (Registered) Register Manufacturer ID " +			"Code, MSB"); +		PRINT_NXS(67, spd->mod_section.registered.reg_rev, +			"reg_rev       (Registered) Register " +			"Revision Number"); +		PRINT_NXS(68, spd->mod_section.registered.reg_type, +			"reg_type      (Registered) Register Type"); +		for (i = 69; i <= 76; i++) { +			printf("%-3d    : %02x rcw[%d]\n", i, +				spd->mod_section.registered.rcw[i-69], i-69); +		} +		break; +	default: +		/* Module-specific Section, Unsupported Module Type */ +		printf("%-3d-%3d: ", 60, 116); + +		for (i = 60; i <= 116; i++) +			printf("%02x", spd->mod_section.uc[i - 60]); + +		break; +	} + +	/* Unique Module ID: Bytes 117-125 */ +	PRINT_NXS(117, spd->mmid_lsb, "Module MfgID Code LSB - JEP-106"); +	PRINT_NXS(118, spd->mmid_msb, "Module MfgID Code MSB - JEP-106"); +	PRINT_NXS(119, spd->mloc,     "Mfg Location"); +	PRINT_NNXXS(120, 121, spd->mdate[0], spd->mdate[1], "Mfg Date"); + +	printf("%-3d-%3d: ", 122, 125); + +	for (i = 122; i <= 125; i++) +		printf("%02x ", spd->sernum[i - 122]); +	printf("   Module Serial Number\n"); + +	/* CRC: Bytes 126-127 */ +	PRINT_NNXXS(126, 127, spd->crc[0], spd->crc[1], "  SPD CRC"); + +	/* Other Manufacturer Fields and User Space: Bytes 128-255 */ +	printf("%-3d-%3d: ", 128, 145); +	for (i = 128; i <= 145; i++) +		printf("%02x ", spd->mpart[i - 128]); +	printf("   Mfg's Module Part Number\n"); + +	PRINT_NNXXS(146, 147, spd->mrev[0], spd->mrev[1], +		"Module Revision code"); + +	PRINT_NXS(148, spd->dmid_lsb, "DRAM MfgID Code LSB - JEP-106"); +	PRINT_NXS(149, spd->dmid_msb, "DRAM MfgID Code MSB - JEP-106"); + +	printf("%-3d-%3d: ", 150, 175); +	for (i = 150; i <= 175; i++) +		printf("%02x ", spd->msd[i - 150]); +	printf("   Mfg's Specific Data\n"); + +	printf("%-3d-%3d: ", 176, 255); +	for (i = 176; i <= 255; i++) +		printf("%02x", spd->cust[i - 176]); +	printf("   Mfg's Specific Data\n"); + +} +#endif + +static inline void generic_spd_dump(const generic_spd_eeprom_t *spd) +{ +#if defined(CONFIG_FSL_DDR1) +	ddr1_spd_dump(spd); +#elif defined(CONFIG_FSL_DDR2) +	ddr2_spd_dump(spd); +#elif defined(CONFIG_FSL_DDR3) +	ddr3_spd_dump(spd); +#endif +} + +static void fsl_ddr_printinfo(const fsl_ddr_info_t *pinfo, +			unsigned int ctrl_mask, +			unsigned int dimm_mask, +			unsigned int do_mask) +{ +	unsigned int i, j, retval; + +	/* STEP 1:  DIMM SPD data */ +	if (do_mask & STEP_GET_SPD) { +		for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++) { +			if (!(ctrl_mask & (1 << i))) +				continue; + +			for (j = 0; j < CONFIG_DIMM_SLOTS_PER_CTLR; j++) { +				if (!(dimm_mask & (1 << j))) +					continue; + +				printf("SPD info:  Controller=%u " +						"DIMM=%u\n", i, j); +				generic_spd_dump( +					&(pinfo->spd_installed_dimms[i][j])); +				printf("\n"); +			} +			printf("\n"); +		} +		printf("\n"); +	} + +	/* STEP 2:  DIMM Parameters */ +	if (do_mask & STEP_COMPUTE_DIMM_PARMS) { +		for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++) { +			if (!(ctrl_mask & (1 << i))) +				continue; +			for (j = 0; j < CONFIG_DIMM_SLOTS_PER_CTLR; j++) { +				if (!(dimm_mask & (1 << j))) +					continue; +				printf("DIMM parameters:  Controller=%u " +						"DIMM=%u\n", i, j); +				print_dimm_parameters( +					&(pinfo->dimm_params[i][j])); +				printf("\n"); +			} +			printf("\n"); +		} +		printf("\n"); +	} + +	/* STEP 3:  Common Parameters */ +	if (do_mask & STEP_COMPUTE_COMMON_PARMS) { +		for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++) { +			if (!(ctrl_mask & (1 << i))) +				continue; +			printf("\"lowest common\" DIMM parameters:  " +					"Controller=%u\n", i); +			print_lowest_common_dimm_parameters( +				&pinfo->common_timing_params[i]); +			printf("\n"); +		} +		printf("\n"); +	} + +	/* STEP 4:  User Configuration Options */ +	if (do_mask & STEP_GATHER_OPTS) { +		for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++) { +			if (!(ctrl_mask & (1 << i))) +				continue; +			printf("User Config Options: Controller=%u\n", i); +			print_memctl_options(&pinfo->memctl_opts[i]); +			printf("\n"); +		} +		printf("\n"); +	} + +	/* STEP 5:  Address assignment */ +	if (do_mask & STEP_ASSIGN_ADDRESSES) { +		for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++) { +			if (!(ctrl_mask & (1 << i))) +				continue; +			for (j = 0; j < CONFIG_DIMM_SLOTS_PER_CTLR; j++) { +				printf("Address Assignment: Controller=%u " +						"DIMM=%u\n", i, j); +				printf("Don't have this functionality yet\n"); +			} +			printf("\n"); +		} +		printf("\n"); +	} + +	/* STEP 6:  computed controller register values */ +	if (do_mask & STEP_COMPUTE_REGS) { +		for (i = 0; i < CONFIG_NUM_DDR_CONTROLLERS; i++) { +			if (!(ctrl_mask & (1 << i))) +				continue; +			printf("Computed Register Values: Controller=%u\n", i); +			print_fsl_memctl_config_regs( +				&pinfo->fsl_ddr_config_reg[i]); +			retval = check_fsl_memctl_config_regs( +				&pinfo->fsl_ddr_config_reg[i]); +			if (retval) { +				printf("check_fsl_memctl_config_regs " +					"result = %u\n", retval); +			} +			printf("\n"); +		} +		printf("\n"); +	} +} + +struct data_strings { +	const char *data_name; +	unsigned int step_mask; +	unsigned int dimm_number_required; +}; + +#define DATA_OPTIONS(name, step, dimm) {#name, step, dimm} + +unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo) +{ +	unsigned long long ddrsize; +	const char *prompt = "FSL DDR>"; +	unsigned int len; +	char buffer[CONFIG_SYS_CBSIZE]; +	char *argv[CONFIG_SYS_MAXARGS + 1];	/* NULL terminated */ +	int argc; +	unsigned int next_step = STEP_GET_SPD; +	static const struct data_strings options[] = { +		DATA_OPTIONS(spd, STEP_GET_SPD, 1), +		DATA_OPTIONS(dimmparms, STEP_COMPUTE_DIMM_PARMS, 1), +		DATA_OPTIONS(commonparms, STEP_COMPUTE_COMMON_PARMS, 0), +		DATA_OPTIONS(opts, STEP_GATHER_OPTS, 0), +		DATA_OPTIONS(addresses, STEP_ASSIGN_ADDRESSES, 0), +		DATA_OPTIONS(regs, STEP_COMPUTE_REGS, 0), +	}; +	static const unsigned int n_opts = ARRAY_SIZE(options); +	const char *usage = { +		"commands:\n" +		"print      print SPD and intermediate computed data\n" +		"reset      reboot machine\n" +		"recompute  reload SPD and options to default and recompute regs\n" +		"edit       modify spd, parameter, or option\n" +		"compute    recompute registers from current next_step to end\n" +		"next_step  shows current next_step\n" +		"help       this message\n" +		"go         program the memory controller and continue with u-boot\n" +	}; + +	/* +	 * The strategy for next_step is that it points to the next +	 * step in the computation process that needs to be done. +	 */ +	while (1) { +		/* +		 * No need to worry for buffer overflow here in +		 * this function;  readline() maxes out at CFG_CBSIZE +		 */ +		len = readline_into_buffer(prompt,  buffer); +		argc = parse_line(buffer, argv); +		if (argc == 0) +			continue; + + +		if (strcmp(argv[0], "help") == 0) { +			puts(usage); +			continue; +		} + +		if (strcmp(argv[0], "next_step") == 0) { +			printf("next_step = 0x%02X (%s)\n", +			       next_step, +			       step_to_string(next_step)); +			continue; +		} + +		if (strcmp(argv[0], "edit") == 0) { +			unsigned int i, j; +			unsigned int error = 0; +			unsigned int step_mask = 0; +			unsigned int ctlr_mask = 0; +			unsigned int dimm_mask = 0; +			char *p_element = NULL; +			char *p_value = NULL; +			unsigned int dimm_number_required = 0; +			unsigned int ctrl_num; +			unsigned int dimm_num; +			unsigned int matched = 0; + +			if (argc == 1) { +				/* Only the element and value must be last */ +				printf("edit <c#> <d#> " +					"<spd|dimmparms|commonparms|opts|" +					"addresses|regs> <element> <value>\n"); +				printf("for spd, specify byte number for " +					"element\n"); +				continue; +			} + +			for (i = 1; i < argc - 2; i++) { +				for (j = 0; j < n_opts; j++) { +					if (strcmp(options[j].data_name, +						argv[i]) != 0) +						continue; +					step_mask |= options[j].step_mask; +					dimm_number_required = +						options[j].dimm_number_required; +					matched = 1; +					break; +				} + +				if (matched) +					continue; + +				if (argv[i][0] == 'c') { +					char c = argv[i][1]; +					if (isdigit(c)) +						ctlr_mask |= 1 << (c - '0'); +					continue; +				} + +				if (argv[i][0] == 'd') { +					char c = argv[i][1]; +					if (isdigit(c)) +						dimm_mask |= 1 << (c - '0'); +					continue; +				} + +				printf("unknown arg %s\n", argv[i]); +				step_mask = 0; +				error = 1; +				break; +			} + + +			if (error) +				continue; + + +			/* Check arguments */ + +			/* ERROR: If no steps were found */ +			if (step_mask == 0) { +				printf("Error: No valid steps were specified " +						"in argument.\n"); +				continue; +			} + +			/* ERROR: If multiple steps were found */ +			if (step_mask & (step_mask - 1)) { +				printf("Error: Multiple steps specified in " +						"argument.\n"); +				continue; +			} + +			/* ERROR: Controller not specified */ +			if (ctlr_mask == 0) { +				printf("Error: controller number not " +					"specified or no element and " +					"value specified\n"); +				continue; +			} + +			if (ctlr_mask & (ctlr_mask - 1)) { +				printf("Error: multiple controllers " +						"specified, %X\n", ctlr_mask); +				continue; +			} + +			/* ERROR: DIMM number not specified */ +			if (dimm_number_required && dimm_mask == 0) { +				printf("Error: DIMM number number not " +					"specified or no element and " +					"value specified\n"); +				continue; +			} + +			if (dimm_mask & (dimm_mask - 1)) { +				printf("Error: multipled DIMMs specified\n"); +				continue; +			} + +			p_element = argv[argc - 2]; +			p_value = argv[argc - 1]; + +			ctrl_num = __ilog2(ctlr_mask); +			dimm_num = __ilog2(dimm_mask); + +			switch (step_mask) { +			case STEP_GET_SPD: +				{ +					unsigned int element_num; +					unsigned int value; + +					element_num = simple_strtoul(p_element, +								     NULL, 0); +					value = simple_strtoul(p_value, +							       NULL, 0); +					fsl_ddr_spd_edit(pinfo, +							       ctrl_num, +							       dimm_num, +							       element_num, +							       value); +					next_step = STEP_COMPUTE_DIMM_PARMS; +				} +				break; + +			case STEP_COMPUTE_DIMM_PARMS: +				fsl_ddr_dimm_parameters_edit( +						 pinfo, ctrl_num, dimm_num, +						 p_element, p_value); +				next_step = STEP_COMPUTE_COMMON_PARMS; +				break; + +			case STEP_COMPUTE_COMMON_PARMS: +				lowest_common_dimm_parameters_edit(pinfo, +						ctrl_num, p_element, p_value); +				next_step = STEP_GATHER_OPTS; +				break; + +			case STEP_GATHER_OPTS: +				fsl_ddr_options_edit(pinfo, ctrl_num, +							   p_element, p_value); +				next_step = STEP_ASSIGN_ADDRESSES; +				break; + +			case STEP_ASSIGN_ADDRESSES: +				printf("editing of address assignment " +						"not yet implemented\n"); +				break; + +			case STEP_COMPUTE_REGS: +				{ +					fsl_ddr_regs_edit(pinfo, +								ctrl_num, +								p_element, +								p_value); +					next_step = STEP_PROGRAM_REGS; +				} +				break; + +			default: +				printf("programming error\n"); +				while (1) +					; +				break; +			} +			continue; +		} + +		if (strcmp(argv[0], "reset") == 0) { +			/* +			 * Reboot machine. +			 * Args don't seem to matter because this +			 * doesn't return +			 */ +			do_reset(NULL, 0, 0, NULL); +		} + +		if (strcmp(argv[0], "recompute") == 0) { +			/* +			 * Recalculate everything, starting with +			 * loading SPD EEPROM from DIMMs +			 */ +			next_step = STEP_GET_SPD; +			ddrsize = fsl_ddr_compute(pinfo, next_step, 0); +			continue; +		} + +		if (strcmp(argv[0], "compute") == 0) { +			/* +			 * Compute rest of steps starting at +			 * the current next_step/ +			 */ +			ddrsize = fsl_ddr_compute(pinfo, next_step, 0); +			continue; +		} + +		if (strcmp(argv[0], "print") == 0) { +			unsigned int i, j; +			unsigned int error = 0; +			unsigned int step_mask = 0; +			unsigned int ctlr_mask = 0; +			unsigned int dimm_mask = 0; +			unsigned int matched = 0; + +			if (argc == 1) { +				printf("print [c<n>] [d<n>] [spd] [dimmparms] " +				  "[commonparms] [opts] [addresses] [regs]\n"); +				continue; +			} + +			for (i = 1; i < argc; i++) { +				for (j = 0; j < n_opts; j++) { +					if (strcmp(options[j].data_name, +						argv[i]) != 0) +						continue; +					step_mask |= options[j].step_mask; +					matched = 1; +					break; +				} + +				if (matched) +					continue; + +				if (argv[i][0] == 'c') { +					char c = argv[i][1]; +					if (isdigit(c)) +						ctlr_mask |= 1 << (c - '0'); +					continue; +				} + +				if (argv[i][0] == 'd') { +					char c = argv[i][1]; +					if (isdigit(c)) +						dimm_mask |= 1 << (c - '0'); +					continue; +				} + +				printf("unknown arg %s\n", argv[i]); +				step_mask = 0; +				error = 1; +				break; +			} + +			if (error) +				continue; + +			/* If no particular controller was found, print all */ +			if (ctlr_mask == 0) +				ctlr_mask = 0xFF; + +			/* If no particular dimm was found, print all dimms. */ +			if (dimm_mask == 0) +				dimm_mask = 0xFF; + +			/* If no steps were found, print all steps. */ +			if (step_mask == 0) +				step_mask = STEP_ALL; + +			fsl_ddr_printinfo(pinfo, ctlr_mask, +						dimm_mask, step_mask); +			continue; +		} + +		if (strcmp(argv[0], "go") == 0) { +			if (next_step) +				ddrsize = fsl_ddr_compute(pinfo, next_step, 0); +			break; +		} + +		printf("unknown command %s\n", argv[0]); +	} + +	debug("end of memory = %llu\n", (u64)ddrsize); + +	return ddrsize; +} diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/main.c b/arch/powerpc/cpu/mpc8xxx/ddr/main.c index 5699b0c2c..f52ad9f69 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/main.c +++ b/arch/powerpc/cpu/mpc8xxx/ddr/main.c @@ -135,7 +135,6 @@ void fsl_ddr_get_spd(generic_spd_eeprom_t *ctrl_dimms_spd,   *				|  interleaving   */ -#ifdef DEBUG  const char *step_string_tbl[] = {  	"STEP_GET_SPD",  	"STEP_COMPUTE_DIMM_PARMS", @@ -156,7 +155,6 @@ const char * step_to_string(unsigned int step) {  	return step_string_tbl[s];  } -#endif  int step_assign_addresses(fsl_ddr_info_t *pinfo,  			  unsigned int dbw_cap_adj[], @@ -499,7 +497,12 @@ phys_size_t fsl_ddr_sdram(void)  	memset(&info, 0, sizeof(fsl_ddr_info_t));  	/* Compute it once normally. */ -	total_memory = fsl_ddr_compute(&info, STEP_GET_SPD, 0); +#ifdef CONFIG_FSL_DDR_INTERACTIVE +	if (getenv("ddr_interactive")) +		total_memory = fsl_ddr_interactive(&info); +	else +#endif +		total_memory = fsl_ddr_compute(&info, STEP_GET_SPD, 0);  	/* Check for memory controller interleaving. */  	memctl_interleaved = 0; diff --git a/doc/README.fsl-ddr b/doc/README.fsl-ddr index abfb7f192..1d50153d5 100644 --- a/doc/README.fsl-ddr +++ b/doc/README.fsl-ddr @@ -222,3 +222,153 @@ Single slot system  Reference http://www.samsung.com/global/business/semiconductor/products/dram/downloads/applicationnote/ddr2_odt_control_200603.pdf + +Interactive DDR debugging +=========================== + +For DDR parameter tuning up and debugging, the interactive DDR debugging can +be activated by saving an environment variable "ddr_interactive". The value +doesn't matter. Once activated, U-boot prompts "FSL DDR>" before enabling DDR +controller. The available commands can be seen by typing "help". + +The example flow of using interactive debugging is +type command "compute" to calculate the parameters from the default +type command "print" with arguments to show SPD, options, registers +type command "edit" with arguments to change any if desired +type command "go" to continue calculation and enable DDR controller +type command "reset" to reset the board +type command "recompute" to reload SPD and start over + +Note, check "next_step" to show the flow. For example, after edit opts, the +next_step is STEP_ASSIGN_ADDRESSES. After editing registers, the next_step is +STEP_PROGRAM_REGS. Upon issuing command "go", DDR controller will be enabled +with current setting without further calculation. + +The detail syntax for each commands are + +print [c<n>] [d<n>] [spd] [dimmparms] [commonparms] [opts] [addresses] [regs] +	c<n>		- the controller number, eg. c0, c1 +	d<n>		- the DIMM number, eg. d0, d1 +	spd		- print SPD data +	dimmparms	- DIMM paramaters, calcualted from SPD +	commonparms	- lowest common parameters for all DIMMs +	opts		- options +	addresses	- address assignment (not implemented yet) +	regs		- controller registers + +edit <c#> <d#> <spd|dimmparms|commonparms|opts|addresses|regs> <element> <value> +	c<n>		- the controller number, eg. c0, c1 +	d<n>		- the DIMM number, eg. d0, d1 +	spd		- print SPD data +	dimmparms	- DIMM paramaters, calcualted from SPD +	commonparms	- lowest common parameters for all DIMMs +	opts		- options +	addresses	- address assignment (not implemented yet) +	regs		- controller registers +	<element>	- name of the modified element +			  byte number if the object is SPD +	<value>		- decimal or heximal (prefixed with 0x) numbers + +reset +	no arguement	- reset the board + +recompute +	no argument	- reload SPD and start over + +compute +	no argument	- recompute from current next_step + +next_step +	no argument	- show current next_step + +help +	no argument	- print a list of all commands + +go +	no argument	- program memory controller(s) and continue with U-boot + +Examples of debugging flow + +	FSL DDR>compute +	Detected UDIMM UG51U6400N8SU-ACF +	SL DDR>print +	print [c<n>] [d<n>] [spd] [dimmparms] [commonparms] [opts] [addresses] [regs] +	FSL DDR>print dimmparms +	DIMM parameters:  Controller=0 DIMM=0 +	DIMM organization parameters: +	module part name = UG51U6400N8SU-ACF +	rank_density = 2147483648 bytes (2048 megabytes) +	capacity = 4294967296 bytes (4096 megabytes) +	burst_lengths_bitmask = 0C +	base_addresss = 0 (00000000 00000000) +	n_ranks = 2 +	data_width = 64 +	primary_sdram_width = 64 +	ec_sdram_width = 0 +	registered_dimm = 0 +	n_row_addr = 15 +	n_col_addr = 10 +	edc_config = 0 +	n_banks_per_sdram_device = 8 +	tCKmin_X_ps = 1500 +	tCKmin_X_minus_1_ps = 0 +	tCKmin_X_minus_2_ps = 0 +	tCKmax_ps = 0 +	caslat_X = 960 +	tAA_ps = 13125 +	caslat_X_minus_1 = 0 +	caslat_X_minus_2 = 0 +	caslat_lowest_derated = 0 +	tRCD_ps = 13125 +	tRP_ps = 13125 +	tRAS_ps = 36000 +	tWR_ps = 15000 +	tWTR_ps = 7500 +	tRFC_ps = 160000 +	tRRD_ps = 6000 +	tRC_ps = 49125 +	refresh_rate_ps = 7800000 +	tIS_ps = 0 +	tIH_ps = 0 +	tDS_ps = 0 +	tDH_ps = 0 +	tRTP_ps = 7500 +	tDQSQ_max_ps = 0 +	tQHS_ps = 0 +	FSL DDR>edit c0 opts ECC_mode 0 +	FSL DDR>edit c0 regs cs0_bnds 0x000000FF +	FSL DDR>go +	2 GiB left unmapped +	4 GiB (DDR3, 64-bit, CL=9, ECC off) +	       DDR Chip-Select Interleaving Mode: CS0+CS1 +	Testing 0x00000000 - 0x7fffffff +	Testing 0x80000000 - 0xffffffff +	Remap DDR 2 GiB left unmapped + +	POST memory PASSED +	Flash: 128 MiB +	L2:    128 KB enabled +	Corenet Platform Cache: 1024 KB enabled +	SERDES: timeout resetting bank 3 +	SRIO1: disabled +	SRIO2: disabled +	MMC:  FSL_ESDHC: 0 +	EEPROM: Invalid ID (ff ff ff ff) +	PCIe1: disabled +	PCIe2: Root Complex, x1, regs @ 0xfe201000 +	  01:00.0     - 8086:10d3 - Network controller +	PCIe2: Bus 00 - 01 +	PCIe3: disabled +	In:    serial +	Out:   serial +	Err:   serial +	Net:   Initializing Fman +	Fman1: Uploading microcode version 101.8.0 +	e1000: 00:1b:21:81:d2:e0 +	FM1@DTSEC1, FM1@DTSEC2, FM1@DTSEC3, FM1@DTSEC4, FM1@DTSEC5, e1000#0 [PRIME] +	Warning: e1000#0 MAC addresses don't match: +	Address in SROM is         00:1b:21:81:d2:e0 +	Address in environment is  00:e0:0c:00:ea:05 + +	Hit any key to stop autoboot:  0 +	=> diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h index b9b89cfa5..f1ef1df18 100644 --- a/include/configs/p1_p2_rdb_pc.h +++ b/include/configs/p1_p2_rdb_pc.h @@ -232,7 +232,7 @@  #define CONFIG_DDR_SPD  #define CONFIG_SYS_SPD_BUS_NUM 1  #define SPD_EEPROM_ADDRESS 0x52 -#define CONFIG_FSL_DDR_INTERACTIVE +#undef CONFIG_FSL_DDR_INTERACTIVE  #ifdef CONFIG_P1020MBG  #define CONFIG_SYS_SDRAM_SIZE_LAW	LAW_SIZE_2G |