diff options
| author | Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> | 2008-04-24 07:57:16 +0200 | 
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2008-04-25 00:08:32 +0200 | 
| commit | 4acbc6c7f993cae409c424615415a3e76820f13d (patch) | |
| tree | 013de65b24718348bb85bd7792041cab4eb0bb24 /drivers/net/ne2000.c | |
| parent | b4aff1ffaf7120032c653357c007faa14f74d29d (diff) | |
| download | olio-uboot-2014.01-4acbc6c7f993cae409c424615415a3e76820f13d.tar.xz olio-uboot-2014.01-4acbc6c7f993cae409c424615415a3e76820f13d.zip | |
NE2000: coding style cleanup
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Diffstat (limited to 'drivers/net/ne2000.c')
| -rw-r--r-- | drivers/net/ne2000.c | 276 | 
1 files changed, 151 insertions, 125 deletions
| diff --git a/drivers/net/ne2000.c b/drivers/net/ne2000.c index 99baeea3e..d09da7829 100644 --- a/drivers/net/ne2000.c +++ b/drivers/net/ne2000.c @@ -1,5 +1,5 @@  /* -Ported to U-Boot  by Christian Pellegrin <chri@ascensit.com> +Ported to U-Boot by Christian Pellegrin <chri@ascensit.com>  Based on sources from the Linux kernel (pcnet_cs.c, 8390.h) and  eCOS(if_dp83902a.c, if_dp83902a.h). Both of these 2 wonderful world @@ -57,13 +57,13 @@ and are covered by the appropriate copyright disclaimers included herein.  ==========================================================================  #####DESCRIPTIONBEGIN#### -Author(s):    gthomas -Contributors: gthomas, jskov, rsandifo -Date:	      2001-06-13 +Author(s):	gthomas +Contributors:	gthomas, jskov, rsandifo +Date:		2001-06-13  Purpose:  Description: -FIXME:	      Will fail if pinged with large packets (1520 bytes) +FIXME:		Will fail if pinged with large packets (1520 bytes)  Add promisc config  Add SNMP @@ -77,24 +77,26 @@ Add SNMP  #include <net.h>  #include <malloc.h> -#define mdelay(n)       udelay((n)*1000) +#define mdelay(n)	udelay((n)*1000)  /* forward definition of function used for the uboot interface */  void uboot_push_packet_len(int len);  void uboot_push_tx_done(int key, int val);  /* -  ------------------------------------------------------------------------ -  Debugging details - -  Set to perms of: -  0 disables all debug output -  1 for process debug output -  2 for added data IO output: get_reg, put_reg -  4 for packet allocation/free output -  8 for only startup status, so we can tell we're installed OK -*/ -/*#define DEBUG 0xf*/ + * Debugging details + * + * Set to perms of: + * 0 disables all debug output + * 1 for process debug output + * 2 for added data IO output: get_reg, put_reg + * 4 for packet allocation/free output + * 8 for only startup status, so we can tell we're installed OK + */ +#if 0 +#define DEBUG 0xf +#else  #define DEBUG 0 +#endif  #if DEBUG & 1  #define DEBUG_FUNCTION() do { printf("%s\n", __FUNCTION__); } while (0) @@ -128,27 +130,28 @@ dp83902a_init(void)  	DEBUG_FUNCTION();  	base = dp->base; -	if (!base) return false;  /* No device found */ +	if (!base) +		return false;	/* No device found */  	DEBUG_LINE();  #if defined(NE2000_BASIC_INIT)  	/* AX88796L doesn't need */  	/* Prepare ESA */ -	DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_PAGE1);  /* Select page 1 */ +	DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_PAGE1);	/* Select page 1 */  	/* Use the address from the serial EEPROM */  	for (i = 0; i < 6; i++)  		DP_IN(base, DP_P1_PAR0+i, dp->esa[i]); -	DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_PAGE0);  /* Select page 0 */ +	DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_PAGE0);	/* Select page 0 */  	printf("NE2000 - %s ESA: %02x:%02x:%02x:%02x:%02x:%02x\n", -	       "eeprom", -	       dp->esa[0], -	       dp->esa[1], -	       dp->esa[2], -	       dp->esa[3], -	       dp->esa[4], -	       dp->esa[5] ); +		"eeprom", +		dp->esa[0], +		dp->esa[1], +		dp->esa[2], +		dp->esa[3], +		dp->esa[4], +		dp->esa[5] );  #endif	/* NE2000_BASIC_INIT */  	return true; @@ -162,7 +165,7 @@ dp83902a_stop(void)  	DEBUG_FUNCTION(); -	DP_OUT(base, DP_CR, DP_CR_PAGE0 | DP_CR_NODMA | DP_CR_STOP);  /* Brutal */ +	DP_OUT(base, DP_CR, DP_CR_PAGE0 | DP_CR_NODMA | DP_CR_STOP);	/* Brutal */  	DP_OUT(base, DP_ISR, 0xFF);		/* Clear any pending interrupts */  	DP_OUT(base, DP_IMR, 0x00);		/* Disable all interrupts */ @@ -170,11 +173,11 @@ dp83902a_stop(void)  }  /* -  This function is called to "start up" the interface.  It may be called -  multiple times, even when the hardware is already running.  It will be -  called whenever something "hardware oriented" changes and should leave -  the hardware ready to send/receive packets. -*/ + * This function is called to "start up" the interface. It may be called + * multiple times, even when the hardware is already running. It will be + * called whenever something "hardware oriented" changes and should leave + * the hardware ready to send/receive packets. + */  static void  dp83902a_start(u8 * enaddr)  { @@ -196,16 +199,16 @@ dp83902a_start(u8 * enaddr)  	dp->tx_started = false;  	dp->running = true;  	DP_OUT(base, DP_PSTART, dp->rx_buf_start); /* Receive ring start page */ -	DP_OUT(base, DP_BNDRY, dp->rx_buf_end-1); /* Receive ring boundary */ +	DP_OUT(base, DP_BNDRY, dp->rx_buf_end - 1); /* Receive ring boundary */  	DP_OUT(base, DP_PSTOP, dp->rx_buf_end);	/* Receive ring end page */ -	dp->rx_next = dp->rx_buf_start-1; +	dp->rx_next = dp->rx_buf_start - 1;  	dp->running = true;  	DP_OUT(base, DP_ISR, 0xFF);		/* Clear any pending interrupts */  	DP_OUT(base, DP_IMR, DP_IMR_All);	/* Enable all interrupts */ -	DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_PAGE1 | DP_CR_STOP);  /* Select page 1 */ -	DP_OUT(base, DP_P1_CURP, dp->rx_buf_start);   /* Current page - next free page for Rx */ +	DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_PAGE1 | DP_CR_STOP);	/* Select page 1 */ +	DP_OUT(base, DP_P1_CURP, dp->rx_buf_start);	/* Current page - next free page for Rx */  	dp->running = true; -	for (i = 0;  i < ETHER_ADDR_LEN;  i++) { +	for (i = 0; i < ETHER_ADDR_LEN; i++) {  		/* FIXME */  		/*((vu_short*)( base + ((DP_P1_PAR0 + i) * 2) +  		 * 0x1400)) = enaddr[i];*/ @@ -214,15 +217,15 @@ dp83902a_start(u8 * enaddr)  	/* Enable and start device */  	DP_OUT(base, DP_CR, DP_CR_PAGE0 | DP_CR_NODMA | DP_CR_START);  	DP_OUT(base, DP_TCR, DP_TCR_NORMAL); /* Normal transmit operations */ -	DP_OUT(base, DP_RCR, DP_RCR_AB);  /* Accept broadcast, no errors, no multicast */ +	DP_OUT(base, DP_RCR, DP_RCR_AB); /* Accept broadcast, no errors, no multicast */  	dp->running = true;  }  /* -  This routine is called to start the transmitter.  It is split out from the -  data handling routine so it may be called either when data becomes first -  available or when an Tx interrupt occurs -*/ + * This routine is called to start the transmitter. It is split out from the + * data handling routine so it may be called either when data becomes first + * available or when an Tx interrupt occurs + */  static void  dp83902a_start_xmit(int start_page, int len) @@ -249,9 +252,9 @@ dp83902a_start_xmit(int start_page, int len)  }  /* -  This routine is called to send data to the hardware.  It is known a-priori -  that there is free buffer space (dp->tx_next). -*/ + * This routine is called to send data to the hardware. It is known a-priori + * that there is free buffer space (dp->tx_next). + */  static void  dp83902a_send(u8 *data, int total_len, u32 key)  { @@ -265,7 +268,8 @@ dp83902a_send(u8 *data, int total_len, u32 key)  	DEBUG_FUNCTION();  	len = pkt_len = total_len; -	if (pkt_len < IEEE_8023_MIN_FRAME) pkt_len = IEEE_8023_MIN_FRAME; +	if (pkt_len < IEEE_8023_MIN_FRAME) +		pkt_len = IEEE_8023_MIN_FRAME;  	start_page = dp->tx_next;  	if (dp->tx_next == dp->tx_buf1) { @@ -284,17 +288,19 @@ dp83902a_send(u8 *data, int total_len, u32 key)  	printf("TX prep page %d len %d\n", start_page, pkt_len);  #endif -	DP_OUT(base, DP_ISR, DP_ISR_RDC);  /* Clear end of DMA */ +	DP_OUT(base, DP_ISR, DP_ISR_RDC);	/* Clear end of DMA */  	{ -		/* Dummy read. The manual sez something slightly different, */ -		/* but the code is extended a bit to do what Hitachi's monitor */ -		/* does (i.e., also read data). */ +		/* +		 * Dummy read. The manual sez something slightly different, +		 * but the code is extended a bit to do what Hitachi's monitor +		 * does (i.e., also read data). +		 */  		u16 tmp;  		int len = 1; -		DP_OUT(base, DP_RSAL, 0x100-len); -		DP_OUT(base, DP_RSAH, (start_page-1) & 0xff); +		DP_OUT(base, DP_RSAL, 0x100 - len); +		DP_OUT(base, DP_RSAH, (start_page - 1) & 0xff);  		DP_OUT(base, DP_RBCL, len);  		DP_OUT(base, DP_RBCH, 0);  		DP_OUT(base, DP_CR, DP_CR_PAGE0 | DP_CR_RDMA | DP_CR_START); @@ -302,8 +308,10 @@ dp83902a_send(u8 *data, int total_len, u32 key)  	}  #ifdef CYGHWR_NS_DP83902A_PLF_BROKEN_TX_DMA -	/* Stall for a bit before continuing to work around random data */ -	/* corruption problems on some platforms. */ +	/* +	 * Stall for a bit before continuing to work around random data +	 * corruption problems on some platforms. +	 */  	CYGACC_CALL_IF_DELAY_US(1);  #endif @@ -336,16 +344,18 @@ dp83902a_send(u8 *data, int total_len, u32 key)  		printf("  + %d bytes of padding\n", pkt_len - total_len);  #endif  		/* Padding to 802.3 length was required */ -		for (i = total_len;  i < pkt_len;) { +		for (i = total_len; i < pkt_len;) {  			i++;  			DP_OUT_DATA(dp->data, 0);  		}  	}  #ifdef CYGHWR_NS_DP83902A_PLF_BROKEN_TX_DMA -	/* After last data write, delay for a bit before accessing the */ -	/* device again, or we may get random data corruption in the last */ -	/* datum (on some platforms). */ +	/* +	 * After last data write, delay for a bit before accessing the +	 * device again, or we may get random data corruption in the last +	 * datum (on some platforms). +	 */  	CYGACC_CALL_IF_DELAY_US(1);  #endif @@ -360,21 +370,21 @@ dp83902a_send(u8 *data, int total_len, u32 key)  	/* Start transmit if not already going */  	if (!dp->tx_started) {  		if (start_page == dp->tx1) { -			dp->tx_int = 1;  /* Expecting interrupt from BUF1 */ +			dp->tx_int = 1; /* Expecting interrupt from BUF1 */  		} else { -			dp->tx_int = 2;  /* Expecting interrupt from BUF2 */ +			dp->tx_int = 2; /* Expecting interrupt from BUF2 */  		}  		dp83902a_start_xmit(start_page, pkt_len);  	}  }  /* -  This function is called when a packet has been received.  It's job is -  to prepare to unload the packet from the hardware.  Once the length of -  the packet is known, the upper layer of the driver can be told.  When -  the upper layer is ready to unload the packet, the internal function -  'dp83902a_recv' will be called to actually fetch it from the hardware. -*/ + * This function is called when a packet has been received. It's job is + * to prepare to unload the packet from the hardware. Once the length of + * the packet is known, the upper layer of the driver can be told. When + * the upper layer is ready to unload the packet, the internal function + * 'dp83902a_recv' will be called to actually fetch it from the hardware. + */  static void  dp83902a_RxEvent(void)  { @@ -407,9 +417,9 @@ dp83902a_RxEvent(void)  		DP_OUT(base, DP_RSAH, pkt);  		if (dp->rx_next == pkt) {  			if (cur == dp->rx_buf_start) -				DP_OUT(base, DP_BNDRY, dp->rx_buf_end-1); +				DP_OUT(base, DP_BNDRY, dp->rx_buf_end - 1);  			else -				DP_OUT(base, DP_BNDRY, cur-1); /* Update pointer */ +				DP_OUT(base, DP_BNDRY, cur - 1); /* Update pointer */  			return;  		}  		dp->rx_next = pkt; @@ -420,13 +430,13 @@ dp83902a_RxEvent(void)  #endif  		/* read header (get data size)*/ -		for (i = 0;  i < sizeof(rcv_hdr);) { +		for (i = 0; i < sizeof(rcv_hdr);) {  			DP_IN_DATA(dp->data, rcv_hdr[i++]);  		}  #if DEBUG & 5  		printf("rx hdr %02x %02x %02x %02x\n", -		       rcv_hdr[0], rcv_hdr[1], rcv_hdr[2], rcv_hdr[3]); +			rcv_hdr[0], rcv_hdr[1], rcv_hdr[2], rcv_hdr[3]);  #endif  		len = ((rcv_hdr[3] << 8) | rcv_hdr[2]) - sizeof(rcv_hdr); @@ -434,19 +444,19 @@ dp83902a_RxEvent(void)  		uboot_push_packet_len(len);  		if (rcv_hdr[1] == dp->rx_buf_start) -			DP_OUT(base, DP_BNDRY, dp->rx_buf_end-1); +			DP_OUT(base, DP_BNDRY, dp->rx_buf_end - 1);  		else -			DP_OUT(base, DP_BNDRY, rcv_hdr[1]-1); /* Update pointer */ +			DP_OUT(base, DP_BNDRY, rcv_hdr[1] - 1); /* Update pointer */  	}  }  /* -  This function is called as a result of the "eth_drv_recv()" call above. -  It's job is to actually fetch data for a packet from the hardware once -  memory buffers have been allocated for the packet.  Note that the buffers -  may come in pieces, using a scatter-gather list.  This allows for more -  efficient processing in the upper layers of the stack. -*/ + * This function is called as a result of the "eth_drv_recv()" call above. + * It's job is to actually fetch data for a packet from the hardware once + * memory buffers have been allocated for the packet. Note that the buffers + * may come in pieces, using a scatter-gather list. This allows for more + * efficient processing in the upper layers of the stack. + */  static void  dp83902a_recv(u8 *data, int len)  { @@ -478,7 +488,7 @@ dp83902a_recv(u8 *data, int len)  #endif  	saved = false; -	for (i = 0;  i < 1;  i++) { +	for (i = 0; i < 1; i++) {  		if (data) {  			mlen = len;  #if DEBUG & 4 @@ -545,8 +555,10 @@ dp83902a_TxEvent(void)  	uboot_push_tx_done(key, 0);  } -/* Read the tally counters to clear them.  Called in response to a CNT */ -/* interrupt. */ +/* + * Read the tally counters to clear them. Called in response to a CNT + * interrupt. + */  static void  dp83902a_ClearCounters(void)  { @@ -560,8 +572,10 @@ dp83902a_ClearCounters(void)  	DP_OUT(base, DP_ISR, DP_ISR_CNT);  } -/* Deal with an overflow condition.  This code follows the procedure set */ -/* out in section 7.0 of the datasheet. */ +/* + * Deal with an overflow condition. This code follows the procedure set + * out in section 7.0 of the datasheet. + */  static void  dp83902a_Overflow(void)  { @@ -581,9 +595,11 @@ dp83902a_Overflow(void)  	DP_OUT(base, DP_TCR, DP_TCR_LOCAL);  	DP_OUT(base, DP_CR, DP_CR_START | DP_CR_NODMA); -	/* Read in as many packets as we can and acknowledge any and receive */ -	/* interrupts.  Since the buffer has overflowed, a receive event of */ -	/* some kind will have occured. */ +	/* +	 * Read in as many packets as we can and acknowledge any and receive +	 * interrupts. Since the buffer has overflowed, a receive event of +	 * some kind will have occured. +	 */  	dp83902a_RxEvent();  	DP_OUT(base, DP_ISR, DP_ISR_RxP|DP_ISR_RxE); @@ -591,8 +607,10 @@ dp83902a_Overflow(void)  	DP_OUT(base, DP_ISR, DP_ISR_OFLW);  	DP_OUT(base, DP_TCR, DP_TCR_NORMAL); -	/* If a transmit command was issued, but no transmit event has occured, */ -	/* restart it here. */ +	/* +	 * If a transmit command was issued, but no transmit event has occured, +	 * restart it here. +	 */  	DP_IN(base, DP_ISR, isr);  	if (dp->tx_started && !(isr & (DP_ISR_TxP|DP_ISR_TxE))) {  		DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_TXPKT | DP_CR_START); @@ -609,25 +627,33 @@ dp83902a_poll(void)  	DP_OUT(base, DP_CR, DP_CR_NODMA | DP_CR_PAGE0 | DP_CR_START);  	DP_IN(base, DP_ISR, isr);  	while (0 != isr) { -		/* The CNT interrupt triggers when the MSB of one of the error */ -		/* counters is set.  We don't much care about these counters, but */ -		/* we should read their values to reset them. */ +		/* +		 * The CNT interrupt triggers when the MSB of one of the error +		 * counters is set. We don't much care about these counters, but +		 * we should read their values to reset them. +		 */  		if (isr & DP_ISR_CNT) {  			dp83902a_ClearCounters();  		} -		/* Check for overflow.  It's a special case, since there's a */ -		/* particular procedure that must be followed to get back into */ -		/* a running state.a */ +		/* +		 * Check for overflow. It's a special case, since there's a +		 * particular procedure that must be followed to get back into +		 * a running state.a +		 */  		if (isr & DP_ISR_OFLW) {  			dp83902a_Overflow();  		} else { -			/* Other kinds of interrupts can be acknowledged simply by */ -			/* clearing the relevant bits of the ISR.  Do that now, then */ -			/* handle the interrupts we care about. */ -			DP_OUT(base, DP_ISR, isr);      /* Clear set bits */ +			/* +			 * Other kinds of interrupts can be acknowledged simply by +			 * clearing the relevant bits of the ISR. Do that now, then +			 * handle the interrupts we care about. +			 */ +			DP_OUT(base, DP_ISR, isr);	/* Clear set bits */  			if (!dp->running) break;	/* Is this necessary? */ -			/* Check for tx_started on TX event since these may happen */ -			/* spuriously it seems. */ +			/* +			 * Check for tx_started on TX event since these may happen +			 * spuriously it seems. +			 */  			if (isr & (DP_ISR_TxP|DP_ISR_TxE) && dp->tx_started) {  				dp83902a_TxEvent();  			} @@ -658,8 +684,8 @@ typedef struct hw_info_t {  #define HAS_MII		0x40  #define USE_SHMEM	0x80	/* autodetected */ -#define AM79C9XX_HOME_PHY	0x00006B90  /* HomePNA PHY */ -#define AM79C9XX_ETH_PHY	0x00006B70  /* 10baseT PHY */ +#define AM79C9XX_HOME_PHY	0x00006B90	/* HomePNA PHY */ +#define AM79C9XX_ETH_PHY	0x00006B70	/* 10baseT PHY */  #define MII_PHYID_REV_MASK	0xfffffff0  #define MII_PHYID_REG1		0x02  #define MII_PHYID_REG2		0x03 @@ -669,7 +695,7 @@ static hw_info_t hw_info[] = {  	{ /* Allied Telesis LA-PCM */ 0x0ff0, 0x00, 0x00, 0xf4, 0 },  	{ /* APEX MultiCard */ 0x03f4, 0x00, 0x20, 0xe5, 0 },  	{ /* ASANTE FriendlyNet */ 0x4910, 0x00, 0x00, 0x94, -	  DELAY_OUTPUT | HAS_IBM_MISC }, +			DELAY_OUTPUT | HAS_IBM_MISC },  	{ /* Danpex EN-6200P2 */ 0x0110, 0x00, 0x40, 0xc7, 0 },  	{ /* DataTrek NetCard */ 0x0ff0, 0x00, 0x20, 0xe8, 0 },  	{ /* Dayna CommuniCard E */ 0x0110, 0x00, 0x80, 0x19, 0 }, @@ -677,48 +703,48 @@ static hw_info_t hw_info[] = {  	{ /* EP-210 Ethernet */ 0x0110, 0x00, 0x40, 0x33, 0 },  	{ /* EP4000 Ethernet */ 0x01c0, 0x00, 0x00, 0xb4, 0 },  	{ /* Epson EEN10B */ 0x0ff0, 0x00, 0x00, 0x48, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* ELECOM Laneed LD-CDWA */ 0xb8, 0x08, 0x00, 0x42, 0 },  	{ /* Hypertec Ethernet */ 0x01c0, 0x00, 0x40, 0x4c, 0 },  	{ /* IBM CCAE */ 0x0ff0, 0x08, 0x00, 0x5a, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* IBM CCAE */ 0x0ff0, 0x00, 0x04, 0xac, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* IBM CCAE */ 0x0ff0, 0x00, 0x06, 0x29, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* IBM FME */ 0x0374, 0x08, 0x00, 0x5a, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* IBM FME */ 0x0374, 0x00, 0x04, 0xac, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* Kansai KLA-PCM/T */ 0x0ff0, 0x00, 0x60, 0x87, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* NSC DP83903 */ 0x0374, 0x08, 0x00, 0x17, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* NSC DP83903 */ 0x0374, 0x00, 0xc0, 0xa8, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* NSC DP83903 */ 0x0374, 0x00, 0xa0, 0xb0, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* NSC DP83903 */ 0x0198, 0x00, 0x20, 0xe0, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* I-O DATA PCLA/T */ 0x0ff0, 0x00, 0xa0, 0xb0, 0 },  	{ /* Katron PE-520 */ 0x0110, 0x00, 0x40, 0xf6, 0 },  	{ /* Kingston KNE-PCM/x */ 0x0ff0, 0x00, 0xc0, 0xf0, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* Kingston KNE-PCM/x */ 0x0ff0, 0xe2, 0x0c, 0x0f, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* Kingston KNE-PC2 */ 0x0180, 0x00, 0xc0, 0xf0, 0 },  	{ /* Maxtech PCN2000 */ 0x5000, 0x00, 0x00, 0xe8, 0 },  	{ /* NDC Instant-Link */ 0x003a, 0x00, 0x80, 0xc6, 0 },  	{ /* NE2000 Compatible */ 0x0ff0, 0x00, 0xa0, 0x0c, 0 },  	{ /* Network General Sniffer */ 0x0ff0, 0x00, 0x00, 0x65, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* Panasonic VEL211 */ 0x0ff0, 0x00, 0x80, 0x45, -	  HAS_MISC_REG | HAS_IBM_MISC }, +			HAS_MISC_REG | HAS_IBM_MISC },  	{ /* PreMax PE-200 */ 0x07f0, 0x00, 0x20, 0xe0, 0 },  	{ /* RPTI EP400 */ 0x0110, 0x00, 0x40, 0x95, 0 },  	{ /* SCM Ethernet */ 0x0ff0, 0x00, 0x20, 0xcb, 0 },  	{ /* Socket EA */ 0x4000, 0x00, 0xc0, 0x1b, -	  DELAY_OUTPUT | HAS_MISC_REG | USE_BIG_BUF }, +			DELAY_OUTPUT | HAS_MISC_REG | USE_BIG_BUF },  	{ /* Socket LP-E CF+ */ 0x01c0, 0x00, 0xc0, 0x1b, 0 },  	{ /* SuperSocket RE450T */ 0x0110, 0x00, 0xe0, 0x98, 0 },  	{ /* Volktek NPL-402CT */ 0x0060, 0x00, 0x40, 0x05, 0 }, @@ -744,11 +770,11 @@ u32 nic_base;  static u8 *pbuf = NULL;  static int pkey = -1; -static int initialized=0; +static int initialized = 0;  void uboot_push_packet_len(int len) {  	PRINTK("pushed len = %d\n", len); -	if (len>=2000) { +	if (len >= 2000) {  		printf("NE2000: packet too big\n");  		return;  	} @@ -779,7 +805,7 @@ int eth_init(bd_t *bd) {  #ifdef CONFIG_DRIVER_NE2000_CCR  	{ -		vu_char *p =  (vu_char *) CONFIG_DRIVER_NE2000_CCR; +		vu_char *p = (vu_char *) CONFIG_DRIVER_NE2000_CCR;  		PRINTK("CCR before is %x\n", *p);  		*p = CONFIG_DRIVER_NE2000_VAL; @@ -811,7 +837,7 @@ int eth_init(bd_t *bd) {  		return -1;  	dp83902a_start(dev_addr); -	initialized=1; +	initialized = 1;  	return 0;  } @@ -821,7 +847,7 @@ void eth_halt() {  	PRINTK("### eth_halt\n");  	if(initialized)  		dp83902a_stop(); -	initialized=0; +	initialized = 0;  }  int eth_rx() { |