diff options
| author | Heiko Schocher <hs@denx.de> | 2011-08-01 04:01:43 +0000 | 
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2011-08-04 23:30:38 +0200 | 
| commit | 780f13a9e1a21098c6255aaa1c46ed80aa7a436c (patch) | |
| tree | 4273c1af78aa2f3079e11997e12814d66d47439e /drivers/hwmon/lm73.c | |
| parent | fb6440ee9b110b759ef61fd80bbd0df1bbf0f37b (diff) | |
| download | olio-uboot-2014.01-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.tar.xz olio-uboot-2014.01-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.zip | |
hwmon: do not init sensors on startup
The U-Boot Design Principles[1] clearly say:
  Initialize devices only when they are needed within U-Boot, i.e. don't
  initialize the Ethernet interface(s) unless U-Boot performs a download
  over Ethernet; don't initialize any IDE or USB devices unless U-Boot
  actually tries to load files from these, etc. (and don't forget to
  shut down these devices after using them - otherwise nasty things may
  happen when you try to boot your OS).
So, do not initialize and read the sensors on startup.
Signed-off-by: Heiko Schocher <hs@denx.de>
cc: Wolfgang Denk <wd@denx.de>
cc: Holger Brunck <holger.brunck@keymile.com>
Diffstat (limited to 'drivers/hwmon/lm73.c')
| -rw-r--r-- | drivers/hwmon/lm73.c | 20 | 
1 files changed, 2 insertions, 18 deletions
| diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c index 7b5d893ff..45cc6db58 100644 --- a/drivers/hwmon/lm73.c +++ b/drivers/hwmon/lm73.c @@ -112,7 +112,7 @@ int dtt_write(int const sensor, int const reg, int const val)  			      dlen);  } /* dtt_write() */ -static int _dtt_init(int const sensor) +int dtt_init_one(int const sensor)  {  	int val; @@ -148,23 +148,7 @@ static int _dtt_init(int const sensor)  	dtt_read(sensor, DTT_CONTROL);	/* clear temperature flags */  	return 0; -} /* _dtt_init() */ - -int dtt_init(void) -{ -	int i; -	unsigned char sensors[] = CONFIG_DTT_SENSORS; -	const char *const header = "DTT:   "; - -	for (i = 0; i < sizeof(sensors); i++) { -		if (0 != _dtt_init(sensors[i])) -			printf("%s%d FAILED INIT\n", header, i + 1); -		else -			printf("%s%d is %i C\n", header, i + 1, -			       dtt_get_temp(sensors[i])); -	} -	return 0; -} /* dtt_init() */ +} /* dtt_init_one() */  int dtt_get_temp(int const sensor)  { |