diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2009-06-14 21:35:22 -0400 | 
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2009-07-17 22:15:27 +0200 | 
| commit | 569460ebf14b87bd8fdb2352bde95d35ee96e13b (patch) | |
| tree | fc59dfc9e8b70f18c275da33b1c84945e7a203ef /common/cmd_sata.c | |
| parent | 02e22c2de1ce2312f2636fa473a60c8d8f18d8aa (diff) | |
| download | olio-uboot-2014.01-569460ebf14b87bd8fdb2352bde95d35ee96e13b.tar.xz olio-uboot-2014.01-569460ebf14b87bd8fdb2352bde95d35ee96e13b.zip | |
sata: namespace curr_device variable
The curr_device variable really should be namespaced with a "sata_" prefix
since it is only used by the sata code.  It also avoids random conflicts
with other pieces of code (like cmd_mmc):
common/libcommon.a(cmd_sata.o):(.data.curr_device+0x0):
	multiple definition of `curr_device'
common/libcommon.a(cmd_mmc.o):(.data.curr_device+0x0): first defined here
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'common/cmd_sata.c')
| -rw-r--r-- | common/cmd_sata.c | 24 | 
1 files changed, 12 insertions, 12 deletions
| diff --git a/common/cmd_sata.c b/common/cmd_sata.c index a8147e0e0..1693a7e31 100644 --- a/common/cmd_sata.c +++ b/common/cmd_sata.c @@ -28,7 +28,7 @@  #include <part.h>  #include <sata.h> -int curr_device = -1; +int sata_curr_device = -1;  block_dev_desc_t sata_dev_desc[CONFIG_SYS_SATA_MAX_DEVICE];  int __sata_initialize(void) @@ -52,7 +52,7 @@ int __sata_initialize(void)  		if ((sata_dev_desc[i].lba > 0) && (sata_dev_desc[i].blksz > 0))  			init_part(&sata_dev_desc[i]);  	} -	curr_device = 0; +	sata_curr_device = 0;  	return rc;  }  int sata_initialize(void) __attribute__((weak,alias("__sata_initialize"))); @@ -70,7 +70,7 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])  		return sata_initialize();  	/* If the user has not yet run `sata init`, do it now */ -	if (curr_device == -1) +	if (sata_curr_device == -1)  		if (sata_initialize())  			return 1; @@ -91,12 +91,12 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])  			}  			return 0;  		} else if (strncmp(argv[1],"dev", 3) == 0) { -			if ((curr_device < 0) || (curr_device >= CONFIG_SYS_SATA_MAX_DEVICE)) { +			if ((sata_curr_device < 0) || (sata_curr_device >= CONFIG_SYS_SATA_MAX_DEVICE)) {  				puts("\nno SATA devices available\n");  				return 1;  			} -			printf("\nSATA device %d: ", curr_device); -			dev_print(&sata_dev_desc[curr_device]); +			printf("\nSATA device %d: ", sata_curr_device); +			dev_print(&sata_dev_desc[sata_curr_device]);  			return 0;  		} else if (strncmp(argv[1],"part",4) == 0) {  			int dev, ok; @@ -131,7 +131,7 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])  			if (sata_dev_desc[dev].type == DEV_TYPE_UNKNOWN)  				return 1; -			curr_device = dev; +			sata_curr_device = dev;  			puts("... is now current device\n"); @@ -158,12 +158,12 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])  			lbaint_t blk = simple_strtoul(argv[3], NULL, 16);  			printf("\nSATA read: device %d block # %ld, count %ld ... ", -				curr_device, blk, cnt); +				sata_curr_device, blk, cnt); -			n = sata_read(curr_device, blk, cnt, (u32 *)addr); +			n = sata_read(sata_curr_device, blk, cnt, (u32 *)addr);  			/* flush cache after read */ -			flush_cache(addr, cnt * sata_dev_desc[curr_device].blksz); +			flush_cache(addr, cnt * sata_dev_desc[sata_curr_device].blksz);  			printf("%ld blocks read: %s\n",  				n, (n==cnt) ? "OK" : "ERROR"); @@ -176,9 +176,9 @@ int do_sata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])  			lbaint_t blk = simple_strtoul(argv[3], NULL, 16);  			printf("\nSATA write: device %d block # %ld, count %ld ... ", -				curr_device, blk, cnt); +				sata_curr_device, blk, cnt); -			n = sata_write(curr_device, blk, cnt, (u32 *)addr); +			n = sata_write(sata_curr_device, blk, cnt, (u32 *)addr);  			printf("%ld blocks written: %s\n",  				n, (n == cnt) ? "OK" : "ERROR"); |