diff options
| author | Wolfgang Denk <wd@denx.de> | 2010-07-17 01:06:04 +0200 | 
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2010-07-24 20:43:57 +0200 | 
| commit | 47e26b1bf91ddef69f4a3892815c857db094cef9 (patch) | |
| tree | 7d688085d23779707c637703273f79bd3cca83e0 /common/cmd_bedbug.c | |
| parent | debb6299ac1180a08f29f88c6d782b21a9c98707 (diff) | |
| download | olio-uboot-2014.01-47e26b1bf91ddef69f4a3892815c857db094cef9.tar.xz olio-uboot-2014.01-47e26b1bf91ddef69f4a3892815c857db094cef9.zip | |
cmd_usage(): simplify return code handling
Lots of code use this construct:
	cmd_usage(cmdtp);
	return 1;
Change cmd_usage() let it return 1 - then we can replace all these
ocurrances by
	return cmd_usage(cmdtp);
This fixes a few places with incorrect return code handling, too.
Signed-off-by: Wolfgang Denk <wd@denx.de>
Diffstat (limited to 'common/cmd_bedbug.c')
| -rw-r--r-- | common/cmd_bedbug.c | 12 | 
1 files changed, 4 insertions, 8 deletions
| diff --git a/common/cmd_bedbug.c b/common/cmd_bedbug.c index d01ee19ee..2bd62e243 100644 --- a/common/cmd_bedbug.c +++ b/common/cmd_bedbug.c @@ -84,10 +84,8 @@ int do_bedbug_dis (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])  	addr = dis_last_addr;  	len = dis_last_len; -	if (argc < 2) { -		cmd_usage(cmdtp); -		return 1; -	} +	if (argc < 2) +		return cmd_usage(cmdtp);  	if ((flag & CMD_FLAG_REPEAT) == 0) {  		/* New command */ @@ -125,10 +123,8 @@ int do_bedbug_asm (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])  	/* -------------------------------------------------- */  	int rcode = 0; -	if (argc < 2) { -		cmd_usage(cmdtp); -		return 1; -	} +	if (argc < 2) +		return cmd_usage(cmdtp);  	printf ("\nEnter '.' when done\n");  	mem_addr = simple_strtoul (argv[1], NULL, 16); |