diff options
| author | Simon Glass <sjg@chromium.org> | 2012-11-30 13:01:22 +0000 |
|---|---|---|
| committer | Albert ARIBAUD <albert.u.boot@aribaud.net> | 2013-01-10 22:27:41 +0100 |
| commit | 2f8d8d6b3aedcea36db84872a4174eb8d5903f8f (patch) | |
| tree | 998ed04ad1d6c340e8260145240a3e833385c243 /arch/arm | |
| parent | fe34f8dc8ca719d83a4bc67a35e15dfc780559e9 (diff) | |
| download | olio-uboot-2014.01-2f8d8d6b3aedcea36db84872a4174eb8d5903f8f.tar.xz olio-uboot-2014.01-2f8d8d6b3aedcea36db84872a4174eb8d5903f8f.zip | |
arm: Move bootstage record for board_init_f() to after arch_cpu_init()
The timer may be inited in arch_cpu_init() so it is not safe to make a
bootstage mark before this is called. Arrange the code to fix this.
Note: The question was raised as to why we don't keep all archs in sync.
PowerPC doesn't have specific bootstage markers at present (although it
does use boot progress). I hope that the generic board series will solve
this problem in general, but in the meantime this is a real problem, and
only in ARM.
We now get a correct time for board_init_f:
Timer summary in microseconds:
Mark Elapsed Stage
0 0 reset
100,000 100,000 spl_start
848,530 748,530 board_init_f
907,301 58,771 board_init_r
910,478 3,177 board_init
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'arch/arm')
| -rw-r--r-- | arch/arm/lib/board.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index ec5c35f13..404ef4dce 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -232,8 +232,17 @@ int __power_init_board(void) int power_init_board(void) __attribute__((weak, alias("__power_init_board"))); + /* Record the board_init_f() bootstage (after arch_cpu_init()) */ +static int mark_bootstage(void) +{ + bootstage_mark_name(BOOTSTAGE_ID_START_UBOOT_F, "board_init_f"); + + return 0; +} + init_fnc_t *init_sequence[] = { arch_cpu_init, /* basic arch cpu dependent setup */ + mark_bootstage, #ifdef CONFIG_OF_CONTROL fdtdec_check_fdt, #endif @@ -277,8 +286,6 @@ void board_init_f(ulong bootflag) void *new_fdt = NULL; size_t fdt_size = 0; - bootstage_mark_name(BOOTSTAGE_ID_START_UBOOT_F, "board_init_f"); - memset((void *)gd, 0, sizeof(gd_t)); gd->mon_len = _bss_end_ofs; |