diff options
| author | Kim Phillips <kim.phillips@freescale.com> | 2012-10-29 13:34:34 +0000 | 
|---|---|---|
| committer | Tom Rini <trini@ti.com> | 2012-11-04 11:00:36 -0700 | 
| commit | 960d70c60055cbc4fbf4ce170959ecf2839bc788 (patch) | |
| tree | 58e17ff030c5477cc71423f4d9981b0fbd804408 | |
| parent | 0637059088a2579b3c0d67a5ca7d34dd7721204f (diff) | |
| download | olio-uboot-2014.01-960d70c60055cbc4fbf4ce170959ecf2839bc788.tar.xz olio-uboot-2014.01-960d70c60055cbc4fbf4ce170959ecf2839bc788.zip | |
drivers/net/: sparse fixes
phy.c:46:5: warning: symbol 'genphy_config_advert' was not declared. Should it be static?
phy.c:121:5: warning: symbol 'genphy_setup_forced' was not declared. Should it be static?
phy.c:468:5: warning: symbol 'phy_probe' was not declared. Should it be static?
phy.c:491:19: warning: symbol 'get_phy_driver' was not declared. Should it be static?
phy.c:508:19: warning: symbol 'phy_device_create' was not declared. Should it be static?
phy.c:552:5: warning: symbol 'get_phy_id' was not declared. Should it be static?
phy.c:584:19: warning: symbol 'get_phy_device' was not declared. Should it be sta
vitesse.c:126:5: warning: symbol 'vsc8601_config' was not declared. Should it be static?
vsc7385.c:33:5: warning: symbol 'vsc7385_upload_firmware' was not declared. Should it be static?
tgec_phy.c:33:5: warning: symbol 'tgec_mdio_write' was not declared. Should it be static?
tgec_phy.c:75:5: warning: symbol 'tgec_mdio_read' was not declared. Should it be static?
tgec_phy.c:117:5: warning: symbol 'tgec_mdio_reset' was not declared. Should it be static?
eth.c:48:6: warning: symbol 'dtsec_configure_serdes' was not declared. Should it be static?
p4080.c:26:5: warning: symbol 'port_to_devdisr' was not declared. Should it be static?
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
| -rw-r--r-- | drivers/net/fm/eth.c | 2 | ||||
| -rw-r--r-- | drivers/net/fm/p1023.c | 2 | ||||
| -rw-r--r-- | drivers/net/fm/p4080.c | 2 | ||||
| -rw-r--r-- | drivers/net/fm/p5020.c | 2 | ||||
| -rw-r--r-- | drivers/net/fm/tgec_phy.c | 10 | ||||
| -rw-r--r-- | drivers/net/phy/phy.c | 19 | ||||
| -rw-r--r-- | drivers/net/phy/vitesse.c | 2 | ||||
| -rw-r--r-- | drivers/net/vsc7385.c | 1 | 
8 files changed, 21 insertions, 19 deletions
| diff --git a/drivers/net/fm/eth.c b/drivers/net/fm/eth.c index 82c787bf3..54b142f47 100644 --- a/drivers/net/fm/eth.c +++ b/drivers/net/fm/eth.c @@ -46,7 +46,7 @@ static int num_controllers;  			TBICR_FULL_DUPLEX | TBICR_SPEED1_SET)  /* Configure the TBI for SGMII operation */ -void dtsec_configure_serdes(struct fm_eth *priv) +static void dtsec_configure_serdes(struct fm_eth *priv)  {  #ifdef CONFIG_SYS_FMAN_V3  	u32 value; diff --git a/drivers/net/fm/p1023.c b/drivers/net/fm/p1023.c index 9765da5b2..387d2a382 100644 --- a/drivers/net/fm/p1023.c +++ b/drivers/net/fm/p1023.c @@ -23,7 +23,7 @@  #include <asm/immap_85xx.h>  #include <asm/fsl_serdes.h> -u32 port_to_devdisr[] = { +static u32 port_to_devdisr[] = {  	[FM1_DTSEC1] = MPC85xx_DEVDISR_TSEC1,  	[FM1_DTSEC2] = MPC85xx_DEVDISR_TSEC2,  }; diff --git a/drivers/net/fm/p4080.c b/drivers/net/fm/p4080.c index 9dc6049c3..b04fd0f65 100644 --- a/drivers/net/fm/p4080.c +++ b/drivers/net/fm/p4080.c @@ -23,7 +23,7 @@  #include <asm/immap_85xx.h>  #include <asm/fsl_serdes.h> -u32 port_to_devdisr[] = { +static u32 port_to_devdisr[] = {  	[FM1_DTSEC1] = FSL_CORENET_DEVDISR2_DTSEC1_1,  	[FM1_DTSEC2] = FSL_CORENET_DEVDISR2_DTSEC1_2,  	[FM1_DTSEC3] = FSL_CORENET_DEVDISR2_DTSEC1_3, diff --git a/drivers/net/fm/p5020.c b/drivers/net/fm/p5020.c index a7a6e43fe..539104483 100644 --- a/drivers/net/fm/p5020.c +++ b/drivers/net/fm/p5020.c @@ -23,7 +23,7 @@  #include <asm/immap_85xx.h>  #include <asm/fsl_serdes.h> -u32 port_to_devdisr[] = { +static u32 port_to_devdisr[] = {  	[FM1_DTSEC1] = FSL_CORENET_DEVDISR2_DTSEC1_1,  	[FM1_DTSEC2] = FSL_CORENET_DEVDISR2_DTSEC1_2,  	[FM1_DTSEC3] = FSL_CORENET_DEVDISR2_DTSEC1_3, diff --git a/drivers/net/fm/tgec_phy.c b/drivers/net/fm/tgec_phy.c index 2d349ad03..2be69d716 100644 --- a/drivers/net/fm/tgec_phy.c +++ b/drivers/net/fm/tgec_phy.c @@ -30,8 +30,8 @@   * until the write is done before it returns.  All PHY configuration has to be   * done through the TSEC1 MIIM regs   */ -int tgec_mdio_write(struct mii_dev *bus, int port_addr, int dev_addr, -			int regnum, u16 value) +static int tgec_mdio_write(struct mii_dev *bus, int port_addr, int dev_addr, +			   int regnum, u16 value)  {  	u32 mdio_ctl;  	u32 stat_val; @@ -72,8 +72,8 @@ int tgec_mdio_write(struct mii_dev *bus, int port_addr, int dev_addr,   * Clears miimcom first.  All PHY configuration has to be done through the   * TSEC1 MIIM regs   */ -int tgec_mdio_read(struct mii_dev *bus, int port_addr, int dev_addr, -			int regnum) +static int tgec_mdio_read(struct mii_dev *bus, int port_addr, int dev_addr, +			  int regnum)  {  	u32 mdio_ctl;  	u32 stat_val; @@ -114,7 +114,7 @@ int tgec_mdio_read(struct mii_dev *bus, int port_addr, int dev_addr,  	return in_be32(®s->mdio_data) & 0xffff;  } -int tgec_mdio_reset(struct mii_dev *bus) +static int tgec_mdio_reset(struct mii_dev *bus)  {  	return 0;  } diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index baef60f82..1ffa791dc 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -43,7 +43,7 @@   *   what is supported.  Returns < 0 on error, 0 if the PHY's advertisement   *   hasn't changed, and > 0 if it has changed.   */ -int genphy_config_advert(struct phy_device *phydev) +static int genphy_config_advert(struct phy_device *phydev)  {  	u32 advertise;  	int oldadv, adv; @@ -118,7 +118,7 @@ int genphy_config_advert(struct phy_device *phydev)   * Description: Configures MII_BMCR to force speed/duplex   *   to the values in phydev. Assumes that the values are valid.   */ -int genphy_setup_forced(struct phy_device *phydev) +static int genphy_setup_forced(struct phy_device *phydev)  {  	int err;  	int ctl = 0; @@ -465,7 +465,7 @@ int phy_register(struct phy_driver *drv)  	return 0;  } -int phy_probe(struct phy_device *phydev) +static int phy_probe(struct phy_device *phydev)  {  	int err = 0; @@ -488,7 +488,7 @@ static struct phy_driver *generic_for_interface(phy_interface_t interface)  	return &genphy_driver;  } -struct phy_driver *get_phy_driver(struct phy_device *phydev, +static struct phy_driver *get_phy_driver(struct phy_device *phydev,  				phy_interface_t interface)  {  	struct list_head *entry; @@ -505,8 +505,9 @@ struct phy_driver *get_phy_driver(struct phy_device *phydev,  	return generic_for_interface(interface);  } -struct phy_device *phy_device_create(struct mii_dev *bus, int addr, int phy_id, -					phy_interface_t interface) +static struct phy_device *phy_device_create(struct mii_dev *bus, int addr, +					    int phy_id, +					    phy_interface_t interface)  {  	struct phy_device *dev; @@ -549,7 +550,7 @@ struct phy_device *phy_device_create(struct mii_dev *bus, int addr, int phy_id,   * Description: Reads the ID registers of the PHY at @addr on the   *   @bus, stores it in @phy_id and returns zero on success.   */ -int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id) +static int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id)  {  	int phy_reg; @@ -581,8 +582,8 @@ int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id)   * Description: Reads the ID registers of the PHY at @addr on the   *   @bus, then allocates and returns the phy_device to represent it.   */ -struct phy_device *get_phy_device(struct mii_dev *bus, int addr, -				phy_interface_t interface) +static struct phy_device *get_phy_device(struct mii_dev *bus, int addr, +					 phy_interface_t interface)  {  	u32 phy_id = 0x1fffffff;  	int i; diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c index 0a0f40dbd..6c5cb9977 100644 --- a/drivers/net/phy/vitesse.c +++ b/drivers/net/phy/vitesse.c @@ -123,7 +123,7 @@ static int cis8204_config(struct phy_device *phydev)  }  /* Vitesse VSC8601 */ -int vsc8601_config(struct phy_device *phydev) +static int vsc8601_config(struct phy_device *phydev)  {  	/* Configure some basic stuff */  #ifdef CONFIG_SYS_VSC8601_SKEWFIX diff --git a/drivers/net/vsc7385.c b/drivers/net/vsc7385.c index ada42c41f..a5110e516 100644 --- a/drivers/net/vsc7385.c +++ b/drivers/net/vsc7385.c @@ -16,6 +16,7 @@  #include <common.h>  #include <asm/io.h>  #include <asm/errno.h> +#include "vsc7385.h"  /*   * Upload a Vitesse VSC7385 firmware image to the hardware |