diff options
| author | Jeroen Hofstee <jeroen@myspectrum.nl> | 2013-01-22 10:44:12 +0000 | 
|---|---|---|
| committer | Anatolij Gustschin <agust@denx.de> | 2013-03-21 10:16:53 +0100 | 
| commit | 00a0ca5986c13d24ebbc5000cc1b7a1cdac0ba4b (patch) | |
| tree | 88ba8d340866a41eb7142b39fa0121975e12b0f1 | |
| parent | f1d205a19cc89ae5a840cd45115201847dd5b73a (diff) | |
| download | olio-uboot-2014.01-00a0ca5986c13d24ebbc5000cc1b7a1cdac0ba4b.tar.xz olio-uboot-2014.01-00a0ca5986c13d24ebbc5000cc1b7a1cdac0ba4b.zip | |
common/lcd.c: remove global lcd_base
lcd_base is available as gd->fb_base as well, there is no need
to keep a seperate copy.
For completeness the ack of Bo Shen is for the atmel part.
Cc: Alessandro Rubini <rubini@unipv.it>
Cc: Anatolij Gustschin <agust@denx.de>
Cc: Bo Shen <voice.shen@atmel.com>
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
Cc: Nikita Kiryanov <nikita@compulab.co.il>
Cc: Simon Glass <sjg@chromium.org>
Cc: Stelian Pop <stelian@popies.net>
Cc: Tom Warren <twarren@nvidia.com>
Acked-by: Bo Shen <voice.shen@atmel.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
[agust: also fix cm_t35 board while rebasing]
Signed-off-by: Anatolij Gustschin <agust@denx.de>
| -rw-r--r-- | board/cm_t35/display.c | 2 | ||||
| -rw-r--r-- | board/mcc200/lcd.c | 8 | ||||
| -rw-r--r-- | common/lcd.c | 1 | ||||
| -rw-r--r-- | drivers/video/atmel_hlcdfb.c | 2 | ||||
| -rw-r--r-- | drivers/video/atmel_lcdfb.c | 2 | ||||
| -rw-r--r-- | drivers/video/exynos_fb.c | 8 | ||||
| -rw-r--r-- | drivers/video/mpc8xx_lcd.c | 12 | ||||
| -rw-r--r-- | drivers/video/pxa_lcd.c | 2 | ||||
| -rw-r--r-- | drivers/video/tegra.c | 6 | ||||
| -rw-r--r-- | include/lcd.h | 5 | 
10 files changed, 9 insertions, 39 deletions
| diff --git a/board/cm_t35/display.c b/board/cm_t35/display.c index d4487f31f..a004ea1d8 100644 --- a/board/cm_t35/display.c +++ b/board/cm_t35/display.c @@ -381,8 +381,6 @@ static enum display_type env_parse_displaytype(char *displaytype)  	return NONE;  } -void *lcd_base; -  void lcd_ctrl_init(void *lcdbase)  {  	struct prcm *prcm = (struct prcm *)PRCM_BASE; diff --git a/board/mcc200/lcd.c b/board/mcc200/lcd.c index caf8d8b11..190190853 100644 --- a/board/mcc200/lcd.c +++ b/board/mcc200/lcd.c @@ -68,10 +68,6 @@ vidinfo_t panel_info = {  	LCD_WIDTH, LCD_HEIGHT, LCD_BPP  }; -/* - * Frame buffer memory information - */ -void *lcd_base;			/* Start of framebuffer memory  */  /*   *  The device we use to communicate with PSoC @@ -147,12 +143,12 @@ void lcd_enable (void)  #if !defined(SWAPPED_LCD)  	for (i=0; i<fb_size; i++) { -		serial_putc_raw_dev (PSOC_PSC, ((char *)lcd_base)[i]); +		serial_putc_raw_dev(PSOC_PSC, ((char *)gd->fb_base)[i]);  	}  #else      {  	int x, y, pwidth; -	char *p = (char *)lcd_base; +	char *p = (char *)gd->fb_base;  	pwidth = ((panel_info.vl_col+7) >> 3);  	for (y=0; y<panel_info.vl_row; y++) { diff --git a/common/lcd.c b/common/lcd.c index 874f18220..eceb8ada0 100644 --- a/common/lcd.c +++ b/common/lcd.c @@ -109,6 +109,7 @@ static short console_col;  static short console_row;  static void *lcd_console_address; +static void *lcd_base;			/* Start of framebuffer memory	*/  static char lcd_flush_dcache;	/* 1 to flush dcache after each lcd update */ diff --git a/drivers/video/atmel_hlcdfb.c b/drivers/video/atmel_hlcdfb.c index 32626cfed..fc9589774 100644 --- a/drivers/video/atmel_hlcdfb.c +++ b/drivers/video/atmel_hlcdfb.c @@ -29,8 +29,6 @@  #include <lcd.h>  #include <atmel_hlcdc.h> -void *lcd_base;				/* Start of framebuffer memory	*/ -  /* configurable parameters */  #define ATMEL_LCDC_CVAL_DEFAULT		0xc8  #define ATMEL_LCDC_DMA_BURST_LEN	8 diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c index 370d9ca13..2afeab2ff 100644 --- a/drivers/video/atmel_lcdfb.c +++ b/drivers/video/atmel_lcdfb.c @@ -29,8 +29,6 @@  #include <lcd.h>  #include <atmel_lcdc.h> -void *lcd_base;				/* Start of framebuffer memory	*/ -  /* configurable parameters */  #define ATMEL_LCDC_CVAL_DEFAULT		0xc8  #define ATMEL_LCDC_DMA_BURST_LEN	8 diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c index 82b19e521..c0f1830dc 100644 --- a/drivers/video/exynos_fb.c +++ b/drivers/video/exynos_fb.c @@ -33,7 +33,7 @@  #include "exynos_fb.h" -void *lcd_base; +DECLARE_GLOBAL_DATA_PTR;  static unsigned int panel_width, panel_height; @@ -44,11 +44,9 @@ static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)  	fb_size = vid->vl_row * vid->vl_col * (NBITS(vid->vl_bpix) >> 3); -	lcd_base = lcdbase; -  	palette_size = NBITS(vid->vl_bpix) == 8 ? 256 : 16; -	exynos_fimd_lcd_init_mem((unsigned long)lcd_base, +	exynos_fimd_lcd_init_mem((unsigned long)lcdbase,  			(unsigned long)fb_size, palette_size);  } @@ -140,7 +138,7 @@ void lcd_ctrl_init(void *lcdbase)  void lcd_enable(void)  {  	if (panel_info.logo_on) { -		memset(lcd_base, 0, panel_width * panel_height * +		memset((void *) gd->fb_base, 0, panel_width * panel_height *  				(NBITS(panel_info.vl_bpix) >> 3));  #ifdef CONFIG_CMD_BMP  		draw_logo(); diff --git a/drivers/video/mpc8xx_lcd.c b/drivers/video/mpc8xx_lcd.c index 26ad432b2..1aa196731 100644 --- a/drivers/video/mpc8xx_lcd.c +++ b/drivers/video/mpc8xx_lcd.c @@ -255,14 +255,6 @@ vidinfo_t panel_info = {  #endif  /*----------------------------------------------------------------------*/ - -/* - * Frame buffer memory information - */ -void *lcd_base;			/* Start of framebuffer memory	*/ - -/************************************************************************/ -  void lcd_ctrl_init (void *lcdbase);  void lcd_enable (void);  #if LCD_BPP == LCD_COLOR8 @@ -392,8 +384,8 @@ void lcd_ctrl_init (void *lcdbase)  	 * BIG NOTE:  This has to be modified to load A and B depending  	 * upon the split mode of the LCD.  	 */ -	lcdp->lcd_lcfaa = (ulong)lcd_base; -	lcdp->lcd_lcfba = (ulong)lcd_base; +	lcdp->lcd_lcfaa = (ulong)lcdbase; +	lcdp->lcd_lcfba = (ulong)lcdbase;  	/* MORE HACKS...This must be updated according to 823 manual  	 * for different panels. diff --git a/drivers/video/pxa_lcd.c b/drivers/video/pxa_lcd.c index 57243ce61..fef49c1fe 100644 --- a/drivers/video/pxa_lcd.c +++ b/drivers/video/pxa_lcd.c @@ -332,8 +332,6 @@ void lcd_getcolreg (ushort regno, ushort *red, ushort *green, ushort *blue);  void lcd_ctrl_init	(void *lcdbase);  void lcd_enable	(void); -void *lcd_base;			/* Start of framebuffer memory	*/ -  static int pxafb_init_mem (void *lcdbase, vidinfo_t *vid);  static void pxafb_setup_gpio (vidinfo_t *vid);  static void pxafb_enable_controller (vidinfo_t *vid); diff --git a/drivers/video/tegra.c b/drivers/video/tegra.c index 3d684ce07..8d533955a 100644 --- a/drivers/video/tegra.c +++ b/drivers/video/tegra.c @@ -60,8 +60,6 @@ enum {  	LCD_MAX_LOG2_BPP	= 4,		/* 2^4 = 16 bpp */  }; -void *lcd_base;			/* Start of framebuffer memory	*/ -  vidinfo_t panel_info = {  	/* Insert a value here so that we don't end up in the BSS */  	.vl_col = -1, @@ -90,8 +88,6 @@ void lcd_ctrl_init(void *lcdbase)  	assert(disp_config); -	lcd_base = (void *)disp_config->frame_buffer; -  	/* Make sure that we can acommodate the selected LCD */  	assert(disp_config->width <= LCD_MAX_WIDTH);  	assert(disp_config->height <= LCD_MAX_HEIGHT); @@ -112,7 +108,7 @@ void lcd_ctrl_init(void *lcdbase)  	/* Enable flushing after LCD writes if requested */  	lcd_set_flush_dcache(config.cache_type & FDT_LCD_CACHE_FLUSH); -	debug("LCD frame buffer at %p\n", lcd_base); +	debug("LCD frame buffer at %08X\n", disp_config->frame_buffer);  }  ulong calc_fbsize(void) diff --git a/include/lcd.h b/include/lcd.h index 9b8ffeb99..f88b7e95c 100644 --- a/include/lcd.h +++ b/include/lcd.h @@ -33,11 +33,6 @@ extern char lcd_is_enabled;  extern int lcd_line_length; -/* - * Frame buffer memory information - */ -extern void *lcd_base;			/* Start of framebuffer memory	*/ -  extern struct vidinfo panel_info;  extern void lcd_ctrl_init (void *lcdbase); |