diff options
Diffstat (limited to 'kernel/rcutorture.c')
| -rw-r--r-- | kernel/rcutorture.c | 54 | 
1 files changed, 18 insertions, 36 deletions
diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c index aaa7b9f3532..31dea01c85f 100644 --- a/kernel/rcutorture.c +++ b/kernel/rcutorture.c @@ -339,7 +339,6 @@ rcu_stutter_wait(char *title)  struct rcu_torture_ops {  	void (*init)(void); -	void (*cleanup)(void);  	int (*readlock)(void);  	void (*read_delay)(struct rcu_random_state *rrsp);  	void (*readunlock)(int idx); @@ -431,7 +430,6 @@ static void rcu_torture_deferred_free(struct rcu_torture *p)  static struct rcu_torture_ops rcu_ops = {  	.init		= NULL, -	.cleanup	= NULL,  	.readlock	= rcu_torture_read_lock,  	.read_delay	= rcu_read_delay,  	.readunlock	= rcu_torture_read_unlock, @@ -475,7 +473,6 @@ static void rcu_sync_torture_init(void)  static struct rcu_torture_ops rcu_sync_ops = {  	.init		= rcu_sync_torture_init, -	.cleanup	= NULL,  	.readlock	= rcu_torture_read_lock,  	.read_delay	= rcu_read_delay,  	.readunlock	= rcu_torture_read_unlock, @@ -493,7 +490,6 @@ static struct rcu_torture_ops rcu_sync_ops = {  static struct rcu_torture_ops rcu_expedited_ops = {  	.init		= rcu_sync_torture_init, -	.cleanup	= NULL,  	.readlock	= rcu_torture_read_lock,  	.read_delay	= rcu_read_delay,  /* just reuse rcu's version. */  	.readunlock	= rcu_torture_read_unlock, @@ -536,7 +532,6 @@ static void rcu_bh_torture_deferred_free(struct rcu_torture *p)  static struct rcu_torture_ops rcu_bh_ops = {  	.init		= NULL, -	.cleanup	= NULL,  	.readlock	= rcu_bh_torture_read_lock,  	.read_delay	= rcu_read_delay,  /* just reuse rcu's version. */  	.readunlock	= rcu_bh_torture_read_unlock, @@ -553,7 +548,6 @@ static struct rcu_torture_ops rcu_bh_ops = {  static struct rcu_torture_ops rcu_bh_sync_ops = {  	.init		= rcu_sync_torture_init, -	.cleanup	= NULL,  	.readlock	= rcu_bh_torture_read_lock,  	.read_delay	= rcu_read_delay,  /* just reuse rcu's version. */  	.readunlock	= rcu_bh_torture_read_unlock, @@ -570,7 +564,6 @@ static struct rcu_torture_ops rcu_bh_sync_ops = {  static struct rcu_torture_ops rcu_bh_expedited_ops = {  	.init		= rcu_sync_torture_init, -	.cleanup	= NULL,  	.readlock	= rcu_bh_torture_read_lock,  	.read_delay	= rcu_read_delay,  /* just reuse rcu's version. */  	.readunlock	= rcu_bh_torture_read_unlock, @@ -589,19 +582,7 @@ static struct rcu_torture_ops rcu_bh_expedited_ops = {   * Definitions for srcu torture testing.   */ -static struct srcu_struct srcu_ctl; - -static void srcu_torture_init(void) -{ -	init_srcu_struct(&srcu_ctl); -	rcu_sync_torture_init(); -} - -static void srcu_torture_cleanup(void) -{ -	synchronize_srcu(&srcu_ctl); -	cleanup_srcu_struct(&srcu_ctl); -} +DEFINE_STATIC_SRCU(srcu_ctl);  static int srcu_torture_read_lock(void) __acquires(&srcu_ctl)  { @@ -672,8 +653,7 @@ static int srcu_torture_stats(char *page)  }  static struct rcu_torture_ops srcu_ops = { -	.init		= srcu_torture_init, -	.cleanup	= srcu_torture_cleanup, +	.init		= rcu_sync_torture_init,  	.readlock	= srcu_torture_read_lock,  	.read_delay	= srcu_read_delay,  	.readunlock	= srcu_torture_read_unlock, @@ -687,8 +667,7 @@ static struct rcu_torture_ops srcu_ops = {  };  static struct rcu_torture_ops srcu_sync_ops = { -	.init		= srcu_torture_init, -	.cleanup	= srcu_torture_cleanup, +	.init		= rcu_sync_torture_init,  	.readlock	= srcu_torture_read_lock,  	.read_delay	= srcu_read_delay,  	.readunlock	= srcu_torture_read_unlock, @@ -712,8 +691,7 @@ static void srcu_torture_read_unlock_raw(int idx) __releases(&srcu_ctl)  }  static struct rcu_torture_ops srcu_raw_ops = { -	.init		= srcu_torture_init, -	.cleanup	= srcu_torture_cleanup, +	.init		= rcu_sync_torture_init,  	.readlock	= srcu_torture_read_lock_raw,  	.read_delay	= srcu_read_delay,  	.readunlock	= srcu_torture_read_unlock_raw, @@ -727,8 +705,7 @@ static struct rcu_torture_ops srcu_raw_ops = {  };  static struct rcu_torture_ops srcu_raw_sync_ops = { -	.init		= srcu_torture_init, -	.cleanup	= srcu_torture_cleanup, +	.init		= rcu_sync_torture_init,  	.readlock	= srcu_torture_read_lock_raw,  	.read_delay	= srcu_read_delay,  	.readunlock	= srcu_torture_read_unlock_raw, @@ -747,8 +724,7 @@ static void srcu_torture_synchronize_expedited(void)  }  static struct rcu_torture_ops srcu_expedited_ops = { -	.init		= srcu_torture_init, -	.cleanup	= srcu_torture_cleanup, +	.init		= rcu_sync_torture_init,  	.readlock	= srcu_torture_read_lock,  	.read_delay	= srcu_read_delay,  	.readunlock	= srcu_torture_read_unlock, @@ -783,7 +759,6 @@ static void rcu_sched_torture_deferred_free(struct rcu_torture *p)  static struct rcu_torture_ops sched_ops = {  	.init		= rcu_sync_torture_init, -	.cleanup	= NULL,  	.readlock	= sched_torture_read_lock,  	.read_delay	= rcu_read_delay,  /* just reuse rcu's version. */  	.readunlock	= sched_torture_read_unlock, @@ -799,7 +774,6 @@ static struct rcu_torture_ops sched_ops = {  static struct rcu_torture_ops sched_sync_ops = {  	.init		= rcu_sync_torture_init, -	.cleanup	= NULL,  	.readlock	= sched_torture_read_lock,  	.read_delay	= rcu_read_delay,  /* just reuse rcu's version. */  	.readunlock	= sched_torture_read_unlock, @@ -814,7 +788,6 @@ static struct rcu_torture_ops sched_sync_ops = {  static struct rcu_torture_ops sched_expedited_ops = {  	.init		= rcu_sync_torture_init, -	.cleanup	= NULL,  	.readlock	= sched_torture_read_lock,  	.read_delay	= rcu_read_delay,  /* just reuse rcu's version. */  	.readunlock	= sched_torture_read_unlock, @@ -1396,12 +1369,16 @@ rcu_torture_print_module_parms(struct rcu_torture_ops *cur_ops, char *tag)  		 "fqs_duration=%d fqs_holdoff=%d fqs_stutter=%d "  		 "test_boost=%d/%d test_boost_interval=%d "  		 "test_boost_duration=%d shutdown_secs=%d " +		 "stall_cpu=%d stall_cpu_holdoff=%d " +		 "n_barrier_cbs=%d "  		 "onoff_interval=%d onoff_holdoff=%d\n",  		 torture_type, tag, nrealreaders, nfakewriters,  		 stat_interval, verbose, test_no_idle_hz, shuffle_interval,  		 stutter, irqreader, fqs_duration, fqs_holdoff, fqs_stutter,  		 test_boost, cur_ops->can_boost,  		 test_boost_interval, test_boost_duration, shutdown_secs, +		 stall_cpu, stall_cpu_holdoff, +		 n_barrier_cbs,  		 onoff_interval, onoff_holdoff);  } @@ -1502,6 +1479,7 @@ rcu_torture_onoff(void *arg)  	unsigned long delta;  	int maxcpu = -1;  	DEFINE_RCU_RANDOM(rand); +	int ret;  	unsigned long starttime;  	VERBOSE_PRINTK_STRING("rcu_torture_onoff task started"); @@ -1522,7 +1500,13 @@ rcu_torture_onoff(void *arg)  					 torture_type, cpu);  			starttime = jiffies;  			n_offline_attempts++; -			if (cpu_down(cpu) == 0) { +			ret = cpu_down(cpu); +			if (ret) { +				if (verbose) +					pr_alert("%s" TORTURE_FLAG +						 "rcu_torture_onoff task: offline %d failed: errno %d\n", +						 torture_type, cpu, ret); +			} else {  				if (verbose)  					pr_alert("%s" TORTURE_FLAG  						 "rcu_torture_onoff task: offlined %d\n", @@ -1936,8 +1920,6 @@ rcu_torture_cleanup(void)  	rcu_torture_stats_print();  /* -After- the stats thread is stopped! */ -	if (cur_ops->cleanup) -		cur_ops->cleanup();  	if (atomic_read(&n_rcu_torture_error) || n_rcu_torture_barrier_error)  		rcu_torture_print_module_parms(cur_ops, "End of test: FAILURE");  	else if (n_online_successes != n_online_attempts ||  |