diff options
Diffstat (limited to 'fs/hpfs/hpfs_fn.h')
| -rw-r--r-- | fs/hpfs/hpfs_fn.h | 80 | 
1 files changed, 37 insertions, 43 deletions
diff --git a/fs/hpfs/hpfs_fn.h b/fs/hpfs/hpfs_fn.h index c15adbca07f..dd552f862c8 100644 --- a/fs/hpfs/hpfs_fn.h +++ b/fs/hpfs/hpfs_fn.h @@ -13,6 +13,7 @@  #include <linux/pagemap.h>  #include <linux/buffer_head.h>  #include <linux/slab.h> +#include <asm/unaligned.h>  #include "hpfs.h" @@ -51,18 +52,16 @@ struct hpfs_inode_info {  	unsigned i_disk_sec;	/* (files) minimalist cache of alloc info */  	unsigned i_n_secs;	/* (files) minimalist cache of alloc info */  	unsigned i_ea_size;	/* size of extended attributes */ -	unsigned i_conv : 2;	/* (files) crlf->newline hackery */  	unsigned i_ea_mode : 1;	/* file's permission is stored in ea */  	unsigned i_ea_uid : 1;	/* file's uid is stored in ea */  	unsigned i_ea_gid : 1;	/* file's gid is stored in ea */  	unsigned i_dirty : 1; -	struct mutex i_mutex; -	struct mutex i_parent_mutex;  	loff_t **i_rddir_off;  	struct inode vfs_inode;  };  struct hpfs_sb_info { +	struct mutex hpfs_mutex;	/* global hpfs lock */  	ino_t sb_root;			/* inode number of root dir */  	unsigned sb_fs_size;		/* file system size, sectors */  	unsigned sb_bitmaps;		/* sector number of bitmap list */ @@ -74,7 +73,6 @@ struct hpfs_sb_info {  	uid_t sb_uid;			/* uid from mount options */  	gid_t sb_gid;			/* gid from mount options */  	umode_t sb_mode;		/* mode from mount options */ -	unsigned sb_conv : 2;		/* crlf->newline hackery */  	unsigned sb_eas : 2;		/* eas: 0-ignore, 1-ro, 2-rw */  	unsigned sb_err : 2;		/* on errs: 0-cont, 1-ro, 2-panic */  	unsigned sb_chk : 2;		/* checks: 0-no, 1-normal, 2-strict */ @@ -87,20 +85,9 @@ struct hpfs_sb_info {  	unsigned *sb_bmp_dir;		/* main bitmap directory */  	unsigned sb_c_bitmap;		/* current bitmap */  	unsigned sb_max_fwd_alloc;	/* max forwad allocation */ -	struct mutex hpfs_creation_de;	/* when creating dirents, nobody else -					   can alloc blocks */ -	/*unsigned sb_mounting : 1;*/  	int sb_timeshift;  }; -/* - * conv= options - */ - -#define CONV_BINARY 0			/* no conversion */ -#define CONV_TEXT 1			/* crlf->newline */ -#define CONV_AUTO 2			/* decide based on file contents */ -  /* Four 512-byte buffers and the 2k block obtained by concatenating them */  struct quad_buffer_head { @@ -113,7 +100,7 @@ struct quad_buffer_head {  static inline dnode_secno de_down_pointer (struct hpfs_dirent *de)  {    CHKCOND(de->down,("HPFS: de_down_pointer: !de->down\n")); -  return *(dnode_secno *) ((void *) de + de->length - 4); +  return le32_to_cpu(*(dnode_secno *) ((void *) de + le16_to_cpu(de->length) - 4));  }  /* The first dir entry in a dnode */ @@ -127,41 +114,46 @@ static inline struct hpfs_dirent *dnode_first_de (struct dnode *dnode)  static inline struct hpfs_dirent *dnode_end_de (struct dnode *dnode)  { -  CHKCOND(dnode->first_free>=0x14 && dnode->first_free<=0xa00,("HPFS: dnode_end_de: dnode->first_free = %d\n",(int)dnode->first_free)); -  return (void *) dnode + dnode->first_free; +  CHKCOND(le32_to_cpu(dnode->first_free)>=0x14 && le32_to_cpu(dnode->first_free)<=0xa00,("HPFS: dnode_end_de: dnode->first_free = %x\n",(unsigned)le32_to_cpu(dnode->first_free))); +  return (void *) dnode + le32_to_cpu(dnode->first_free);  }  /* The dir entry after dir entry de */  static inline struct hpfs_dirent *de_next_de (struct hpfs_dirent *de)  { -  CHKCOND(de->length>=0x20 && de->length<0x800,("HPFS: de_next_de: de->length = %d\n",(int)de->length)); -  return (void *) de + de->length; +  CHKCOND(le16_to_cpu(de->length)>=0x20 && le16_to_cpu(de->length)<0x800,("HPFS: de_next_de: de->length = %x\n",(unsigned)le16_to_cpu(de->length))); +  return (void *) de + le16_to_cpu(de->length);  }  static inline struct extended_attribute *fnode_ea(struct fnode *fnode)  { -	return (struct extended_attribute *)((char *)fnode + fnode->ea_offs + fnode->acl_size_s); +	return (struct extended_attribute *)((char *)fnode + le16_to_cpu(fnode->ea_offs) + le16_to_cpu(fnode->acl_size_s));  }  static inline struct extended_attribute *fnode_end_ea(struct fnode *fnode)  { -	return (struct extended_attribute *)((char *)fnode + fnode->ea_offs + fnode->acl_size_s + fnode->ea_size_s); +	return (struct extended_attribute *)((char *)fnode + le16_to_cpu(fnode->ea_offs) + le16_to_cpu(fnode->acl_size_s) + le16_to_cpu(fnode->ea_size_s)); +} + +static unsigned ea_valuelen(struct extended_attribute *ea) +{ +	return ea->valuelen_lo + 256 * ea->valuelen_hi;  }  static inline struct extended_attribute *next_ea(struct extended_attribute *ea)  { -	return (struct extended_attribute *)((char *)ea + 5 + ea->namelen + ea->valuelen); +	return (struct extended_attribute *)((char *)ea + 5 + ea->namelen + ea_valuelen(ea));  }  static inline secno ea_sec(struct extended_attribute *ea)  { -	return *(secno *)((char *)ea + 9 + ea->namelen); +	return le32_to_cpu(get_unaligned((secno *)((char *)ea + 9 + ea->namelen)));  }  static inline secno ea_len(struct extended_attribute *ea)  { -	return *(secno *)((char *)ea + 5 + ea->namelen); +	return le32_to_cpu(get_unaligned((secno *)((char *)ea + 5 + ea->namelen)));  }  static inline char *ea_data(struct extended_attribute *ea) @@ -186,13 +178,13 @@ static inline void copy_de(struct hpfs_dirent *dst, struct hpfs_dirent *src)  	dst->not_8x3 = n;  } -static inline unsigned tstbits(unsigned *bmp, unsigned b, unsigned n) +static inline unsigned tstbits(u32 *bmp, unsigned b, unsigned n)  {  	int i;  	if ((b >= 0x4000) || (b + n - 1 >= 0x4000)) return n; -	if (!((bmp[(b & 0x3fff) >> 5] >> (b & 0x1f)) & 1)) return 1; +	if (!((le32_to_cpu(bmp[(b & 0x3fff) >> 5]) >> (b & 0x1f)) & 1)) return 1;  	for (i = 1; i < n; i++) -		if (/*b+i < 0x4000 &&*/ !((bmp[((b+i) & 0x3fff) >> 5] >> ((b+i) & 0x1f)) & 1)) +		if (!((le32_to_cpu(bmp[((b+i) & 0x3fff) >> 5]) >> ((b+i) & 0x1f)) & 1))  			return i + 1;  	return 0;  } @@ -200,12 +192,12 @@ static inline unsigned tstbits(unsigned *bmp, unsigned b, unsigned n)  /* alloc.c */  int hpfs_chk_sectors(struct super_block *, secno, int, char *); -secno hpfs_alloc_sector(struct super_block *, secno, unsigned, int, int); +secno hpfs_alloc_sector(struct super_block *, secno, unsigned, int);  int hpfs_alloc_if_possible(struct super_block *, secno);  void hpfs_free_sectors(struct super_block *, secno, unsigned);  int hpfs_check_free_dnodes(struct super_block *, int);  void hpfs_free_dnode(struct super_block *, secno); -struct dnode *hpfs_alloc_dnode(struct super_block *, secno, dnode_secno *, struct quad_buffer_head *, int); +struct dnode *hpfs_alloc_dnode(struct super_block *, secno, dnode_secno *, struct quad_buffer_head *);  struct fnode *hpfs_alloc_fnode(struct super_block *, secno, fnode_secno *, struct buffer_head **);  struct anode *hpfs_alloc_anode(struct super_block *, secno, anode_secno *, struct buffer_head **); @@ -222,8 +214,6 @@ void hpfs_remove_fnode(struct super_block *, fnode_secno fno);  /* buffer.c */ -void hpfs_lock_creation(struct super_block *); -void hpfs_unlock_creation(struct super_block *);  void *hpfs_map_sector(struct super_block *, unsigned, struct buffer_head **, int);  void *hpfs_get_sector(struct super_block *, unsigned, struct buffer_head **);  void *hpfs_map_4sectors(struct super_block *, unsigned, struct quad_buffer_head *, int); @@ -247,7 +237,7 @@ void hpfs_del_pos(struct inode *, loff_t *);  struct hpfs_dirent *hpfs_add_de(struct super_block *, struct dnode *,  				const unsigned char *, unsigned, secno);  int hpfs_add_dirent(struct inode *, const unsigned char *, unsigned, -		    struct hpfs_dirent *, int); +		    struct hpfs_dirent *);  int hpfs_remove_dirent(struct inode *, dnode_secno, struct hpfs_dirent *, struct quad_buffer_head *, int);  void hpfs_count_dnodes(struct super_block *, dnode_secno, int *, int *, int *);  dnode_secno hpfs_de_as_down_as_possible(struct super_block *, dnode_secno dno); @@ -303,7 +293,6 @@ int hpfs_compare_names(struct super_block *, const unsigned char *, unsigned,  		       const unsigned char *, unsigned, int);  int hpfs_is_name_long(const unsigned char *, unsigned);  void hpfs_adjust_length(const unsigned char *, unsigned *); -void hpfs_decide_conv(struct inode *, const unsigned char *, unsigned);  /* namei.c */ @@ -346,21 +335,26 @@ static inline time32_t gmt_to_local(struct super_block *s, time_t t)  /*   * Locking:   * - * hpfs_lock() is a leftover from the big kernel lock. - * Right now, these functions are empty and only left - * for documentation purposes. The file system no longer - * works on SMP systems, so the lock is not needed - * any more. + * hpfs_lock() locks the whole filesystem. It must be taken + * on any method called by the VFS.   * - * If someone is interested in making it work again, this - * would be the place to start by adding a per-superblock - * mutex and fixing all the bugs and performance issues - * caused by that. + * We don't do any per-file locking anymore, it is hard to + * review and HPFS is not performance-sensitive anyway.   */  static inline void hpfs_lock(struct super_block *s)  { +	struct hpfs_sb_info *sbi = hpfs_sb(s); +	mutex_lock(&sbi->hpfs_mutex);  }  static inline void hpfs_unlock(struct super_block *s)  { +	struct hpfs_sb_info *sbi = hpfs_sb(s); +	mutex_unlock(&sbi->hpfs_mutex); +} + +static inline void hpfs_lock_assert(struct super_block *s) +{ +	struct hpfs_sb_info *sbi = hpfs_sb(s); +	WARN_ON(!mutex_is_locked(&sbi->hpfs_mutex));  }  |