diff options
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-amd756.c | 5 | ||||
| -rw-r--r-- | drivers/i2c/busses/i2c-viapro.c | 5 | ||||
| -rw-r--r-- | drivers/i2c/chips/at24.c | 1 | ||||
| -rw-r--r-- | drivers/i2c/chips/ds1682.c | 1 | ||||
| -rw-r--r-- | drivers/i2c/chips/menelaus.c | 34 | 
5 files changed, 17 insertions, 29 deletions
diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c index 1ea39254dac..424dad6f18d 100644 --- a/drivers/i2c/busses/i2c-amd756.c +++ b/drivers/i2c/busses/i2c-amd756.c @@ -332,10 +332,6 @@ static int __devinit amd756_probe(struct pci_dev *pdev,  	int error;  	u8 temp; -	/* driver_data might come from user-space, so check it */ -	if (id->driver_data >= ARRAY_SIZE(chipname)) -		return -EINVAL; -  	if (amd756_ioport) {  		dev_err(&pdev->dev, "Only one device supported "  		       "(you have a strange motherboard, btw)\n"); @@ -412,7 +408,6 @@ static struct pci_driver amd756_driver = {  	.id_table	= amd756_ids,  	.probe		= amd756_probe,  	.remove		= __devexit_p(amd756_remove), -	.dynids.use_driver_data = 1,  };  static int __init amd756_init(void) diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c index 73dc52e114e..9f194d9efd9 100644 --- a/drivers/i2c/busses/i2c-viapro.c +++ b/drivers/i2c/busses/i2c-viapro.c @@ -332,10 +332,6 @@ static int __devinit vt596_probe(struct pci_dev *pdev,  	unsigned char temp;  	int error = -ENODEV; -	/* driver_data might come from user-space, so check it */ -	if (id->driver_data & 1 || id->driver_data > 0xff) -		return -EINVAL; -  	/* Determine the address of the SMBus areas */  	if (force_addr) {  		vt596_smba = force_addr & 0xfff0; @@ -483,7 +479,6 @@ static struct pci_driver vt596_driver = {  	.name		= "vt596_smbus",  	.id_table	= vt596_ids,  	.probe		= vt596_probe, -	.dynids.use_driver_data = 1,  };  static int __init i2c_vt596_init(void) diff --git a/drivers/i2c/chips/at24.c b/drivers/i2c/chips/at24.c index 2a4acb26956..d4775528abc 100644 --- a/drivers/i2c/chips/at24.c +++ b/drivers/i2c/chips/at24.c @@ -460,7 +460,6 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)  	 */  	at24->bin.attr.name = "eeprom";  	at24->bin.attr.mode = chip.flags & AT24_FLAG_IRUGO ? S_IRUGO : S_IRUSR; -	at24->bin.attr.owner = THIS_MODULE;  	at24->bin.read = at24_bin_read;  	at24->bin.size = chip.byte_len; diff --git a/drivers/i2c/chips/ds1682.c b/drivers/i2c/chips/ds1682.c index 23be4d42cb0..f3ee4a1abb7 100644 --- a/drivers/i2c/chips/ds1682.c +++ b/drivers/i2c/chips/ds1682.c @@ -190,7 +190,6 @@ static struct bin_attribute ds1682_eeprom_attr = {  	.attr = {  		.name = "eeprom",  		.mode = S_IRUGO | S_IWUSR, -		.owner = THIS_MODULE,  	},  	.size = DS1682_EEPROM_SIZE,  	.read = ds1682_eeprom_read, diff --git a/drivers/i2c/chips/menelaus.c b/drivers/i2c/chips/menelaus.c index 176126d3a01..4b364bae6b3 100644 --- a/drivers/i2c/chips/menelaus.c +++ b/drivers/i2c/chips/menelaus.c @@ -832,52 +832,52 @@ static irqreturn_t menelaus_irq(int irq, void *_menelaus)  static void menelaus_to_time(char *regs, struct rtc_time *t)  { -	t->tm_sec = BCD2BIN(regs[0]); -	t->tm_min = BCD2BIN(regs[1]); +	t->tm_sec = bcd2bin(regs[0]); +	t->tm_min = bcd2bin(regs[1]);  	if (the_menelaus->rtc_control & RTC_CTRL_MODE12) { -		t->tm_hour = BCD2BIN(regs[2] & 0x1f) - 1; +		t->tm_hour = bcd2bin(regs[2] & 0x1f) - 1;  		if (regs[2] & RTC_HR_PM)  			t->tm_hour += 12;  	} else -		t->tm_hour = BCD2BIN(regs[2] & 0x3f); -	t->tm_mday = BCD2BIN(regs[3]); -	t->tm_mon = BCD2BIN(regs[4]) - 1; -	t->tm_year = BCD2BIN(regs[5]) + 100; +		t->tm_hour = bcd2bin(regs[2] & 0x3f); +	t->tm_mday = bcd2bin(regs[3]); +	t->tm_mon = bcd2bin(regs[4]) - 1; +	t->tm_year = bcd2bin(regs[5]) + 100;  }  static int time_to_menelaus(struct rtc_time *t, int regnum)  {  	int	hour, status; -	status = menelaus_write_reg(regnum++, BIN2BCD(t->tm_sec)); +	status = menelaus_write_reg(regnum++, bin2bcd(t->tm_sec));  	if (status < 0)  		goto fail; -	status = menelaus_write_reg(regnum++, BIN2BCD(t->tm_min)); +	status = menelaus_write_reg(regnum++, bin2bcd(t->tm_min));  	if (status < 0)  		goto fail;  	if (the_menelaus->rtc_control & RTC_CTRL_MODE12) {  		hour = t->tm_hour + 1;  		if (hour > 12) -			hour = RTC_HR_PM | BIN2BCD(hour - 12); +			hour = RTC_HR_PM | bin2bcd(hour - 12);  		else -			hour = BIN2BCD(hour); +			hour = bin2bcd(hour);  	} else -		hour = BIN2BCD(t->tm_hour); +		hour = bin2bcd(t->tm_hour);  	status = menelaus_write_reg(regnum++, hour);  	if (status < 0)  		goto fail; -	status = menelaus_write_reg(regnum++, BIN2BCD(t->tm_mday)); +	status = menelaus_write_reg(regnum++, bin2bcd(t->tm_mday));  	if (status < 0)  		goto fail; -	status = menelaus_write_reg(regnum++, BIN2BCD(t->tm_mon + 1)); +	status = menelaus_write_reg(regnum++, bin2bcd(t->tm_mon + 1));  	if (status < 0)  		goto fail; -	status = menelaus_write_reg(regnum++, BIN2BCD(t->tm_year - 100)); +	status = menelaus_write_reg(regnum++, bin2bcd(t->tm_year - 100));  	if (status < 0)  		goto fail; @@ -914,7 +914,7 @@ static int menelaus_read_time(struct device *dev, struct rtc_time *t)  	}  	menelaus_to_time(regs, t); -	t->tm_wday = BCD2BIN(regs[6]); +	t->tm_wday = bcd2bin(regs[6]);  	return 0;  } @@ -927,7 +927,7 @@ static int menelaus_set_time(struct device *dev, struct rtc_time *t)  	status = time_to_menelaus(t, MENELAUS_RTC_SEC);  	if (status < 0)  		return status; -	status = menelaus_write_reg(MENELAUS_RTC_WKDAY, BIN2BCD(t->tm_wday)); +	status = menelaus_write_reg(MENELAUS_RTC_WKDAY, bin2bcd(t->tm_wday));  	if (status < 0) {  		dev_err(&the_menelaus->client->dev, "rtc write reg %02x "  				"err %d\n", MENELAUS_RTC_WKDAY, status);  |