diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-26 20:16:07 -0800 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-26 20:16:07 -0800 | 
| commit | d895cb1af15c04c522a25c79cc429076987c089b (patch) | |
| tree | 895dc9157e28f603d937a58be664e4e440d5530c /kernel/sysctl_binary.c | |
| parent | 9626357371b519f2b955fef399647181034a77fe (diff) | |
| parent | d3d009cb965eae7e002ea5badf603ea8f4c34915 (diff) | |
| download | olio-linux-3.10-d895cb1af15c04c522a25c79cc429076987c089b.tar.xz olio-linux-3.10-d895cb1af15c04c522a25c79cc429076987c089b.zip | |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs pile (part one) from Al Viro:
 "Assorted stuff - cleaning namei.c up a bit, fixing ->d_name/->d_parent
  locking violations, etc.
  The most visible changes here are death of FS_REVAL_DOT (replaced with
  "has ->d_weak_revalidate()") and a new helper getting from struct file
  to inode.  Some bits of preparation to xattr method interface changes.
  Misc patches by various people sent this cycle *and* ocfs2 fixes from
  several cycles ago that should've been upstream right then.
  PS: the next vfs pile will be xattr stuff."
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (46 commits)
  saner proc_get_inode() calling conventions
  proc: avoid extra pde_put() in proc_fill_super()
  fs: change return values from -EACCES to -EPERM
  fs/exec.c: make bprm_mm_init() static
  ocfs2/dlm: use GFP_ATOMIC inside a spin_lock
  ocfs2: fix possible use-after-free with AIO
  ocfs2: Fix oops in ocfs2_fast_symlink_readpage() code path
  get_empty_filp()/alloc_file() leave both ->f_pos and ->f_version zero
  target: writev() on single-element vector is pointless
  export kernel_write(), convert open-coded instances
  fs: encode_fh: return FILEID_INVALID if invalid fid_type
  kill f_vfsmnt
  vfs: kill FS_REVAL_DOT by adding a d_weak_revalidate dentry op
  nfsd: handle vfs_getattr errors in acl protocol
  switch vfs_getattr() to struct path
  default SET_PERSONALITY() in linux/elf.h
  ceph: prepopulate inodes only when request is aborted
  d_hash_and_lookup(): export, switch open-coded instances
  9p: switch v9fs_set_create_acl() to inode+fid, do it before d_instantiate()
  9p: split dropping the acls from v9fs_set_create_acl()
  ...
Diffstat (limited to 'kernel/sysctl_binary.c')
| -rw-r--r-- | kernel/sysctl_binary.c | 39 | 
1 files changed, 7 insertions, 32 deletions
| diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c index b669ca1fa10..b25115e8c7f 100644 --- a/kernel/sysctl_binary.c +++ b/kernel/sysctl_binary.c @@ -970,7 +970,6 @@ out:  static ssize_t bin_intvec(struct file *file,  	void __user *oldval, size_t oldlen, void __user *newval, size_t newlen)  { -	mm_segment_t old_fs = get_fs();  	ssize_t copied = 0;  	char *buffer;  	ssize_t result; @@ -983,13 +982,10 @@ static ssize_t bin_intvec(struct file *file,  	if (oldval && oldlen) {  		unsigned __user *vec = oldval;  		size_t length = oldlen / sizeof(*vec); -		loff_t pos = 0;  		char *str, *end;  		int i; -		set_fs(KERNEL_DS); -		result = vfs_read(file, buffer, BUFSZ - 1, &pos); -		set_fs(old_fs); +		result = kernel_read(file, 0, buffer, BUFSZ - 1);  		if (result < 0)  			goto out_kfree; @@ -1016,7 +1012,6 @@ static ssize_t bin_intvec(struct file *file,  	if (newval && newlen) {  		unsigned __user *vec = newval;  		size_t length = newlen / sizeof(*vec); -		loff_t pos = 0;  		char *str, *end;  		int i; @@ -1032,9 +1027,7 @@ static ssize_t bin_intvec(struct file *file,  			str += snprintf(str, end - str, "%lu\t", value);  		} -		set_fs(KERNEL_DS); -		result = vfs_write(file, buffer, str - buffer, &pos); -		set_fs(old_fs); +		result = kernel_write(file, buffer, str - buffer, 0);  		if (result < 0)  			goto out_kfree;  	} @@ -1048,7 +1041,6 @@ out:  static ssize_t bin_ulongvec(struct file *file,  	void __user *oldval, size_t oldlen, void __user *newval, size_t newlen)  { -	mm_segment_t old_fs = get_fs();  	ssize_t copied = 0;  	char *buffer;  	ssize_t result; @@ -1061,13 +1053,10 @@ static ssize_t bin_ulongvec(struct file *file,  	if (oldval && oldlen) {  		unsigned long __user *vec = oldval;  		size_t length = oldlen / sizeof(*vec); -		loff_t pos = 0;  		char *str, *end;  		int i; -		set_fs(KERNEL_DS); -		result = vfs_read(file, buffer, BUFSZ - 1, &pos); -		set_fs(old_fs); +		result = kernel_read(file, 0, buffer, BUFSZ - 1);  		if (result < 0)  			goto out_kfree; @@ -1094,7 +1083,6 @@ static ssize_t bin_ulongvec(struct file *file,  	if (newval && newlen) {  		unsigned long __user *vec = newval;  		size_t length = newlen / sizeof(*vec); -		loff_t pos = 0;  		char *str, *end;  		int i; @@ -1110,9 +1098,7 @@ static ssize_t bin_ulongvec(struct file *file,  			str += snprintf(str, end - str, "%lu\t", value);  		} -		set_fs(KERNEL_DS); -		result = vfs_write(file, buffer, str - buffer, &pos); -		set_fs(old_fs); +		result = kernel_write(file, buffer, str - buffer, 0);  		if (result < 0)  			goto out_kfree;  	} @@ -1126,19 +1112,15 @@ out:  static ssize_t bin_uuid(struct file *file,  	void __user *oldval, size_t oldlen, void __user *newval, size_t newlen)  { -	mm_segment_t old_fs = get_fs();  	ssize_t result, copied = 0;  	/* Only supports reads */  	if (oldval && oldlen) { -		loff_t pos = 0;  		char buf[40], *str = buf;  		unsigned char uuid[16];  		int i; -		set_fs(KERNEL_DS); -		result = vfs_read(file, buf, sizeof(buf) - 1, &pos); -		set_fs(old_fs); +		result = kernel_read(file, 0, buf, sizeof(buf) - 1);  		if (result < 0)  			goto out; @@ -1174,18 +1156,14 @@ out:  static ssize_t bin_dn_node_address(struct file *file,  	void __user *oldval, size_t oldlen, void __user *newval, size_t newlen)  { -	mm_segment_t old_fs = get_fs();  	ssize_t result, copied = 0;  	if (oldval && oldlen) { -		loff_t pos = 0;  		char buf[15], *nodep;  		unsigned long area, node;  		__le16 dnaddr; -		set_fs(KERNEL_DS); -		result = vfs_read(file, buf, sizeof(buf) - 1, &pos); -		set_fs(old_fs); +		result = kernel_read(file, 0, buf, sizeof(buf) - 1);  		if (result < 0)  			goto out; @@ -1214,7 +1192,6 @@ static ssize_t bin_dn_node_address(struct file *file,  	}  	if (newval && newlen) { -		loff_t pos = 0;  		__le16 dnaddr;  		char buf[15];  		int len; @@ -1231,9 +1208,7 @@ static ssize_t bin_dn_node_address(struct file *file,  				le16_to_cpu(dnaddr) >> 10,  				le16_to_cpu(dnaddr) & 0x3ff); -		set_fs(KERNEL_DS); -		result = vfs_write(file, buf, len, &pos); -		set_fs(old_fs); +		result = kernel_write(file, buf, len, 0);  		if (result < 0)  			goto out;  	} |